[pull] master from chromium:master #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
pull bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
This reverts commit 0d437e0. Reason for revert: Breaks Lacros. [343589:343589:0726/205512.291579:FATAL:sandbox_seccomp_bpf_linux.cc(239)] Check failed: BPFBasePolicy::GetFSDeniedErrno() == (*__errno_location ()) (1 vs. 13) #0 0x7fa2e2e3a8af base::debug::CollectStackTrace() #1 0x7fa2e2baee0a base::debug::StackTrace::StackTrace() #2 0x7fa2e2baedc5 base::debug::StackTrace::StackTrace() #3 0x7fa2e2bfe239 logging::LogMessage::~LogMessage() #4 0x7fa2e2bfe959 logging::LogMessage::~LogMessage() #5 0x7fa2e2b6e5eb logging::CheckError::~CheckError() #6 0x7fa2cc927b2f sandbox::policy::SandboxSeccompBPF::RunSandboxSanityChecks() #7 0x7fa2cc91fc71 sandbox::policy::SandboxLinux::StartSeccompBPF() #8 0x7fa2cc9206fd sandbox::policy::SandboxLinux::InitializeSandbox() #9 0x7fa2d83e65a3 content::(anonymous namespace)::StartSandboxLinux() #10 0x7fa2d83e62b9 content::(anonymous namespace)::ContentSandboxHelper::EnsureSandboxInitialized() #11 0x7fa2a32de13e gpu::GpuInit::InitializeAndStartSandbox() #12 0x7fa2d83e5ca0 content::GpuMain() #13 0x7fa2dbd8a5ad content::RunZygote() #14 0x7fa2dbd8aa3a content::RunOtherNamedProcessTypeMain() #15 0x7fa2dbd8b7b4 content::ContentMainRunnerImpl::Run() #16 0x7fa2dbd889ae content::RunContentProcess() #17 0x7fa2dbd892fd content::ContentMain() #18 0x5588c3250966 ChromeMain #19 0x5588c3250812 main #20 0x7fa2a56aed0a __libc_start_main #21 0x5588c325072a _start To repro the failure, follow go/lacros-build and build linux Lacros. Lacros can't be launched with the failure above. Original change's description: > Use EACCES over EPERM for broker process denied errno > > When dlopen is called without an absolute path, it looks in a number > of search paths for the requested library (e.g. /lib64/libfoo.so, > /usr/lib/libfoo.so). Often, these files don't exist and the > corresponding openat syscall should return ENOENT, but because of > the GPU sandbox, the syscall returns EPERM instead [1]. glibc's > implementation of dlopen, however, early-exits when it sees an > unexpected errno [2] and terminates without attempting the remaining > search paths. Thus, even if the library *is* allowlisted in a later > path, dlopen will still exit with a failure. > > This CL fixes this issue by changing the denied errno to EACCES for > the broker process. > > Bug: 1233028 > Change-Id: I192098eb072f2ee6fb18aa7da3d1998f8328149f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3054490 > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Brian Ho <hob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#905330} Bug: 1233028 Change-Id: I111ff2bf802615e1299aee7feb88471d49a238e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3055402 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Owners-Override: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#905685}
pull bot
pushed a commit
that referenced
this pull request
Aug 12, 2021
Update UserSessionInitializer::PreStartSession() to take bool is_primary_session and only call NetworkCertLoader::MarkUserNSSDBWillBeInitialized() when true. Fixes crash: 2021-08-08T22:59:06.505936Z FATAL chrome[21728:21728]: [network_cert_loader.cc(148)] Check failed: state_ == State::kNotInitialized || state_ == State::kMarkedWillBeInitialized. #0 0x57e49567eb89 base::debug::CollectStackTrace() #1 0x57e4955c5c93 base::debug::StackTrace::StackTrace() #2 0x57e48fd06890 logging::LogMessage::~LogMessage() #3 0x57e4955d904e logging::LogMessage::~LogMessage() #4 0x57e497827697 chromeos::NetworkCertLoader::CertCache::MarkWillBeInitialized() #5 0x57e4978277d2 chromeos::NetworkCertLoader::MarkUserNSSDBWillBeInitialized() #6 0x57e4937607ac ash::UserSessionManager::StartSession() #7 0x57e493712814 chromeos::ExistingUserController::OnAuthSuccess() #8 0x57e498a7a9e5 chromeos::LoginPerformer::OnAuthSuccess() #9 0x57e498a72c39 chromeos::CryptohomeAuthenticator::OnAuthSuccess() #10 0x57e490df73f4 base::TaskAnnotator::RunTask() #11 0x57e48fe5bc9d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #12 0x57e4956477c2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x57e4909e2445 base::MessagePumpLibevent::Run() #14 0x57e495647a83 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #15 0x57e49560bb56 base::RunLoop::Run() #16 0x57e4924d69f1 content::BrowserMainLoop::RunMainMessageLoop() #17 0x57e4924d8840 content::BrowserMainRunnerImpl::Run() #18 0x57e4924d3ce8 content::BrowserMain() #19 0x57e495082b38 content::RunBrowserProcessMain() #20 0x57e495083e3b content::ContentMainRunnerImpl::RunBrowser() #21 0x57e4950838c6 content::ContentMainRunnerImpl::Run() #22 0x57e49508123e content::RunContentProcess() #23 0x57e495081c40 content::ContentMain() #24 0x57e4910cf23e ChromeMain #25 0x789c45710e05 __libc_start_main #26 0x57e4910cf0da _start Task trace: #0 0x57e498a73fcc chromeos::CryptohomeAuthenticator::Resolve() #1 0x57e496c95be1 dbus::ObjectProxy::OnPendingCallIsComplete() #2 0x57e496c91b91 dbus::Bus::OnDispatchStatusChanged() #3 0x57e49567fa66 base::FileDescriptorWatcher::Controller::Watcher::OnFileCanReadWithoutBlocking() Change-Id: I4b250f807ca8f3fff35cb380b3a47ce98b7ade09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3080039 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#910647}
The new name is easier to read. Change-Id: Ie29d1e1ddb31c17950b3344e158a191a5a3efb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3108518 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/main@{#913904}
Quick Run's users have indicated an interest in this builder, which is as of yet unexplored with RTS. This bot will be used to test that out. Other CLs for this builder: https://crrev.com/i/4070035 https://crrev.com/c/3108009 Bug: 1241549 Change-Id: I08ce5bda7ac9637df4e1745ae524c40e6afc1a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3107740 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#913905}
Bug: chromium:1207342 Change-Id: I6606657207da1a065f5ea0c53debfec2f75dea35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3107113 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/main@{#913906}
This reverts commit 6e18e0d. Reason for revert: Tree closure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8838358063796181409/+/u/compile/raw_io.output_failure_summary_ Original change's description: > [Resubmit] Pass the credentials mode to the download service. > > The default is still 'Allow' which will not affect any existing download > clients, however the clients will be able to customize the credentials > mode as needed. > > This was already reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/3100108 > but was reverted due to a dependency issue. The CL adds an extra > dependency (diff against patchset 1 which contains the original submission) > > Bug: 1239709 > Change-Id: I074c7e096e326ea39d40905e65b79c781dc541ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110007 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#913861} Bug: 1239709 Change-Id: I82c40b1433aafcd71bea5a16ca6197b81c355151 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110756 Commit-Queue: Yi Gu <yigu@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Yi Gu <yigu@chromium.org> Auto-Submit: Yi Gu <yigu@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#913907}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3ba415c7e099..2b4ec955341d 2021-08-20 linxinan@google.com Add new subcommand for 'Changes Submitted Together'. 2021-08-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1236658 Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: I12452fcc24072414c873a3723c6baa178f53518f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111196 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#913908}
Also fixed / added tests in test_runner_test.py to cover this change and added it to PRESUBMIT. Bug: 1132476, 1215238 Change-Id: Idabec3b8cda3d63906f9579bce024ac49f3e2100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3094944 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by: Jeff Yoon <jeffyoon@google.com> Cr-Commit-Position: refs/heads/main@{#913909}
This CL should avoid BrowserContext::GetDefaultStoragePartition calls after the shutdown of that BrowserContext has already started. If shutdown has started, then after this CL: - BrowsingDataRemoverImpl::OnTaskComplete will return early. This will prevent internal calls to BrowsingDataRemoverImpl::GetStoragePartition. Additionally this will prevent calls to BrowsingDataRemoverImpl::Notify and (transitively) posting of BrowsingDataRemoverImpl::RunNextTask. - BrowsingDataRemoverImpl::RunNextTask will return early. This will prevent calls to BrowsingDataRemoverImpl::RemoveImpl which also calls BrowsingDataRemoverImpl::GetStoragePartition. Bug: 1216406 Change-Id: I89a4adc959012ec7df2835ba6c56ac47c8ca69b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2959604 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/main@{#913910}
Clients in this group were crashing because due to writing when blocking was disallowed. Note that this experiment is enabled only on canary and dev. Blocking is okay here for the Extended Variations Safe Mode experiment. One experiment group needs to write information to disk to detect crashes. Bug: b/184937096 Change-Id: I553b2a89c126e6e69aa0d276bcd5c09d475db6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3105665 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#913911}
With this CL, Lacros join Ash/Chrome and Android as part of the group of platforms that have touch based drag/drop setting enabled. Test case: https://glitch.com/~simple-drag-drop BUG=1236653 Change-Id: I9d5563b84fb58bc9c6690bf2843c33a55d5a2573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3101253 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#913912}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36979ee355d6..6db93bd5df09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com,yigu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1221410 Tbr: kelvinjiang@google.com,yigu@google.com Change-Id: Ibb37cf5bfe8c27b3b15fd04f1a859597cfd76f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110514 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#913913}
Per w3c/webcodecs#346 VideoColorSpace attributes are no longer nullable (their internals still are). And VideoEncoderConfig.colorSpace is now removed (UA picks output color space). Work remains to fully plumb the correct output colorspace. See bug crbug/1241448 Bug: 1241470, 1241448 Change-Id: Id8d8c78e5b936bb696e42c1d121e4c0102fa7abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3106040 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/main@{#913914}
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tester%20(Ozone%20Wayland)/16996/test-results Bug: 1232197 Change-Id: Ib19c6553fe6a9712f72101b888eddb0f369f7e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111126 Commit-Queue: Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Owners-Override: Yi Gu <yigu@chromium.org> Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/main@{#913915}
This is a follow up of CL [1], where the touch drag/drop setting was enabled for Lacros, similarly to ChromeOS and Android. At this point, this CL relaxes WaylandDataDragController::StartSession(), verifying whether a pointer button is down OR an active touch. This enables data drag/drop with touch. Test case: https://glitch.com/~simple-drag-drop [1] https://crrev.com/c/3101253 BUG=1236653 R=nickdiego@igalia.com Change-Id: I4e752cbaba7dedcda350ce0bec53f253ec34bdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111065 Reviewed-by: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#913916}
errors wl_log_set_handler_client() allows chrome to print wl_log in preferred format and output streams. See how exo does it: https://source.chromium.org/chromium/chromium/src/+/main:components/exo/wayland/server.cc;l=147;drc=6f5405753a101d6059b45d702a3bcec75a28c114 Change-Id: I9002704a4ceb89f60cb897baf52743e5b3159d90 Bug: 1172305, 1190819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3107893 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/main@{#913917}
ReadAvailableTypes() wrongly showed that the SVG format was only available on Macs. The existing SVG test only checked IsFormatAvailable(), allowing the test to pass while real code was broken. Bug: 1241712 Change-Id: I677ab25a61ee55d3945843b5ade43741d041dd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111085 Reviewed-by: Peter Kvitek <kvitekp@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#913918}
See bug for details. Bug: 1241883 Change-Id: If5fa1044c947b4147da3d03244fe048d9218e1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111348 Commit-Queue: Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Owners-Override: Yi Gu <yigu@chromium.org> Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/main@{#913919}
This reverts commit 8973a67. Reason for revert: Culprit reverted in crbug.com/1241808 Original change's description: > [Sheriff] Disable EmergencyStopTracingTest.StopOnThreadPool > > See bug for details. > > Bug: 1241883 > Change-Id: If5fa1044c947b4147da3d03244fe048d9218e1c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111348 > Commit-Queue: Yi Gu <yigu@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Owners-Override: Yi Gu <yigu@chromium.org> > Auto-Submit: Yi Gu <yigu@chromium.org> > Reviewed-by: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/main@{#913919} Bug: 1241883 Change-Id: I4ac8b94cda0e712ead99cddfe6624482a724af48 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110768 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yi Gu <yigu@chromium.org> Owners-Override: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#913920}
Test is flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests%20(with%20patch)&tests=TooltipBrowserTest.ShowTooltipFromIFrameWithKeyboard Bug: 1241736 Change-Id: I2ec3f13cbc7bf109bb9b9a7004fdd1512c5ea4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111019 Commit-Queue: Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Owners-Override: Yi Gu <yigu@chromium.org> Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/main@{#913921}
This change removes the use of Value::GetAsString and replaces with Value::is_string, Value::GetString(), Value::GetIfString(). This CL was uploaded by git cl split. R=garykac@chromium.org Bug: 1187007 Change-Id: Ie34612c95578135b75a295b50de14b000fcde059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3097110 Auto-Submit: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/main@{#913922}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2b6063995b67..55dc71680e20 2021-08-20 pfaffe@chromium.org Fix sorting order when searching for files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia844cbcda7cff25ee5fee0c8f08e7e3471e047a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111191 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#913923}
https://dawn.googlesource.com/dawn.git/+log/bd45466c6d4c..491e9c87bd91 2021-08-20 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from d47a7ef0cf0c to f6a49d69b4bf (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC jrprice@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: jrprice@google.com Change-Id: I30e7512bdcfaf99c7158b3f63be7b5fc34ed77dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110517 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#913924}
CaptureHandleConfig is provided by the captured page to the browser using MediaDevicesDispatcherHost mojo bridge. There is currently no way for this config to be cached in the browser for non-primary pages. 1) BFCache is disabled for a frame if media capabilties are used by accessing this interface. So a page which provides this config is never cached using BFCache. 2) For pre-rendered pages, binding this interface is deferred until activation. This change adds a test to ensure this. Bug: 1224404 Change-Id: I4e3ded6b02ca90c5109af3e5e2834aaadb41ec12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3021361 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/main@{#913925}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/39b068a4..1d285090 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3203e7218e86d4fb95024f4fcdebeb3d49519ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111465 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#913926}
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/nNOU--_vWyI Bug: 1114172 Change-Id: I1fb4542f5996ab84a4aed77c029ad8716ff45ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3107719 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#913927}
Reduce unnecessary logging in production and some other cleanup bits. BUG=b:184720732 TEST=Verify builds and manually tested with Photos. Change-Id: Iddef985449c977cfae10f0541c8a0fc709b77124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3107731 Commit-Queue: Alan Ding <alanding@chromium.org> Reviewed-by: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/main@{#913928}
If accuracy tip is shown and site connection is secure, show "Accuracy check" chip in the location bar. Bug: 1240143 Change-Id: If55f9a6f43dc83256065ea93e68b234af6be48cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3094069 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/main@{#913929}
We are attempting to roll out ChromeOS FYI Release (kevin). However we are failing almost every run of webgl2_conformance_validating_tests. Currently various tests will crash due to PartitionAlloc Heap corruption errors. TEST=webgl2_conformance_validating_tests Bug: 1212917 Change-Id: I8aa34f064e511b506b40e1b06f2cb779d60701ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111165 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/main@{#913930}
This extends the expiry of Compositing.Renderer.LayerSkippedForDrawPropertiesDueToBackface so that it matches the expiry of Compositing.Renderer.LayerUpdateSkippedDueToBackface. Both of them seem likely to be useful when looking at backface-visibility interop in the coming months. Also add myself as an additional owner of both. Bug: 1235397, 1008483 Change-Id: I9e261adacbe7991159e231e0033adebeab1861f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111998 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#914130}
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202108210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/1lohddnhRFFq6qsCuuqFv25S4gSWpjIT7fgy2g-Y_8EC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: If6c8200c11a9095fe772b51e9f222f9ac98ba08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112366 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914131}
…77.48-r1 to 93-4577.36-1629108064-benchmark-93.0.4577.51-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I18a2ac4443f524720746200397acff0cf109b1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112466 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914132}
…cast builds Bug: 1066980 Change-Id: I73f81c15a1201d18bbc5d5bba32cca219098c6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111029 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/main@{#914133}
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e4b161d43b8b..ffda0347a440 2021-08-20 ldionne.2@gmail.com [libc++] Remove test-suite annotations for unsupported Clang versions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/libcxxabi-chromium Please CC thakis@chromium.org,hans@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: thakis@chromium.org,hans@chromium.org Change-Id: I712cf320f7ef943b255304b3578d1b89502e7b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112468 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914134}
Change-Id: Ic6d31396e7b89e6dc00936a81d9817a1580b3188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112446 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914135}
…a chromecast builds" This reverts commit e6d1f72. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision e6d1f72 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2ZDFmNzJiNmQ1OTM2MGNiYTVjOWM4NzU5YThjMWQ4NjMxMjc1MDYM Sample Failed Build: https://ci.chromium.org/b/8838260418218419745 Sample Failed Step: compile Original change's description: > Enable -Wunreachable-code-aggressive in lacros and non-fuchsia chromecast builds > > Bug: 1066980 > Change-Id: I73f81c15a1201d18bbc5d5bba32cca219098c6df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111029 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Arthur Eubanks <aeubanks@google.com> > Reviewed-by: Arthur Eubanks <aeubanks@google.com> > Cr-Commit-Position: refs/heads/main@{#914133} Change-Id: Ibfda2c636249ad331afe3d009eec4da12d6c186c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112326 Reviewed-by: Avi Drissman <avi@chromium.org> Owners-Override: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#914136}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da572a71d098..ae5a55e99c8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I3eed507f11f8c84b32e533d118d6893fe408c57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112487 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914137}
The install source for the system web app is InstallSource::kSystem. Change-Id: I7bf03e4a350cdff54545eb6ebb43723fdf8aaa44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110806 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/main@{#914138}
GetAppTypeName() is now declared in a header, and no longer implemented in an anonymous namespace. We add a browser test, in preparation for refactoring GetAppTypeNameForWebApp() to not rely on WebAppProvider. Currently only web apps are tested. Bug: 1239989 Change-Id: I62109b74bf65839edff8a4cf78a055befd162703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110165 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#914139}
Change-Id: I644a88a54c99a19d656d531e4ce19d5f62aaabbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112570 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914140}
We avoid calling WebAppProvider::Get(), as the web app provider for the Ash process cannot tell us about web apps managed by the Lacros process. Bug: 1239989 Change-Id: I0600de9116be2d7f98dd9f6d2f58ae7396bcc88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3102786 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#914141}
This CL will add skew tests for version 93.0.4577.56. See crbug.com/1041619 and crbug.com/1099017 for more information. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: Ie50b2fc726c75b6ae6a94fd6267474dd961b16c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112572 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914142}
This CL will add skew tests for version 94.0.4606.15. See crbug.com/1041619 and crbug.com/1099017 for more information. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I0e7a0056cb36576b51cdeda294408c7674e4440f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112573 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914143}
This requires moving the String::Utf8() implementation to StringView. In addition, StringView must provide an implementation of ContainsOnlyASCIIOrEmpty(). Note, there do not appear to be any unit tests for Utf8(), ContainsOnlyASCIIOrEmpty(), or StringUTF8Adaptor() that could be updated to test against StringView. Fixed: 1241614 Change-Id: Iac9223a8d1030c11ed53d7d5460b98d8209e3c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3110927 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#914144}
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: If501acbcd66681107b8663ee3ef9c45c05edce4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111548 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914145}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2ec525f0a062..0dcde0a0d7ba 2021-08-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8559e2daf3dc6051e1384af8c6a024134daa039c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112515 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914146}
Removed the possibility of using the old ZipArchiver-based ZIP creation system. The new ZipFileCreator-based system has been released and enabled by default in M-93. Removed Chrome feature FilesZipPack and matching flag files-zip-pack Note that the ZipArchiver extension itself is still installed on the system. It will be removed in a subsequent CL. BUG=chromium:1201052, chromium:912236 TEST=Manual tests, checking that ZIP files can still be created Change-Id: Ic832930fd41a588d68984eadd52dfb37cfa86416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3104652 Reviewed-by: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/main@{#914147}
https://skia.googlesource.com/skia.git/+log/51e33b51542b..ab6c8725fbcf 2021-08-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 32db94dfd0b8 to 36d308a1e51f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: borenet@google.com Change-Id: I293219e363ede48ebc0ab9dd5042e0e45e3ce416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112371 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914148}
The ZipArchiver extension is not used anymore. Note that the ZipArchiver extension itself is still installed on the system. It will be removed in a subsequent CL. BUG=chromium:1201052, chromium:912236 TEST=Manual tests, checking that ZIP files can still be created and mounted Change-Id: Iad4ee1a6ec5b6eea3a6d0d42966834fe949c6730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3105629 Reviewed-by: Jeremie Boulic <jboulic@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/main@{#914149}
Change-Id: I096fe963f5bad776de2f05dc7eb91989b584c30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3111170 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914150}
We have observed significant memory regressions on processes where BRP is "disabled", because it wasn't fully disabled. Until now each process would always start in the BRP-enabled state, and switch to disabled state only once the process type is known. This CL reverses it. As a result, we're losing protection for pointers that point to early allocations. The difficult part of this CL was dealing with aligned alloc partition. It has to be separated into its own partition when BRP is enabled (unless "previous slot" configuration is used). When enable_runtime_backup_ref_ptr_control is on, such a separation has to occur upon enabling BRP -- this also means we don't have to create a dedicated aligned alloc partition in processes that never get BRP enabled. If BRP is enabled at init, such a separation has to occur at init as well. DCHECK_IS_ON adds further complexity, as it requires to make this separation at init, regardless of when/if BRP is enabled. Bug: 1073933 Change-Id: Ie54c419a10b49db33f3d18e03421905e1e59fc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3086051 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#914151}
…s found in Blink > editing Paragraph boundaries should be the same regardless as to whether they have been computed in ui/accessibility/ax_position.h in the browser process, or in third_party/blink/renderer/core/editing/visible_units_paragraph.cc". Otherwise, pressing Ctrl+Up/Down (or Option-Up/Down on the Mac) while in a content editable would move to different boundaries than the ones used to read out the current paragraph by screen readers. Also fixes AXRange so that it doesn't add a preceding line break when computing the text spanning the range and the first paragraph is completely ignored. Otherwise the user will be confused since the user's actual position in the tree's text representation appears to be after the ignored paragraph. navigates by paragraph in rich edit fields. R=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: Screen readers both on Win and on Mac now read the current paragraph when the user Bug: 1135589, 1147543, 1027753, 1015408 Change-Id: I9cfe36a2ad187f0ec3dc496fd806662a8fb76233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3097371 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#914152}
https://skia.googlesource.com/skia.git/+log/ab6c8725fbcf..6b335c53e8c2 2021-08-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: borenet@google.com Change-Id: I1c6463b026c556899e18ee5af185728dfd860bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3112298 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#914153}
pull bot
pushed a commit
that referenced
this pull request
Sep 25, 2021
This reverts commit 77e9679. Reason for revert: Likely cause of failure Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" The failure is a crash in browser_tests. This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. Here is the first failure as an example: Retrying 1 test (retry #0) [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x556151f72449 base::debug::CollectStackTrace() #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() #9 0x5561502b8919 content::Navigator::DidNavigate() #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x5561530201e0 mojo::MessageDispatcher::Accept() #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x55615301e323 base::internal::Invoker<>::RunOnce() #20 0x556151f35f23 base::TaskAnnotator::RunTask() #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x556151fa9c4b base::MessagePumpLibevent::Run() #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x556151f18c1b base::RunLoop::Run() #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() #38 0x556150036912 content::BrowserMain() #39 0x556150bf6aed content::RunBrowserProcessMain() #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() #41 0x556150bf752e content::ContentMainRunnerImpl::Run() #42 0x556150bf5b38 content::RunContentProcess() #43 0x556150bf5c08 content::ContentMain() #44 0x5561525e3543 content::BrowserTestBase::SetUp() #45 0x556151ec12c1 InProcessBrowserTest::SetUp() #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x55614f308e8f testing::Test::Run() #48 0x55614f3097c5 testing::TestInfo::Run() #49 0x55614f309f21 testing::TestSuite::Run() #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() #51 0x55614f31338b testing::UnitTest::Run() #52 0x556151fd7ff2 base::TestSuite::Run() #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x556152613c1f content::LaunchTests() #55 0x556151e98224 LaunchChromeTests() #56 0x556151e9638b main #57 0x7f7dd56c4bf7 __libc_start_main #58 0x55614cca11ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 Here is the fourth: (different test in the same suite, different stack trace): [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x564f24b8af29 base::debug::CollectStackTrace() #1 0x564f24af2843 base::debug::StackTrace::StackTrace() #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() #9 0x564f22ed15f9 content::Navigator::DidNavigate() #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x564f24bc28cb base::MessagePumpLibevent::Run() #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x564f24b316fb base::RunLoop::Run() #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() #28 0x564f2522df45 content::RunAllPendingInMessageLoop() #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() #38 0x564f22c4f832 content::BrowserMain() #39 0x564f2380f5bd content::RunBrowserProcessMain() #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() #42 0x564f2380e608 content::RunContentProcess() #43 0x564f2380e6d8 content::ContentMain() #44 0x564f251fc233 content::BrowserTestBase::SetUp() #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x564f21f21e4f testing::Test::Run() #48 0x564f21f22785 testing::TestInfo::Run() #49 0x564f21f22ee1 testing::TestSuite::Run() #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() #51 0x564f21f2c34b testing::UnitTest::Run() #52 0x564f24bf0c72 base::TestSuite::Run() #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x564f2522c62f content::LaunchTests() #55 0x564f24ab0cf4 LaunchChromeTests() #56 0x564f24aaee5b main #57 0x7f03d336fbf7 __libc_start_main #58 0x564f1f8b94ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 Original change's description: > Privatise unnecessarily public current_input_method in > InputMethodManagerImpl::StateImpl. > > This involves replacing some direct pokes of current_input_method > with public GetCurrentInputMethod() that employs a fallback onto > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > blank. This should be more reasonable and consistent. > > Bug: 1134465 > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924702} Bug: 1134465 Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 Auto-Submit: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#924810}
pull bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
… CrosState" This reverts commit 3895114. Reason for revert: likely cause of failures Step "chromeos_components_unittests on Ubuntu-18.04" failing on builder "Linux Chromium OS ASan LSan Tests (1)" The first run with the relevant failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/40730/overview The following tests consistently fail starting after this first run: CrosStateSenderTest.NotificationFeatureStateChanged CrosStateSenderTest.PerformUpdateCrosStateRetrySequence The first fails with this stack trace: --- [ RUN ] CrosStateSenderTest.NotificationFeatureStateChanged ================================================================= ==4136==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700004b31c at pc 0x5559c16fed11 bp 0x7fffb87b9250 sp 0x7fffb87b9248 READ of size 4 at 0x60700004b31c thread T0 #0 0x5559c16fed10 in chromeos::multidevice_setup::MultiDeviceSetupClient::GetFeatureState(chromeos::multidevice_setup::mojom::Feature) const ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:51:44 #1 0x5559ce6da0ed in chromeos::phonehub::CrosStateSender::PerformUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:93:34 #2 0x5559ce6d9e1d in chromeos::phonehub::CrosStateSender::AttemptUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:85:3 #3 0x5559c17102b7 in chromeos::secure_channel::ConnectionManager::NotifyStatusChanged() ./../../chromeos/services/secure_channel/public/cpp/client/connection_manager.cc:23:14 #4 0x5559ba7314dc in chromeos::phonehub::CrosStateSenderTest_NotificationFeatureStateChanged_Test::TestBody() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:146:29 #5 0x5559baf612a1 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x5559baf612a1 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2706:5 #7 0x5559baf62ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #8 0x5559baf647b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #9 0x5559baf87628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #10 0x5559baf86d49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x5559baf86d49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #12 0x5559c6e8422f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #13 0x5559c6e8422f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #14 0x5559bd07db0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #15 0x5559c6e8a853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #16 0x5559c6e8a4d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #17 0x5559ba482d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #18 0x7f002b751bf6 in __libc_start_main ??:0:0 0x60700004b31c is located 4 bytes to the right of 72-byte region [0x60700004b2d0,0x60700004b318) allocated by thread T0 here: #0 0x5559ba47faed in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 #1 0x5559c14ad498 in __libcpp_operator_new<unsigned long> ./../../buildtools/third_party/libc++/trunk/include/new:235:10 #2 0x5559c14ad498 in __libcpp_allocate ./../../buildtools/third_party/libc++/trunk/include/new:261:10 #3 0x5559c14ad498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator.h:82:38 #4 0x5559c14ad498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator_traits.h:261:20 #5 0x5559c14ad498 in std::__1::vector<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState>, std::__1::allocator<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> > >::__vallocate(unsigned long) ./../../buildtools/third_party/libc++/trunk/include/vector:994:37 #6 0x5559c16fdfe3 in vector<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../buildtools/third_party/libc++/trunk/include/vector:1224:9 #7 0x5559c16fdfe3 in flat_tree<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../base/containers/flat_tree.h:571:20 #8 0x5559c16fdfe3 in flat_tree ./../../base/containers/flat_tree.h:595:7 #9 0x5559c16fdfe3 in flat_tree ./../../base/containers/flat_map.h:211:15 #10 0x5559c16fdfe3 in chromeos::multidevice_setup::MultiDeviceSetupClient::GenerateDefaultFeatureStatesMap() ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:21:10 #11 0x5559d736b57e in chromeos::multidevice_setup::FakeMultiDeviceSetupClient::FakeMultiDeviceSetupClient() ./../../chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup_client.cc:13:27 #12 0x5559ba733ad7 in make_unique<chromeos::multidevice_setup::FakeMultiDeviceSetupClient> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725:32 #13 0x5559ba733ad7 in chromeos::phonehub::CrosStateSenderTest::SetUp() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:40:9 #14 0x5559baf6118e in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #15 0x5559baf6118e in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2701:3 #16 0x5559baf62ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #17 0x5559baf647b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #18 0x5559baf87628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #19 0x5559baf86d49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x5559baf86d49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #21 0x5559c6e8422f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #22 0x5559c6e8422f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #23 0x5559bd07db0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #24 0x5559c6e8a853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #25 0x5559c6e8a4d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #26 0x5559ba482d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #27 0x7f002b751bf6 in __libc_start_main ??:0:0 SUMMARY: AddressSanitizer: heap-buffer-overflow (/b/s/w/ir/out/Release/chromeos_components_unittests+0x15f40d10) Shadow bytes around the buggy address: 0x0c0e80001610: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fa fa 0x0c0e80001620: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c0e80001630: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fd fd 0x0c0e80001640: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0e80001650: fd fd fd fd fd fd fa fa fa fa 00 00 00 00 00 00 =>0x0c0e80001660: 00 00 00[fa]fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0e80001670: fd fa fa fa fa fa fd fd fd fd fd fd fd fd fd fd 0x0c0e80001680: fa fa fa fa 00 00 00 00 00 00 00 00 00 00 fa fa 0x0c0e80001690: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c0e800016a0: fd fd fd fd fd fd fd fd fd fd fa fa fa fa 00 00 0x0c0e800016b0: 00 00 00 00 00 00 00 00 fa fa fa fa 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==4136==ABORTING --- The second fails with this one: --- [ RUN ] CrosStateSenderTest.PerformUpdateCrosStateRetrySequence ================================================================= ==3811==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700005f9ec at pc 0x5579c6175d11 bp 0x7ffd5e6a0e10 sp 0x7ffd5e6a0e08 READ of size 4 at 0x60700005f9ec thread T0 #0 0x5579c6175d10 in chromeos::multidevice_setup::MultiDeviceSetupClient::GetFeatureState(chromeos::multidevice_setup::mojom::Feature) const ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:51:44 #1 0x5579d31510ed in chromeos::phonehub::CrosStateSender::PerformUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:93:34 #2 0x5579d3150e1d in chromeos::phonehub::CrosStateSender::AttemptUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:85:3 #3 0x5579c61872b7 in chromeos::secure_channel::ConnectionManager::NotifyStatusChanged() ./../../chromeos/services/secure_channel/public/cpp/client/connection_manager.cc:23:14 #4 0x5579bf1a3085 in chromeos::phonehub::CrosStateSenderTest_PerformUpdateCrosStateRetrySequence_Test::TestBody() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:63:29 #5 0x5579bf9d82a1 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x5579bf9d82a1 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2706:5 #7 0x5579bf9d9ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #8 0x5579bf9db7b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #9 0x5579bf9fe628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #10 0x5579bf9fdd49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x5579bf9fdd49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #12 0x5579cb8fb22f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #13 0x5579cb8fb22f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #14 0x5579c1af4b0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #15 0x5579cb901853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #16 0x5579cb9014d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #17 0x5579beef9d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #18 0x7fc58b24bbf6 in __libc_start_main ??:0:0 0x60700005f9ec is located 4 bytes to the right of 72-byte region [0x60700005f9a0,0x60700005f9e8) allocated by thread T0 here: #0 0x5579beef6aed in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 #1 0x5579c5f24498 in __libcpp_operator_new<unsigned long> ./../../buildtools/third_party/libc++/trunk/include/new:235:10 #2 0x5579c5f24498 in __libcpp_allocate ./../../buildtools/third_party/libc++/trunk/include/new:261:10 #3 0x5579c5f24498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator.h:82:38 #4 0x5579c5f24498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator_traits.h:261:20 #5 0x5579c5f24498 in std::__1::vector<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState>, std::__1::allocator<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> > >::__vallocate(unsigned long) ./../../buildtools/third_party/libc++/trunk/include/vector:994:37 #6 0x5579c6174fe3 in vector<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../buildtools/third_party/libc++/trunk/include/vector:1224:9 #7 0x5579c6174fe3 in flat_tree<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../base/containers/flat_tree.h:571:20 #8 0x5579c6174fe3 in flat_tree ./../../base/containers/flat_tree.h:595:7 #9 0x5579c6174fe3 in flat_tree ./../../base/containers/flat_map.h:211:15 #10 0x5579c6174fe3 in chromeos::multidevice_setup::MultiDeviceSetupClient::GenerateDefaultFeatureStatesMap() ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:21:10 #11 0x5579dbde257e in chromeos::multidevice_setup::FakeMultiDeviceSetupClient::FakeMultiDeviceSetupClient() ./../../chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup_client.cc:13:27 #12 0x5579bf1aaad7 in make_unique<chromeos::multidevice_setup::FakeMultiDeviceSetupClient> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725:32 #13 0x5579bf1aaad7 in chromeos::phonehub::CrosStateSenderTest::SetUp() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:40:9 #14 0x5579bf9d818e in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #15 0x5579bf9d818e in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2701:3 #16 0x5579bf9d9ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #17 0x5579bf9db7b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #18 0x5579bf9fe628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #19 0x5579bf9fdd49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x5579bf9fdd49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #21 0x5579cb8fb22f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #22 0x5579cb8fb22f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #23 0x5579c1af4b0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #24 0x5579cb901853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #25 0x5579cb9014d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #26 0x5579beef9d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #27 0x7fc58b24bbf6 in __libc_start_main ??:0:0 SUMMARY: AddressSanitizer: heap-buffer-overflow (/b/s/w/ir/out/Release/chromeos_components_unittests+0x15f40d10) Shadow bytes around the buggy address: 0x0c0e80003ee0: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fd fd 0x0c0e80003ef0: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0e80003f00: fd fd fd fd fd fd fa fa fa fa fd fd fd fd fd fd 0x0c0e80003f10: fd fd fd fd fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0e80003f20: fd fd fa fa fa fa fd fd fd fd fd fd fd fd fd fd =>0x0c0e80003f30: fa fa fa fa 00 00 00 00 00 00 00 00 00[fa]fa fa 0x0c0e80003f40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==3811==ABORTING --- Original change's description: > [CameraRoll]Send camera roll setting to the Android device in CrosState > > Include camera roll setting state as part of CrosState, > so connected mobile device would be able to get update > when setting value is toggled. > > Change-Id: I04d0ed3872d5adeff5e8f8dc76c6eb6df3a50b9c > Bug: https://crbug.com/1221297 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173740 > Commit-Queue: Jianbing Wu <jianbing@google.com> > Auto-Submit: Jianbing Wu <jianbing@google.com> > Reviewed-by: Jon Mann <jonmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924995} Bug: https://crbug.com/1221297 Change-Id: Ic87d96786b4244b27b1e284f801df8799911b1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184482 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Mark Pearson <mpearson@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#925118}
pull bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
This reverts commit 37ea471. Reason for revert: Reverted CL is unrelated to the cited "reason for revert". Original change's description: > Revert "Privatise unnecessarily public current_input_method in" > > This reverts commit 77e9679. > > Reason for revert: > Likely cause of failure > Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" > > The failure is a crash in browser_tests. > > This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. > > Here is the first failure as an example: > Retrying 1 test (retry #0) > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed > 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als > 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x556151f72449 base::debug::CollectStackTrace() > #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() > #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() > #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() > #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() > #9 0x5561502b8919 content::Navigator::DidNavigate() > #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() > #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() > #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x5561530201e0 mojo::MessageDispatcher::Accept() > #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x55615301e323 base::internal::Invoker<>::RunOnce() > #20 0x556151f35f23 base::TaskAnnotator::RunTask() > #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x556151fa9c4b base::MessagePumpLibevent::Run() > #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x556151f18c1b base::RunLoop::Run() > #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() > #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() > #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() > #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() > #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() > #38 0x556150036912 content::BrowserMain() > #39 0x556150bf6aed content::RunBrowserProcessMain() > #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() > #41 0x556150bf752e content::ContentMainRunnerImpl::Run() > #42 0x556150bf5b38 content::RunContentProcess() > #43 0x556150bf5c08 content::ContentMain() > #44 0x5561525e3543 content::BrowserTestBase::SetUp() > #45 0x556151ec12c1 InProcessBrowserTest::SetUp() > #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x55614f308e8f testing::Test::Run() > #48 0x55614f3097c5 testing::TestInfo::Run() > #49 0x55614f309f21 testing::TestSuite::Run() > #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() > #51 0x55614f31338b testing::UnitTest::Run() > #52 0x556151fd7ff2 base::TestSuite::Run() > #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x556152613c1f content::LaunchTests() > #55 0x556151e98224 LaunchChromeTests() > #56 0x556151e9638b main > #57 0x7f7dd56c4bf7 __libc_start_main > #58 0x55614cca11ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 > > Here is the fourth: (different test in the same suite, different stack trace): > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff > 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB > 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als > 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x564f24b8af29 base::debug::CollectStackTrace() > #1 0x564f24af2843 base::debug::StackTrace::StackTrace() > #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() > #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() > #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() > #9 0x564f22ed15f9 content::Navigator::DidNavigate() > #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() > #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() > #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() > #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() > #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() > #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x564f24bc28cb base::MessagePumpLibevent::Run() > #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x564f24b316fb base::RunLoop::Run() > #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() > #28 0x564f2522df45 content::RunAllPendingInMessageLoop() > #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() > #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() > #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() > #38 0x564f22c4f832 content::BrowserMain() > #39 0x564f2380f5bd content::RunBrowserProcessMain() > #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() > #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() > #42 0x564f2380e608 content::RunContentProcess() > #43 0x564f2380e6d8 content::ContentMain() > #44 0x564f251fc233 content::BrowserTestBase::SetUp() > #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() > #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x564f21f21e4f testing::Test::Run() > #48 0x564f21f22785 testing::TestInfo::Run() > #49 0x564f21f22ee1 testing::TestSuite::Run() > #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() > #51 0x564f21f2c34b testing::UnitTest::Run() > #52 0x564f24bf0c72 base::TestSuite::Run() > #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x564f2522c62f content::LaunchTests() > #55 0x564f24ab0cf4 LaunchChromeTests() > #56 0x564f24aaee5b main > #57 0x7f03d336fbf7 __libc_start_main > #58 0x564f1f8b94ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 > > Original change's description: > > Privatise unnecessarily public current_input_method in > > InputMethodManagerImpl::StateImpl. > > > > This involves replacing some direct pokes of current_input_method > > with public GetCurrentInputMethod() that employs a fallback onto > > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > > blank. This should be more reasonable and consistent. > > > > Bug: 1134465 > > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > > Reviewed-by: Keith Lee <keithlee@chromium.org> > > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#924702} > > Bug: 1134465 > Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Owners-Override: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924810} Bug: 1134465 Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#925158}
pull bot
pushed a commit
that referenced
this pull request
Oct 16, 2021
This reverts commit 842626c. Reason for revert: [sheriff] suspected to cause multiple failures in SafetyTipPageInfoBubbleViewBrowserTests on linux-ubsan-vptr: https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr/6970 Sample failure: [ RUN ] All/SafetyTipPageInfoBubbleViewBrowserTest.BubbleWaitsForVisible/1 [...] ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23: runtime error: downcast of address 0x180601885e00 which does not point to an object of type 'PageInfoBubbleView' 0x180601885e00: note: object is of type 'PageInfoNewBubbleView' 00 00 00 00 18 70 11 10 50 56 00 00 80 68 50 01 06 18 00 00 b8 00 00 00 30 00 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'PageInfoNewBubbleView' #0 0x564ffa77d440 in SafetyTipPageInfoBubbleViewBrowserTest::CheckPageInfoShowsSafetyTipInfo(Browser*, security_state::SafetyTipStatus, GURL const&) chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 #1 0x564ffa788397 in SafetyTipPageInfoBubbleViewBrowserTest_BubbleWaitsForVisible_Test::RunTestOnMainThread() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:837:3 #2 0x565002ae1026 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:868:7 #3 0x565001aae15a in Run base/callback.h:142:12 #4 0x565001aae15a in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1745:38 #5 0x565001aaba50 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1083:18 #6 0x564ffd8e2f00 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:957:28 #7 0x564ffe307f82 in Run base/callback.h:142:12 #8 0x564ffe307f82 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:41:29 #9 0x564ffd8e2368 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:865:25 #10 0x564ffd8e889c in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:131:15 #11 0x564ffd8dec1e in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:45:32 #12 0x564fff2a06e8 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:641:10 #13 0x564fff2a2e90 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) content/app/content_main_runner_impl.cc:1137:10 #14 0x564fff2a1f18 in content::ContentMainRunnerImpl::Run(bool) content_main_runner_impl.cc #15 0x564fff29dde0 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) content_main.cc #16 0x564fff29e7dd in content::ContentMain(content::ContentMainParams const&) content_main.cc #17 0x565002adfcff in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:712:3 #18 0x5650018271c4 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:401:20 #19 0x564ffa79d759 in SafetyTipPageInfoBubbleViewBrowserTest::SetUp() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:306:27 #20 0x564ffb8f8c7d in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2701:3 #21 0x564ffb8fa600 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2885:11 #22 0x564ffb8fc1bb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3044:30 #23 0x564ffb9115ca in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5903:44 #24 0x564ffb90fd8c in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5470:10 #25 0x565001a12e28 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #26 0x565001a12e28 in base::TestSuite::Run() base/test/test_suite.cc:445:16 #27 0x5650017d0bac in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:88:22 #28 0x5650017d0c1b in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome_test_launcher.cc #29 0x565002b8529b in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:409:31 #30 0x5650017d11b1 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:284:10 #31 0x5650017c9dcc in main chrome/test/base/browser_tests_main.cc:61:10 #32 0x7fc242b01bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6) #33 0x564ff76da7e9 in _start (/b/s/w/ir/out/Release/browser_tests+0xe8af7e9) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 in Original change's description: > Enable PageInfoV2Desktop by default > > Enable flag and remove testing config. > > Bug: 1188101 > Change-Id: Ifd839436f3d4c0127d15b449bbca84855ccd858f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217207 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Cr-Commit-Position: refs/heads/main@{#931972} Bug: 1188101 Change-Id: Ic51b9fdc730b7046e24b4d394248218b86eef09d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226638 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932067}
pull bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
This CL changes the aura::WindowObserver hook used in
exo::ExtendedDragSource:
Previously, ExtendedDragSource::OnWindowVisibilityChanging() was
used to call ash::ToplevelWindowEventHandler::AttemptToStartDrag(),
and kick off the drag 'n drop.
Problem is that for the scenario of TabletMode ON and WebUITabStrip
OFF, using OnWindowVisibilityChanging() hook is too early.
Reason:
In today's ToT, when a window detaches, during a tab drag 'n drop,
the following check takes place and fails, causing the whole
operation to abort (see lines 309-310 below):
295 std::unique_ptr<WindowResizer> CreateWindowResizerForTabletMode(
296 aura::Window* window, ...) {
(...)
306 WindowState* window_state = WindowState::Get(window);
307 // Only maximized/fullscreen/snapped window can be dragged from
308 // the top of the screen.
309 if (!window_state->IsMaximized() && !window_state->IsFullscreen()
310 && !window_state->IsSnapped()) {
311 return nullptr;
This happens because the |window_state| in case is only set to
MAXIMIZED from a code that uses OnWindowVisibilityChanged() hook:
(...)
#12 0x7fe849164dda TabletModeWindowManager::OnWindowVisibilityChanged()
(...)
#15 0x7fe8520d2be3 aura::Window::NotifyWindowVisibilityChanged()
#16 0x7fe8520cdf2c aura::Window::SetVisibleInternal()
#17 0x7fe8520cdc54 aura::Window::Show()
#18 0x7fe84cfcf013 views::NativeWidgetAura::Show()
#19 0x7fe84cf89398 views::Widget::Show()
#20 0x561eee1cb154 exo::ShellSurfaceBase::CommitWidget()
#21 0x561eee1cacf6 exo::ShellSurfaceBase::OnSurfaceCommit()
Hence, using OnDraggedWindowVisibilityChanging() in
exo::ExtendedDragSource class is too early.
This CL changes the hook used to OnWindowVisibilityChanged(),
and also sets the following aura::Window properties, used by the
drag 'n drop logic: ash::kTabDraggingSourceWindowKey and
ash::kIsDraggingTabsKey.
With this change, the functionality starts to take shape, and it is
possible to drag the window around. Snapping and merge-back are still
not fully functional (see follow up CLs).
R=oshima@chromium.org
BUG=1252941
Change-Id: I8600652a974210e3081e97d6d65639582ad222ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254858
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/main@{#939226}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )