[pull] master from chromium:master #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This fetches and runs update.py to fetch the current stable clang and uses that clang. We still need the gcc toolchain's libstdc++. This probably slightly speeds up our ToT bots on Linux, although I didn't measure. Some future work: * Build against ToT libc++ instead of the gcc toolchain's libstdc++ * Use goma since the stable clang should always work with goma * Build our clang so the default linker is lld? This deviates from a normal clang build, but makes us immune to issues with old system linkers, which keeps biting us in LLVM tests. Bug: 1013560 Change-Id: I0e694a61e36d648a68fa8059a844309cc079440c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758156 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#862657}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d20870514252..9ab6e050326e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Icc36e66be0e342d30e51b14fab51af3c78df46cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757015 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862658}
Change-Id: I7e5a7c142e787a5bd7a8384b6c31a8a3d1157b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758567 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862659}
UkmRecorder now in chrome/ doesn't have chrome-specific dependencies. Moves java/native files to //components/ukm/android. Bug: 1171512 Change-Id: Ib8cc8068d2aa4dd341be7abc6c67a576e5687cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2755527 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#862660}
This is a reland of 1737674. In addition to the original change, this change removes other base::string16 usages in chrome/browser/web_applications/. Original change's description: > Reland "[LSC] Remove base::string16 alias" > > This is a reland of 13140c8. > This removes the last usage in chrome/installer/setup/downgrade_cleanup.cc > > > Original change's description: > > [LSC] Remove base::string16 alias > > > > This change removes the base::string16 alias and replaces remaining > > references to base::string16 with std::u16string. > > > > The base/strings/string16.h file and its #includes across the codebase > > will be removed in a follow-up. > > > > Bug: 1184339 > > Change-Id: I92da07f562821c50f0679b19d53af0e72459d163 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2756107 > > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > > Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Owners-Override: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#862431} > > Bug: 1184339 > Change-Id: I8d5b8afed26cf235a7871416b5827bdd7b3efd58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2756867 > Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org> > Owners-Override: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#862592} Bug: 1184339 Change-Id: I952ad65f72ab7b49b15f247cd358e26ba1f12869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757472 Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#862661}
https://android.googlesource.com/platform/external/perfetto.git/+log/a69cfa0429c0..dd9e5129de61 2021-03-12 lalitm@google.com Merge "metrics: add sched duration to trace metadata" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iffb5d3346374b4ba4f692d80287ba7e4f6dabc2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2755902 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862662}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: I781a30f6c9950da903c2e8450da2f8ebea05cc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757075 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862663}
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202103130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/AvrhwSKvouEQfjPW1oyNKtm8-iyQah8Rti0GXOOOOIQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I11edb8e7f2c33a5f55a7c67ff628626f73176885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758086 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862664}
https://skia.googlesource.com/skia.git/+log/90898de3468d..ddcb4d94f9dd 2021-03-13 brianosman@google.com In pipeline stage generator, never emit declarations for opaque types 2021-03-13 bungeman@google.com Expose text and clusters in SkTextBlob::Iter. 2021-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c62ff0e to ed65743 (453 revisions) 2021-03-12 jvanverth@google.com Precompile cached SkSL to MTLRenderPipelineState. 2021-03-12 csmartdalton@google.com Unblock msaa clip atlas on AMD, Imagination, and Adreno If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1187654,chromium:738643 Tbr: kjlubick@google.com Change-Id: I91d1a4c410ff2686c77456e860628b3e6fd9e0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758410 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862665}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb4b5329e328..05e08fc58eb8 2021-03-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic71f0a5b16b4821de932f6645ec3331ad727785c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758414 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862666}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I55ab7fcc9b96a3a19b60d8024321e8f1c5670808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757104 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862667}
AddAppAndShortcut() is called from various places, not only when an app is installed, but also when an app is launched. GetResizeLockState() has all the logic to calculate the resize lock state properly, so we need to call the function all the time instead of relying on the caller of AddAppAndShortcut() for setting the proper value. BUG=b:180252639 BUG=b:180252634 BUG=b:181613915 TEST=The resize lock state is properly restored after restart. Change-Id: If35de90b1bc229ec80ab280a9a92077027cff101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2745179 Reviewed-by: Long Cheng <lgcheng@google.com> Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#862668}
When a transfer is cancelled, the initiator of the cancellation should
1. write a cancellation frame to inform the other device that they
cancelled the transfer, and
2. wait a few seconds before closing the connection to ensure that
the non-initiating device has time to process the cancellation.
The device that did not initiate the cancellation should immediately
close the connection to the other device.
Before this CL, both the initiator and non-initiator of the cancellation
were waiting 5 seconds before closing the connection. In this CL, we
impose the delay only on the initiator of the cancellation. This ensures
that the connection is promptly closed and does not linger during
subsequent attempts. This is consistent with the implementation on
Android.
Manually verified Chromebook-to-Chromebook and phone-to-Chromebook that
both sender and receiver cancellations at all points in the Nearby Share
flow are properly handled. Subsequent retry attempts are successful
because there are not outstanding connections from previous attempts.
Fixed: 1186375, 1148598
Change-Id: I5bf126f1964747e4e4af440bbe489bb3a0be0d51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2747215
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#862669}
Bug: 1185304 Change-Id: I7d55a84d9f0030bb0a90f1c74e4d4f4dedbe6091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2755187 Reviewed-by: Cathy Li <chili@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#862670}
https://chromium.googlesource.com/angle/angle.git/+log/ca5dbef04014..cd881848f3bb 2021-03-13 ianelliott@google.com Actually skip a flaky/timeout test 2021-03-12 timvp@google.com Create GN arg to enable non-conformant features 2021-03-12 ianelliott@google.com Suppress flaky test on win-swangle If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I6582e2a61523d221e8db6d16aee202420ba53c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758411 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862671}
https://swiftshader.googlesource.com/SwiftShader.git/+log/314aa755ed3a..5cdf55ff2084 2021-03-13 capn@google.com Remove vkGetInstanceProcAddr from exported symbols on Fuchsia If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibebb1fc5fb5719d7a5fb7b157939a88456d278e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758751 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862672}
Bug: 1128060 Change-Id: I2d75fe329fecc927763ef8ab4a5609d593ae6ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2730028 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#862673}
BUG=b:181272129 BUG=b:180252634 TEST=Toggling the flag properly enables/disables the feature. Change-Id: Idfef0c36bbe7f8e47d0271b0ed854203fa702db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2744920 Reviewed-by: Long Cheng <lgcheng@google.com> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#862674}
Eventually AGSA will handle the case where the Chrome/AGSA accounts mismatch. Until then, we need to filter out users that have multiple accounts on the device. Putting this behind a flag to turn it off when AGSA supports the mismatch directly. Bug: 1182496 Change-Id: Id94379eabbe13f2c013dccf3bb03431b061aeb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2750824 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#862675}
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202103130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/E-e_LNx__jOJ0yLIln2aF9UR5pvhCAxrB89x9yTSZ9gC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: If580edeb81f4b7e70d73d2c9751da7a77a102d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758085 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862676}
Change-Id: I9e1390906f9493ce0da0ae13dd6a2754617f3ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758941 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862677}
https://chromium.googlesource.com/vulkan-deps.git/+log/9120d4ae84c6..d70f9e670332 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e93b165c7..478754c005 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,ynovikov@chromium.org Change-Id: I1b98e0e5523ffb1c7648fe1301806f0f1df0114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757462 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862678}
https://chromium.googlesource.com/catapult.git/+log/58bac6811f21..6e87bddf1b60 2021-03-13 weizhong@google.com Revert "Reland "Do not use StringIO"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1183514 Tbr: rmhasan@google.com Change-Id: I140c7287d19e0fae91e700a5496ce01e8884e685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757459 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862679}
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-amd64-generic-chrome R=chrome-os-gardeners@google.com Change-Id: I008326b818746c4c93c38ef3a5d69a9db25b96bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758228 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862680}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ab6e050326e..a53225ae25c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9b58d6acaa02e0eba803e287ccda3878268d778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758416 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862681}
https://skia.googlesource.com/skia.git/+log/ddcb4d94f9dd..4f3f64c110b1 2021-03-13 brianosman@google.com Preserve 'const' on globals and function parameters in runtime effects 2021-03-13 johnstiles@google.com Add Make factory function to Block. 2021-03-13 johnstiles@google.com Remove `fForceInline` argument from EmitArgs. 2021-03-13 johnstiles@google.com Revert "Performance experiment: Disable SkSL inliner in nanobench/skpbench." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ifabea0bade8ed74ec6b6e4e6e39f7467e2dfe1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757054 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862682}
This change removes #includes of base/strings/string16.h from the codebase. Bug: 1184339 Change-Id: I3b29dd94c6955d01029d24f88177b755863c865d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2756167 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#862683}
https://android.googlesource.com/platform/external/perfetto.git/+log/dd9e5129de61..09b47874a931 2021-03-13 treehugger-gerrit@google.com Merge "Refactor perfetto::StaticString into a standalone file." 2021-03-12 dsrbecky@google.com Merge "Adjust libunwindstack JIT API." 2021-03-12 lalitm@google.com Merge "perfetto: allow guardrail override on user builds" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I699f20db00854171b7f56e4b1cc0a8e5752670de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2757053 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862684}
This change removes base/strings/string16.h and remaining references to it from the code base. Bug: 1184339 Change-Id: Ia52688fac747cd2d70ea5d52be5d7c2dd0db4829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2756251 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Owners-Override: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#862685}
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202103140700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/um54hF8JE4xULrTZpNV8QAuySBY4KWesjpo7xpta5M8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I5a8f3d99cd63b01ecf1546aab632dd713300be43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758418 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862686}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/05e08fc58eb8..1582b65ca743 2021-03-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I315fc10594f5ccee4e4b32dbef4f7ce9617dc9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758417 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#862687}
pull bot
pushed a commit
that referenced
this pull request
Mar 15, 2021
…m_gtests This CL moves the check that verifies readiness of x11::Connection to InitializeUI that should be sufficient to stop execution of the browser if it's not possible to connect to XDisplay. In own turn, this allows to run such tests as vr_pixeltests, which do not actually require XDisplay. Otherwise, the following callstack results in a crash (when vr_pixeltests run). [FATAL:ozone_platform_x11.cc(277)] Check failed: x11::Connection::Get()->Ready(). Missing X server or $DISPLAY #0 0x557d0bc225f9 base::debug::CollectStackTrace() #1 0x557d0bba3a53 base::debug::StackTrace::StackTrace() #2 0x557d0bbad33f logging::LogMessage::~LogMessage() #3 0x557d0bbadcee logging::LogMessage::~LogMessage() #4 0x557d0bb0d498 ui::(anonymous namespace)::OzonePlatformX11::InitializeCommon() #5 0x557d0bb0d2bc ui::(anonymous namespace)::OzonePlatformX11::InitializeGPU() #6 0x557d0c358dd6 gl::GLImageTestSupport::InitializeGL() Bug: 1177253 Change-Id: I435d03b4688e72b37c10f16d12ac2130cff90f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2700032 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#862870}
pull bot
pushed a commit
that referenced
this pull request
Mar 19, 2021
This reverts commit b2446a0 Reason for revert: Trying again w/ build fixes. The two issues we saw yesterday with reland attempt #5 were fixed in https://crrev.com/c/2768998 (remoting linux installer) https://crrev.com/c/2768998 (GLES test scripts) But the change wasn't in the tree for very long, so there may well be more. Let's try again to see. Bug: 1112471 Cq-Include-Trybots: luci.chromium.try:linux-angle-rel Cq-Include-Trybots: luci.chrome.try:linux-chrome Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#864372}
pull bot
pushed a commit
that referenced
this pull request
Mar 19, 2021
This reverts commit d9caee7. Reason for revert: I believe this causes failure on Builder win-chrome. First failure: https://ci.chromium.org/ui/p/chrome/builders/ci/win-chrome/19774/blamelist Original change's description: > Reland #6 of "Force Python 3 to be used in build." > > This reverts commit b2446a0 > > Reason for revert: Trying again w/ build fixes. > > The two issues we saw yesterday with reland attempt #5 > were fixed in > https://crrev.com/c/2768998 (remoting linux installer) > https://crrev.com/c/2768998 (GLES test scripts) > > But the change wasn't in the tree for very long, so there may > well be more. Let's try again to see. > > Bug: 1112471 > Cq-Include-Trybots: luci.chromium.try:linux-angle-rel > Cq-Include-Trybots: luci.chrome.try:linux-chrome > Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#864372} Bug: 1112471 Change-Id: I1458c5a5ee5dbb8e1e6cfe367998ff378b29ba53 Cq-Include-Trybots: luci.chromium.try:linux-angle-rel Cq-Include-Trybots: luci.chrome.try:linux-chrome No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2774784 Auto-Submit: Owen Min <zmin@chromium.org> Owners-Override: Owen Min <zmin@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#864764}
pull bot
pushed a commit
that referenced
this pull request
Mar 23, 2021
This CL fixes a segfault when a WaylandScreen is created after a WaylandWindow.. Basically, when WaylandScreen is created, it gets the list of existing outputs, which it uses to create displays. In its own turn, it also checks what WaylandWindows are on those displays and calls WaylandWindow::UpdateBufferScale. This operation also results in SetBounds to be called, which calls to PlatformWindowDelegate::GetMinimumSizeForWindow, which requires ScreenOzone instance to have PlatformScreen (WaylandScreen in this case) to be set. But as long as creation of the screen, updating buffer scale, and setting updated bounds based on new scale value happens in the same sequence of calls, ScreenOzone just doesn't have the PlatformScreen set, and it results in a crash. See the stacktrace below - #3 0x7f9c30bba4c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x556900be4bad aura::ScreenOzone::GetPrimaryDisplay() #5 0x5568ff6aebff views::DesktopWindowTreeHostPlatform::GetRootTransform() #6 0x5568ff6af1ba views::DesktopWindowTreeHostPlatform::GetMinimumSizeForWindow() #7 0x5568faeb9aaf ui::WaylandWindow::SetBounds() #8 0x5568faeb961e ui::WaylandWindow::UpdateBufferScale() #9 0x5568faeb473d ui::WaylandScreen::AddOrUpdateDisplay() #10 0x5568faeb3023 ui::WaylandOutputManager::CreateWaylandScreen() #11 0x5568faec7fa2 ui::(anonymous namespace)::OzonePlatformWayland::CreateScreen() #12 0x556900be480a aura::ScreenOzone::ScreenOzone() #13 0x5568ff6aa10e views::DesktopScreenOzone::DesktopScreenOzone() This only happens in test environments (interactive_ui_tests, when Ozone is initialized, WaylandWindows are created, but the screen instance is created and set a bit later. Thus, make WaylandWindow use existing information about preferred outputs that it has. Bug: 1134495 Change-Id: I3f2f9349adc85684d5cf4f5e2bca8497c326bb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2773276 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#865569}
pull bot
pushed a commit
that referenced
this pull request
Apr 1, 2021
This is a reland of d9caee7. A number of fixes have landed in between then and now, and I think we're ready for another round. Original change's description: > Reland #6 of "Force Python 3 to be used in build." > > This reverts commit b2446a0 > > Reason for revert: Trying again w/ build fixes. > > The two issues we saw yesterday with reland attempt #5 > were fixed in > https://crrev.com/c/2768998 (remoting linux installer) > https://crrev.com/c/2768998 (GLES test scripts) > > But the change wasn't in the tree for very long, so there may > well be more. Let's try again to see. > > Bug: 1112471 > Cq-Include-Trybots: luci.chromium.try:linux-angle-rel > Cq-Include-Trybots: luci.chrome.try:linux-chrome > Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#864372} Bug: 1112471 Change-Id: Iccef0aa5d92c28fee1ce67e446b9b15a7cc0745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2792623 Commit-Queue: Dirk Pranke <dpranke@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#868187}
pull bot
pushed a commit
that referenced
this pull request
Apr 8, 2021
This reverts commit 0a70004. Reason for revert: https://crbug.com/1196930 Original change's description: > Reland #7 of "Force Python 3 to be used in build." > > This is a reland of d9caee7. > > A number of fixes have landed in between then and now, and I > think we're ready for another round. > > Original change's description: > > Reland #6 of "Force Python 3 to be used in build." > > > > This reverts commit b2446a0 > > > > Reason for revert: Trying again w/ build fixes. > > > > The two issues we saw yesterday with reland attempt #5 > > were fixed in > > https://crrev.com/c/2768998 (remoting linux installer) > > https://crrev.com/c/2768998 (GLES test scripts) > > > > But the change wasn't in the tree for very long, so there may > > well be more. Let's try again to see. > > > > Bug: 1112471 > > Cq-Include-Trybots: luci.chromium.try:linux-angle-rel > > Cq-Include-Trybots: luci.chrome.try:linux-chrome > > Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#864372} > > Bug: 1112471 > Change-Id: Iccef0aa5d92c28fee1ce67e446b9b15a7cc0745a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2792623 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#868187} Bug: 1112471, 1196930 Change-Id: I405a771ffc29ed40e74764008c9e0be1e4b9ef7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812719 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#870378}
pull bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
This reverts commit c787d2a. Reason for revert: Causes flaky failures on some Linux bots, e.g., https://ci.chromium.org/p/chromium/builders/ci/Linux%20Ozone%20Tester%20%28Wayland%29 Example failure: browser_tests_wayland failed because of: ExtensionBackForwardCacheContentScriptDisabledBrowserTest.CSSDisallowed pattern of failures on this bot: https://screenshot.googleplex.com/87iSx5FiDVGZRmF Failure error is ../../chrome/browser/extensions/back_forward_cache_browsertest.cc:110: Failure Value of: delete_observer_rfh_a.deleted() Actual: false Expected: true Stack trace: #0 0x563563bb7efc extensions::ExtensionBackForwardCacheContentScriptDisabledBrowserTest_CSSDisallowed_Test::RunTestOnMainThread() #1 0x563567b440ce content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #2 0x5635676da77d ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #3 0x5635676d9d54 ChromeBrowserMainParts::PreMainMessageLoopRun() #4 0x56356561f0df content::BrowserMainLoop::PreMainMessageLoopRun() #5 0x563565a4e6a3 content::StartupTaskRunner::RunAllTasksNow() #6 0x56356561ed5d content::BrowserMainLoop::CreateStartupTasks() #7 0x563565621228 content::BrowserMainRunnerImpl::Initialize() #8 0x56356561d610 content::BrowserMain() #9 0x563566297393 content::ContentMainRunnerImpl::RunBrowser() #10 0x563566296f1d content::ContentMainRunnerImpl::Run() #11 0x5635662944ad content::RunContentProcess() #12 0x563566294e4d content::ContentMain() #13 0x563567b43778 content::BrowserTestBase::SetUp() #14 0x563567587576 InProcessBrowserTest::SetUp() The same error appears on other bots when this fails too, e.g., https://ci.chromium.org/p/chromium/builders/ci/Linux%20Ozone%20Tester%20%28X11%29/29058 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8850497656556318928/+/steps/browser_tests_x11/0/logs/Deterministic_failure:_ExtensionBackForwardCacheContentScriptDisabledBrowserTest.CSSDisallowed__status_FAILURE_/0 Original change's description: > If an extension does a content injection disable bf cache. > > This code tracks whether a content injection (insertCSS, contentScript, > executeScript) has occurred for a WebFrame. If so then turn off > BFCache for the frame. > > BUG=1192785 > > Change-Id: I682a9efb247aae358023e3a591368c84d47001ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787195 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#870582} Bug: 1192785 Change-Id: Ib122b1d64155d85009038d961306ac620053564b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2816001 Auto-Submit: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#870681}
pull bot
pushed a commit
that referenced
this pull request
Apr 14, 2021
This reverts commit 38b6a9a. Reason for revert: The issues affecting the official win build and the swarming dev instance have been fixed, so hopefully it's safe to try Yet Again. Original change's description: > Revert "Reland #7 of "Force Python 3 to be used in build."" > > This reverts commit 0a70004. > > Reason for revert: > https://crbug.com/1196930 > > Original change's description: > > Reland #7 of "Force Python 3 to be used in build." > > > > This is a reland of d9caee7. > > > > A number of fixes have landed in between then and now, and I > > think we're ready for another round. > > > > Original change's description: > > > Reland #6 of "Force Python 3 to be used in build." > > > > > > This reverts commit b2446a0 > > > > > > Reason for revert: Trying again w/ build fixes. > > > > > > The two issues we saw yesterday with reland attempt #5 > > > were fixed in > > > https://crrev.com/c/2768998 (remoting linux installer) > > > https://crrev.com/c/2768998 (GLES test scripts) > > > > > > But the change wasn't in the tree for very long, so there may > > > well be more. Let's try again to see. > > > > > > Bug: 1112471 > > > Cq-Include-Trybots: luci.chromium.try:linux-angle-rel > > > Cq-Include-Trybots: luci.chrome.try:linux-chrome > > > Change-Id: Ie5483d1f6838deeaf0f9b7cddc0bb57a82960c29 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2769361 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Cr-Commit-Position: refs/heads/master@{#864372} > > > > Bug: 1112471 > > Change-Id: Iccef0aa5d92c28fee1ce67e446b9b15a7cc0745a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2792623 > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#868187} > > Bug: 1112471, 1196930 > Change-Id: I405a771ffc29ed40e74764008c9e0be1e4b9ef7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2812719 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#870378} Bug: 1112471 Bug: 1196930 Change-Id: Ia8caaf2f7f962e7e413fdba47f9acb46150f10a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824170 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Erik Staab <estaab@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#872124}
pull bot
pushed a commit
that referenced
this pull request
Apr 19, 2021
This reverts commit 7ae3611. Reason for revert: cast_shell+browsertests failing on Cast [Audio] Linux First failure https://ci.chromium.org/ui/p/chromium/builders/ci/Cast%20Audio%20Linux/103652/overview Example crash stack BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x55bcce76b6a9 base::debug::CollectStackTrace() #1 0x55bcce6dfda3 base::debug::StackTrace::StackTrace() #2 0x55bcd0fb5cac content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fd872d664c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x55bcccba88b0 _ZNSt3__17find_ifINS_11__wrap_iterIPKN4base8internal24UncheckedObserverAdapterEEEZNS3_23ProjectedUnaryPredicateIZNKS2_12ObserverListIN3net16MDnsListenerImplELb0ELb1ES4_E11HasObserverEPKSB_EUlRKT_E_NS2_8identityEEEDaRSF_RT0_EUlOSF_E_EESF_SF_SF_SL_ #5 0x55bcccba889e _ZN4base6ranges7find_ifINSt3__111__wrap_iterIPKNS_8internal24UncheckedObserverAdapterEEEZNKS_12ObserverListIN3net16MDnsListenerImplELb0ELb1ES5_E11HasObserverEPKSB_EUlRKT_E_NS_8identityENS2_26random_access_iterator_tagEEEDaSF_SF_T0_T1_ #6 0x55bcccba6dca base::ObserverList<>::RemoveObserver() #7 0x55bccd28a44e chromecast::DisplayConfiguratorObserver::~DisplayConfiguratorObserver() #8 0x55bccd26fbcd chromecast::shell::CastBrowserMainParts::~CastBrowserMainParts() #9 0x55bccd26fc7c chromecast::shell::CastBrowserMainParts::~CastBrowserMainParts() #10 0x55bccd3a6836 content::BrowserMainLoop::~BrowserMainLoop() #11 0x55bccd3a6920 content::BrowserMainLoop::~BrowserMainLoop() #12 0x55bccd3a9c06 content::BrowserMainRunnerImpl::Shutdown() #13 0x55bccd3a65aa content::BrowserMain() #14 0x55bcce68bc80 content::RunBrowserProcessMain() #15 0x55bcce68c9a6 content::ContentMainRunnerImpl::RunBrowser() #16 0x55bcce68c62c content::ContentMainRunnerImpl::Run() #17 0x55bcce68ad93 content::RunContentProcess() #18 0x55bcce68b49a content::ContentMain() #19 0x55bcd0fb50e1 content::BrowserTestBase::SetUp() #20 0x55bccc9fdf90 chromecast::WebviewTest::SetUp() #21 0x55bcce69a89c testing::Test::Run() #22 0x55bcce69adb8 testing::TestInfo::Run() #23 0x55bcce69b27d testing::TestSuite::Run() #24 0x55bcce6a2233 testing::internal::UnitTestImpl::RunAllTests() #25 0x55bcce6a1f87 testing::UnitTest::Run() #26 0x55bcd0fa57ef base::TestSuite::Run() #27 0x55bccc9de2a4 chromecast::shell::CastTestLauncherDelegate::RunTestSuite() #28 0x55bcd0fb930e content::LaunchTests() #29 0x55bccc9de23c main #30 0x7fd872d51840 __libc_start_main #31 0x55bccc9de12a _start Original change's description: > Add display change observer. > > Centralize the logic to force a repaint post display changes in an > observer. This way the complexity of refreshing the display is > handled in the observer rather than in every piece of code that > needs to update the display state. > > Bug: b/180040068 > Test: Ran cast_shell on the desktop to verify there are no crashes > Change-Id: I022850322c8b9177463bdc0526121016ebf0f330 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727577 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Shiv Sakhuja <shivsak@google.com> > Cr-Commit-Position: refs/heads/master@{#873512} Bug: b/180040068 Change-Id: Id01a6e537f2285a9c35ce90acc9eba81b0ea6c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2835019 Owners-Override: Olga Sharonova <olka@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#873746}
pull bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
This reverts commit 0d437e0. Reason for revert: Breaks Lacros. [343589:343589:0726/205512.291579:FATAL:sandbox_seccomp_bpf_linux.cc(239)] Check failed: BPFBasePolicy::GetFSDeniedErrno() == (*__errno_location ()) (1 vs. 13) #0 0x7fa2e2e3a8af base::debug::CollectStackTrace() #1 0x7fa2e2baee0a base::debug::StackTrace::StackTrace() #2 0x7fa2e2baedc5 base::debug::StackTrace::StackTrace() #3 0x7fa2e2bfe239 logging::LogMessage::~LogMessage() #4 0x7fa2e2bfe959 logging::LogMessage::~LogMessage() #5 0x7fa2e2b6e5eb logging::CheckError::~CheckError() #6 0x7fa2cc927b2f sandbox::policy::SandboxSeccompBPF::RunSandboxSanityChecks() #7 0x7fa2cc91fc71 sandbox::policy::SandboxLinux::StartSeccompBPF() #8 0x7fa2cc9206fd sandbox::policy::SandboxLinux::InitializeSandbox() #9 0x7fa2d83e65a3 content::(anonymous namespace)::StartSandboxLinux() #10 0x7fa2d83e62b9 content::(anonymous namespace)::ContentSandboxHelper::EnsureSandboxInitialized() #11 0x7fa2a32de13e gpu::GpuInit::InitializeAndStartSandbox() #12 0x7fa2d83e5ca0 content::GpuMain() #13 0x7fa2dbd8a5ad content::RunZygote() #14 0x7fa2dbd8aa3a content::RunOtherNamedProcessTypeMain() #15 0x7fa2dbd8b7b4 content::ContentMainRunnerImpl::Run() #16 0x7fa2dbd889ae content::RunContentProcess() #17 0x7fa2dbd892fd content::ContentMain() #18 0x5588c3250966 ChromeMain #19 0x5588c3250812 main #20 0x7fa2a56aed0a __libc_start_main #21 0x5588c325072a _start To repro the failure, follow go/lacros-build and build linux Lacros. Lacros can't be launched with the failure above. Original change's description: > Use EACCES over EPERM for broker process denied errno > > When dlopen is called without an absolute path, it looks in a number > of search paths for the requested library (e.g. /lib64/libfoo.so, > /usr/lib/libfoo.so). Often, these files don't exist and the > corresponding openat syscall should return ENOENT, but because of > the GPU sandbox, the syscall returns EPERM instead [1]. glibc's > implementation of dlopen, however, early-exits when it sees an > unexpected errno [2] and terminates without attempting the remaining > search paths. Thus, even if the library *is* allowlisted in a later > path, dlopen will still exit with a failure. > > This CL fixes this issue by changing the denied errno to EACCES for > the broker process. > > Bug: 1233028 > Change-Id: I192098eb072f2ee6fb18aa7da3d1998f8328149f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3054490 > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Brian Ho <hob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#905330} Bug: 1233028 Change-Id: I111ff2bf802615e1299aee7feb88471d49a238e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3055402 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Owners-Override: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#905685}
pull bot
pushed a commit
that referenced
this pull request
Aug 12, 2021
Update UserSessionInitializer::PreStartSession() to take bool is_primary_session and only call NetworkCertLoader::MarkUserNSSDBWillBeInitialized() when true. Fixes crash: 2021-08-08T22:59:06.505936Z FATAL chrome[21728:21728]: [network_cert_loader.cc(148)] Check failed: state_ == State::kNotInitialized || state_ == State::kMarkedWillBeInitialized. #0 0x57e49567eb89 base::debug::CollectStackTrace() #1 0x57e4955c5c93 base::debug::StackTrace::StackTrace() #2 0x57e48fd06890 logging::LogMessage::~LogMessage() #3 0x57e4955d904e logging::LogMessage::~LogMessage() #4 0x57e497827697 chromeos::NetworkCertLoader::CertCache::MarkWillBeInitialized() #5 0x57e4978277d2 chromeos::NetworkCertLoader::MarkUserNSSDBWillBeInitialized() #6 0x57e4937607ac ash::UserSessionManager::StartSession() #7 0x57e493712814 chromeos::ExistingUserController::OnAuthSuccess() #8 0x57e498a7a9e5 chromeos::LoginPerformer::OnAuthSuccess() #9 0x57e498a72c39 chromeos::CryptohomeAuthenticator::OnAuthSuccess() #10 0x57e490df73f4 base::TaskAnnotator::RunTask() #11 0x57e48fe5bc9d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #12 0x57e4956477c2 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x57e4909e2445 base::MessagePumpLibevent::Run() #14 0x57e495647a83 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #15 0x57e49560bb56 base::RunLoop::Run() #16 0x57e4924d69f1 content::BrowserMainLoop::RunMainMessageLoop() #17 0x57e4924d8840 content::BrowserMainRunnerImpl::Run() #18 0x57e4924d3ce8 content::BrowserMain() #19 0x57e495082b38 content::RunBrowserProcessMain() #20 0x57e495083e3b content::ContentMainRunnerImpl::RunBrowser() #21 0x57e4950838c6 content::ContentMainRunnerImpl::Run() #22 0x57e49508123e content::RunContentProcess() #23 0x57e495081c40 content::ContentMain() #24 0x57e4910cf23e ChromeMain #25 0x789c45710e05 __libc_start_main #26 0x57e4910cf0da _start Task trace: #0 0x57e498a73fcc chromeos::CryptohomeAuthenticator::Resolve() #1 0x57e496c95be1 dbus::ObjectProxy::OnPendingCallIsComplete() #2 0x57e496c91b91 dbus::Bus::OnDispatchStatusChanged() #3 0x57e49567fa66 base::FileDescriptorWatcher::Controller::Watcher::OnFileCanReadWithoutBlocking() Change-Id: I4b250f807ca8f3fff35cb380b3a47ce98b7ade09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3080039 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#910647}
pull bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
Render-process: Raise an exception of focus() is called multiple times. Browser-process: Kill the render process if it sends more than one message concerning an explicit call to focus(). Design-doc: https://docs.google.com/document/d/1LHJRt-ry9hwzFTbPxKrmD0VvtEFEU6lvqsD7k6wwGKM Bug: 1215480 Change-Id: I64792fda8ccdf88c61edd229ad400b38a931d6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3131040 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#916804}
pull bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
This reverts commit 4f0f07d. Reason for revert: This is causing failures on the asan/lsan bot. https://bugs.chromium.org/p/chromium/issues/detail?id=1250054 ==7374==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55b1cff1c2ce in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/ranges/algorithm.h:31:10)> ./../../buildtools/third_party/libc++/trunk/include/algorithm:942:5 #1 0x55b1cff1c2ce in find_if<std::__1::__wrap_iter<base::internal::UncheckedObserverAdapter *>, (lambda at ../../base/observer_list.h:284:21), base::identity, std::__1::random_access_iterator_tag> ./../../base/ranges/algorithm.h:465:10 #2 0x55b1cff1c2ce in find_if<std::__1::vector<base::internal::UncheckedObserverAdapter, std::__1::allocator<base::internal::UncheckedObserverAdapter> > &, (lambda at ../../base/observer_list.h:284:21), base::identity, std::__1::random_access_iterator_tag> ./../../base/ranges/algorithm.h:483:10 #3 0x55b1cff1c2ce in base::ObserverList<aura::EnvObserver, false, true, base::internal::UncheckedObserverAdapter>::RemoveObserver(aura::EnvObserver const*) ./../../base/observer_list.h:283:21 #4 0x55b1b16a5284 in Reset ./../../base/scoped_observation.h:69:7 #5 0x55b1b16a5284 in base::ScopedObservation<aura::Env, aura::EnvObserver, &(aura::Env::AddObserver(aura::EnvObserver*)), &(aura::Env::RemoveObserver(aura::EnvObserver*))>::~ScopedObservation() ./../../base/scoped_observation.h:53:26 #6 0x55b1c95200e4 in ash::ArcOverlayManager::~ArcOverlayManager() ./../../ash/public/cpp/external_arc/overlay/arc_overlay_manager.cc:52:1 #7 0x55b1c9520174 in ash::ArcOverlayManager::~ArcOverlayManager() arc_overlay_manager.cc:0:0 #8 0x55b1b0a0deea in operator() ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:54:5 #9 0x55b1b0a0deea in reset ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:315:7 #10 0x55b1b0a0deea in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:269:19 #11 0x55b1b0a0deea in payments::(anonymous namespace)::AndroidPaymentAppFactoryTest::~AndroidPaymentAppFactoryTest() ./../../chrome/browser/payments/android_payment_app_factory_browsertest.cc:29:52 #12 0x55b1b0a10f5c in payments::(anonymous Original change's description: > [Web Payment] App store billing never shows browser UI. > > Before this patch, immediately resolving the promise passed into > PaymentRequest.show() (the so-called "show() promise"), e.g., by calling > PaymentRequest.show(Promise.resolve({})), would have the possibility of > both showing the browser payment sheet and invoking the payment app, > because the code did not expect that the promise would be resolved > faster than enumerating the locally installed payment apps. > > This patch prevents invoking a payment app or showing the browser > payment sheet when the show() promise resolves before the locally > installed payment apps have been enumerated. > > After this patch, immediately resolving the show() promise will not > result in both showing the browser payment sheet and invoking the > payment app at the same time. > > Bug: 1237921 > Change-Id: I132700146d6f9334a5c56d136f80fcdc62873313 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160759 > Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#921617} Bug: 1237921 Change-Id: I8a1e6c7c6080b175d180d4c37d2fbc3d7eb77af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163453 Auto-Submit: Scott Violet <sky@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/main@{#921917}
pull bot
pushed a commit
that referenced
this pull request
Sep 25, 2021
This reverts commit 77e9679. Reason for revert: Likely cause of failure Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" The failure is a crash in browser_tests. This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. Here is the first failure as an example: Retrying 1 test (retry #0) [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x556151f72449 base::debug::CollectStackTrace() #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() #9 0x5561502b8919 content::Navigator::DidNavigate() #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x5561530201e0 mojo::MessageDispatcher::Accept() #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x55615301e323 base::internal::Invoker<>::RunOnce() #20 0x556151f35f23 base::TaskAnnotator::RunTask() #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x556151fa9c4b base::MessagePumpLibevent::Run() #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x556151f18c1b base::RunLoop::Run() #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() #38 0x556150036912 content::BrowserMain() #39 0x556150bf6aed content::RunBrowserProcessMain() #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() #41 0x556150bf752e content::ContentMainRunnerImpl::Run() #42 0x556150bf5b38 content::RunContentProcess() #43 0x556150bf5c08 content::ContentMain() #44 0x5561525e3543 content::BrowserTestBase::SetUp() #45 0x556151ec12c1 InProcessBrowserTest::SetUp() #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x55614f308e8f testing::Test::Run() #48 0x55614f3097c5 testing::TestInfo::Run() #49 0x55614f309f21 testing::TestSuite::Run() #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() #51 0x55614f31338b testing::UnitTest::Run() #52 0x556151fd7ff2 base::TestSuite::Run() #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x556152613c1f content::LaunchTests() #55 0x556151e98224 LaunchChromeTests() #56 0x556151e9638b main #57 0x7f7dd56c4bf7 __libc_start_main #58 0x55614cca11ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 Here is the fourth: (different test in the same suite, different stack trace): [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x564f24b8af29 base::debug::CollectStackTrace() #1 0x564f24af2843 base::debug::StackTrace::StackTrace() #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() #9 0x564f22ed15f9 content::Navigator::DidNavigate() #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #24 0x564f24bc28cb base::MessagePumpLibevent::Run() #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #26 0x564f24b316fb base::RunLoop::Run() #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() #28 0x564f2522df45 content::RunAllPendingInMessageLoop() #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() #38 0x564f22c4f832 content::BrowserMain() #39 0x564f2380f5bd content::RunBrowserProcessMain() #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() #42 0x564f2380e608 content::RunContentProcess() #43 0x564f2380e6d8 content::ContentMain() #44 0x564f251fc233 content::BrowserTestBase::SetUp() #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() #47 0x564f21f21e4f testing::Test::Run() #48 0x564f21f22785 testing::TestInfo::Run() #49 0x564f21f22ee1 testing::TestSuite::Run() #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() #51 0x564f21f2c34b testing::UnitTest::Run() #52 0x564f24bf0c72 base::TestSuite::Run() #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #54 0x564f2522c62f content::LaunchTests() #55 0x564f24ab0cf4 LaunchChromeTests() #56 0x564f24aaee5b main #57 0x7f03d336fbf7 __libc_start_main #58 0x564f1f8b94ea _start from https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 Original change's description: > Privatise unnecessarily public current_input_method in > InputMethodManagerImpl::StateImpl. > > This involves replacing some direct pokes of current_input_method > with public GetCurrentInputMethod() that employs a fallback onto > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > blank. This should be more reasonable and consistent. > > Bug: 1134465 > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924702} Bug: 1134465 Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 Auto-Submit: Mark Pearson <mpearson@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#924810}
pull bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
… CrosState" This reverts commit 3895114. Reason for revert: likely cause of failures Step "chromeos_components_unittests on Ubuntu-18.04" failing on builder "Linux Chromium OS ASan LSan Tests (1)" The first run with the relevant failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/40730/overview The following tests consistently fail starting after this first run: CrosStateSenderTest.NotificationFeatureStateChanged CrosStateSenderTest.PerformUpdateCrosStateRetrySequence The first fails with this stack trace: --- [ RUN ] CrosStateSenderTest.NotificationFeatureStateChanged ================================================================= ==4136==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700004b31c at pc 0x5559c16fed11 bp 0x7fffb87b9250 sp 0x7fffb87b9248 READ of size 4 at 0x60700004b31c thread T0 #0 0x5559c16fed10 in chromeos::multidevice_setup::MultiDeviceSetupClient::GetFeatureState(chromeos::multidevice_setup::mojom::Feature) const ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:51:44 #1 0x5559ce6da0ed in chromeos::phonehub::CrosStateSender::PerformUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:93:34 #2 0x5559ce6d9e1d in chromeos::phonehub::CrosStateSender::AttemptUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:85:3 #3 0x5559c17102b7 in chromeos::secure_channel::ConnectionManager::NotifyStatusChanged() ./../../chromeos/services/secure_channel/public/cpp/client/connection_manager.cc:23:14 #4 0x5559ba7314dc in chromeos::phonehub::CrosStateSenderTest_NotificationFeatureStateChanged_Test::TestBody() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:146:29 #5 0x5559baf612a1 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x5559baf612a1 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2706:5 #7 0x5559baf62ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #8 0x5559baf647b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #9 0x5559baf87628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #10 0x5559baf86d49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x5559baf86d49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #12 0x5559c6e8422f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #13 0x5559c6e8422f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #14 0x5559bd07db0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #15 0x5559c6e8a853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #16 0x5559c6e8a4d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #17 0x5559ba482d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #18 0x7f002b751bf6 in __libc_start_main ??:0:0 0x60700004b31c is located 4 bytes to the right of 72-byte region [0x60700004b2d0,0x60700004b318) allocated by thread T0 here: #0 0x5559ba47faed in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 #1 0x5559c14ad498 in __libcpp_operator_new<unsigned long> ./../../buildtools/third_party/libc++/trunk/include/new:235:10 #2 0x5559c14ad498 in __libcpp_allocate ./../../buildtools/third_party/libc++/trunk/include/new:261:10 #3 0x5559c14ad498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator.h:82:38 #4 0x5559c14ad498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator_traits.h:261:20 #5 0x5559c14ad498 in std::__1::vector<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState>, std::__1::allocator<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> > >::__vallocate(unsigned long) ./../../buildtools/third_party/libc++/trunk/include/vector:994:37 #6 0x5559c16fdfe3 in vector<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../buildtools/third_party/libc++/trunk/include/vector:1224:9 #7 0x5559c16fdfe3 in flat_tree<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../base/containers/flat_tree.h:571:20 #8 0x5559c16fdfe3 in flat_tree ./../../base/containers/flat_tree.h:595:7 #9 0x5559c16fdfe3 in flat_tree ./../../base/containers/flat_map.h:211:15 #10 0x5559c16fdfe3 in chromeos::multidevice_setup::MultiDeviceSetupClient::GenerateDefaultFeatureStatesMap() ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:21:10 #11 0x5559d736b57e in chromeos::multidevice_setup::FakeMultiDeviceSetupClient::FakeMultiDeviceSetupClient() ./../../chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup_client.cc:13:27 #12 0x5559ba733ad7 in make_unique<chromeos::multidevice_setup::FakeMultiDeviceSetupClient> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725:32 #13 0x5559ba733ad7 in chromeos::phonehub::CrosStateSenderTest::SetUp() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:40:9 #14 0x5559baf6118e in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #15 0x5559baf6118e in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2701:3 #16 0x5559baf62ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #17 0x5559baf647b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #18 0x5559baf87628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #19 0x5559baf86d49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x5559baf86d49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #21 0x5559c6e8422f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #22 0x5559c6e8422f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #23 0x5559bd07db0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #24 0x5559c6e8a853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #25 0x5559c6e8a4d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #26 0x5559ba482d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #27 0x7f002b751bf6 in __libc_start_main ??:0:0 SUMMARY: AddressSanitizer: heap-buffer-overflow (/b/s/w/ir/out/Release/chromeos_components_unittests+0x15f40d10) Shadow bytes around the buggy address: 0x0c0e80001610: fa fa fa fa fd fd fd fd fd fd fd fd fd fd fa fa 0x0c0e80001620: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c0e80001630: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fd fd 0x0c0e80001640: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0e80001650: fd fd fd fd fd fd fa fa fa fa 00 00 00 00 00 00 =>0x0c0e80001660: 00 00 00[fa]fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0e80001670: fd fa fa fa fa fa fd fd fd fd fd fd fd fd fd fd 0x0c0e80001680: fa fa fa fa 00 00 00 00 00 00 00 00 00 00 fa fa 0x0c0e80001690: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c0e800016a0: fd fd fd fd fd fd fd fd fd fd fa fa fa fa 00 00 0x0c0e800016b0: 00 00 00 00 00 00 00 00 fa fa fa fa 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==4136==ABORTING --- The second fails with this one: --- [ RUN ] CrosStateSenderTest.PerformUpdateCrosStateRetrySequence ================================================================= ==3811==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700005f9ec at pc 0x5579c6175d11 bp 0x7ffd5e6a0e10 sp 0x7ffd5e6a0e08 READ of size 4 at 0x60700005f9ec thread T0 #0 0x5579c6175d10 in chromeos::multidevice_setup::MultiDeviceSetupClient::GetFeatureState(chromeos::multidevice_setup::mojom::Feature) const ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:51:44 #1 0x5579d31510ed in chromeos::phonehub::CrosStateSender::PerformUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:93:34 #2 0x5579d3150e1d in chromeos::phonehub::CrosStateSender::AttemptUpdateCrosState() ./../../chromeos/components/phonehub/cros_state_sender.cc:85:3 #3 0x5579c61872b7 in chromeos::secure_channel::ConnectionManager::NotifyStatusChanged() ./../../chromeos/services/secure_channel/public/cpp/client/connection_manager.cc:23:14 #4 0x5579bf1a3085 in chromeos::phonehub::CrosStateSenderTest_PerformUpdateCrosStateRetrySequence_Test::TestBody() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:63:29 #5 0x5579bf9d82a1 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x5579bf9d82a1 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2706:5 #7 0x5579bf9d9ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #8 0x5579bf9db7b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #9 0x5579bf9fe628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #10 0x5579bf9fdd49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x5579bf9fdd49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #12 0x5579cb8fb22f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #13 0x5579cb8fb22f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #14 0x5579c1af4b0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #15 0x5579cb901853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #16 0x5579cb9014d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #17 0x5579beef9d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #18 0x7fc58b24bbf6 in __libc_start_main ??:0:0 0x60700005f9ec is located 4 bytes to the right of 72-byte region [0x60700005f9a0,0x60700005f9e8) allocated by thread T0 here: #0 0x5579beef6aed in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 #1 0x5579c5f24498 in __libcpp_operator_new<unsigned long> ./../../buildtools/third_party/libc++/trunk/include/new:235:10 #2 0x5579c5f24498 in __libcpp_allocate ./../../buildtools/third_party/libc++/trunk/include/new:261:10 #3 0x5579c5f24498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator.h:82:38 #4 0x5579c5f24498 in allocate ./../../buildtools/third_party/libc++/trunk/include/__memory/allocator_traits.h:261:20 #5 0x5579c5f24498 in std::__1::vector<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState>, std::__1::allocator<std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> > >::__vallocate(unsigned long) ./../../buildtools/third_party/libc++/trunk/include/vector:994:37 #6 0x5579c6174fe3 in vector<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../buildtools/third_party/libc++/trunk/include/vector:1224:9 #7 0x5579c6174fe3 in flat_tree<const std::__1::pair<chromeos::multidevice_setup::mojom::Feature, chromeos::multidevice_setup::mojom::FeatureState> *> ./../../base/containers/flat_tree.h:571:20 #8 0x5579c6174fe3 in flat_tree ./../../base/containers/flat_tree.h:595:7 #9 0x5579c6174fe3 in flat_tree ./../../base/containers/flat_map.h:211:15 #10 0x5579c6174fe3 in chromeos::multidevice_setup::MultiDeviceSetupClient::GenerateDefaultFeatureStatesMap() ./../../chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client.cc:21:10 #11 0x5579dbde257e in chromeos::multidevice_setup::FakeMultiDeviceSetupClient::FakeMultiDeviceSetupClient() ./../../chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup_client.cc:13:27 #12 0x5579bf1aaad7 in make_unique<chromeos::multidevice_setup::FakeMultiDeviceSetupClient> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:725:32 #13 0x5579bf1aaad7 in chromeos::phonehub::CrosStateSenderTest::SetUp() ./../../chromeos/components/phonehub/cros_state_sender_unittest.cc:40:9 #14 0x5579bf9d818e in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #15 0x5579bf9d818e in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2701:3 #16 0x5579bf9d9ca4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2885:11 #17 0x5579bf9db7b3 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3044:30 #18 0x5579bf9fe628 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5903:44 #19 0x5579bf9fdd49 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x5579bf9fdd49 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5470:10 #21 0x5579cb8fb22f in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #22 0x5579cb8fb22f in base::TestSuite::Run() ./../../base/test/test_suite.cc:465:16 #23 0x5579c1af4b0e in base::OnceCallback<int ()>::Run() && ./../../base/callback.h:99:12 #24 0x5579cb901853 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:177:38 #25 0x5579cb9014d5 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:247:10 #26 0x5579beef9d45 in main ./../../chromeos/components/run_all_unittests.cc:22:10 #27 0x7fc58b24bbf6 in __libc_start_main ??:0:0 SUMMARY: AddressSanitizer: heap-buffer-overflow (/b/s/w/ir/out/Release/chromeos_components_unittests+0x15f40d10) Shadow bytes around the buggy address: 0x0c0e80003ee0: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fd fd 0x0c0e80003ef0: fd fd fd fd fd fd fd fd fa fa fa fa fd fd fd fd 0x0c0e80003f00: fd fd fd fd fd fd fa fa fa fa fd fd fd fd fd fd 0x0c0e80003f10: fd fd fd fd fa fa fa fa fd fd fd fd fd fd fd fd 0x0c0e80003f20: fd fd fa fa fa fa fd fd fd fd fd fd fd fd fd fd =>0x0c0e80003f30: fa fa fa fa 00 00 00 00 00 00 00 00 00[fa]fa fa 0x0c0e80003f40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e80003f80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==3811==ABORTING --- Original change's description: > [CameraRoll]Send camera roll setting to the Android device in CrosState > > Include camera roll setting state as part of CrosState, > so connected mobile device would be able to get update > when setting value is toggled. > > Change-Id: I04d0ed3872d5adeff5e8f8dc76c6eb6df3a50b9c > Bug: https://crbug.com/1221297 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173740 > Commit-Queue: Jianbing Wu <jianbing@google.com> > Auto-Submit: Jianbing Wu <jianbing@google.com> > Reviewed-by: Jon Mann <jonmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924995} Bug: https://crbug.com/1221297 Change-Id: Ic87d96786b4244b27b1e284f801df8799911b1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184482 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Mark Pearson <mpearson@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#925118}
pull bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
This reverts commit 37ea471. Reason for revert: Reverted CL is unrelated to the cited "reason for revert". Original change's description: > Revert "Privatise unnecessarily public current_input_method in" > > This reverts commit 77e9679. > > Reason for revert: > Likely cause of failure > Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" > > The failure is a crash in browser_tests. > > This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. > > Here is the first failure as an example: > Retrying 1 test (retry #0) > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed > 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als > 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x556151f72449 base::debug::CollectStackTrace() > #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() > #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() > #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() > #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() > #9 0x5561502b8919 content::Navigator::DidNavigate() > #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() > #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() > #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x5561530201e0 mojo::MessageDispatcher::Accept() > #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x55615301e323 base::internal::Invoker<>::RunOnce() > #20 0x556151f35f23 base::TaskAnnotator::RunTask() > #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x556151fa9c4b base::MessagePumpLibevent::Run() > #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x556151f18c1b base::RunLoop::Run() > #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() > #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() > #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() > #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() > #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() > #38 0x556150036912 content::BrowserMain() > #39 0x556150bf6aed content::RunBrowserProcessMain() > #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() > #41 0x556150bf752e content::ContentMainRunnerImpl::Run() > #42 0x556150bf5b38 content::RunContentProcess() > #43 0x556150bf5c08 content::ContentMain() > #44 0x5561525e3543 content::BrowserTestBase::SetUp() > #45 0x556151ec12c1 InProcessBrowserTest::SetUp() > #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x55614f308e8f testing::Test::Run() > #48 0x55614f3097c5 testing::TestInfo::Run() > #49 0x55614f309f21 testing::TestSuite::Run() > #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() > #51 0x55614f31338b testing::UnitTest::Run() > #52 0x556151fd7ff2 base::TestSuite::Run() > #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x556152613c1f content::LaunchTests() > #55 0x556151e98224 LaunchChromeTests() > #56 0x556151e9638b main > #57 0x7f7dd56c4bf7 __libc_start_main > #58 0x55614cca11ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 > > Here is the fourth: (different test in the same suite, different stack trace): > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff > 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB > 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als > 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x564f24b8af29 base::debug::CollectStackTrace() > #1 0x564f24af2843 base::debug::StackTrace::StackTrace() > #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() > #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() > #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() > #9 0x564f22ed15f9 content::Navigator::DidNavigate() > #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() > #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() > #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() > #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() > #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() > #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x564f24bc28cb base::MessagePumpLibevent::Run() > #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x564f24b316fb base::RunLoop::Run() > #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() > #28 0x564f2522df45 content::RunAllPendingInMessageLoop() > #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() > #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() > #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() > #38 0x564f22c4f832 content::BrowserMain() > #39 0x564f2380f5bd content::RunBrowserProcessMain() > #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() > #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() > #42 0x564f2380e608 content::RunContentProcess() > #43 0x564f2380e6d8 content::ContentMain() > #44 0x564f251fc233 content::BrowserTestBase::SetUp() > #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() > #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x564f21f21e4f testing::Test::Run() > #48 0x564f21f22785 testing::TestInfo::Run() > #49 0x564f21f22ee1 testing::TestSuite::Run() > #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() > #51 0x564f21f2c34b testing::UnitTest::Run() > #52 0x564f24bf0c72 base::TestSuite::Run() > #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x564f2522c62f content::LaunchTests() > #55 0x564f24ab0cf4 LaunchChromeTests() > #56 0x564f24aaee5b main > #57 0x7f03d336fbf7 __libc_start_main > #58 0x564f1f8b94ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 > > Original change's description: > > Privatise unnecessarily public current_input_method in > > InputMethodManagerImpl::StateImpl. > > > > This involves replacing some direct pokes of current_input_method > > with public GetCurrentInputMethod() that employs a fallback onto > > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > > blank. This should be more reasonable and consistent. > > > > Bug: 1134465 > > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > > Reviewed-by: Keith Lee <keithlee@chromium.org> > > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#924702} > > Bug: 1134465 > Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Owners-Override: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924810} Bug: 1134465 Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#925158}
pull bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
…ch providers."." This reverts commit 23f829c. Reason for revert: Breaks TranslateManagerRenderViewHostTest.BubbleUnknownLanguage on linux-chromeos-chrome [ RUN ] TranslateManagerRenderViewHostTest.BubbleUnknownLanguage Received signal 11 SEGV_MAPERR 000000000108 #0 0x56400916c589 base::debug::CollectStackTrace() #1 0x5640090da7c3 base::debug::StackTrace::StackTrace() #2 0x56400916c0df base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fc34d615980 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1297f) #4 0x56400acc1794 TemplateURLService::GetDefaultSearchProvider() #5 0x564009765d6a RenderViewContextMenu::IsRegionSearchEnabled() #6 0x564009762d17 RenderViewContextMenu::AppendPageItems() #7 0x564009762838 RenderViewContextMenu::InitMenu() #8 0x56400886430c RenderViewContextMenuBase::Init() #9 0x5640034ae263 translate::(anonymous namespace)::TranslateManagerRenderViewHostTest_BubbleUnknownLanguage_Test::TestBody() ... Original change's description: > Reland "Add region search support for non-Google default search providers.". > > This an attempted reland of the following reverted change: > https://chromium-review.googlesource.com/c/chromium/src/+/3199698 > > PS1 is identical to the original change with a few minor modifications to resolve merge conflicts. > > The changes from the original is the adding of an instance variable to LensRegionSearchController representing whether the default search engine is Google. This could not be used in the controller directly due to an include rule. This is now instead passed as part of the Start() function through render_view_context_menu. > > > Bug: 1255702,1255897, b/198833501 > Change-Id: I83c4b0a5728ab3ba122d248c05c2f27b76a05a4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203970 > Commit-Queue: Juan Mojica <juanmojica@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ben Goldberger <benwgold@google.com> > Cr-Commit-Position: refs/heads/main@{#928974} Bug: 1255702,1255897, b/198833501 Change-Id: I1bf2e732ac781a5708f4a319ecf5df960239a860 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210916 Auto-Submit: Timothy Loh <timloh@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Owners-Override: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/main@{#929066}
pull bot
pushed a commit
that referenced
this pull request
Oct 16, 2021
This reverts commit 842626c. Reason for revert: [sheriff] suspected to cause multiple failures in SafetyTipPageInfoBubbleViewBrowserTests on linux-ubsan-vptr: https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr/6970 Sample failure: [ RUN ] All/SafetyTipPageInfoBubbleViewBrowserTest.BubbleWaitsForVisible/1 [...] ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23: runtime error: downcast of address 0x180601885e00 which does not point to an object of type 'PageInfoBubbleView' 0x180601885e00: note: object is of type 'PageInfoNewBubbleView' 00 00 00 00 18 70 11 10 50 56 00 00 80 68 50 01 06 18 00 00 b8 00 00 00 30 00 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'PageInfoNewBubbleView' #0 0x564ffa77d440 in SafetyTipPageInfoBubbleViewBrowserTest::CheckPageInfoShowsSafetyTipInfo(Browser*, security_state::SafetyTipStatus, GURL const&) chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 #1 0x564ffa788397 in SafetyTipPageInfoBubbleViewBrowserTest_BubbleWaitsForVisible_Test::RunTestOnMainThread() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:837:3 #2 0x565002ae1026 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:868:7 #3 0x565001aae15a in Run base/callback.h:142:12 #4 0x565001aae15a in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1745:38 #5 0x565001aaba50 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1083:18 #6 0x564ffd8e2f00 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:957:28 #7 0x564ffe307f82 in Run base/callback.h:142:12 #8 0x564ffe307f82 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:41:29 #9 0x564ffd8e2368 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:865:25 #10 0x564ffd8e889c in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:131:15 #11 0x564ffd8dec1e in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:45:32 #12 0x564fff2a06e8 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:641:10 #13 0x564fff2a2e90 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) content/app/content_main_runner_impl.cc:1137:10 #14 0x564fff2a1f18 in content::ContentMainRunnerImpl::Run(bool) content_main_runner_impl.cc #15 0x564fff29dde0 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) content_main.cc #16 0x564fff29e7dd in content::ContentMain(content::ContentMainParams const&) content_main.cc #17 0x565002adfcff in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:712:3 #18 0x5650018271c4 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:401:20 #19 0x564ffa79d759 in SafetyTipPageInfoBubbleViewBrowserTest::SetUp() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:306:27 #20 0x564ffb8f8c7d in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2701:3 #21 0x564ffb8fa600 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2885:11 #22 0x564ffb8fc1bb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3044:30 #23 0x564ffb9115ca in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5903:44 #24 0x564ffb90fd8c in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5470:10 #25 0x565001a12e28 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #26 0x565001a12e28 in base::TestSuite::Run() base/test/test_suite.cc:445:16 #27 0x5650017d0bac in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:88:22 #28 0x5650017d0c1b in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome_test_launcher.cc #29 0x565002b8529b in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:409:31 #30 0x5650017d11b1 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:284:10 #31 0x5650017c9dcc in main chrome/test/base/browser_tests_main.cc:61:10 #32 0x7fc242b01bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6) #33 0x564ff76da7e9 in _start (/b/s/w/ir/out/Release/browser_tests+0xe8af7e9) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 in Original change's description: > Enable PageInfoV2Desktop by default > > Enable flag and remove testing config. > > Bug: 1188101 > Change-Id: Ifd839436f3d4c0127d15b449bbca84855ccd858f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217207 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Cr-Commit-Position: refs/heads/main@{#931972} Bug: 1188101 Change-Id: Ic51b9fdc730b7046e24b4d394248218b86eef09d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226638 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932067}
pull bot
pushed a commit
that referenced
this pull request
Oct 16, 2021
… off" This reverts commit 7db902d. Reason for revert: [sheriff] suspected to cause multiple AccountProfileMapperTest failures on linux-lacros-tester-rel: First failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/16078 Sample failure: [ RUN ] AccountProfileMapperTest.RemovePrimaryAccountFromPrimaryProfile Received signal 11 SEGV_MAPERR 209300000105 #0 0x5584a2716cd9 base::debug::CollectStackTrace() #1 0x5584a2684db3 base::debug::StackTrace::StackTrace() #2 0x5584a2716823 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f9750773980 (/lib/x86_64-linux-gnu/libpthread-2.27.so+0x1297f) #4 0x5584a269ec4c base::internal::WeakReference::IsValid() #5 0x55849d569978 base::ObserverList<>::RemoveObserver() #6 0x5584a2edaf01 ProfileAccountManager::Shutdown() #7 0x5584a377e0bc DependencyManager::PerformInterlockedTwoPhaseShutdown() #8 0x5584a1be43ae TestingProfile::~TestingProfile() #9 0x55849cf239ae (anonymous namespace)::PermissionManagerTestingProfile::~PermissionManagerTestingProfile() #10 0x5584a2d094bf ProfileDestroyer::DestroyOriginalProfileNow() #11 0x5584a2d091ed ProfileDestroyer::DestroyProfileWhenAppropriate() #12 0x5584a2d1a886 ProfileManager::ProfileInfo::~ProfileInfo() #13 0x5584a1be6fef std::__1::__tree<>::destroy() #14 0x5584a2d1ca09 ProfileManager::~ProfileManager() #15 0x5584a1be14ae FakeProfileManager::~FakeProfileManager() #16 0x5584a1be5d12 TestingProfileManager::~TestingProfileManager() #17 0x55849dc1309b AccountProfileMapperTest_GetAccounts_Test::~AccountProfileMapperTest_GetAccounts_Test() #18 0x55849ef2f92c testing::TestInfo::Run() #19 0x55849ef30617 testing::TestSuite::Run() Original change's description: > [Lacros] Do not create AccountProfileMapper if the feature is off > > AccountProfileMapper should only be created if the > kMultiProfileAccountConsistency feature is enabled. Otherwise, it might > have negative side-effects like deleting user profiles. > > To add a DCHECK(kMultiProfileAccountConsistency) to > AccountProfileMapper, > this CL also enables kMultiProfileAccountConsistency in all related > unit tests. This appears to be a non-trivial task because ProfileManager > will now create its own instance of AccountProfileMapper that doesn't > use an AccountManagerFacade mock. > > This CL adds a TestingProfileManager::SetAccountProfileMapper() methods > to inject a fake instance for testing. > > Bug: 1226045 > Change-Id: I69f74aed3f4bd9bdb107912d5e92872d53691a07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222809 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#931942} Bug: 1226045 Change-Id: If5ee60910f6cba1aabc407dba814448f538a2d39 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227179 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932071}
pull bot
pushed a commit
that referenced
this pull request
Oct 29, 2021
Overall feature: ---------------- Region Capture is a feature allowing the cropping of self-capture video tracks to track the coordinates of an HTMLElement in the browsing context. Public design-doc: https://docs.google.com/document/d/1dULARMnMZggfWqa_Ti_GrINRNYXGIli3XK9brzAKEV8/edit?usp=sharing Spec draft (very WIP): https://eladalon1983.github.io/region-capture/ (This will be finished soon and moved to the WICG; hopefully to be eventually adopted by the W3C.) This CL sub-chain: ------------------ The Region Capture feature introduces two new APIs: * navigator.mediaDevices.produceCropId() * BrowserCaptureMediaStreamTrack.cropTo() This CL sub-chain deals with the latter. This CL: -------- Plumb the crop message (and callback) all the way to FrameSinkVideoCaptureDevice. Next CLs: --------- * Invoke the callback with a rejection message if not self-capture. * Send the message onwards to viz::ClientFrameSinkVideoCapturer. Bug: 1247761 Change-Id: Id86be452ab19aad39ba71a622cd9a689be481d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232118 Auto-Submit: Elad Alon <eladalon@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#936048}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )