[pull] master from chromium:master #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This change gives new widget the ability to dynamically respond to size changes on the launcher screen. The change enables the widget to be vertically resize-able. There is no way we could specify the maximum height of the widget, so these may be scaled up to the maximum surface size, however the layout remains constrained to its bounds. What changes is that when crossing size boundary, the widget may update its internal layout with a different one. The boundary is determined by the minimum size of the medium widget. The logic is simplified as well - being reduced to a single base class handling dynamic widget + 2 dummy overrides that are required by the Manifest file. Bug: 1213541 Change-Id: I5c90cf4e7e37f8ef7550cf686f28d6a7ca417f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180386 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/main@{#924838}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1fe1bc5bf7c..b79b29f1aff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmonette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmonette@google.com Change-Id: I98ba8c2fa2a09a25607f1ea9821f5e5682f0704b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182408 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#924839}
This declaration was left over and not implemented or used. Change-Id: Id3c9ff180393e24f35cab43ea093e201a74240d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182645 Commit-Queue: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#924840}
This adjusts expectations for css-transforms tests that were fixed in the WPT repository in the following PRs: web-platform-tests/wpt#30928 web-platform-tests/wpt#30929 web-platform-tests/wpt#30930 web-platform-tests/wpt#30931 web-platform-tests/wpt#30932 web-platform-tests/wpt#30933 web-platform-tests/wpt#30934 web-platform-tests/wpt#30935 web-platform-tests/wpt#30937 In most cases this just means removing Failure expectations, although: * in two cases (skew-test1 from 30929, transform-fixed-bg-003 from 30937) the Failure expectations are not removed because the tests still require fuzz, * in another case (30937) the test fixes only changed which of the transform-fixed-bg-*.html tests are failing (and this change moves the one just added by the WPT importer down near the rest, along with the removal of two Failure expectations), * in another case (css-transforms-transformlist from 30928) the test needs further fixes so I can't adjust anything yet, and * in another case (transform-table-008 from 30933) the test still fails in virtual/transform-interop-disabled/. Bug: 1175179 Change-Id: Idd77ca87e3172e89ad5a304b14af78c73e9a4e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182781 Commit-Queue: David Baron <dbaron@chromium.org> Auto-Submit: David Baron <dbaron@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#924841}
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/159c9ad23e8b..e4717df71a4f 2021-09-23 dinor@google.com Merge pull request #3195 from Inujel:fix-3194 2021-09-23 dinor@google.com Merge pull request #3573 from cclauss:patch-1 2021-09-23 dinor@google.com Merge pull request #3574 from Vertexwahn:switch_to_native_cc_rules 2021-09-23 absl-team@google.com Googletest export 2021-09-23 absl-team@google.com Internal change 2021-09-16 dmauro@google.com Merge pull request #3519 from AkashKumarSingh11032001:master 2021-09-16 absl-team@google.com Googletest export 2021-09-15 dmauro@google.com Googletest export 2021-09-15 absl-team@google.com Googletest export 2021-09-15 dmauro@google.com Googletest export 2021-09-15 dmauro@google.com Googletest export 2021-09-15 absl-team@google.com Googletest export If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC asully@google.com,preethim@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win-chrome Tbr: asully@google.com,preethim@google.com Change-Id: I8fc21a04c2d2ac663917ae59e5b50c5ad04783f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180378 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#924842}
The experiment is still ongoing, so extending through M99. Bug: None Change-Id: I3fcde68246cabc7197eb6433bad17da19f991d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182641 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Reviewed-by: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/main@{#924843}
This inlines all remaining DISALLOW_* macros in extensions/. This is done manually (vim regex + manually finding insertion position). IWYU cleanup is left as a separate pass that is easier when these macros go away. Bug: 1010217 Change-Id: Iaa7350a03f343ce441c57eb8df1812be7cd518f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179855 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#924844}
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/de71511109..1ce4ceca2b Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/de71511109..1ce4ceca2b Bug: 1251757 Change-Id: I4b4bb77068e2e7aa4c31ad61dce98dc7da702939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3181708 Reviewed-by: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#924845}
Adds a crashkey with the current count of RenderFrameHosts for the RenderProcessHost involved in the crash. Bug: 1148542 Change-Id: I3ec9cd7df4834745246bdb3528e56bceffe8ec1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179666 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: W. James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/main@{#924846}
Screen capture observes when image container is added or removed from the view. However, in a refactor CL (http://crrev/c/3123711), we changed the lifecycle of image container, so now screen capture should observe the visibility of image container instead. This CL makes that change, adds some small fixes to the notification class and re-enables the flaky test that is caused by this issue. Fixed: 1245273 Change-Id: I6df419298ae7dd1ee8c179a37afd1becebf7cbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169080 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/main@{#924847}
Migrating files that are not shared with CrOS Settings. Bug: 1234307 Change-Id: Ifd6db45b8801b3e67d8b67d897789e2fc0663234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179300 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#924848}
Allow extensions to use new session storage area as part of the Storage API. Move from canary to stable, and update tests that used the trunk channel. Bug: 1185226 Change-Id: Ibf8b54fcc1571bb4332e7681061538580c31f208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3070039 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Emilia Paz <emiliapaz@chromium.org> Cr-Commit-Position: refs/heads/main@{#924849}
To prepare for Storage Partitioning, the abstract parent class AbstractOriginEnumerators and its child classes were refactored to return blink::StorageKeys rather than than url::Origins. While this CL does not change how the database is accessed (using origin and type), it will reduce the number of callsites where a url::Origin is converted in-line to a StorageKey value. This is a benefit because it greatly reduces the amount of time spent maintaining and refactoring when a change to the StorageKey constructor is made. Bug: 1247726 Change-Id: I8bad13189405f095f22298d91d243dc7059675e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169132 Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Kyra Seevers <kyraseevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#924850}
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-amd64-generic-chrome R=chrome-os-gardeners-reviews@google.com Change-Id: I736fa47e2867e801322d8de4458d479faf4093d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182804 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#924851}
https://chromium.googlesource.com/catapult.git/+log/3d49e1ccfd12..444aba89e1c3 2021-09-24 heiserya@google.com Pinpoint -> BQ: Only save a row if at least one metric is populated If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1251393 Tbr: zhanliang@google.com Change-Id: I886183d7bc4ecc67cef3bf6fd8f3fab4e0d3729e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182663 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#924852}
Adds a missing APK used for performance testing that was accidentally removed in some recent refactoring. Bug: 1252642 Change-Id: I80b45e15c23ce639499b55abdf38eaaeb6528b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182648 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/main@{#924853}
Adds a new builder/tester pair to replace the existing "Mac FYI arm64 Release (Apple DTK)" bot. Bug: 1252191 Change-Id: Ifd3d5269daa9e144baa2433ecdfc022c1b7839a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179809 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/main@{#924854}
This reverts commit 69c83b4. Reason for revert: broke linux-ozone-rel Original change's description: > ozone: make linux-ozone-rel bot run only Wayland > > As Ozone/X11 is default backend now, the linux-rel bot runs tests > with Ozone/X11 backend. Linux-ozone-rel can stop running x11 tests > and free resources for Wayland backend. Thus, it is being made > Wayland only bot now and will be also renamed to linux-wayland-rel. > > What's more Headless variant is not needed as it doesn't really > run tests. > > Bug: 1252668 > Change-Id: If013b5dec84722329dd863ede313588e548db683 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3178909 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/main@{#924833} Bug: 1252668 Change-Id: Ice7581f98d5e00adeecf1c44e119d414672ad403 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183220 Auto-Submit: Maksim Sisov <msisov@igalia.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#924855}
The flag itself has already been removed, but flag-metadata.json was not updated. Bug: 1218269 Change-Id: I35d78eb839fc5046b7268fedebc8aa3bf50437d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182647 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/main@{#924856}
Bug: 1246540 Change-Id: I06207709e6e0c69bc519702b6ce692e31cc0f89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3176576 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/main@{#924857}
https://chromium-review.googlesource.com/c/chromium/src/+/3166110 broke the test infrastructure but only disabled the skew tests for clients lte M95. It also needed to disable the skew tests for implementations lte M95. Bug: 1252887 Change-Id: I285e52fa15929ab6039a78ebc819504604581146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183024 Owners-Override: Filip Gorski <fgorski@chromium.org> Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#924858}
…tions Bug: 1249870 Change-Id: I41994371aa7db832e5315a919f69244478e7f93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172736 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/main@{#924859}
Just like MacOS, LaCros delegated compositing requires released overlays to propagate back to SkiaRenderer in order to release the backings for the aggregate render passes. This propagation follows the mac code closely with the exception of the special case handling for solid color quads. Bug: 1203921 Change-Id: Iba09e2b2e17d2dc554d0936bb0427a8ae58b6e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171533 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/main@{#924860}
This CL removes unnecessary USE_X11 define, which is deprecated. Also makes DesktopWindowTreeHostLinuxTest platform independent as when Wayland starts to support activation, these tests will be enabled. Bug: 1096425 Change-Id: I55c982ac702ad6dccb6f85618568f1e418597d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179050 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#924861}
Update DevicePairingHandler not to manually call FinishCurrentPairingRequest() when a pairing is cancelled. This call is unnecessary because calling device->CancelPairing() will automatically cause the device's Connect() callback to fire with an error code, which will cause FinishCurrentPairingRequest() to be called. Adding an extra call causes a crash since pair_device_callback_ has already ran. Also update OnDelegateDisconnect() not to call NotifyFinished() when a pairing delegate has disconnected. This is because if a pairing attempt fails, and the user wishes to attempt a new pairing, a new pairing delegate is created, which will disconnect the old one. We should not notify that we have finished pairing when the old one disconnects because the pairing handler can still receive new pairing requests. Bug: 101321 Change-Id: I6ff388586107333a3f7fef540703a51944408bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180023 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/main@{#924862}
This is a refactoring to help make it easier to support the use of multi-screen information in iframes. (See issue 1182855.) Previously, RenderWidgetHostView dealt in DisplayList while RenderWidgetHostImpl and visual properties dealt in ScreenInfos. It is possible to convert from Display to ScreenInfo and from DisplayList into ScreenInfos, but it is not possible to do the reverse. As visual properties deal with ScreenInfos, RenderWidgetHostViewChildFrame is then in an awkward spot. It needs to provide a DisplayList to RenderWidgetHostImpl but only has ScreenInfos to give. One alternative considered was to check if this was a child frame and do some static cast on the view to reach in and get the ScreenInfos directly. This is a bit awkward from an OO perspective, and leaves RenderWidgetHostViewChildFrame::GetDisplayList as a function that should never be called. This patch instead replaces the RenderWidgetHostView::GetDisplayList function with a RenderWidgetHostView::GetScreenInfos function. In a followup, RenderWidgetHostViewChildFrame should be able to implement this directly to pass the full set of ScreenInfos. This also works towards a data structure cleanup where DisplayList is the ui/display internal list of all the displays on the system, and ScreenInfos is the widget-centric view of those displays, which knows about which ScreenInfo is current. (Arguably display::Display and display::ScreenInfo can also be combined at some point.) This will then allow a follow-up to remove DisplayList's mojom (as ScreenInfo already has it to be sent to Blink) and to remove DisplayList's notion of the current display, which is only sometimes valid. Bug: 1182855 Change-Id: Ifa3f0b819122b4457fcedde6649faf2b985e575d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138774 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: Mike Wasserman <msw@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/main@{#924863}
This reverts commit 4309ad2. Reason for revert: Already have a Canary release with these CHECKs. Original change's description: > Add some CHECKs to get better crash data > > This patch adds some CHECKs to get better crash data for > crbug.com/1250831. We will revert it after one Canary release. > > Bug: 1250831 > Change-Id: I3e6ff34c3bdb83d52985d39faa4aa18daabc12d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177650 > Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924197} Bug: 1250831 Change-Id: I45af16d33ca7dd442ae8348da83b93a4d59fe730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182643 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#924864}
Removes the GPU arm Mac builders with "DTK" in the name since we have created new "M1" builders to replace them. Bug: 1252191 Change-Id: Ide444eea6539d339646f9c7b0a4d42ae1935780d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183020 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/main@{#924865}
Extends a few notification related flags in flag-metadata.json. Bug: NONE Change-Id: I387097e55e7890d9c377ba6ea2c78bc557b4091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182741 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#924866}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b389445afd1d..8600cfe5a264 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I45d3ea99989adb0ff6b75470c275e710f546061a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184083 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925060}
Roll Chrome Mac PGO profile from chrome-mac-main-1632569839-2bda687fea657332211f13c7b029fbe0674bd6d0.profdata to chrome-mac-main-1632592667-7f9c1da9b57bc2f9f7f9938ab9d0379c7ebff4f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6edf02b9d2311977eb28356ac9c2f947ecf04e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184272 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925061}
https://skia.googlesource.com/skia.git/+log/6f06bab63249..aeb5d4daed3a 2021-09-25 michaelludwig@google.com [graphite] Flesh out Device/SDC a bit more If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I8f7c8fcc3571954ccb53092e0257e7eb5892466c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184268 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925062}
- This change fixes an issue where tests that were unable to be run were being reported as failures in the Diagnostics UI. Bug: 1197335 Change-Id: I0f3b1770136b78a69d6a95b162359331ef0af983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182807 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/main@{#925063}
Change-Id: Idd02a0893bc26acfa270a1230868fcb19206f31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183427 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925064}
Roll Chrome Linux PGO profile from chrome-linux-main-1632569839-444aba213804fb3410f36037d07ed372fd2c849e.profdata to chrome-linux-main-1632592667-8fe51e116e0ff57b7f61a91b1494597352fed443.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7850cf8e5d1bb6dd4c0a7edcb2931c750235b0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184278 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925065}
Roll Chrome Win64 PGO profile from chrome-win64-main-1632579934-4c1a3af8ac9427cb273448cec78b2b238542ee91.profdata to chrome-win64-main-1632592667-85b909abf94dc770d861d86cde4f3d8f012e28b8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icc751ff502cddd1dfe92744106174ca62d796a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184271 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925066}
Using wpt-import in Chromium 0818271. With Chromium commits locally applied on WPT: e2dc11a "Fix flaky coop reporting tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: I64a23f632fad85c1e9c904db58641428da29ea84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183782 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925067}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8600cfe5a264..03bb10fdcdce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I73ba73f046cda8eb83ad4f9eced63ca11d213466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184270 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925068}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8ce61b9d..0c958868 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I170a6c400cfd1bcf40eb0172cc48a8064dff9ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183783 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925069}
Roll Chrome Win32 PGO profile from chrome-win32-main-1632579934-d45b660146fd450adb8aafb44c056cedb8b3e3af.profdata to chrome-win32-main-1632592667-2cef6c9c84d185349d8be4088e1c6439967d664d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If26083c7977dde5a61a44843ce2c860e31c7af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184275 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925070}
This is actually somewhat inefficient: base::DoNothing() generates a callback, which is then wrapped by another callback. Calling Run() on the result callback requires jumping through two thunks before actually dispatching the bound functor (which, of course, does nothing). Convert the various uses to use a lambda instead. Bug: 1252980 Change-Id: Icf9481cc9a161e176496f17f0db581cf6f450cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183366 Reviewed-by: Anqing Zhao <anqing@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Owners-Override: Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#925071}
Roll Chrome Win64 PGO profile from chrome-win64-main-1632592667-85b909abf94dc770d861d86cde4f3d8f012e28b8.profdata to chrome-win64-main-1632602966-cabe1808d149467a93d860a59e569070debd0d57.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0cfd6ffac320c68a3fe9f54853a330c71a6faeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184285 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925072}
…d687c02-1 Ran `./tools/clang/scripts/upload_revision.py ed687c021161b87858260f8583bfc8b178903593`. Bug: 1251147 Change-Id: I54a7abde718f0711a953a27c17fcea2ab3594ff5 Cq-Include-Trybots: chromium/try:android-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac11-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-asan,win7-rel Cq-Include-Trybots: chromium/try:android-official,fuchsia-official Cq-Include-Trybots: chromium/try:mac-official,linux-official Cq-Include-Trybots: chromium/try:win-official,win32-official Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182789 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/main@{#925073}
Roll Chrome Win32 PGO profile from chrome-win32-main-1632592667-2cef6c9c84d185349d8be4088e1c6439967d664d.profdata to chrome-win32-main-1632602966-e26b86b88f1b8246b077aef19aea9776006eca02.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie2defb73263079b865c992c69bb5ffff76e128ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184287 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925074}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC clank-library-failures@google.com,mheikal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: clank-library-failures@google.com,mheikal@google.com Change-Id: Ic9dae4eb9383d1dc7ebf117854e942a02f28eab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184289 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925075}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03bb10fdcdce..70f148a37948 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I44f4f1dc5286e5d9d9e3ff1c4a66020f7d8db31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184381 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925076}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Ic20f8be3ef4453fb01eb0ec202e15f5b25f7a92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184288 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925077}
Roll Chrome Linux PGO profile from chrome-linux-main-1632592667-8fe51e116e0ff57b7f61a91b1494597352fed443.profdata to chrome-linux-main-1632613016-45822416ec7d3bb4f62afb9f5de0d725a1f374f2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I390f0d13f8b262d85026eb95e62cbaeabcbeb706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184510 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925078}
Roll Chrome Mac PGO profile from chrome-mac-main-1632592667-7f9c1da9b57bc2f9f7f9938ab9d0379c7ebff4f4.profdata to chrome-mac-main-1632613016-15d316daa5cb0d3ce63998f5bf029971a584b138.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idab73dcde501fae977afd11fc438afbf9fa93402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184509 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925079}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/70f148a37948..9ffa7a4a05e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1239409 Tbr: Change-Id: I9facefaa69300a7a60f6274c29bf96ddd1862a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184479 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925080}
Roll Chrome Win64 PGO profile from chrome-win64-main-1632602966-cabe1808d149467a93d860a59e569070debd0d57.profdata to chrome-win64-main-1632613016-920ef4b6aad6e1e7efff235e4c1d1606e0a75b61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If273123788cf519918d5ca8d7a1fd52a4eca5cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184501 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925081}
Roll Chrome Win32 PGO profile from chrome-win32-main-1632602966-e26b86b88f1b8246b077aef19aea9776006eca02.profdata to chrome-win32-main-1632613016-a73b4e09f16f6a9ecdaeee0578e76a908107f2fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaa8a2f1bbb80b5c9f06f964d9ac352acdce9392d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184505 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925082}
This CL will add skew tests for version 94.0.4606.65. See crbug.com/1041619 and crbug.com/1099017 for more information. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I2f18414349a723afe39ee208a7ba82c8e25ce5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183038 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925083}
This CL will add skew tests for version 95.0.4638.26. See crbug.com/1041619 and crbug.com/1099017 for more information. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I052b885567663be988a74a6dc794e45e80a9be59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184520 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925084}
As that is the place we're trying to track down. BUG=1245816,1247152 TEST=none Change-Id: Ia94691812ae5e829d7e09f272e1fae8c52aa1399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183386 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#925085}
Add aggregation statistics for the app platform metrics UKM, so that we can see the statistics from the UKM dashboard. BUG=1250971 Change-Id: Ib3f6fe37165cdbc38a98fb099771e1a283195b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179562 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#925086}
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I508ce7b2698b4446d6eefb5753f3e7321987f167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184521 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#925087}
pull bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
This reverts commit 37ea471. Reason for revert: Reverted CL is unrelated to the cited "reason for revert". Original change's description: > Revert "Privatise unnecessarily public current_input_method in" > > This reverts commit 77e9679. > > Reason for revert: > Likely cause of failure > Step "browser_tests on Ubuntu-18.04" failing on builder "linux-chromeos-chrome" > > The failure is a crash in browser_tests. > > This failure is fairly but not perfectly consistent. In three of the last four runs on this bot, browser_tests failed with something in the NativeInputMethodEngineTest.EmojiSuggestion* suite. It's not always the same test that fails each time. Nevertheless, this is pretty indicative that nowadays something is wrong in this suite. This is the obvious candidate, submitted right when the test became mostly-failing. > > Here is the first failure as an example: > Retrying 1 test (retry #0) > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUrlOrAppNotAllowed > 2021-09-24T11:30:01.258384Z WARNING browser_tests[27592:27592]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [434.616] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T11:30:01.293097Z WARNING browser_tests[27592:27609]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T11:30:01.304548Z ERROR browser_tests[27592:27592]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T11:30:01.309314Z ERROR browser_tests[27592:27592]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T11:30:01.332070Z WARNING browser_tests[27592:27592]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T11:30:01.358975Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359074Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T11:30:01.359110Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T11:30:01.359138Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.359147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T11:30:01.359429Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T11:30:01.359547Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T11:30:01.359581Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T11:30:01.359621Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T11:30:01.360073Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T11:30:01.360118Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T11:30:01.360147Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360161Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360173Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360234Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.360415Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T11:30:01.361882Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T11:30:01.361936Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T11:30:01.361964Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T11:30:01.362091Z WARNING browser_tests[27592:27639]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T11:30:01.412518Z ERROR browser_tests[27592:27592]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T11:30:01.433615Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T11:30:01.451071Z WARNING browser_tests[27592:27592]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T11:30:01.458878Z WARNING browser_tests[27592:27592]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T11:30:01.464809Z INFO browser_tests[27592:27592]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T11:30:01.470495Z INFO browser_tests[27592:27592]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T11:30:01.473373Z WARNING browser_tests[27592:27639]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T11:30:01.535229Z ERROR browser_tests[27592:27639]: [als_reader.cc(52)] Missing num of als > 2021-09-24T11:30:01.535643Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535680Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T11:30:01.535688Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T11:30:01.535695Z ERROR browser_tests[27592:27639]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T11:30:01.555145Z INFO browser_tests[27592:27592]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x556151f72449 base::debug::CollectStackTrace() > #1 0x556151ed9d73 base::debug::StackTrace::StackTrace() > #2 0x5561525e4683 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f7dd56e2040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x5561556c8304 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x5561503c8362 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x5561503d05f0 content::WebContentsImpl::DidFinishNavigation() > #7 0x5561502a5093 content::NavigationRequest::~NavigationRequest() > #8 0x5561502a59dc content::NavigationRequest::~NavigationRequest() > #9 0x5561502b8919 content::Navigator::DidNavigate() > #10 0x5561502caeed content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x5561502ca24a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x5561502e9d60 base::internal::FunctorTraits<>::Invoke<>() > #13 0x5561502e9d0f base::internal::Invoker<>::RunOnce() > #14 0x55614fd53470 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x55615301c6e0 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x5561530201e0 mojo::MessageDispatcher::Accept() > #17 0x55615301d435 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x5561531dc3e2 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x55615301e323 base::internal::Invoker<>::RunOnce() > #20 0x556151f35f23 base::TaskAnnotator::RunTask() > #21 0x556151f467b3 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x556151f46569 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x556151f46b32 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x556151fa9c4b base::MessagePumpLibevent::Run() > #25 0x556151f46d6d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x556151f18c1b base::RunLoop::Run() > #27 0x556151ec159d InProcessBrowserTest::RunUntilBrowserProcessQuits() > #28 0x556151ec207f InProcessBrowserTest::QuitBrowsers() > #29 0x556151ec1fce InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x5561525e3d34 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x556152012479 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x55615201197e ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x55614efa9b98 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x5561500381cd content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x5561503a1a9c content::StartupTaskRunner::RunAllTasksNow() > #36 0x556150037e4a content::BrowserMainLoop::CreateStartupTasks() > #37 0x55615003a147 content::BrowserMainRunnerImpl::Initialize() > #38 0x556150036912 content::BrowserMain() > #39 0x556150bf6aed content::RunBrowserProcessMain() > #40 0x556150bf79bd content::ContentMainRunnerImpl::RunBrowser() > #41 0x556150bf752e content::ContentMainRunnerImpl::Run() > #42 0x556150bf5b38 content::RunContentProcess() > #43 0x556150bf5c08 content::ContentMain() > #44 0x5561525e3543 content::BrowserTestBase::SetUp() > #45 0x556151ec12c1 InProcessBrowserTest::SetUp() > #46 0x55614e1c8786 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x55614f308e8f testing::Test::Run() > #48 0x55614f3097c5 testing::TestInfo::Run() > #49 0x55614f309f21 testing::TestSuite::Run() > #50 0x55614f313798 testing::internal::UnitTestImpl::RunAllTests() > #51 0x55614f31338b testing::UnitTest::Run() > #52 0x556151fd7ff2 base::TestSuite::Run() > #53 0x556151e96409 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x556152613c1f content::LaunchTests() > #55 0x556151e98224 LaunchChromeTests() > #56 0x556151e9638b main > #57 0x7f7dd56c4bf7 __libc_start_main > #58 0x55614cca11ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17628 > > Here is the fourth: (different test in the same suite, different stack trace): > [ RUN ] NativeInputMethodEngineTest.EmojiSuggestionDisabledReasonkUserSettingsOff > 2021-09-24T16:19:05.593039Z WARNING browser_tests[31407:31407]: [audio_manager_linux.cc(60)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > [959.207] default_socket.cc:58 /run/perfetto/ exists but cannot be accessed. Falling back on /tmp/ (errno: 13, Permission denied) > 2021-09-24T16:19:05.646514Z WARNING browser_tests[31407:31423]: [wallpaper_decoder.cc(29)] Failed reading file > 2021-09-24T16:19:05.673272Z ERROR browser_tests[31407:31407]: [print_job_reporting_service_factory.cc(47)] DMToken must be valid > 2021-09-24T16:19:05.678360Z ERROR browser_tests[31407:31407]: [proximity_auth_profile_pref_manager.cc(194)] Failed to find local state prefs for current user. > 2021-09-24T16:19:05.728926Z WARNING browser_tests[31407:31407]: [remote_commands_service.cc(188)] Client is not registered. > 2021-09-24T16:19:05.763864Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.763999Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Cache: 0MB > 2021-09-24T16:19:05.764049Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.README: 0MB > 2021-09-24T16:19:05.764094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.764120Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.WebData: 0MB > 2021-09-24T16:19:05.764270Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.CodeCache: 0MB > 2021-09-24T16:19:05.764446Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SiteCharacteristicsDatabase: 0MB > 2021-09-24T16:19:05.765718Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Favicons: 0MB > 2021-09-24T16:19:05.765751Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginDataForAccount: 0MB > 2021-09-24T16:19:05.766067Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.GCache: 0MB > 2021-09-24T16:19:05.766094Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.History: 0MB > 2021-09-24T16:19:05.766115Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766123Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766131Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766199Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.766336Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LocalStorage: 0MB > 2021-09-24T16:19:05.766472Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.SyncData: 0MB > 2021-09-24T16:19:05.766498Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOCK: 0MB > 2021-09-24T16:19:05.766524Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LoginData: 0MB > 2021-09-24T16:19:05.766552Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.LOG: 0MB > 2021-09-24T16:19:05.766909Z WARNING browser_tests[31407:31433]: [user_data_stats_recorder.cc(186)] Ash.UserDataStatsRecorder.DataSize.Unknown: 0MB > 2021-09-24T16:19:05.880798Z ERROR browser_tests[31407:31407]: [plugin_vm_manager_impl.cc(150)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-09-24T16:19:05.921761Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(509)] One-time key permissions migration started for token: 0. > 2021-09-24T16:19:05.932877Z WARNING browser_tests[31407:31407]: [drivefs_session.cc(65)] DriveFs mount failed with error: 3 > 2021-09-24T16:19:05.951965Z WARNING browser_tests[31407:31407]: [login_unlock_throughput_recorder.cc(58)] Zero frames expected in login animation throughput data > 2021-09-24T16:19:05.973007Z INFO browser_tests[31407:31407]: [android_sms_pairing_state_tracker_impl.cc(71)] No Pairing cookie found > 2021-09-24T16:19:05.977396Z WARNING browser_tests[31407:31428]: [google_brand_chromeos.cc(40)] Brand code file missing: /opt/oem/etc/BRAND_CODE > 2021-09-24T16:19:05.981581Z INFO browser_tests[31407:31407]: [ui_test_utils.cc(224)] NavigateToURL: chrome://newtab/ > 2021-09-24T16:19:06.072941Z ERROR browser_tests[31407:31457]: [als_reader.cc(52)] Missing num of als > 2021-09-24T16:19:06.073283Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(230)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073310Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(233)] crbug.com/1216328: Checking Bluetooth availability ended. > 2021-09-24T16:19:06.073337Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(236)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends. > 2021-09-24T16:19:06.073358Z ERROR browser_tests[31407:31457]: [chrome_browser_main_extra_parts_metrics.cc(240)] crbug.com/1216328: Checking default browser status ended. > 2021-09-24T16:19:06.085536Z INFO browser_tests[31407:31407]: [key_permissions_manager_impl.cc(534)] One-time key permissions migration succeeded for token: 0. > BrowserTestBase received signal: Segmentation fault. Backtrace: > #0 0x564f24b8af29 base::debug::CollectStackTrace() > #1 0x564f24af2843 base::debug::StackTrace::StackTrace() > #2 0x564f251fd373 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #3 0x7f03d338d040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) > #4 0x564f282e0d94 ChromeOmniboxNavigationObserver::DidFinishNavigation() > #5 0x564f22fe1042 content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() > #6 0x564f22fe92d0 content::WebContentsImpl::DidFinishNavigation() > #7 0x564f22ebdd73 content::NavigationRequest::~NavigationRequest() > #8 0x564f22ebe6bc content::NavigationRequest::~NavigationRequest() > #9 0x564f22ed15f9 content::Navigator::DidNavigate() > #10 0x564f22ee3bcd content::RenderFrameHostImpl::DidCommitNavigationInternal() > #11 0x564f22ee2f2a content::RenderFrameHostImpl::DidCommitNavigation() > #12 0x564f22f02a40 base::internal::FunctorTraits<>::Invoke<>() > #13 0x564f22f029ef base::internal::Invoker<>::RunOnce() > #14 0x564f2296c430 content::mojom::NavigationClient_CommitFailedNavigation_ForwardToCallback::Accept() > #15 0x564f25c35100 mojo::InterfaceEndpointClient::HandleValidatedMessage() > #16 0x564f25c38c00 mojo::MessageDispatcher::Accept() > #17 0x564f25c35e55 mojo::InterfaceEndpointClient::HandleIncomingMessage() > #18 0x564f25df4e02 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread() > #19 0x564f25c36d43 base::internal::Invoker<>::RunOnce() > #20 0x564f24b4ea03 base::TaskAnnotator::RunTask() > #21 0x564f24b5f293 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() > #22 0x564f24b5f049 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #23 0x564f24b5f612 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() > #24 0x564f24bc28cb base::MessagePumpLibevent::Run() > #25 0x564f24b5f84d base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() > #26 0x564f24b316fb base::RunLoop::Run() > #27 0x564f22f433f3 content::BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting() > #28 0x564f2522df45 content::RunAllPendingInMessageLoop() > #29 0x564f24adaa96 InProcessBrowserTest::PostRunTestOnMainThread() > #30 0x564f251fca24 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #31 0x564f24c2b0f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #32 0x564f24c2a5fe ChromeBrowserMainParts::PreMainMessageLoopRun() > #33 0x564f21bc1f38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #34 0x564f22c510ed content::BrowserMainLoop::PreMainMessageLoopRun() > #35 0x564f22fba77c content::StartupTaskRunner::RunAllTasksNow() > #36 0x564f22c50d6a content::BrowserMainLoop::CreateStartupTasks() > #37 0x564f22c53067 content::BrowserMainRunnerImpl::Initialize() > #38 0x564f22c4f832 content::BrowserMain() > #39 0x564f2380f5bd content::RunBrowserProcessMain() > #40 0x564f2381048d content::ContentMainRunnerImpl::RunBrowser() > #41 0x564f2380fffe content::ContentMainRunnerImpl::Run() > #42 0x564f2380e608 content::RunContentProcess() > #43 0x564f2380e6d8 content::ContentMain() > #44 0x564f251fc233 content::BrowserTestBase::SetUp() > #45 0x564f24ad9d91 InProcessBrowserTest::SetUp() > #46 0x564f20de0a86 ash::input_method::(anonymous namespace)::NativeInputMethodEngineTest::SetUp() > #47 0x564f21f21e4f testing::Test::Run() > #48 0x564f21f22785 testing::TestInfo::Run() > #49 0x564f21f22ee1 testing::TestSuite::Run() > #50 0x564f21f2c758 testing::internal::UnitTestImpl::RunAllTests() > #51 0x564f21f2c34b testing::UnitTest::Run() > #52 0x564f24bf0c72 base::TestSuite::Run() > #53 0x564f24aaeed9 BrowserTestSuiteRunnerChromeOS::RunTestSuite() > #54 0x564f2522c62f content::LaunchTests() > #55 0x564f24ab0cf4 LaunchChromeTests() > #56 0x564f24aaee5b main > #57 0x7f03d336fbf7 __libc_start_main > #58 0x564f1f8b94ea _start > from > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/17631 > > Original change's description: > > Privatise unnecessarily public current_input_method in > > InputMethodManagerImpl::StateImpl. > > > > This involves replacing some direct pokes of current_input_method > > with public GetCurrentInputMethod() that employs a fallback onto > > InputMethodUtil::GetFallbackInputMethodDescriptor() when ID is > > blank. This should be more reasonable and consistent. > > > > Bug: 1134465 > > Change-Id: I2c423a58547cc7249efdf8056624623998765aba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177760 > > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> > > Reviewed-by: Keith Lee <keithlee@chromium.org> > > Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#924702} > > Bug: 1134465 > Change-Id: I6144a0ebd7472f31d4b937d9e99b6a6c8bc0eee1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182806 > Auto-Submit: Mark Pearson <mpearson@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Owners-Override: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924810} Bug: 1134465 Change-Id: I358d66835e54d67d8d151e3da38da9a8f33d83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184801 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#925158}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )