Properly clean up configkey values from oc_appconfig table when disabling encryption#35756
Closed
Properly clean up configkey values from oc_appconfig table when disabling encryption#35756
configkey values from oc_appconfig table when disabling encryption#35756Conversation
Make create user steps specify explicitly that the user has skeleton files
…th-tolowercase-inshare-api Revert "Convert shareWith to lower case"
Remove deprecated default attributes test steps
Ignore share hooks for masterkey encryption
Send requests in loop rather than scenario outline to speed up CI
The recipient of internal share, should not be able to increase the permission. Signed-off-by: Sujith H <sharidasan@owncloud.com>
skip failing test on ldap and files_primary_s3
The recipient of internal share should not increase permission
…matching-file api test for federation sharing when the receiver has matching file/folder
acceptance test for shares received from multiple users with the same name file/folder
webui login without skeleton files
Add no skeleton steps in webUIRestrictSharing
fix snakeoil tests
…abled Fixup check_apache_module_enabled in run.sh
…/js-yaml-3.13.1 Bump js-yaml from 3.10.0 to 3.13.1 in /build
apiTest for share with only membership groups
change wording of exclude group from sharing tests
Acceptance test for renaming folders received from multiple users wit…
Sort out api sharing test group membership to match with user_ldap
…ption-as-typehint Use Throwable as type hint in the exception callback
…rshipGroups Add webUI tests for share only with membership groups
Contributor
|
@pako81 you have some style errors, run |
pako81
force-pushed
the
reactivating-encryption-fix
branch
from
77d19e7 to
bd3c517
Compare
Codecov Report
@@ Coverage Diff @@
## master #35756 +/- ##
=============================================
- Coverage 65.81% 49.09% -16.73%
=============================================
Files 1228 109 -1119
Lines 70982 10535 -60447
Branches 1289 1289
=============================================
- Hits 46716 5172 -41544
+ Misses 23888 4985 -18903
Partials 378 378
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35756 +/- ##
=============================================
- Coverage 65.81% 49.09% -16.73%
=============================================
Files 1228 109 -1119
Lines 70982 10535 -60447
Branches 1289 1289
=============================================
- Hits 46716 5172 -41544
+ Misses 23888 4985 -18903
Partials 378 378
Continue to review full report at Codecov.
|
…pconfig table when disabling encryption
pako81
force-pushed
the
reactivating-encryption-fix
branch
from
bd3c517 to
51f25cb
Compare
Contributor
|
@pako81 We will work together on this test next week :-) |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, we have the problem that we do not correctly clean up the
configkeyvalues in the oc_appconfig table when disabling encryption.Specifically the
useMasterKeykey for the encryption app, which stays set to1. This seems to lead to theencryption_enabledkey for core to remain set tonoso when trying to reenable the encryption app and runningencryption:select-encryption-type masterkey, this will fail.The same has been observed for user-keys encryption. This PR fixes this behavior by properly cleaning up the
configkeyvalues and making re-enabling of encryption possible.Related Issue
How Has This Been Tested?
Manually by first activating encryption by running:
occ app:enable encryption,occ encryption:enable,occ encryption:select-encryption-type masterkey -yandencryption:encrypt-allThen disable it with
occ app:disable encryption,occ encryption:disableRe-enabling encryption once again and check that when running
occ encryption:select-encryption-type masterkey, no error is triggered.Tested the same with user-keys encryption.
Types of changes
Checklist:
Open tasks: