Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for contact sensor (T110) #877

Merged
merged 5 commits into from
May 7, 2024
Merged

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Apr 27, 2024

Initial support for T110 contact sensor.

TODO:

  • Find out which component is needed
  • Add tests

Related to #875

@rytilahti rytilahti added the enhancement New feature or request label Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.39%. Comparing base (253287c) to head (2cead3c).

Files Patch % Lines
kasa/smart/smartmodule.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
- Coverage   90.39%   90.39%   -0.01%     
==========================================
  Files          70       71       +1     
  Lines        4937     4955      +18     
  Branches     1219     1221       +2     
==========================================
+ Hits         4463     4479      +16     
- Misses        384      385       +1     
- Partials       90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti force-pushed the feat/contact_sensor branch 2 times, most recently from 712f753 to 61556ae Compare May 7, 2024 01:15
Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions/questions

kasa/tests/smart/modules/test_contact.py Outdated Show resolved Hide resolved
kasa/tests/smart/modules/test_contact.py Outdated Show resolved Hide resolved
kasa/tests/smart/modules/test_contact.py Show resolved Hide resolved
kasa/smart/modules/contact.py Show resolved Hide resolved
kasa/smart/modules/contact.py Show resolved Hide resolved
Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let’s merge it

@rytilahti rytilahti linked an issue May 7, 2024 that may be closed by this pull request
@rytilahti rytilahti merged commit 353e844 into master May 7, 2024
27 checks passed
@rytilahti rytilahti deleted the feat/contact_sensor branch May 7, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for T300 and T110
2 participants