-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for contact sensor (T110) #877
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #877 +/- ##
==========================================
- Coverage 90.39% 90.39% -0.01%
==========================================
Files 70 71 +1
Lines 4937 4955 +18
Branches 1219 1221 +2
==========================================
+ Hits 4463 4479 +16
- Misses 384 385 +1
- Partials 90 91 +1 ☔ View full report in Codecov by Sentry. |
712f753
to
61556ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions/questions
61556ae
to
59bc522
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let’s merge it
Initial support for T110 contact sensor.
TODO:
Related to #875