Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli to use common modules and remove iot specific cli testing #913

Merged
merged 4 commits into from
May 14, 2024

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented May 13, 2024

No description provided.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.15%. Comparing base (ef49f44) to head (29f614c).

Files Patch % Lines
kasa/cli.py 82.85% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
+ Coverage   90.49%   91.15%   +0.66%     
==========================================
  Files          78       78              
  Lines        5153     5156       +3     
  Branches     1253     1254       +1     
==========================================
+ Hits         4663     4700      +37     
+ Misses        397      362      -35     
- Partials       93       94       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kasa/cli.py Outdated Show resolved Hide resolved
kasa/cli.py Outdated Show resolved Hide resolved
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would you mind adding some tests to increase the coverage as hinted by codecov?

@sdb9696
Copy link
Collaborator Author

sdb9696 commented May 13, 2024

LGTM, but would you mind adding some tests to increase the coverage as hinted by codecov?

Most of the coverage drop is on patch because a lot of the cli commands are not currently covered in the project. I'll have a look at adding some though.

@sdb9696 sdb9696 merged commit 67b5d7d into master May 14, 2024
26 of 27 checks passed
@sdb9696 sdb9696 deleted the janitor/cli_use_modules branch May 14, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants