Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --help on subcommands #886

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix --help on subcommands #886

merged 1 commit into from
Apr 30, 2024

Conversation

rytilahti
Copy link
Member

Pass a dummy object as context object as it will not be used by --help anyway.

Also, allow defining --help anywhere in the argv, not just in the last place.

Fixes #885.

Pass a dummy object as context object as it will not be used by --help anyway.

Also, allow defining --help anywhere in the argv, not just in the last place.
@rytilahti rytilahti added the bug Something isn't working label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.41%. Comparing base (d3544b4) to head (b664d42).

Files Patch % Lines
kasa/cli.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #886   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          66       66           
  Lines        4779     4779           
  Branches     1181     1181           
=======================================
  Hits         4273     4273           
  Misses        416      416           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rytilahti rytilahti merged commit 7db989e into master Apr 30, 2024
26 of 27 checks passed
@rytilahti rytilahti deleted the fix/cli_subcommand_help branch April 30, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix --help on subcommands
2 participants