Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make module names consistent and remove redundant module casting #909

Merged
merged 3 commits into from
May 11, 2024

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented May 11, 2024

Addresses the inconsistent naming of smart modules by removing all "Module" suffixes and aligning filenames with class names. Removes the casting of modules to the correct module type now that is is redundant due to #895. Also updates the adding of iot modules to use the ModuleNames rather than a free string.

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 97.58065% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.58%. Comparing base (9473d97) to head (85da998).

Files Patch % Lines
kasa/smart/smartdevice.py 92.30% 1 Missing and 1 partial ⚠️
kasa/iot/iotdevice.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   90.57%   90.58%           
=======================================
  Files          75       75           
  Lines        5093     5096    +3     
  Branches     1246     1246           
=======================================
+ Hits         4613     4616    +3     
  Misses        391      391           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696 sdb9696 requested a review from rytilahti May 11, 2024 08:25
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up! Just a minor note that might be worth reconsideration, but other than that this looks good to go for me.

kasa/module.py Outdated Show resolved Hide resolved
@sdb9696 sdb9696 merged commit f259a8f into master May 11, 2024
27 checks passed
@sdb9696 sdb9696 deleted the janitor/rename_modules branch May 11, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants