Add fixture for p300 1.0.15

[rytilahti]

This version adds auto-off for individual strip sockets.

[sdb9696]

I'm guessing this is erroring initially because the parent device does not support auto_off but reports it in the same way as the ks240 reports it's child device features?

I think once #964 is merged we can use the test framework changes in that PR to ensure we call the module on the child devices for this use case. We'd also need to extend the module logic so it actually performs the child query.

I'm thinking we may be able to improve on the current logic around not adding modules that the parent reports but doesn't really support (i.e. ks240). Rather than simply not adding it if the child reports it we could instead implement the _is_supported to look in the parent device info for the appropriate property, i.e. "auto_off_status", "fan_speed_level", "brightness" and not add them that way. I actually think this might already work for the ks240 so will try it out tomorrow.

[rytilahti]

I'm guessing this is erroring initially because the parent device does not support auto_off but reports it in the same way as the ks240 reports it's child device features?

Correct.

I think once #964 is merged we can use the test framework changes in that PR to ensure we call the module on the child devices for this use case.

I'm not sure we can do this type of magic, at least not on all devices, as each individual socket have their own auto off timers.

We'd also need to extend the module logic so it actually performs the child query.

Yes, this would fix it for P300. We probably do not want to perform all child module queries as most of the times the information is already available, but we could use a logic on specific modules to check which extra queries to run?

Rather than simply not adding it if the child reports it we could instead implement the _is_supported to look in the parent device info for the appropriate property, i.e. "auto_off_status", "fan_speed_level", "brightness" and not add them that way.

Sounds worth trying out 👍

[sdb9696]

I'm guessing this is erroring initially because the parent device does not support auto_off but reports it in the same way as the ks240 reports it's child device features?

Correct.

I think once #964 is merged we can use the test framework changes in that PR to ensure we call the module on the child devices for this use case.

I'm not sure we can do this type of magic, at least not on all devices, as each individual socket have their own auto off timers.

We'd also need to extend the module logic so it actually performs the child query.

Yes, this would fix it for P300. We probably do not want to perform all child module queries as most of the times the information is already available, but we could use a logic on specific modules to check which extra queries to run?

Rather than simply not adding it if the child reports it we could instead implement the _is_supported to look in the parent device info for the appropriate property, i.e. "auto_off_status", "fan_speed_level", "brightness" and not add them that way.

Sounds worth trying out 👍

#966 removes the switch hardcoding for not adding unsupported modules to the parent.

The P300 with child auto_off should now be supported with #967.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (db6276d) to head (2ffb62c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
+ Coverage   91.33%   91.49%   +0.16%     
==========================================
  Files          83       83              
  Lines        5539     5539              
  Branches     1349     1349              
==========================================
+ Hits         5059     5068       +9     
+ Misses        374      369       -5     
+ Partials      106      102       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.