chore: build edge binaries in release mode #2292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
Member
Author
This was referenced Apr 1, 2025
Deploying rivet with
|
| Latest commit: |
0043f44
|
| Status: | 🚫 Build failed. |
Deploying rivet-hub with
|
| Latest commit: |
0043f44
|
| Status: | 🚫 Build failed. |
This was referenced Apr 1, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refines the Dockerfiles for edge components to consistently build binaries in release mode, improving performance and aligning with repository best practices.
- In /packages/edge/infra/client/container-runner/Dockerfile, reorders cargo flags to place --release after --bin.
- In /packages/edge/infra/edge-server/Dockerfile, adds the --release flag and updates the binary's relocation, noting the lingering TODO.
- In /packages/edge/infra/client/isolate-v8-runner/Dockerfile, switches cargo build to release mode and adjusts binary path.
- In /packages/edge/infra/client/manager/Dockerfile, transitions from debug to release, updating build and mv commands.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the branch
04-01-chore_add_logging_duration_metrics_to_pegboard_setup
graphite-app
bot
deleted the
04-01-chore_build_edge_binaries_in_release_mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes