-
Notifications
You must be signed in to change notification settings - Fork 135
chore: add script to distribute lz4 binary #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
NathanFlurry
wants to merge
1
commit into
04-01-chore_build_edge_binaries_in_release_mode
from
04-01-chore_add_script_to_distribute_lz4_binary
Closed
chore: add script to distribute lz4 binary #2293
NathanFlurry
wants to merge
1
commit into
04-01-chore_build_edge_binaries_in_release_mode
from
04-01-chore_add_script_to_distribute_lz4_binary
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
Member
Author
This was referenced Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR introduces a new lz4 distribution script that builds and uploads the lz4 binary using Docker, along with its supporting configuration.
- Added build and upload logic in /scripts/lz4/distribute.ts, noting the temporary directory isn’t cleaned up post-run.
- Defined workspace package for lz4 in /scripts/lz4/package.json using tsx and zx.
- Added /scripts/lz4/Dockerfile.debian11 for compiling lz4 on Debian 11-slim.
- Updated the root /package.json to include the new lz4 workspace in the monorepo.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Changes