Skip to content

Conversation

@NathanFlurry
Copy link
Member

Changes

Copy link
Member Author

NathanFlurry commented Apr 1, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cloudflare-workers-and-pages
Copy link

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: d5f0c57
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages
Copy link

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: d5f0c57
Status:🚫  Build failed.

View logs

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR introduces a new lz4 distribution script that builds and uploads the lz4 binary using Docker, along with its supporting configuration.

  • Added build and upload logic in /scripts/lz4/distribute.ts, noting the temporary directory isn’t cleaned up post-run.
  • Defined workspace package for lz4 in /scripts/lz4/package.json using tsx and zx.
  • Added /scripts/lz4/Dockerfile.debian11 for compiling lz4 on Debian 11-slim.
  • Updated the root /package.json to include the new lz4 workspace in the monorepo.

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 2, 2025

Merge activity

  • Apr 2, 1:51 PM EDT: NathanFlurry added this pull request to the Graphite merge queue.
  • Apr 2, 1:52 PM EDT: CI is running for this pull request on a draft pull request (#2299) due to your merge queue CI optimization settings.
  • Apr 2, 1:54 PM EDT: Merged by the Graphite merge queue via draft PR: #2299.

graphite-app bot pushed a commit that referenced this pull request Apr 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Apr 2, 2025
@graphite-app graphite-app bot deleted the 04-01-chore_add_script_to_distribute_lz4_binary branch April 2, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants