Skip to content

perf(pegboard): parallelize writing configs under setup_oci_bundle #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

perf(pegboard): parallelize writing configs under setup_oci_bundle #2289

wants to merge 1 commit into from

Conversation

@NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented Apr 1, 2025

Changes

This was referenced Apr 1, 2025
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Apr 1, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 1, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6910d5
Status:🚫  Build failed.

View logs

@NathanFlurry NathanFlurry force-pushed the 03-31-perf_pegboard_increase_page_size_for_passing_data_from_downlaod_to_lz4 branch from a2bf5a8 to 79ca91f Compare April 1, 2025 05:07
@NathanFlurry NathanFlurry force-pushed the 03-31-perf_pegboard_parallelize_writing_configs_under_setup_oci_bundle branch from 98c0b60 to c6910d5 Compare April 1, 2025 05:07
This was referenced Apr 1, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 2, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6910d5
Status:⚡️  Build in progress...

View logs

@NathanFlurry NathanFlurry force-pushed the 03-31-perf_pegboard_parallelize_writing_configs_under_setup_oci_bundle branch from c6910d5 to 096ea4c Compare April 2, 2025 07:02
@NathanFlurry NathanFlurry force-pushed the 03-31-perf_pegboard_increase_page_size_for_passing_data_from_downlaod_to_lz4 branch from 79ca91f to 6685e2d Compare April 2, 2025 07:02
@NathanFlurry NathanFlurry force-pushed the 03-31-perf_pegboard_parallelize_writing_configs_under_setup_oci_bundle branch from 096ea4c to c6910d5 Compare April 2, 2025 07:25
@NathanFlurry NathanFlurry mentioned this pull request Apr 2, 2025
Closed
@NathanFlurry NathanFlurry marked this pull request as ready for review April 2, 2025 17:51
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 2, 2025 •
edited
Loading

Merge activity

  • Apr 2, 1:51 PM EDT: NathanFlurry added this pull request to the Graphite merge queue.
  • Apr 2, 1:52 PM EDT: CI is running for this pull request on a draft pull request (#2299) due to your merge queue CI optimization settings.
  • Apr 2, 1:54 PM EDT: Merged by the Graphite merge queue via draft PR: #2299.

greptile-apps[bot]
greptile-apps bot reviewed Apr 2, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR optimizes the OCI bundle setup by parallelizing file writes in setup_oci_bundle using tokio::try_join!, replacing sequential writes and aiming for improved performance.

• In packages/edge/infra/client/manager/src/actor/setup.rs, config.json, resolv.conf, and hosts are written concurrently.
• All file contents are fully prepared before the concurrent writes, ensuring independent operations.
• Error propagation via try_join! maintains atomic behavior if any write fails.
• Confirm that the overall atomicity is acceptable in failure scenarios.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

graphite-app bot pushed a commit that referenced this pull request Apr 2, 2025
@NathanFlurry
perf(pegboard): parallelize writing configs under setup_oci_bundle (#…
c1011c5 
…2289)

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot deleted the branch 03-31-perf_pegboard_increase_page_size_for_passing_data_from_downlaod_to_lz4 April 2, 2025 17:54
@graphite-app graphite-app bot closed this Apr 2, 2025
@graphite-app graphite-app bot closed this Apr 2, 2025
@graphite-app graphite-app bot deleted the 03-31-perf_pegboard_parallelize_writing_configs_under_setup_oci_bundle branch April 2, 2025 17:54
@github-actions github-actions bot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanFlurry