perf(pegboard): download & extract with raw unix pipes #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
Member
Author
NathanFlurry
force-pushed
the
04-01-perf_pegboard_download_extract_with_raw_unix_pipes
branch
from
7464d01 to
6953d6a
Compare
Deploying rivet-hub with
|
| Latest commit: |
6953d6a
|
| Status: | 🚫 Build failed. |
Deploying rivet with
|
| Latest commit: |
6953d6a
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors image downloading for enhanced performance by leveraging raw Unix pipes for efficient data transfer and introduces a unified URL shuffling strategy.
• Added get_image_addresses in /packages/edge/infra/client/manager/src/utils/mod.rs using ChaCha12Rng seeded from image ID.
• Refactored download_image in /packages/edge/infra/client/manager/src/actor/setup.rs to build and execute shell commands with Unix pipes.
• Maintained fallback URL logic alongside improved error handling and metrics logging.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
04-01-perf_pegboard_download_extract_with_raw_unix_pipes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes