perf: migrate to lz4 1.10.0 for parallelized decompression #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
Member
Author
This was referenced Apr 1, 2025
Deploying rivet with
|
| Latest commit: |
73c7f9a
|
| Status: | 🚫 Build failed. |
Deploying rivet-hub with
|
| Latest commit: |
73c7f9a
|
| Status: | 🚫 Build failed. |
This was referenced Apr 2, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the lz4 module in mod.rs to download and install lz4 v1.10.0 directly, enabling parallelized decompression.
- Modified lz4 installation logic in packages/core/services/cluster/src/workflows/server/install/install_scripts/components/mod.rs to use a direct curl download.
- Uses indoc for multi-line string support in the new installation script.
- Bypasses apt-get to ensure the correct binary version is used.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the branch
04-01-chore_add_script_to_distribute_lz4_binary
graphite-app
bot
deleted the
04-01-perf_migrate_to_lz4_1.10.0_for_parallelized_decompression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes