chore(api-actor): don't attempt to contact edge dcs without worker nodes #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-hub with
|
| Latest commit: |
32c1fde
|
| Status: | 🚫 Build failed. |
This was referenced Apr 1, 2025
Member
Author
This was referenced Apr 1, 2025
Deploying rivet with
|
| Latest commit: |
32c1fde
|
| Status: | 🚫 Build failed. |
This was referenced Apr 2, 2025
NathanFlurry
changed the base branch from
03-31-perf_pegboard_parallelize_writing_configs_under_setup_oci_bundle
to
graphite-base/2290
NathanFlurry
changed the base branch from
graphite-base/2290
to
03-31-perf_pegboard_parallelize_writing_configs_under_setup_oci_bundle
Contributor
Merge activity
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The PR refactors multiple actor API endpoints to avoid contacting edge datacenters that lack required worker nodes by employing a new filtering utility.
- In /packages/core/api/actor/src/utils.rs, added filter_edge_dc to check for active worker and guard pools.
- In /packages/core/api/actor/src/route/builds.rs, prewarm API calls now filter datacenters using filter_edge_dc.
- In /packages/core/api/actor/src/route/logs.rs, get_logs applies the new filter to limit unnecessary edge requests.
- In /packages/core/api/actor/src/route/actors.rs, various endpoints (get, destroy, upgrade, and list_actors) incorporate the filter for datacenter selection.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…des (#2290) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the branch
03-31-perf_pegboard_parallelize_writing_configs_under_setup_oci_bundle
graphite-app
bot
deleted the
04-01-chore_api-actor_don_t_attempt_to_contact_edge_dcs_without_worker_nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes