perf(pegboard): parallelize download image & setup cni network #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
317678e
|
| Status: | 🚫 Build failed. |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 1, 2025
Deploying rivet-hub with
|
| Latest commit: |
317678e
|
| Status: | 🚫 Build failed. |
NathanFlurry
force-pushed
the
03-31-fix_pegboard_fix_manager_tests
branch
from
d967870 to
5852e82
Compare
NathanFlurry
force-pushed
the
03-31-perf_pegboard_parallelize_download_image_setup_cni_network
branch
from
402aa66 to
317678e
Compare
This was referenced Apr 1, 2025
NathanFlurry
force-pushed
the
03-31-fix_pegboard_fix_manager_tests
branch
from
5852e82 to
e9a7eb9
Compare
NathanFlurry
force-pushed
the
03-31-perf_pegboard_parallelize_download_image_setup_cni_network
branch
2 times, most recently
from
b17fc4e to
317678e
Compare
Contributor
Merge activity
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR optimizes the Actor's setup by parallelizing the filesystem/image download steps with port binding and CNI network setup.
- In packages/edge/infra/client/manager/src/actor/mod.rs, make_fs and download_image are now executed concurrently with bind_ports and optional CNI network configuration.
- The precomputed needs_cni_network flag ensures that the CNI setup logic runs only when required.
- Robust error propagation is maintained through tokio::try_join to ensure consistent state management.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
03-31-perf_pegboard_parallelize_download_image_setup_cni_network
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes