-
Notifications
You must be signed in to change notification settings - Fork 135
chore: add logging & duration metrics to pegboard setup #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add logging & duration metrics to pegboard setup #2291
Conversation
Merge activity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Overall, this PR adds comprehensive duration metrics and enhanced logging to improve traceability during actor setup in Pegboard Manager.
• Updated metrics in /packages/edge/infra/client/manager/src/metrics/mod.rs register histograms for setup sub-steps.
• Added timers and detailed tracing logs in /packages/edge/infra/client/manager/src/actor/setup.rs for make_fs, download_image, and other setup functions.
• Enhanced logging in /packages/edge/infra/client/manager/src/utils/mod.rs for image download and prewarm operations.
• Integrated overall setup timing in /packages/edge/infra/client/manager/src/actor/mod.rs with metrics observations.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->

Changes