feat: add configurable minimum age for lost servers #2297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
c06f934
|
| Status: | 🚫 Build failed. |
This was referenced Apr 2, 2025
Member
Author
NathanFlurry
force-pushed
the
feat_add_configurable_minimum_age_for_lost_servers
branch
from
c06f934 to
2d58d35
Compare
NathanFlurry
force-pushed
the
04-02-fix_cluster_fix_nats_provisioned_in_wrong_subnet
branch
from
e16a32d to
7ba402b
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a configurable minimum age parameter for server pruning, propagating a new min_age field from the prune operation to the lost servers query.
• Updated /packages/core/services/cluster/src/ops/server/prune_with_filter.rs to add min_age in the Input struct and pass it to the lost_list operation.
• Modified /packages/core/services/cluster/src/ops/server/lost_list.rs to use the min_age for filtering servers by creation timestamp, defaulting to 720 minutes if unset.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the branch
04-02-fix_cluster_fix_nats_provisioned_in_wrong_subnet
graphite-app
bot
deleted the
feat_add_configurable_minimum_age_for_lost_servers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes