perf(pegboard): increase page size for passing data from downlaod to lz4 #2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-hub with
|
| Latest commit: |
6685e2d
|
| Status: | 🚫 Build failed. |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 1, 2025
Deploying rivet with
|
| Latest commit: |
6685e2d
|
| Status: | 🚫 Build failed. |
NathanFlurry
force-pushed
the
03-31-perf_pegboard_increase_page_size_for_passing_data_from_downlaod_to_lz4
branch
from
a2bf5a8 to
79ca91f
Compare
NathanFlurry
force-pushed
the
03-31-perf_pegboard_parallelize_download_image_setup_cni_network
branch
from
402aa66 to
317678e
Compare
This was referenced Apr 1, 2025
NathanFlurry
force-pushed
the
03-31-perf_pegboard_parallelize_download_image_setup_cni_network
branch
from
317678e to
b17fc4e
Compare
NathanFlurry
force-pushed
the
03-31-perf_pegboard_increase_page_size_for_passing_data_from_downlaod_to_lz4
branch
from
79ca91f to
6685e2d
Compare
NathanFlurry
force-pushed
the
03-31-perf_pegboard_parallelize_download_image_setup_cni_network
branch
from
b17fc4e to
317678e
Compare
NathanFlurry
force-pushed
the
03-31-perf_pegboard_increase_page_size_for_passing_data_from_downlaod_to_lz4
branch
from
6685e2d to
79ca91f
Compare
Contributor
Merge activity
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The changes improve performance by increasing the read buffer size in the lz4 decompression process within setup.rs.
- Increased buffer size from 8192 to 65536 bytes in file /packages/edge/infra/client/manager/src/actor/setup.rs.
- Reduces system calls during decompression, enhancing performance.
- Maintains robust error handling for both lz4 and tar commands.
- The 64KiB allocation is well justified without raising memory concerns.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…lz4 (#2288) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the branch
03-31-perf_pegboard_parallelize_download_image_setup_cni_network
graphite-app
bot
deleted the
03-31-perf_pegboard_increase_page_size_for_passing_data_from_downlaod_to_lz4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes