Merged
Conversation
- refactor(core): migrate to typescript - refactor(core-api): migrate to typescript - refactor(core-blockchain): migrate to typescript - refactor(core-config): migrate to typescript - refactor(core-container): migrate to typescript - refactor(core-database): migrate to typescript - refactor(core-database-postgres): migrate to typescript - refactor(core-debugger-cli): migrate to typescript - refactor(core-deployer): migrate to typescript - refactor(core-elasticsearch): migrate to typescript - refactor(core-error-tracker-bugsnag): migrate to typescript - refactor(core-error-tracker-sentry): migrate to typescript - refactor(core-event-emitter): migrate to typescript - refactor(core-forger): migrate to typescript - refactor(core-graphql): migrate to typescript - refactor(core-http-utils): migrate to typescript - refactor(core-json-rpc): migrate to typescript - refactor(core-logger): migrate to typescript - refactor(core-logger-winston): migrate to typescript - refactor(core-p2p): migrate to typescript - refactor(core-snapshots): migrate to typescript - refactor(core-snapshots-cli): migrate to typescript - refactor(core-test-utils): migrate to typescript - refactor(core-tester-cli): migrate to typescript - refactor(core-transaction-pool): migrate to typescript - refactor(core-utils): migrate to typescript - refactor(core-vote-report): migrate to typescript - refactor(core-webhooks): migrate to typescript - refactor(crypto): migrate to typescript - refactor(core-transaction-pool): merge core-transaction-pool-mem - fix(core-container): only resolve options for plugins that are registered - refactor(core-p2p): merge the peers.json configuration into the defaults - test(crypto): add delegate model constructor tests - test(crypto): add delegate model passphrase encryption and decryption tests - feat(core): add --launch-mode flag for seeds - test: resolve some issues with beforeEach/afterEach data resets - chore: change how tests are ran on CircleCI to avoid misconfigurations - chore: setup node 11 for CircleCI
Currently we would leave in the list all peers that: "are not me or have invalid port or have invalid version" the intention must have been: "are not me and have valid port and have valid version".
* perf(core-api): use a faster alternative to derive an estimate When we use OFFSET and LIMIT in SQL we want to assess the total number of rows that would have been returned if OFFSET and LIMIT were omitted. Instead of doing a separate query with COUNT(*), parse the output of EXPLAIN SELECT ... and fetch the number of rows from there.
* fix(core-database): delegate ordering * tests(core-database): change tests to include orderBy param * tests(core-api): change tests to include orderBy param
* fix: prevent the list of peers to go become too short
* Reschedule a call to updateNetworkStatusIfNotEnoughPeers() at the end
of updateNetworkStatus(), even if successful.
* Add peers from config.peers.list if the list is too short
* Remove loop by recursion in updateNetworkStatus()
* Remove loop by recursion in discoverPeers() and cycle through the
peers in deterministic fashion after shuffling them. The previous
implementation would pick one random peer and if unsuccessful, then
pick random peer and retry, but this way we could end up retrying with
the same peer over and over again. For example if 70% of the peers
result in failure and 30% not, we could loop a lot of times over the
bad portion of the peers.
* Replay 575ba010 and 776e06ff
575ba010 fix: use __filterPeers to populate seed peers
776e06ff refactor: rename to populateSeedPeers
* fix(test): the return value from monitor.getPeers() is an array
* fix(test): properly handle the return value of getPeers()
…check (#1738) * refactor(core-p2p): replace the network update timeout with a period check * refactor(core-p2p): only sett the last network timeout if it is not set or expired * chore(core-p2p): remove pTimeout dependency * refactor: change name and make sure the next network update is scheduled
* chore(package): update @babel/core to version 7.2.2 * chore(package): update @babel/preset-env to version 7.2.0 * chore(package): update lockfile yarn.lock * chore: update yarn.lock
…ocess queue on fork (#1732) * refactor: remove misleading log output * refactor: move block exception check * fix: reset queue at the beginning of fork recovery * refactor: drop process queue after disregarding unchained block * fix: update blocks from current round after recovery * fix: check if received block contains forged transactions * refactor: only fork when downloaded block cannot be chained with last accepted block * refactor: only check forged transactions if it is a chained block * test: fix * fix(core-p2p): call updateNetworkStatusIfNotEnoughPeers in the correct context (#1737) * refactor(core-p2p): replace the network update timeout with a period check (#1738) * refactor(core-p2p): replace the network update timeout with a period check * refactor(core-p2p): only sett the last network timeout if it is not set or expired * chore(core-p2p): remove pTimeout dependency * refactor: change name and make sure the next network update is scheduled * chore(package): update better-sqlite3 to version 5.2.0 (#1739) * test(core-utils): increase coverage (#1742) * test(core-debugger-cli): increase coverage (#1743) * chore: update @babel/core and @babel/preset-env (#1740) * chore(package): update @babel/core to version 7.2.2 * chore(package): update @babel/preset-env to version 7.2.0 * chore(package): update lockfile yarn.lock * chore: update yarn.lock * test(crypto): increase identity coverage (#1744) * test(crypto): increase handler coverage (#1745) * test(crypto): increase handler coverage (#1746) * test(crypto): increase multi signature/payment coverage (#1747) * docs: changelog and readme formatting (#1824) * refactor: rename resetQueue * fix: only care about missing blocks when process queue is empty * refactor: reword log message * refactor: move fork into function * fix: accept internal blocks even if in fork state * fix: dont show peer tracker after init * refactor: remove useless forked flag
|
@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #2077 +/- ##
===========================================
+ Coverage 56.54% 78.54% +21.99%
===========================================
Files 444 331 -113
Lines 7987 7740 -247
Branches 1031 1091 +60
===========================================
+ Hits 4516 6079 +1563
+ Misses 3023 1630 -1393
+ Partials 448 31 -417
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
spkjp
previously approved these changes
Feb 11, 2019
spkjp
approved these changes
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
developintomasterfor the2.1.0milestone.