[PM-1568] Support Mulch browser for autofill by fd1f · Pull Request #2427 · bitwarden/android

fd1f · 2023-03-23T06:34:31Z

Type of change

Objective

This PR adds the Mulch to the autofill whitelist.

Code changes

src/Android/Accessibility/AccessibilityHelpers.cs
src/Android/Autofill/AutofillHelpers.cs
src/Android/Resources/xml/autofillservice.xml

All to add Mulch support.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…improved the code so there are fewer direct access from the VM to the View (bitwarden#1879)

…ks (bitwarden#1917)

… service name hardcoded to register/resolve a service (bitwarden#1865)

…Also improved a bit the code of copying commands (bitwarden#1974)

…king link (bitwarden#1978)

We only need master password hash because this is currently only used for sso password setting after auto-provisioning. Key Connector is not involved in these accounts

…1976) * Added to AppResources.resx the message warning the user about setting the lockout option to "Never" * Added the condition to check the newly selected option on the vault timeout settings * Changed the wording on the warning as to reflect the mobile version * Changed the vault timeout modal to have the ability to cancel * Simplified the reversion of value if the user cancels the change

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…gOverlayHelper and also added more logging to see when it happens. (bitwarden#1983)

…itwarden#1982)

* feat: update auto totp copy setting * feat: update show icons settings * feat: update auto add settings * feat: update settings and options to sentence case * feat: update translation keys With the latest changes the translation keys had diverged from their contents. This commit fixes that. * fix: revert AndroidManifest changes * chore: add todo comments to fix negative functions

Closes bitwarden/mobile#1985

* PS-920 - Added feedback to user when saving bad formed URLs * Added feedback to user when trying to perform login with bad formed URL * PS-920 - Refactor to use AsyncCommand *(missing file from previous commit) * PS-920 - Fixed whitespace formatting * PS-920 - Removed unused method * PS-920 - Fixed validation * Added comment for hard coded string * PS-920 - Removed unused properties * Fixed url validations * Refactored method to local function * PS-920 - Added exception handling and logging * Added generic error message string to AppResources

…#1971) * EC-259 Added Account switching on share extension on iOS, also improved performance for this and exception handling * EC-259 code formatting * EC-259 Added account switching to Share extension Send view * EC-259 Fixed navigation on share extension when a forms page is already presented * EC-259 Fix send text UI update when going from the iOS extension * EC-259 Improved DateTimeViewModel with helper property to easily setup date and time at the same time and applied on usage

Added Opera GX Support for autofill

…itwarden#1990)

…1993) * EC-324 Added more logging for trying to get more information on list out of range crash on AppCenter * EC-324 Fix include on iOS.Core.csproj on iOS CollectionView files

…d Autofill on iOS given that the string was the same as Autofill Services and the comparison was misleading. Also refactored so that the action is on each item instead of having to compare to act (bitwarden#1989)

…ll (bitwarden#1988)

…n#1914) * settings option to allow screen capture on Android * Improved code on Screen Capture and added prompt to the user to allow screen capture * EC-325 Removed async on OnCreate of MainActivity given that's not necessary anymore Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>

* [SG-467] Fixed url validation so it works with or without http or https * [SG-467] Validation has been refactored for simplicity.

…den#2000) * PS-1080 Added new accessibility text property to the custom field bool icon * PS-1080 Added BoolValue property to the FieldView and added new AccessibilityProperty to bool icon

* [EC-1045] lock action if policy and show message * [EC-1045] add text for policy message * [EC-1045] add consts to policy service * [EC-1045] missed a const * [AC-1045] fix build

bitwarden#2414) This reverts commit dcb5854.

…om API (bitwarden#2390) * [PM-1078] Fingerprint phrase gets calculated from pub key on AuthService instead of coming as a property from the api.

…warden#2417) * [PM-1431] Do not clear Master password if login is ongoing.

Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>

* [PM-1497] Ignore know device api error.

Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>

CLAassistant · 2023-03-23T06:34:37Z

All committers have signed the CLA.

bitwarden-bot · 2023-03-23T06:34:52Z

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-1568

jcrabapple · 2023-04-14T13:52:24Z

Someone please approve this I have been waiting for Bitwarden to work with Mulch! Thank you!

bepoli · 2023-08-29T16:41:30Z

Is this ever going to be merged?
Maybe we need to add some context, since devs may not be aware of Mulch:
Mulch browser is a chromium-based browser developed and maintained by the Divest Computing Group (the same devs of Mull browser, aka us.spotco.fennec_dos, currently supported by Bitwarden).
It is relevant since many users moved from Bromite (a browser currently supported by Bitwarden) to Mulch when the former stopped receiving security updates.

unoukujou · 2023-09-07T09:53:48Z

Somebody please add this. Thanks.

streetsamurai00mi · 2023-09-23T10:27:07Z

waiting for this to be merged

dbosompem · 2023-10-25T09:39:03Z

Hi All, apologies for the long review time. This has been approved by Product Management, and so Engineering will pick this up and assist till it's merged. Thank you for the patience!

D3SOX · 2023-11-22T08:14:22Z

Hate to be that kind of guy but are there any updates on this? Merging this 5 line PR would save me and other Mulch users hours of time. I'm thinking about compiling it myself now, but is it even possible on Linux?
Edit: Used a KVM/QEMU Windows VM, checked out the latest release, cherry-picked the commit and after a lot of fighting with Microsoft products it works!

github-actions bot and others added 30 commits June 29, 2022 09:11

Bumped version to 2022.6.0 (bitwarden#1968)

d9a8182

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Bumped version to 2022.6.1 (bitwarden#1969)

a6ddc24

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Fix crash when trying to Focus an Entry from a background thread and …

dbc1e5e

…improved the code so there are fewer direct access from the VM to the View (bitwarden#1879)

Improved BroadcastService and added try...catch on async void callbac…

448cce3

…ks (bitwarden#1917)

Improved the ServiceContainer to be easier to use and not to have the…

e2502e2

… service name hardcoded to register/resolve a service (bitwarden#1865)

EC-297 Fix possible crash when copying password on cipher item view. …

d246d1d

…Also improved a bit the code of copying commands (bitwarden#1974)

Fix formatting (bitwarden#1975)

547e61a

replace link to mobile section of contributing documentation with wor…

6c7413e

…king link (bitwarden#1978)

Add user verification to reset password request (bitwarden#1980)

58a3662

We only need master password hash because this is currently only used for sso password setting after auto-provisioning. Key Connector is not involved in these accounts

Bumped version to 2022.6.2 (bitwarden#1981)

7802da2

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

EC-308 Fix crash produced by creating avatar image on AccountSwitchin…

846d3a8

…gOverlayHelper and also added more logging to see when it happens. (bitwarden#1983)

Updated the wording on the modal warning when deleting the account (b…

cceded2

…itwarden#1982)

Use correct icon for checked/unchecked boolean (bitwarden#1986)

75e8276

Closes bitwarden/mobile#1985

Add support for iodé Browser (bitwarden#1886)

f2ba86a

Opera GX Autofill Support (bitwarden#1855)

70cf743

Added Opera GX Support for autofill

EC-323 sanitize data on get first letters for avatar image creation (b…

8f3a4b9

…itwarden#1990)

[EC-324] Added more logging for information on list crash (bitwarden#…

1f2fb3f

…1993) * EC-324 Added more logging for trying to get more information on list out of range crash on AppCenter * EC-324 Fix include on iOS.Core.csproj on iOS CollectionView files

EC-312 Fix crash on entering invalid credentials five times on Autofi…

d2fbf5b

…ll (bitwarden#1988)

Add version change check in the version bump workflow (bitwarden#1992)

c07c305

Add publish options to release workflow (bitwarden#1994)

cb0c52f

EC-325 fix format (bitwarden#1995)

5e61fb0

Update 'Dry Run' path in Release workflow (bitwarden#1997)

c2fcc0a

[SG-467] Fix environment url validations (bitwarden#1999)

f809170

* [SG-467] Fixed url validation so it works with or without http or https * [SG-467] Validation has been refactored for simplicity.

[PS-1080] Added text alternative to Boolean custom field icon (bitwar…

263aeef

…den#2000) * PS-1080 Added new accessibility text property to the custom field bool icon * PS-1080 Added BoolValue property to the FieldView and added new AccessibilityProperty to bool icon

jlf0dev and others added 7 commits March 10, 2023 12:55

[EC-1045] add vault timeout action to policy (bitwarden#2372)

dcb5854

* [EC-1045] lock action if policy and show message * [EC-1045] add text for policy message * [EC-1045] add consts to policy service * [EC-1045] missed a const * [AC-1045] fix build

Revert "[EC-1045] add vault timeout action to policy (bitwarden#2372)" (

839aa91

bitwarden#2414) This reverts commit dcb5854.

[PM-1078] Login with Device - Change mobile to not get fingerprint fr…

ccd7120

…om API (bitwarden#2390) * [PM-1078] Fingerprint phrase gets calculated from pub key on AuthService instead of coming as a property from the api.

[PM-1431] [Defect] [Android] New accounts are not able to log in (bit…

151ecf8

…warden#2417) * [PM-1431] Do not clear Master password if login is ongoing.

Autosync the updated translations (bitwarden#2419)

606b001

Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>

[PM-1497] Known device api error (bitwarden#2418)

a6bb089

* [PM-1497] Ignore know device api error.

Bumped version to 2023.3.0 (bitwarden#2423)

c6bdb67

Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>

bitwarden-bot changed the title ~~Support Mulch browser for autofill~~ [PM-1568] Support Mulch browser for autofill Mar 23, 2023

bitwarden-bot added the community-pr label Mar 23, 2023

fd1f force-pushed the master branch 3 times, most recently from b69c5d3 to a3f9c24 Compare March 23, 2023 06:52

add mulch to the whitelist

fa0d018

fd1f force-pushed the master branch from a3f9c24 to fa0d018 Compare March 23, 2023 06:54

SkewedZeppelin mentioned this pull request Jun 1, 2023

Autofill with Bitwarden Divested-Mobile/Mulch#7

Open

unoukujou mentioned this pull request Sep 25, 2023

[PM-3152] Add autofill support for cromite #2640

Merged

5 tasks

yoshiz44 approved these changes Oct 25, 2023

View reviewed changes

D3SOX approved these changes Oct 30, 2023

View reviewed changes

vvolkgang closed this Jun 20, 2024

vvolkgang force-pushed the main branch from ad6ffad to 959a60c Compare June 20, 2024 15:45

SkewedZeppelin mentioned this pull request Sep 26, 2024

Cannot use/create passkeys with Mull #3949

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-1568] Support Mulch browser for autofill#2427

[PM-1568] Support Mulch browser for autofill#2427
fd1f wants to merge 3578 commits intobitwarden:mainfrom
fd1f:master

fd1f commented Mar 23, 2023 •

edited

Loading

Uh oh!

CLAassistant commented Mar 23, 2023 •

edited

Loading

Uh oh!

bitwarden-bot commented Mar 23, 2023

Uh oh!

jcrabapple commented Apr 14, 2023

Uh oh!

bepoli commented Aug 29, 2023

Uh oh!

unoukujou commented Sep 7, 2023

Uh oh!

streetsamurai00mi commented Sep 23, 2023

Uh oh!

dbosompem commented Oct 25, 2023

Uh oh!

D3SOX commented Nov 22, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

fd1f commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Objective

Code changes

Uh oh!

CLAassistant commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bitwarden-bot commented Mar 23, 2023

Uh oh!

jcrabapple commented Apr 14, 2023

Uh oh!

bepoli commented Aug 29, 2023

Uh oh!

unoukujou commented Sep 7, 2023

Uh oh!

streetsamurai00mi commented Sep 23, 2023

Uh oh!

dbosompem commented Oct 25, 2023

Uh oh!

D3SOX commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

fd1f commented Mar 23, 2023 •

edited

Loading

CLAassistant commented Mar 23, 2023 •

edited

Loading

D3SOX commented Nov 22, 2023 •

edited

Loading