Dev meeting 2017 07 25

Agenda

• 3.3.0 stable release on Thursday (@GawainLynch)
  • Current holdup: The Doctrine DBAL 2.6 kerfuffle.
• Reminder: Bob will be AFK from aug 2 - aug 20. (@Bob)
• Reminder: We've dropped release/ from all the version branches. Might need to update your local environments. (@Bob)

e.g.

• Status on drop bear invasion (@YourGitHubID)

Actionable Items

Outcomes

Log

gawainlynch [7:29 PM] 
ping @bob @carson @ross @sahassar @world+dog


sahassar [7:29 PM] 
pong


bob [7:29 PM] 
Pong


gawainlynch [7:30 PM] 
I'm guessing Ross is in DBAL land :wink:


carson [7:30 PM] 
Here


bob 
[7:30 PM] 
DBALa-La-Land


gawainlynch [7:30 PM] 
^this


ross [7:31 PM] 
hello


gawainlynch [7:31 PM] 
OK … really easy one first


[7:31] 
- Reminder: Bob will be AFK from aug 2 - aug 20


[7:31] 
You're all stuck with me!


bob 
[7:31 PM] 
Yes, Indeed I am off! Going to Iceland for 2.5 weeks!


carson [7:31 PM] 
Nice!


bob 
[7:32 PM] 
I'll be present for next week's meeting, and leave the next morning.


[7:32] 
Follow me on Instragram to see if i'm still alive, or eaten by a whale or a glacier.


gawainlynch [7:32 PM] 
It'll be a whale of a time, I'm sure :wink:


[7:33] 
Next easy one, also thanks to Bob:
- Reminder: We've dropped `release/` from all the version branches. Might need to update your local environments.


[7:33] 
… and oh my how nice is it!

bob 
[7:33 PM] 
For me it went smoothly.. `git fetch origin`, all good.

gawainlynch [7:34 PM] 
Yeah, if anyone is stuck (I doubt it) … #git

boltissueball [7:34 PM] 
says you have three choices: 1. man git, 2. nicely ask gawainlynch, or 3. do it the xkcd way: https://xkcd.com/1597/

gawainlynch [7:34 PM] 
Other one is:
- 3.3.0 stable release on Thursday
- Current holdup: The Doctrine DBAL 2.6 kerfuffle .

[7:34] 
OK … so this is kind of a hard call

[7:35] 
I pushed back for Thursday and TBH am happy now to go forward

[7:35] 
What are the collective feelings?

ross [7:35 PM] 
fine for me

bob 
[7:35 PM] 
I have one argument that's a mitigating factor.

gawainlynch [7:35 PM] 
…and can we not ad hom. Marco please

bob 
[7:35 PM] 
the packaged distribution files are packaged on PHP 5.5..

[7:36] 
This means that the "lower end of the spectrum", programmer-wise, is least affected.

ross [7:36 PM] 
I've got through about 20 upgrades so far with no major issues other than some incompatible extensions

bob 
[7:37 PM] 
because, using the disto, you will get DBAL 2.5.x, andyou're good.

ross [7:37 PM] 
and a reminder not to use `ignore-platform-reqs`

bob 
[7:37 PM] 
@ross That's in theblogpost, too: https://bolt.cm/item/fixing-issues-after-the-recent-doctrine-2-6-update
Bolt CMS
Fixing issues after the recent Doctrine 2.6 update | Bolt CMS
Since the beginning of this week, we've had a number of reports from Bolt developers who were getting the following errors after running a Composer …

gawainlynch [7:37 PM] 
Yeah, both of us struck down today by that one, Ross :slightly_smiling_face:

carson [7:37 PM] 
Yall set the php version in “config” key of composer.json right?

bob 
[7:37 PM] 
Oh, wait.. That `ignore-platform-reqs` got lost in editing..

gawainlynch [7:38 PM] 
@carson yeah, and even put it up on the bolt.cm site and docs.bolt.cm (edited)

bob 
[7:38 PM] 
Note to self: Edit that back in after meeting

gawainlynch [7:39 PM] 
https://docs.bolt.cm/3.2/installation/composer-create-project/creating-a-new-project#deploying-to-different-php-versions

[7:39] 
https://bolt.cm/item/fixing-issues-after-the-recent-doctrine-2-6-update

bob 
[7:40 PM] 
@gawainlynch The blogpost is missing the bit about --ignore-platform-reqs

gawainlynch [7:40 PM] 
@bob: I got that, just linking for those that might not have seen (the pages/updates) (edited)

bob 
[7:40 PM] 
Ah, good..  On my list to add back after the meeting

gawainlynch [7:41 PM] 
OK, I'll hang around :slightly_smiling_face:

bob 
[7:41 PM] 
Othet than that, it's mainly #6856, right? (edited)

boltissueball [7:41 PM] 
#6856 [open] DBAL 2.6 Problems https://github.com/bolt/bolt/issues/6856

gawainlynch [7:41 PM] 
Right so … failing blockers that come up, I am hearing from everyone except @sahassar & @carson that we're good with Thursday (edited)

[7:42] 
So speak now or forever hold the release button

bob 
[7:42 PM] 
I'm good to go! Let's get this sucker out there!

gawainlynch [7:42 PM] 
Yeah, 6856 I can fix … I built the needed parts into the schema manager

bob 
[7:43 PM] 
Awesomeballs

gawainlynch [7:43 PM] 
I have just spent since 4 am this morning doing triage so haven't got to it yet

bob 
[7:43 PM] 
No rush, it's good to know you have it under control

gawainlynch [7:43 PM] 
Plus my thought was that people are likely to search the tracker, so an open/closed issue gives them something to find

[7:44] 
Once I knew it wasn't a 3.3 issue, I was happy to not make it a blocker

[7:44] 
OK … well does anyone have anything to table?

bob 
[7:45 PM] 
I'm good for now..

gawainlynch [7:45 PM] 
Oh! https://github.com/bolt/common/pull/7

bob 
[7:45 PM] 
Just want to mention i'm happy we're getting 3.3 over the line!

gawainlynch [7:45 PM] 
I'm good with that either way … and Carson would you like to step up with some details on where all this is going?

[7:46] 
…or I can :wink:

bob 
[7:46 PM] 
pokes @carson with a stick

bob 
[7:46 PM] 
:dusty_stick:

carson [7:46 PM] 
Ummm

[7:47] 
Yeah I can change the class name to `Serialization` if that’s what is wanted

gawainlynch [7:47 PM] 
While Carson is typing … one thing I'd like to ask as a favour … can we refocus on tests with our PRs … I know it is hard and not fun, and yeah … but we're dropping rapidly in coverage at the moment

[7:48] 
@carson: No huge preference … Just a suggestion based on requested feedback (edited)

[7:49] 
The missing (I can't remember if I bought this up) piece of the puzzle on what is going on is splitting some small parts out of core that are genuinely both stand-alone and well tested … and reusable

bob 
[7:50 PM] 
We’ve briefly touched on that last week, I think.

gawainlynch [7:50 PM] 
OK … a bit lost on what I did/didn't bring up

bob 
[7:50 PM] 
Or perhaps that was just me, i’m not certain

[7:50] 
Regardless: Yay!

gawainlynch [7:51 PM] 
Yeah, I just don't want people to think the two of us are submarining stuff … we're just collaborating to get things to a presentable state first

[7:51] 
… and there is a bit more to come

[7:51] 
But please feel free to speak up … it isn't a private cabal … just a coordinated effort to get some stuff moving

carson [7:52 PM] 
^

bob 
[7:52 PM] 
I'm good with it.. The only thing i am  a _tiny_ bit worried about is that it'll remain clear to users..

carson [7:53 PM] 
Well it’s not really for users

[7:53] 
It’s for us and developers

[7:54] 
Users shouldn’t notice any difference

gawainlynch [7:54 PM] 
Yeah, but e.g. "DBAL"

[7:54] 
Oh, come on Slack!

[7:54] 
Anyway … that message will appear when it does

bob 
[7:54 PM] 
euhm, connection lost..

[7:54] 
is this skype?

gawainlynch [7:54 PM] 
Nope … ssh and everything else was up :confused:

bob 
[7:55 PM] 
Let me show an example of how _not_ to do it..


[7:55] 
Let's say you want to check out Flarum. You go here:


gawainlynch [7:55 PM] 
^ what Carson said


bob 
[7:55 PM] 
https://github.com/flarum


[7:55] 
Would you need `core` or `flarum`? Nobody knows!


gawainlynch [7:55 PM] 
OK the order of comments is getting hilarious


bob 
[7:55 PM] 
But, as long as we keep it clear, and we have a good build process, i'm all fine with it.


carson [7:56 PM] 
Yeah I see what you mean Bob


gawainlynch [7:56 PM] 
Yeah, it is core-core stuff … more or less like thubs & filesystem … and we can & will still document important/relevant parts on docs.bolt.cm


carson [7:56 PM] 
I think we can keep it clear


gawainlynch [7:57 PM] 
That is good with me … anyone want the honours?


bob 
[7:57 PM] 
i'll take it!


[7:57] 
#meeting