Epic: Address Book v2 by katspaugh · Pull Request #2280 · 5afe/safe-react

katspaugh · 2021-05-10T15:47:09Z

An epic PR to track the progress of the Address Book v2 implementation.

The QA will happen on this branch too.

⚠️ Please DO NOT update this branch from development via GitHub ⚠️

What to test

Create safe – safe name is stored in the address book
Load safe - safe name is stored in the address book
Add an owner - check name in address book
Replace an owner - check name in address book
Edit safe name in settings
Edit owner name in settings
Directly create an address book entry
Directly edit an address book entry
Check that address book name is shown on transaction details
Name stored in address book it's used over known address name from client-gateway
Deleting a safe using settings button don't delete the address from the address book
Name shown in assets "send" is updated
Name shown in assets "receive" is updated
Name shown in transaction details for owners is correct
Name shown in address book "send" is correct
Names shown in settings > spending limits are correct

* Add import/export buttons to addressBook * Change textSize to icons

github-actions · 2021-05-10T15:47:24Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2021-05-10T15:53:21Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	3	0
Ignored	0	N/A

Result: ✅ success
Annotations: 3 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/routes/load/components/DetailsForm/index.tsx Line 49 - Argument 'values' should be typed.
src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Line 45 - Missing return type on function.
src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Line 45 - Object pattern argument should be typed.

^{Report generated by eslint-plus-action}

github-actions · 2021-05-10T15:58:24Z

Safe Multisig app rinkeby

github-actions · 2021-05-10T15:59:39Z

Safe Multisig app mainnet

* Add export feature * Improve Address book export modal * Use styled-components instead of material-ui styles * Add comment * Improve filename + set loading state false when error

* Remove UNKNOWN from owner list * Fetch Safe Name from address book * Update Safe name in address book when updating from settings > safe details * Fix lint issue

* Added import modal and import functionality * Added modal refactor * Added entry validations * Added message after loading file * Reset values on modal close * Minor formal changes * Entry list validations on separate functions * Minor changes * Text corrections * Check if isAddress instead of checksum * add styles on import * fix sidebar label for ADDRESS BOOK (with a space) * fix modal title in lowecase * replace icons on AB list * Clear upload feedback on modal close * add styles to drag and drop area * add link to Help Center article * remove unused styles * change color when is an error * change error color * fix error color and align file size * Modal refactor * fix button styles on modal * fix long file names Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>

* WIP: add `chainId` with default value to `AddressBookEntry` * WIP: first approach to the new AB structure and data persistence in localStorage * migrate AB * migrate AB actions * migrate AB reducers * update AB selectors * update AB middlewares * update AB utils * update AB model file * migrate AB usage to the new structure * change AB notification key name * fixes after rebase * add `addressBookBatchLoad` action * create a selector for owners with AB data `safeOwnersWithAddressBookDataSelector` * migrate safe->owners structure * make `name` and `address` mandatory for `makeAddressBookEntry` * filter out invalid AB names before storing them * review Load & Open flow for owner's names * update owners' reducers and actions - `editSafeOwner` no longer necessary as there's no name change in the owners' list * create AB map-like selector chainId -> address -> name * auto-complete owner's name if it exist in the AB * update replace owner modal and remove REPLACE_SAFE_OWNER - no longer optimistically update the owner's list if threshold === 1, as it behaves erratically with the constant update from data provided by the services - `REPLACE_SAFE_OWNER` no longer necessary * update remove owner modal and remove REMOVE_SAFE_OWNER - no longer optimistically update the owner's list if threshold === 1, as it behaves erratically with the constant update from data provided by the services - `REMOVE_SAFE_OWNER` no longer necessary * update add owner modal and remove ADD_SAFE_OWNER - no longer optimistically update the owner's list if tx is signed, as it behaves erratically with the constant update from data provided by the services - `ADD_SAFE_OWNER` no longer necessary * update yarn.lock after rebase * fix AddressBookMap type * create a migration function for safe's names * create selectors that require safe's name * remove `name` from the safe model and update related code * JSON.parse if JSON.parsed string returned a string instead of a JSON * remove commented lines * rename BATCH_LOAD to SAFE_LOAD * refactor AddressBookMap to `chainId`->`address`->`AddressBookEntry` * make `chainId` optional for `getNameFromAddressBookSelector` * use `addressBookMapSelector` for a more direct AddressBook entry name lookup * remove `loadedSafeViaUrl` flag, and rely on address book entry instead * replace `addAddressBookEntry` action with `addressBookAddOrUpdate`

…tion

* add back `loadedViaUrl` flag * implicitly set `loadedViaUrl` to `false` when adding a safe via form or setting its name from Settings * exclude safes whose `loadedViaUrl` flag is `true` * hide "Remove Safe" button for safes `loadedViaUrl` * add `loadedViaUrl` flag to mocked safe

github-actions · 2021-05-27T07:41:45Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	8	0
Ignored	9	N/A

Result: ✅ success
Annotations: 8 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/logic/addressBook/store/middleware/index.ts Line 8 - Argument 'store' should be typed.
src/logic/addressBook/store/middleware/index.ts Line 8 - Argument 'next' should be typed.
src/logic/addressBook/store/middleware/index.ts Line 8 - Missing return type on function.
src/logic/addressBook/store/middleware/index.ts Line 8 - Argument 'action' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 49 - Argument 'values' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 124 - Object pattern argument should be typed.
src/routes/open/components/SafeNameForm/index.tsx Line 81 - Argument 'controls' should be typed.
src/routes/open/components/SafeNameForm/index.tsx Line 81 - Object pattern argument should be typed.

^{Report generated by eslint-plus-action}

* Refactor AB migration * Fix AB v2 and safes migration * Don't migrate if already migrated * Restore removeFromStorage

* Add loading state when click on download button * Expand clickable area for link

* Use ADDRESS_BOOK_DEFAULT_NAME instead of hard coded string * Use address book name in Send Collectible review step * Show name if known in contract interaction review * Use string comparison util

Co-authored-by: katspaugh <katspaugh@users.noreply.github.com>

tschubotz · 2021-06-02T10:16:35Z

This link exists on both the export and import modals.

I created a brief help center article. Could this be linked there please? https://help.gnosis-safe.io/en/articles/5299068-address-book-export-and-import

Also, how about re-wording this to Learn about address book import and export? Would be less text.

liliya-soroka · 2021-06-02T10:31:12Z

Isssues related to addressbook
#2378
#2381 - closed as duplication
#2383
#2384
#2385
#2386 - May be critical for the addressbook release

katspaugh · 2021-06-02T10:36:20Z

Thanks @tschubotz, I'm on it.
Edit: fixed in #2380.

liliya-soroka · 2021-06-02T12:59:35Z

@katspaugh , will "Ability to check/uncheck imported addresses in case of a conflict with existing addresses" be implemented in the next addressbook version ? Do we need a ticket for it ?

katspaugh · 2021-06-02T13:54:04Z

@liliya-soroka we decided to skip it completely.

…safe (#2374) * avoid deleting addressBook entry when deleting a safe * avoid deleting addressBook entry when deleting a safe

* Verify chainId column and called import reducer * Added dispatch for addressbook import * Fixed store reducer and notification * Validate all entries on csv data validation * Using utils to verify imported addresses * Add props typing to ImportEntriesModal * Convert chainId to number

…ss-book-v2

* Allow to load new safe with empty owner names * Avoid adding owners to addressbook if name is empty * Remove unnecessary initialization

francovenica · 2021-06-03T13:32:47Z

Here's an old issue that could be related to the AB: #2323

* keep safes with no name for the list of safes * prevent storing only those safes whose `loadedViaUrl` flag is true * update AB before Safe store * default safe name to empty string if it is not available

francovenica · 2021-06-03T20:19:13Z

Still some issues with the sorting. check if it is something we can fix [Addressbook]Default sorting in the addressbook table #2378
The text in the import form is not the same as the image we show in the help section. Can we reconciliate that? AB - Import csv text - The text is different from the one we present in the help section #2395
Issue Name is lost on review page for Contract interaction when "Use custom data (hex encoded)" was used #2384 has not been fixed yet. If is not critical or won't be fixed please comment on it

francovenica · 2021-06-06T22:18:01Z

Didn't find anything that may stop the deployment. We will see how it goes in stg on Monday

[Address Book] - Add Import/Export Buttons (#2278)

5ee9ef7

* Add import/export buttons to addressBook * Change textSize to icons

katspaugh added the Epic label May 10, 2021

katspaugh added this to the Address Book v2 milestone May 10, 2021

matextrem and others added 2 commits May 17, 2021 16:55

[Address Book V2] - Export address book (#2284)

839c947

* Add export feature * Improve Address book export modal * Use styled-components instead of material-ui styles * Add comment * Improve filename + set loading state false when error

[Address book v2] Address book update events (#2293)

7b00ee1

* Remove UNKNOWN from owner list * Fetch Safe Name from address book * Update Safe name in address book when updating from settings > safe details * Fix lint issue

dasanra mentioned this pull request May 18, 2021

UNKNOW is used as owners name if the owners were not renamed during importing safe #2252

Closed

Daniel Sanchez and others added 2 commits May 18, 2021 17:56

Merge branch 'development' into address-book-v2

b59dd8a

katspaugh added the epic-address-book label May 25, 2021

katspaugh modified the milestones: Address Book v2, 3.7.0 May 25, 2021

fernandomg added 4 commits May 26, 2021 17:25

Merge branch 'development' into chore/address-book-v2-conflict-resolu…

dd3d09e

…tion

fix runtime issue with addressBookName not being provided

51c05e9

katspaugh and others added 2 commits May 27, 2021 15:52

[Address Book v2] Fix AB v2 migration (#2345)

2308c1f

* Refactor AB migration * Fix AB v2 and safes migration * Don't migrate if already migrated * Restore removeFromStorage

Export - Add loading state when click on download button (#2325)

0d915a6

* Add loading state when click on download button * Expand clickable area for link

katspaugh mentioned this pull request May 27, 2021

[Address Book v2] Make the address book global #2182

Closed

Daniel Sanchez and others added 3 commits June 1, 2021 12:17

[Address Book v2] 1603 Use addressbook over known addresses (#2352)

e58b6d6

* Use ADDRESS_BOOK_DEFAULT_NAME instead of hard coded string * Use address book name in Send Collectible review step * Show name if known in contract interaction review * Use string comparison util

[AddressBook v2] - Avoid using checksumAddress inside reducer (#2355)

fc0c450

[Address Book v2] - Prevent name validation in AB reducer (#2356)

94bee4f

Co-authored-by: katspaugh <katspaugh@users.noreply.github.com>

katspaugh mentioned this pull request Jun 2, 2021

Use the same link in the import and export modals #2380

Merged

Use the same link in the import and export modals (#2380)

9242d80

fernandomg and others added 4 commits June 2, 2021 15:55

[Address Book v2] - Avoid deleting addressBook entry when deleting a …

5bc38ff

…safe (#2374) * avoid deleting addressBook entry when deleting a safe * avoid deleting addressBook entry when deleting a safe

Merge branch 'development' of github.com:gnosis/safe-react into addre…

548d6d2

…ss-book-v2

[Address Book v2] Allow empty owner names when loading a safe (#2390)

e66040d

* Allow to load new safe with empty owner names * Avoid adding owners to addressbook if name is empty * Remove unnecessary initialization

fernandomg and others added 2 commits June 3, 2021 16:49

keep safes with no name for the list of safes (#2387)

50a7a49

* keep safes with no name for the list of safes * prevent storing only those safes whose `loadedViaUrl` flag is true * update AB before Safe store * default safe name to empty string if it is not available

Set default order by name in address book (#2391)

2d532f3

tschubotz mentioned this pull request Jun 4, 2021

AB - Import csv text - The text is different from the one we present in the help section #2395

Closed

katspaugh mentioned this pull request Jun 7, 2021

Release 3.7.0 #2400

Merged

katspaugh merged commit 2d532f3 into development Jun 7, 2021

github-actions Bot locked and limited conversation to collaborators Jun 7, 2021

Uh oh!

Conversation

katspaugh commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to test

Uh oh!

github-actions Bot commented May 10, 2021

Uh oh!

github-actions Bot commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

github-actions Bot commented May 10, 2021

Uh oh!

github-actions Bot commented May 10, 2021

Uh oh!

github-actions Bot commented May 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

tschubotz commented Jun 2, 2021

Uh oh!

liliya-soroka commented Jun 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

katspaugh commented Jun 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liliya-soroka commented Jun 2, 2021

Uh oh!

katspaugh commented Jun 2, 2021

Uh oh!

francovenica commented Jun 3, 2021

Uh oh!

francovenica commented Jun 3, 2021

Uh oh!

francovenica commented Jun 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

katspaugh commented May 10, 2021 •

edited

Loading

github-actions Bot commented May 10, 2021 •

edited

Loading

github-actions Bot commented May 27, 2021 •

edited

Loading

liliya-soroka commented Jun 2, 2021 •

edited

Loading

katspaugh commented Jun 2, 2021 •

edited

Loading