beta to master#20141
Merged
Merged
Conversation
* Casefold directory when matching against 'addons' * Bump minor version and add changes
* Add an optional trusted fingerprint field to TCPTransport, and check that the server's certificate matches it when connecting insecurely * Bump version and add changes entry --------- Co-authored-by: Sean Budd <sean@nvaccess.org>
#20134) ### Reverts PR Reverts #20096. ### Issues fixed Fixes #20096 (comment) and #20096 (comment). ### Issues reopened Reopens #15159. ### Reason for revert The implementation in #20096 still reviewed the wrong content if you focused a control by pressing tab in focus mode or if you used the review top/bottom line commands. I submitted #20132, but given the proximity to beta, it seems safer to wait for 2026.3 instead. ### Can this PR be reimplemented? If so, what is required for the next attempt See #20132.
Reported in this thread of the translators mailing list.
Summary of the issue:
Magnifier had 2 strings "left" for 2 different uses:
one used as adverb when panning left command was used while already at left edge of the screen to report no move
one other used in compound string "{edge} edge" as an adjective when panning to left edge command was used while already at left of the screen
In some languages, both strings do not translate the same.
Same for "right", "top" and "bottom" strings.
Description of user facing changes:
Panning command feedback when at edge can now be correctly translated.
Description of developer facing changes:
N/A
Description of development approach:
Used 1 string per action with no duplicate
Do not use a compound string since it is no longer needed; this coumpound string was useful only when paning commands were always reporting something but this behaviour has been withdrawn. Moreover, compound strings may be less easy to translate for translators.
None. Fixup of PR #20100 Summary of the issue: Synthesizers may return None for normalized languages, and this is not addressed in #20100. Description of user facing changes: None known. Description of developer facing changes: None. Description of development approach: Considered the situation where the normalized language is None, improved the function to check if a language is supported, and added unit tests for this function.
…#20097) Fixes #19441 Summary of the issue: When NVDA is started with the screen curtain enabled, optionally, NVDA can play a sound warning about this, but braille users aren't informed. Description of user facing changes: If screen curtain is enabled, a message displayed in braille Will report this when NVDA is started. Description of developer facing changes: None. Description of development approach: In core.py, an initialMessage variable has been created. Its value would be the current message ("NVDA started"), or a message like "NVDA started with screen curtain enabled").
Closes #20089 Summary of the issue: winBindings.cfgmgr32 is documented in the 2026.1 developer changes as the replacement location for several deprecated hwPortUtils symbols, but it is not included in binary builds. Description of user facing changes: None. Description of developer facing changes: winBindings.cfgmgr32 will be available in binary builds, matching the documented add-on API migration path. Description of development approach: Explicitly include winBindings.cfgmgr32 in the py2exe includes list, since it is referenced dynamically by hwPortUtils deprecation aliases and is not discovered by static import analysis.
### Reverts PR Reverts #19477 ### Issues fixed Fixes #20122 ### Issues reopened Reopens #19103 ### Reason for revert The referenced commit breaks the use-case where the user is using NVDA Remote Access as their primary means of accessing a headless or otherwise physically inaccessible machine, if the network is unavailable when Remote Access attempts the initial connection. ### Can this PR be reimplemented? If so, what is required for the next attempt Yes. For automatic connections, continue to retry establishing the connection indefinitely, or with some configurable timeout. --------- Co-authored-by: Sean Budd <sean@nvaccess.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.