fix: Denial of service via unindexed database query for unconfigured auth providers (GHSA-g4cf-xj29-wqqr)

[mtrezza]

Issue

Denial of service via unindexed database query for unconfigured auth providers (GHSA-g4cf-xj29-wqqr)

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a vulnerability test suite for GHSA-g4cf-xj29-wqqr and changes findUsersWithAuthData in Auth.js to return early (null) when a provider lacks a configured validator, preventing query construction for unconfigured auth providers.

Changes

Cohort / File(s)	Summary
Vulnerability Test Suite spec/vulnerabilities.spec.js	Added a new describe block with three tests asserting that no database $or queries are issued for unconfigured auth providers during Parse.User().save() signup and POST /challenge, and that queries occur when the provider is configured.
Auth Data Validation Guard src/Auth.js	Updated findUsersWithAuthData to call config.authDataManager.getValidatorForProvider() once and return null immediately when validatorConfig?.validator is absent, avoiding adapter.beforeFind and query construction for unconfigured providers.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant Client as Client
participant Server as Parse Server
participant AuthMgr as AuthDataManager
participant Adapter as DB Adapter
participant DB as Database

Client->>Server: signup /challenge (includes authData)
Server->>AuthMgr: getValidatorForProvider(provider)
alt validator not configured
    AuthMgr-->>Server: validator = null
    Server-->>Client: proceed without DB query (returns null / rejects later)
else validator configured
    AuthMgr-->>Server: validatorConfig with validator
    Server->>Adapter: beforeFind(build query)
    Adapter->>DB: find(query with $or for authData.provider.id)
    DB-->>Adapter: results
    Adapter-->>Server: matching users
    Server-->>Client: continue signup/challenge flow

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: Account takeover via operator injection in authentication data identifier (GHSA-5fw2-8jcv-xh87) #10185: Modifies findUsersWithAuthData with early validation guards to prevent unsafe queries for malformed or unconfigured authData.
• fix: Unlinking auth provider triggers auth data validation #10045: Updates findUsersWithAuthData to skip beforeFind and database query work based on provider validation state.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request is missing a description entirely. The template requires sections for Issue, Approach, and Tasks, none of which are present.	Add a pull request description following the repository template, including the issue being addressed, the approach taken, and relevant task checkboxes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The pull request title accurately describes the main change: fixing a denial of service vulnerability via unindexed database queries for unconfigured auth providers, matching the GHSA identifier and core changes in Auth.js and the test suite.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@spec/vulnerabilities.spec.js`:
- Around line 4145-4207: The new describe block '(GHSA-g4cf-xj29-wqqr) DoS via
unindexed database query for unconfigured auth providers' is accidentally nested
inside the '(GHSA-6qh5-m6g3-xhq6) LiveQuery query depth DoS' describe; fix by
closing the LiveQuery describe before the new block and then closing the new
block after its tests: move the LiveQuery's terminating "});" that currently
appears after the new block's end so that it is placed immediately before the
line with describe('(GHSA-g4cf-xj29-wqqr)...'), and ensure there is a matching
closing "});" following the final test in the new describe; search for the two
describe titles to locate where to reposition the braces.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eed78b46-7c55-40f6-9fa0-e2fcac8ce958

📥 Commits

Reviewing files that changed from the base of the PR and between 48cc262 and 4d27893.

📒 Files selected for processing (2)

• spec/vulnerabilities.spec.js
• src/Auth.js

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.13%. Comparing base (a0530c2) to head (35761f5).
⚠️ Report is 14 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha   #10270      +/-   ##
==========================================
- Coverage   92.53%   92.13%   -0.41%     
==========================================
  Files         192      192              
  Lines       16442    16445       +3     
  Branches      226      226              
==========================================
- Hits        15215    15151      -64     
- Misses       1207     1270      +63     
- Partials       20       24       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.6.0-alpha.52

[parseplatformorg]

🎉 This change has been released in version 9.6.0