fix: Validate body field types in request middleware

[mtrezza]

Issue

Non-string values for body fields _SessionToken, _ClientVersion, _InstallationId, _MasterKey, _ContentType, and base64 (file-via-JSON) in handleParseHeaders cause unhandled TypeError exceptions resulting in HTTP 500 responses instead of proper 403 rejections.

Tasks

• Add type validation for body-extracted fields in middleware
• Add tests for MongoDB
• Add tests for PostgreSQL

Summary by CodeRabbit

• Bug Fixes

  • Middleware now validates request body field types, rejecting non-string values with a 403 to prevent malformed requests from causing server failures.

• Tests

  • Added comprehensive tests for body field type validation to ensure invalid inputs are rejected and valid requests continue to work.
  • Updated an existing test expectation for invalid session tokens to assert an "unauthorized" error.

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks with a short comment before each block to explain its purpose.
• Our review focuses on code concept, not quality. PRs with code issues will be rejected. Use an AI agent.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4d93178b-ee00-49b9-9113-969b2b13fd54

📥 Commits

Reviewing files that changed from the base of the PR and between da75211 and a7ab1a5.

📒 Files selected for processing (1)

• spec/RegexVulnerabilities.spec.js

---

📝 Walkthrough

Walkthrough

Adds strict runtime type validation in request header/body parsing for several fields (_ClientVersion, _InstallationId, _SessionToken, _MasterKey, _ContentType, and base64 in JSON file uploads). Invalid non-string values produce immediate 403 responses. Tests for these validations were added (duplicated in the diff).

Changes

Cohort / File(s)	Summary
Type Validation Tests spec/Middlewares.spec.js	Adds a "body field type validation" test suite exercising handleParseHeaders with non-string body fields (_SessionToken, _ClientVersion, _InstallationId, _ContentType, base64). Verifies 403 responses for invalid types and acceptance of valid string values. The test block is duplicated in the file.
Middleware Type Validation src/middlewares.js	Introduces runtime checks ensuring _ClientVersion, _InstallationId, _SessionToken, _MasterKey, and _ContentType are strings; validates base64 as string for JSON file uploads. Returns an invalidRequest/403 on type mismatch and preserves existing mapping to req.info for valid values.
Test Assertion Update spec/RegexVulnerabilities.spec.js	Adjusts an assertion: previous specific error (Invalid session token, code 209) replaced with a generic 'unauthorized' error expectation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description covers the Issue section and Tasks section but is missing the required Approach section explaining the implementation changes and strategy.	Add an Approach section describing how the type validation was implemented and the control flow adjustments made to handle invalid types.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding type validation for body fields in request middleware to fix unhandled TypeErrors.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/middlewares.js (1)

215-223: ⚠️ Potential issue | 🟡 Minor

Add validation to ensure base64 is provided before buffer conversion.

When base64 is undefined or an empty string and fileViaJSON is true, Buffer.from(base64, 'base64') at line 150 will throw an unhandled TypeError (for undefined) or create an empty buffer (for empty string), rather than returning a proper 403 response. The validation should check that base64 is truthy before conversion.

Suggested fix

  if (fileViaJSON && req.body) {
    if (req.body.base64 && typeof req.body.base64 !== 'string') {
      return invalidRequest(req, res);
    }
+   if (!req.body.base64) {
+     return invalidRequest(req, res);
+   }
    req.fileData = req.body.fileData;
    // We need to repopulate req.body with a buffer
    var base64 = req.body.base64;
    req.body = Buffer.from(base64, 'base64');
  }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/middlewares.js` around lines 215 - 223, The middleware block handling
fileViaJSON must validate that req.body.base64 is present and a non-empty string
before calling Buffer.from; update the fileViaJSON branch to check (e.g. if
(!req.body.base64 || typeof req.body.base64 !== 'string') return
invalidRequest(req, res);) instead of only checking type, then proceed to set
req.fileData and convert with Buffer.from(req.body.base64, 'base64') to
repopulate req.body; reference the existing symbols fileViaJSON,
req.body.base64, invalidRequest, req.fileData, and Buffer.from when making the
change.

🧹 Nitpick comments (1)

spec/Middlewares.spec.js (1)

475-513: Consider adding _MasterKey to the resilience test payloads.

The middleware validates _MasterKey type at lines 174-176, but this field is not included in the payloads array here. Adding it would ensure complete coverage.

🧪 Suggested enhancement

       const payloads = [
         { _SessionToken: { toString: 'evil' } },
         { _ClientVersion: { toLowerCase: 'evil' } },
         { _InstallationId: [1, 2, 3] },
         { _ContentType: { toString: 'evil' } },
+        { _MasterKey: { toString: 'evil' } },
       ];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@spec/Middlewares.spec.js` around lines 475 - 513, The test "should not crash
the server process on non-string body fields" omits a payload case for
_MasterKey even though handleParseHeaders checks its type; add an additional
payload entry (e.g., _MasterKey: { toString: 'evil' } or another non-string
value) to the payloads array in this spec so the middleware's _MasterKey type
validation is exercised alongside the other fields and the test still verifies
the response is 403 and server resilience.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/middlewares.js`:
- Around line 215-223: The middleware block handling fileViaJSON must validate
that req.body.base64 is present and a non-empty string before calling
Buffer.from; update the fileViaJSON branch to check (e.g. if (!req.body.base64
|| typeof req.body.base64 !== 'string') return invalidRequest(req, res);)
instead of only checking type, then proceed to set req.fileData and convert with
Buffer.from(req.body.base64, 'base64') to repopulate req.body; reference the
existing symbols fileViaJSON, req.body.base64, invalidRequest, req.fileData, and
Buffer.from when making the change.

---

Nitpick comments:
In `@spec/Middlewares.spec.js`:
- Around line 475-513: The test "should not crash the server process on
non-string body fields" omits a payload case for _MasterKey even though
handleParseHeaders checks its type; add an additional payload entry (e.g.,
_MasterKey: { toString: 'evil' } or another non-string value) to the payloads
array in this spec so the middleware's _MasterKey type validation is exercised
alongside the other fields and the test still verifies the response is 403 and
server resilience.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3af882bb-b6c1-48d7-8070-db17bf8fd091

📥 Commits

Reviewing files that changed from the base of the PR and between ad463d2 and da75211.

📒 Files selected for processing (2)

• spec/Middlewares.spec.js
• src/middlewares.js

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.55%. Comparing base (ad463d2) to head (a7ab1a5).
⚠️ Report is 77 commits behind head on alpha.

Files with missing lines	Patch %	Lines
src/middlewares.js	85.71%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha   #10209      +/-   ##
==========================================
- Coverage   92.56%   92.55%   -0.01%     
==========================================
  Files         192      192              
  Lines       16284    16296      +12     
  Branches      199      199              
==========================================
+ Hits        15073    15083      +10     
- Misses       1194     1196       +2     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.6.0-alpha.23

[parseplatformorg]

🎉 This change has been released in version 9.6.0