fix: Sanitize control characters in page parameter response headers

[mtrezza]

Issue

Sanitize control characters in page parameter response headers

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

Extended test coverage for CRLF injection handling in PagesRouter page parameters. Refactored PagesRouter to centralize page parameter header construction into a dedicated helper method that handles URI-encoding and control character stripping.

Changes

Cohort / File(s)	Summary
Test Coverage spec/PagesRouter.spec.js	Added two test cases to verify CRLF injection robustness: one validating 200 response for direct page requests with CRLF-containing tokens, and another ensuring no 500 errors on resend_verification_email POST requests with CRLF injection.
Header Parameter Centralization src/Routers/PagesRouter.js	Introduced new composePageParamHeaders(params) helper method that consolidates header construction logic with URI-encoding (when enabled) and control character stripping. Replaced inline header-building code across multiple call sites to use this centralized method.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: PagesRouter header parameters are not URL-encoded to support non-ASCII characters in app name #10078 — Modifies PagesRouter header-construction logic for page parameters with centralized header handling and optional URI-encoding.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author, missing all required sections from the template including Issue, Approach, and Tasks.	Add a comprehensive description following the repository template, including issue reference, approach explanation, and completion status of required tasks.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: sanitizing control characters in page parameter response headers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

spec/PagesRouter.spec.js (1)

1056-1068: Tighten this redirect-path test with explicit status/behavior assertions.

Right now it only proves “not 500.” Please also assert the expected redirect contract (e.g., 303 and expected location pattern) so this test catches semantic regressions, not just crashes.

Suggested assertion hardening

       const response = await request({
         method: 'POST',
         url: url,
         headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
         body: `username=${encodeURIComponent(crlf)}`,
         followRedirects: false,
       }).catch(e => e);
       expect(response.status).not.toBe(500);
+      expect(response.status).toBe(303);
+      expect(response.headers.location).toContain('/email_verification_send_');

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@spec/PagesRouter.spec.js` around lines 1056 - 1068, The test currently only
asserts the response is not 500; tighten it by asserting the full redirect
contract: when posting to the resend_verification_email endpoint with the CRLF
payload (variable crlf) and followRedirects: false, assert response.status
equals the expected redirect status (e.g., 303) and assert
response.headers.location matches the expected pattern (e.g., contains the
verification page or safe base URL) to ensure proper redirect behavior; keep the
existing variables (crlf, url, request) and the non-redirecting request options
but replace the loose not-to-be-500 check with explicit status and Location
header assertions.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/Routers/PagesRouter.js`:
- Around line 552-573: The composePageParamHeaders function currently calls
encodeURIComponent directly (when pagesConfig.encodePageParamHeaders is true),
which throws URIError on malformed Unicode; update composePageParamHeaders to
convert the param value to a string and call String.prototype.toWellFormed() on
it before calling encodeURIComponent (use value =
value.toString().toWellFormed() when available) so lone surrogates are fixed and
encodeURIComponent won't throw; keep the existing control-character stripping
and header key construction using pageParamHeaderPrefix and p[0].toLowerCase().

---

Nitpick comments:
In `@spec/PagesRouter.spec.js`:
- Around line 1056-1068: The test currently only asserts the response is not
500; tighten it by asserting the full redirect contract: when posting to the
resend_verification_email endpoint with the CRLF payload (variable crlf) and
followRedirects: false, assert response.status equals the expected redirect
status (e.g., 303) and assert response.headers.location matches the expected
pattern (e.g., contains the verification page or safe base URL) to ensure proper
redirect behavior; keep the existing variables (crlf, url, request) and the
non-redirecting request options but replace the loose not-to-be-500 check with
explicit status and Location header assertions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 17b536bf-bca9-400a-bb11-75cdf7431eca

📥 Commits

Reviewing files that changed from the base of the PR and between c77c884 and 64aeecf.

📒 Files selected for processing (2)

• spec/PagesRouter.spec.js
• src/Routers/PagesRouter.js

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.60%. Comparing base (f521576) to head (ef1fd00).
⚠️ Report is 44 commits behind head on alpha.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha   #10237   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files         192      192           
  Lines       16351    16351           
  Branches      201      201           
=======================================
  Hits        15142    15142           
  Misses       1192     1192           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.6.0-alpha.38

[parseplatformorg]

🎉 This change has been released in version 9.6.0