fix: Locale parameter path traversal in pages router

[mtrezza]

Issue

Locale parameter path traversal in pages router

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.60%. Comparing base (337ffd6) to head (a4cb56c).
⚠️ Report is 42 commits behind head on alpha.

Files with missing lines	Patch %	Lines
src/Routers/PagesRouter.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha   #10242      +/-   ##
==========================================
+ Coverage   92.19%   92.60%   +0.40%     
==========================================
  Files         192      192              
  Lines       16351    16355       +4     
  Branches      201      201              
==========================================
+ Hits        15075    15145      +70     
+ Misses       1255     1193      -62     
+ Partials       21       17       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fe9fa529-5bbc-4aee-987d-282d1000d5de

📥 Commits

Reviewing files that changed from the base of the PR and between 088c0e2 and a4cb56c.

📒 Files selected for processing (1)

• src/Routers/PagesRouter.js

🚧 Files skipped from review as they are similar to previous changes (1)

• src/Routers/PagesRouter.js

---

📝 Walkthrough

Walkthrough

Adds runtime validation in PagesRouter.getLocale to reject locale values that are non-strings or don't match /^[a-zA-Z]{2,3}(-[a-zA-Z0-9]{2,8})*$/, and updates tests to assert rejection of XSS payloads and path-traversal sequences in the locale query parameter.

Changes

Cohort / File(s)	Summary
Router implementation src/Routers/PagesRouter.js	Adds runtime checks in getLocale: return undefined for non-string or regex-nonmatching locale values; preserves valid locale flow.
Tests spec/PagesRouter.spec.js	Adds test ensuring locale query with path traversal sequences is rejected and default page served; renames/adjusts XSS test to assert rejection (response must not contain XSS payload).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• fix: Cross-Site Scripting (XSS) via HTML pages for password reset and email verification #9985: Related changes to PagesRouter locale/XSS handling and test adjustments.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request has no description provided by the author, while the repository template requires multiple sections including Issue, Approach, and Tasks.	Add a pull request description following the repository template, including the issue being fixed, the approach taken, and completed tasks such as tests and security checks.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding locale parameter validation to prevent path traversal attacks in the pages router.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/Routers/PagesRouter.js`:
- Around line 550-553: In getLocale, non-string locale values bypass validation
and get returned; change the logic so any locale that is not a string is
rejected by returning undefined, and only strings that pass the
/^[a-zA-Z]{2,3}(-[a-zA-Z0-9]{2,8})*$/ check are returned—update the condition in
getLocale to first verify typeof locale === 'string' and return undefined for
all non-strings, then apply the regex and return undefined for non-matching
strings, otherwise return the validated locale.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a224c31e-5025-4564-a5e2-a346102d2223

📥 Commits

Reviewing files that changed from the base of the PR and between cd0ec81 and 088c0e2.

📒 Files selected for processing (2)

• spec/PagesRouter.spec.js
• src/Routers/PagesRouter.js

[parseplatformorg]

🎉 This change has been released in version 9.6.0-alpha.39

[parseplatformorg]

🎉 This change has been released in version 9.6.0