Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes to MainWindow and some cleanup #2402

Merged
merged 1 commit into from Oct 20, 2018

Conversation

Projects
None yet
3 participants
@droidmonkey
Copy link
Member

commented Oct 20, 2018

Description

  • Fix MainWindow startup when minimize to tray was enabled
  • Reduce duplicate code in DatabaseWidget.cpp
  • Fix snapcraft build dependencies
  • Add support for CTRL+TAB, CTRL+PGUP, CTRL+SHIFT+TAB, CTRL+PGDN to focus database tabs from any location
  • Add CTRL+SHIFT+M shortcut to minimize to tray
  • Allow minimize instead of app exit without tray icon

Motivation and context

Resolves #1876
Resolves #2008
Resolves #2254
Resolves #2280 (adds a guard to not minimize to tray if the tray is not enabled)
Resolves #1333 (TAB (group -> entry), SHIFT+TAB (entry -> group))
Resolves #1727
Resolves #1595
Resolves #795

How has this been tested?

Manually on Windows and Linux

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
Multiple fixes to MainWindow and some cleanup
* Fix MainWindow startup when minimize to tray was enabled
* Reduce duplicate code in DatabaseWidget.cpp
* Fix snapcraft build dependencies
* Add support for CTRL+TAB, CTRL+PGUP, CTRL+SHIFT+TAB, CTRL+PGDN to control database tabs from any focus location
* Add CTRL+SHIFT+M shortcut to minimize to tray
* Allow minimize instead of app exit without tray icon

@droidmonkey droidmonkey added the ux label Oct 20, 2018

@droidmonkey droidmonkey added this to the v2.4.0 milestone Oct 20, 2018

@droidmonkey droidmonkey requested review from weslly and phoerious Oct 20, 2018

@phoerious
Copy link
Member

left a comment

I haven't tested it on Linux, but looks good to me.

@phoerious phoerious added the bug label Oct 20, 2018

@weslly

weslly approved these changes Oct 20, 2018

Copy link
Member

left a comment

It solved the minimize on startup issue and everything else seems to be working fine

@phoerious phoerious merged commit a44138d into develop Oct 20, 2018

3 checks passed

CodeFactor No issues found.
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@phoerious phoerious deleted the fix/mainwindow branch Oct 20, 2018

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.