Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final PR for 2.4.0 #2802

Merged
merged 4 commits into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@droidmonkey
Copy link
Member

droidmonkey commented Mar 18, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

  • Fix #2609 - Database can be created without a password; a warning is shown
  • Fix #2647 - Wording updated for question about "legacy" browser settings
  • Fix #1598 - Utility script to install native messaging configuration when using snaps or flatpak. Re-enabled browser extension support while building a snap.

make format will be run and merged right after this PR and before the tag is made.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.

@droidmonkey droidmonkey added this to the v2.4.0 milestone Mar 18, 2019

@droidmonkey droidmonkey requested review from phoerious and varjolintu Mar 18, 2019

@droidmonkey droidmonkey changed the base branch from develop to release/2.4.0 Mar 18, 2019

@droidmonkey droidmonkey force-pushed the fix/last-chance branch from 0d7060d to 7173af9 Mar 18, 2019

@varjolintu

This comment has been minimized.

Copy link
Member

varjolintu commented Mar 19, 2019

I cannot get the proxy to communicate with the snap version even after the helper script. I can see from ss -apx that the socket is listening but strace never reports any connection to the socket KeePassXC is listening.

@droidmonkey

This comment has been minimized.

Copy link
Member Author

droidmonkey commented Mar 19, 2019

I have a fix for it, going to push in a moment

@varjolintu

This comment has been minimized.

Copy link
Member

varjolintu commented Mar 19, 2019

And btw, I wonder if that script is even necessary because we changed the native messaging script updating to be enabled by default. Would it solve the problem automatically? However, for me the option is disabled in the settings when using snaps, and it cannot be changed.

@droidmonkey droidmonkey force-pushed the fix/last-chance branch 2 times, most recently from a603e02 to 4c19510 Mar 19, 2019

droidmonkey added some commits Mar 18, 2019

Use existing extension when creating backup file
* passwords.kdbx -> passwords.old.kdbx
* passwords.db -> passwords.old.db
* passwords -> passwords.old
Allow database creation without password
* The warning about not having a password is now properly shown (previously it did not let you continue at all)
* General cleanup of the master key editing workflow
@droidmonkey

This comment has been minimized.

Copy link
Member Author

droidmonkey commented Mar 19, 2019

The executable running in the snap cannot write to any "dot-folder" so we cannot inject the json file from the snap. This is the purpose of the script.

@droidmonkey droidmonkey force-pushed the fix/last-chance branch from 4c19510 to 0b840d2 Mar 19, 2019

Allow snap builds to use keepassxc-proxy
* Updated browser extension settings for snap usage
* Support Snap 3.0 Changes
* Add missing stage packages
* Correct proxy communication with snaps

@droidmonkey droidmonkey force-pushed the fix/last-chance branch from 0b840d2 to 239462e Mar 19, 2019

@droidmonkey droidmonkey merged commit 306bf0f into release/2.4.0 Mar 19, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@droidmonkey droidmonkey deleted the fix/last-chance branch Mar 19, 2019

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.