Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer default error messages #2622

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
2 participants
@varjolintu
Copy link
Member

varjolintu commented Jan 20, 2019

Modify the error messages to be a little more clearer. Any suggestions are very welcome.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

The previous error messages are not clear enough to describe the error situation.

Testing strategy

Manually.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@varjolintu varjolintu added this to the v2.4.0 milestone Jan 20, 2019

@varjolintu varjolintu requested review from phoerious and droidmonkey Jan 20, 2019

@varjolintu varjolintu force-pushed the varjolintu:fix/error_messages branch from bfc9a38 to 4bf8a2a Jan 20, 2019

@droidmonkey
Copy link
Member

droidmonkey left a comment

See comments

Show resolved Hide resolved src/browser/BrowserAction.cpp Outdated
Show resolved Hide resolved src/browser/BrowserAction.cpp Outdated

@varjolintu varjolintu force-pushed the varjolintu:fix/error_messages branch from 4bf8a2a to eec82c3 Jan 21, 2019

@varjolintu varjolintu referenced this pull request Jan 21, 2019

Merged

Clearer error messages #392

Show resolved Hide resolved src/browser/BrowserAction.cpp Outdated
Show resolved Hide resolved src/browser/BrowserAction.cpp Outdated
@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Jan 21, 2019

Other error codes not used are:

ERROR_KEEPASS_KEY_CHANGE_FAILED
ERROR_KEEPASS_ENCRYPTION_KEY_UNRECOGNIZED
ERROR_KEEPASS_NO_SAVED_DATABASES_FOUND
ERROR_KEEPASS_EMPTY_MESSAGE_RECEIVED

@varjolintu varjolintu force-pushed the varjolintu:fix/error_messages branch from eec82c3 to dee21b2 Jan 22, 2019

@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Jan 22, 2019

@droidmonkey Those unused error messages are now removed. The reason for those was to keep the similarity with the browser extension, but that's not really needed. I also added some error messages to certain points that could be useful. Thanks for the review.

@varjolintu varjolintu force-pushed the varjolintu:fix/error_messages branch from dee21b2 to 9abaf41 Jan 22, 2019

@droidmonkey droidmonkey merged commit d662992 into keepassxreboot:develop Jan 25, 2019

4 checks passed

CodeFactor 1 issue fixed.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@varjolintu varjolintu deleted the varjolintu:fix/error_messages branch Jan 25, 2019

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.