library: add Adw.Clamp entry #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
requested changes
Jun 4, 2023
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
It doesn't build.
The formatting is off.
The strings should use _()
Please test and review your work before submitting.
src/Library/demos/Clamp/main.blp
Outdated
Comment on lines
17
to
26
| TextView { | ||
| height-request: 180; | ||
| width-request: 60; | ||
| editable: true; | ||
| bottom-margin: 12; | ||
| wrap-mode: char; | ||
| buffer: Gtk.TextBuffer { | ||
| text: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."; | ||
| } | ||
| } |
src/Library/demos/Clamp/main.blp
Outdated
|
|
||
| LinkButton { | ||
| label: "API Reference"; | ||
| uri: "https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.Clamp.html"; |
Contributor
There was a problem hiding this comment.
Links should be to adw 1.3 docs
Contributor
Author
|
Made the following Changes:
|
Contributor
|
If this is one ready for re-review, please remember to hit that button again 🙂 We don't want to make you wait, or start re-reviewing before you're ready. |
Add a basic example of Drag-and-Drop, with re-orderable list box rows.
* Adds Adw.AboutWindow Demo * Updated Link * Updated Code * Updated Icon * Added Acknowledgement Section
* library: Add AdwAnimation entry * Animation: Fix CallbackAnimationTarget and add AnimationTarget example * Animation: Add links * Animation: Changes from review * Animation: Update main.css
* Added TextView Demo * Updated JS Code * Updated Code * Formatting Changes
* libary: Add SpinButton entry * Spin Button: Add link to tutorial * Spin Button: Changes from review * Spin Button: Translated strings * Spin Button: Add comments for clarity
* library: Add AdwBanner entry * Banner: Translate strings
* library: add carousel entry * make carousel functional * add main.vala * fix horizontal orientation * fix alignment on prefsrow * main.vala: fix formatting * Apply suggestions from code review Fix formatting and remove stuff Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com> * main.blp: fix spacing * remove quotes --------- Co-authored-by: wlhunter <wlhunter@go.olemiss.edu> Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
Signal handlers have semantic around return values. Let's not encourage developers to use async signal handlers as it can lead to hard to debug issues. Also some other improvements
* Add columnview * test * Update * Clean Up and implement colview * Refactoring and applied suggested changes * Applied changes * Progress * Updated * Update * Update * Reverse * Applied Suggested Changes * Minor Change
* library: Add Menu entry * Menu: Minor change from review Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com> * Set default text color to green This should be visible in any color scheme. --------- Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com> Co-authored-by: Andy Holmes <andrew.g.r.holmes@gmail.com>
Use `meson.project_source_root()` where necessary.
The getter was missing for `Workbench.CompletionRequest:cancellable`.
* Adds launcher entry * Updated code * Clean Up * Applied changes * Updated demo * Suggested Changes * New property
* library: Add vala demo for Text View * Fix for code review * Fix for code review workbenchdev#2
* library: Add Navigation Split View entry * Navigation Split View: Replicate Adw Demo * Navigation Split View: Changes from code review * Navigation Split View: Update main.json
* library: Port Wallpaper and Screenshot demos to Vala * library: Port Account and Color Picker demos to Vala * library: Port Email demo to Vala * library: Port Location demo to Vala
* library: Port Event Controllers demo to Vala * library: Cast workbench.window when add_controller is called
sonnyp
approved these changes
Aug 13, 2023
Contributor
sonnyp
left a comment
sonnyp
left a comment
There was a problem hiding this comment.
I wanted to do something more complicated but I think this is a good entry anyway and it's easy to go from it to the documentation.
sonnyp
pushed a commit
that referenced
this pull request
Aug 18, 2023
sonnyp
pushed a commit
that referenced
this pull request
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #287
Implemented Adw.Clamp demo following the description that was discussed. Added some more functionality to enhance UI. Looking for an early review.