...so that arg parsing can rely on strings satisfying
a "doesn't start with --" convention.

Signed-off-by: John Spray <john.spray@redhat.com>

This relied on a behaviour where positional
arguments could be omitted if the subsequent
argument was of a different type.

This was pretty weird, and in any case the reweight-by-utilization
command is likely to go away soon.

Signed-off-by: John Spray <john.spray@redhat.com>

This replaces use of CephChoices for cases like
--yes-i-really-really-mean-it.

It's a relatively invasive change, because both
client and server need to handle backward compatibility:
 - Clients are easy, they just cope with the server's
   use of CephChoices/CephString with a few special case
   strings to recognise --yes-i-really-mean-it and similar
 - Servers are harder, they have to convert CephBool arguments
   into a similar CephChoices argument that older clients will
   understand.  This involves propagating feature flags into
   some code paths that couldn't see them before.

Signed-off-by: John Spray <john.spray@redhat.com>

Signed-off-by: John Spray <john.spray@redhat.com>

Signed-off-by: John Spray <john.spray@redhat.com>

Fixes: https://tracker.ceph.com/issues/36681

Signed-off-by: Volker Theile <vtheile@suse.com>

Remove a context from peer_ack_ctxs before completing to avoid a race
with a listener inserting a new one.

Fixes: http://tracker.ceph.com/issues/36683
Signed-off-by: Mykola Golub <mgolub@suse.com>

test/rbd_mirror: race in TestMockImageMap.AddInstancePingPongImageTest

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

qa/tests: update links for centos latest to point to 7.5

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>

…n-empty

test: make readable.sh fail if it doesn't run anything

Reviewed-by:  Sage Weil <sage@redhat.com>

rbd: support namespaces for image migration

Reviewed-by: Mykola Golub <mgolub@suse.com>

rbd-mirror: update mirror status when stopping

Reviewed-by: Mykola Golub <mgolub@suse.com>

rgw: Return tenant field in bucket_stats function

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Rewrote the documentation in a step-by-step style, reformatted using RST's
titles instead of bolds, added installation of GIT if needed, added
installation of compilers needed for tcmu-runner

Signed-off-by: Massimiliano Cuttini <massimiliano.cuttini@phoenixweb.it>

* refs/pull/24870/head:
	client: request next osdmap for blacklisted client

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn>

Signed-off-by: Mykola Golub <mgolub@suse.com>

Signed-off-by: Mykola Golub <mgolub@suse.com>

Signed-off-by: Mykola Golub <mgolub@suse.com>

doc: rewrote the iscsi-target-cli installation

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>

Signed-off-by: Mykola Golub <mgolub@suse.com>

Separate diskprediction local plugin from the diskprediction plugin.
Devicehealth invoke device prediction function related on the global
 configuration "device_failure_prediction_mode".

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>

Fixes: https://tracker.ceph.com/issues/36193

Enable API auditing with 'ceph dashboard set-audit-api-enabled true' (default is false). If you do not want to log the request payload, then disable it via 'set-audit-api-log-payload false' (default is true).

Example output:
2018-10-08 10:25:21.850994 mgr.x [INF] [DASHBOARD] from='https://[::1]:44410' path='/api/auth' method='POST' user='None' params='{"username": "admin", "password": "***", "stay_signed_in": false}'

Signed-off-by: Volker Theile <vtheile@suse.com>

Currently /var/lib/ceph/bootstrap-rbd-mirror is absent, which means we
need to create it manually in order to pool the
client.bootstrap-rbd-mirror key.

Signed-off-by: Sébastien Han <seb@redhat.com>

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

- Updated 'requests' in requirements.txt.

Fixes: https://tracker.ceph.com/issues/36632

Signed-off-by: Alfonso Martínez <almartin@redhat.com>

mgr/dashboard: Simplification of PoolForm method

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

spec: add missing rbd mirror bootstrap directory

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

In certain situations a new task is already in the current summary before we
manually push it to the running task list.
Since we were not checking that, at the end of the operation we would have 2
entries for the same task and that would be displayed in the UI.

Signed-off-by: Tiago Melo <tmelo@suse.com>

mgr/dashboard: Audit REST API calls

Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>

Fixes: https://tracker.ceph.com/issues/36616
Signed-off-by: Stephan Müller <smueller@suse.com>

…read

Fixes: http://tracker.ceph.com/issues/36625
Signed-off-by: Yang Honggang <yanghonggang@umcloud.com>

[RFC] mgr/dashboard: Cleanup of OSD list methods

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>

rbd: return error code when the source and distination namespace are different

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

rbd: make sure the return-value 'r' will be returned

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

It is particularly useful when running multiple rbd-mirror instances
in Active-Passive or Active-Active mode.

Signed-off-by: Mykola Golub <mgolub@suse.com>

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Permits setting restrictive permissions on these secrets.

Fixes: http://tracker.ceph.com/issues/36621

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

* refs/pull/24814/head:
	Merge PR ceph#24804 into nautilus
	include/types: fixed compile warning for signed/unsigned comparison
	osd/PrimaryLogPG: uncommitted dup ops should respond with logged return code
	osd/PrimaryLogPG: propagate error return codes on object copy_get ops
	osd/PGLog: optionally record error return codes for extra_reqids
	osd/osd_types: include PG log return codes in object copy data

Reviewed-by: Neha Ojha <nojha@redhat.com>

The guards are based on spos, which does not change across the call to
_merge_collection, which means we can't open and close multiple guards
within this call.  Instead, use a single set of set_guards and closes
surrounding both the collection and temp.

Also, remove the conditional guard around _remove_collection, which we
want to (try to) do (again) as long as we didn't complete our global
replay guard.

Fixes: http://tracker.ceph.com/issues/36610
Signed-off-by: Sage Weil <sage@redhat.com>

cmake: do not pass -B{symbolic,symbolic-functions} to linker on FreeBSD

Reviewed-by: Kefu Chai <kchai@redhat.com>

Fixes: http://tracker.ceph.com/issues/35684

Signed-off-by: familyuu <guodan1@lenovo.com>

mgr/dashboard: CRUSH map viewer

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Avoid code exception when the remote plugin not enabled.

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>

Signed-off-by: Tiago Melo <tmelo@suse.com>

Signed-off-by: Tiago Melo <tmelo@suse.com>

Signed-off-by: Tiago Melo <tmelo@suse.com>

Signed-off-by: Tiago Melo <tmelo@suse.com>

Recent Angular update is causing a warning to be shown when you call
"router.navigate" outside an angular zone.

This is not affecting the code itself, just the unit tests.

Signed-off-by: Tiago Melo <tmelo@suse.com>

Fixes: https://tracker.ceph.com/issues/36702

Signed-off-by: Tiago Melo <tmelo@suse.com>

ceph-volume tests install ceph-ansible's requirements.txt dependencies

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

It turned out that "_filterValue" wasn't needed for any form.

Fixes: http://tracker.ceph.com/issues/26861
Signed-off-by: Stephan Müller <smueller@suse.com>

* refs/pull/24835/head:
	include/buffer: make static_assert c++11-safe

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

* refs/pull/21723/head:
	osd: flush dirty data if cache_target_dirty_ratio = 0.0

Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>

* refs/pull/20735/head:
	msg/async: fix variable type to make it same to EventCenter::init() incoming parameter type

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

* refs/pull/14982/head:
	common/mempool: tolerate sum < 0
	common/ceph_context: add perf counters for all mempools
	common/ceph_common: add heartbeat perf counters unconditionally

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

The current behavior when submitting an empty mail field in the RGW user form
that was previously filled was to replace it with "false".

This was a regression introduced through the use of "CdFormGroup" which had
a "_filterValue" method which converted empty strings into false, but it was
removed now.

Fixes: http://tracker.ceph.com/issues/26861
Signed-off-by: Stephan Müller <smueller@suse.com>

Fixes: http://tracker.ceph.com/issues/36606
Signed-off-by: Igor Fedotov <ifedotov@suse.com>

mgr/dashboard: Simplify OSD disabled action test

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Signed-off-by: Alfredo Deza <adeza@redhat.com>

Signed-off-by: Alfredo Deza <adeza@redhat.com>

test/librbd: migration supporting namespace tests

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

rbd-nbd: do not ceph_abort() after print the usages

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

…ance

rbd: show info about mirror daemon instance in image mirror status output

Reviewed-by: Jason Dillaman <dillaman@redhat.com>

* refs/pull/15047/head:
	tool/ceph_objectstore_tool: add new op that reset last_complete to last_update

Reviewed-by: Sage Weil <sage@redhat.com>

ceph-volume tests.systemd update imports for systemd module

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Also remove all references to the ceph-client test kernel since v4.16 has been
released.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>

Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>

Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>

Signed-off-by: songweibin <song.weibin@zte.com.cn>

mgr/dashboard: Update npm packages

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>

There is a typo in implemented commands for OSD. It reads deep_scrub
instead of deep-scrub which is the true valid command.

Fixes: http://tracker.ceph.com/issues/36720
Signed-off-by: Boris Ranto <branto@redhat.com>

Signed-off-by: John Spray <john.spray@redhat.com>

Signed-off-by: John Spray <john.spray@redhat.com>

mgr/restful: Fix deep-scrub typo

Reviewed-by: John Spray <john.spray@redhat.com>

Failed to import _strptime because the import lockis held by another thread

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>

…ole-doc

rgw: Improvements to STS Lite documentation.

…t failures

- Fix bug in Dashboard QA unit test framework. Don't set the application type header manually, this is done by the requests library if required.
- Enhance QA unit test helper: Print the response of the API request if it fails. This should help to identify the problem more easily.
- Fix bug in the OSD controller. A parameter needs to be converted to integer.
- Take care that the params of the request object are not modified.

The issue was introduced by PR ceph#24475. The CherryPy json_in plugin disclosed the errorneous unit test helper implementation.

Fixes: https://tracker.ceph.com/issues/36708

Signed-off-by: Volker Theile <vtheile@suse.com>

Signed-off-by: Alfredo Deza <adeza@redhat.com>

ceph-volume util.encryption robust blkid+lsblk detection of lockbox

Reviewed-by: Andrew Schoen <aschoen@redhat.com>

Signed-off-by: Julien Collet <julien.collet@cern.ch>

Fixes: https://tracker.ceph.com/issues/36091
Signed-off-by: Mykola Golub <mgolub@suse.com>

when a new type is added and still running an older osd.

Signed-off-by: Mykola Golub <mgolub@suse.com>

- python-* packages are using the C APIs which are not changed across
librados2 and librados3.

Signed-off-by: Kefu Chai <kchai@redhat.com>

this change reverts cac1d6f

Signed-off-by: Kefu Chai <kchai@redhat.com>

this change partially reverts 6eca7d0

Signed-off-by: Kefu Chai <kchai@redhat.com>

this change partially reverts 6eca7d0

Signed-off-by: Kefu Chai <kchai@redhat.com>

this change reverts b8ff781

Signed-off-by: Kefu Chai <kchai@redhat.com>

we have switched from tmap to omap long ago.

but keep the server side implementation around, in case ancient
client is still using these tmap APIs.

also, tmap_update() is kept, because librbd is using it for v1 image
backward compatibility.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Signed-off-by: Kefu Chai <kchai@redhat.com>

Add support for osd_delete_sleep configuration value

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

libradospp-{dev,devel} is necessary for compiling sources in
examples/librados/hello_world.cc

Signed-off-by: Kefu Chai <kchai@redhat.com>

My using nop() instead of setattr() we avoid crashing
a replica that is missing the object for some reason.
Although this is a corruption, it would be getting "fix"
by removal of the snapshot.

In the other cases we accept completely missing keys (ENOENT)
that happens when an object is removed somehow or missed
by recovery/backfill.

Signed-off-by: David Zafman <dzafman@redhat.com>

Signed-off-by: lvshuhua <lvshuhua@cmss.chinamobile.com>

rgw: use chunked encoding to get partial results out faster

doc/rados: correct osd path in troubleshooting-mon.rst

Reviewed-by: Kefu Chai <kchai@redhat.com>

bluestore/NVMEDevice.cc: fix ceph_assert() when enable SPDK with 64KB kernel page size

Reviewed-by: Kefu Chai <kchai@redhat.com>