Dev meeting 2015 11 17

Nov 18 05:29:52 <carsonfull>	Ok well I'm here :)
Nov 18 05:30:12 <gawainlynch>	pinging Bopp carsonfull rarilaDroid2 rossriley SahAssar SahAssar2 
Nov 18 05:30:20 <Bopp>	yes, i assume we'll just go briefly over the tracker issue list, and see if we're all on the same page :-)
Nov 18 05:30:26 <rossriley>	hello
Nov 18 05:30:26 <gawainlynch>	^ this
Nov 18 05:30:29 <rossriley>	present
Nov 18 05:30:30 <Bopp>	*raises hand*
Nov 18 05:31:04 <gawainlynch>	Where is our issue manager, damnit! :-D
Nov 18 05:31:14 <slick0>	release manager present!
Nov 18 05:31:16 *	slick0 hides
Nov 18 05:31:26 <rossriley>	slick0: still monday?
Nov 18 05:31:26 <slick0>	2.3 out on friday!
Nov 18 05:31:31 <gawainlynch>	slick0: Be very careful what you put your hand up for :-D
Nov 18 05:31:33 <slick0>	rossriley: it got moved up
Nov 18 05:31:48 <rossriley>	slick0: is a can-do person
Nov 18 05:31:49 <slick0>	gawainlynch: hehe, true
Nov 18 05:32:02 <carsonfull>	can-do what?
Nov 18 05:32:03 <Bopp>	brb, assigning all issues to slick0
Nov 18 05:32:16 <gawainlynch>	OK… SahAssar is in channel so let him catch up via logs :-)
Nov 18 05:32:29 <gawainlynch>	OK… rossriley stellar performance this last week
Nov 18 05:32:36 <Bopp>	#4202 for the lazy
Nov 18 05:32:37 <gawainlynch>	Anything pending now on your end?
Nov 18 05:32:37 -[BoltIssueBall]/#boltcms-	#4202 [open] [Tracker] Bolt 2.3 Release Blocking Issues https://github.com/bolt/bolt/issues/4202 
Nov 18 05:32:49 <gawainlynch>	4360 by the look
Nov 18 05:33:00 <rossriley>	yes, repeating fields work now
Nov 18 05:33:11 <rossriley>	I think rarila has sorted most of my js problems….
Nov 18 05:33:27 <Bopp>	is rarilaDroid2 present? 
Nov 18 05:33:37 <gawainlynch>	So just that… um… template fields thing then?
Nov 18 05:33:43 <rossriley>	yes
Nov 18 05:33:52 <rossriley>	and I volunteered for the upload path one too
Nov 18 05:34:10 <gawainlynch>	#3983 
Nov 18 05:34:10 <rossriley>	#3983
Nov 18 05:34:11 -[BoltIssueBall]/#boltcms-	#3983 [open] Fix hardcoded file upload paths (files/) https://github.com/bolt/bolt/issues/3983  — assigned to rossriley
Nov 18 05:34:11 -[BoltIssueBall]/#boltcms-	#3983 [open] Fix hardcoded file upload paths (files/) https://github.com/bolt/bolt/issues/3983  — assigned to rossriley
Nov 18 05:34:14 <gawainlynch>	Snap
Nov 18 05:34:35 <gawainlynch>	OK, so those two might well fall this next week then?
Nov 18 05:34:39 <rossriley>	yes
Nov 18 05:34:50 <gawainlynch>	OK… Bopp 
Nov 18 05:35:08 <Bopp>	that's me! 
Nov 18 05:35:09 <gawainlynch>	Also been a busy bee, mate
Nov 18 05:35:27 <gawainlynch>	#4281 seems to be the outstanding one
Nov 18 05:35:28 -[BoltIssueBall]/#boltcms-	#4281 [open] Extension's query dialogue break when no stable versions are available https://github.com/bolt/bolt/issues/4281  — assigned to bobdenotter
Nov 18 05:35:45 <Bopp>	Yes, I'm mainly busy with #4444, and some smaller bits
Nov 18 05:35:46 -[BoltIssueBall]/#boltcms-	#4444 [open] [Tracker] Missing functionality for widgets. https://github.com/bolt/bolt/issues/4444  — assigned to bobdenotter
Nov 18 05:36:18 <gawainlynch>	Should we bump 4281 to rarilaDroid2 then?
Nov 18 05:36:24 <Bopp>	And when i have time, i want to work with SahAssar to get the new theme beaten into shape :-)
Nov 18 05:36:42 <Bopp>	It's coming along nicely, but still needs some work. We'll get there. 
Nov 18 05:36:57 <Bopp>	that's it for me, at the moment
Nov 18 05:37:16 <gawainlynch>	Should we bump 4281 though?
Nov 18 05:37:30 <Bopp>	no, i'll fix that
Nov 18 05:37:35 <gawainlynch>	Ok
Nov 18 05:37:49 <gawainlynch>	carsonfull: You've got the most on your plate…
Nov 18 05:38:07 <gawainlynch>	carsonfull: How is FS coming along?
Nov 18 05:38:08 <carsonfull>	Believe me, it feels like it
Nov 18 05:38:25 <carsonfull>	Haven't touched it
Nov 18 05:38:33 <gawainlynch>	I know… we should take advantage of my time zone line up with yours and collaborate on some of this stuff again
Nov 18 05:38:42 <carsonfull>	Definitely
Nov 18 05:38:57 <gawainlynch>	#4108 should be easy… just need to know what you want done
Nov 18 05:38:58 -[BoltIssueBall]/#boltcms-	#4108 [open] Filter db tables (was Port #3949 to 2.3) https://github.com/bolt/bolt/issues/4108  — assigned to CarsonF
Nov 18 05:39:19 <gawainlynch>	The CSRF stuff though… I really need some help on if I am to tackle
Nov 18 05:39:36 <carsonfull>	You can take that if you want. I think my only thought (that differed from 2.2) is killing the db initialize method
Nov 18 05:39:45 <carsonfull>	which you may have already done
Nov 18 05:39:53 <gawainlynch>	Sort of… I think
Nov 18 05:39:58 <carsonfull>	Yeah I can help with CSRF
Nov 18 05:40:17 <carsonfull>	Well nope it's still there lol
Nov 18 05:40:26 <carsonfull>	That's really a separate issue though
Nov 18 05:40:28 <gawainlynch>	OK, let us pen in some time when you've finished work and get kicking
Nov 18 05:40:40 <gawainlynch>	rossriley: #2409 
Nov 18 05:40:40 -[BoltIssueBall]/#boltcms-	#2409 [open] Errors in search results front end https://github.com/bolt/bolt/issues/2409 
Nov 18 05:40:42 <carsonfull>	Can we make that a ticket?
Nov 18 05:41:02 <gawainlynch>	carsonfull: For which parts? There are already several
Nov 18 05:41:12 <carsonfull>	kill checkDatabaseConnection
Nov 18 05:41:17 <carsonfull>	App::
Nov 18 05:41:29 <Bopp>	i still think that issue is completely mislabeld. 
Nov 18 05:41:32 <gawainlynch>	carsonfull: Yeah, already tried… we need to rework exception handling
Nov 18 05:41:41 <carsonfull>	?
Nov 18 05:41:51 <carsonfull>	Shouldn't be a problem
Nov 18 05:41:57 <carsonfull>	Just an exception listener
Nov 18 05:42:01 <carsonfull>	new one
Nov 18 05:42:12 <Bopp>	it is _not_ an error or a bug, just a misunderstanding or representation of what's implemented. (the search one, that is)
Nov 18 05:42:16 <gawainlynch>	Yeah, tried with that other branch that nearly killed me… but I have a fresh head now
Nov 18 05:42:38 <gawainlynch>	Bopp: On 2409 agreed… just that rossriley had made some progress on that
Nov 18 05:43:06 <carsonfull>	gawainlynch: Let's try again, because it's wrong. GMO just overrides the function to do nothing.
Nov 18 05:43:19 <gawainlynch>	carsonfull: Agreed
Nov 18 05:43:36 <gawainlynch>	carsonfull: We'll talk it up later when you're off work
Nov 18 05:43:59 <gawainlynch>	OK… I think that's it then
Nov 18 05:44:10 <carsonfull>	Ok. But yeah that can be separate from the filter tables one. Which makes that basically the same as what was implemented for 2.2
Nov 18 05:44:47 <gawainlynch>	Bopp: Do you want to relabel/update 2409 as well?
Nov 18 05:45:22 <Bopp>	yes. I'll self-assign, and potentially kill it off and split into actionable parts. 
Nov 18 05:45:31 <gawainlynch>	#karma Bopp 
Nov 18 05:45:33 <[BoltIssueBall]>	BoltKarma for Bopp is now 191
Nov 18 05:46:04 <Bopp>	done
Nov 18 05:46:18 <slick0>	#karma Bopp 
Nov 18 05:46:20 <[BoltIssueBall]>	BoltKarma for Bopp is now 192
Nov 18 05:46:34 <gawainlynch>	carsonfull: OK so you and I can spend the next week hammering that DB/Session stuff and that should give the others space to clear their remainders and we'll check in say in 14 days and see how we're pinned for release
Nov 18 05:46:53 <carsonfull>	Ok
Nov 18 05:47:07 <Bopp>	i wouldn't mind doing 15 minutes again next week? 
Nov 18 05:47:19 <gawainlynch>	Bopp: Not a problem, I am on board with that
Nov 18 05:47:30 <gawainlynch>	rossriley & carsonfull?
Nov 18 05:47:35 <carsonfull>	Sure thing
Nov 18 05:47:54 >ChanServ<	op #boltcms gawainlynch 
Nov 18 05:47:55 *	ChanServ gives channel operator status to gawainlynch
Nov 18 05:48:08 *	gawainlynch has changed the topic to: Welcome to the Bolt CMS community | http://bolt.cm/ | Latest news: Bolt 2.2.13 stable released | Development branch feature frozen | Dev meeting November 24 @ 18:30 UTC
Nov 18 05:48:14 <Bopp>	This took literally 15 minutes, and i think it's a good way to get an overview of the status
Nov 18 05:48:33 <carsonfull>	Bolt's going agile :)
Nov 18 05:48:43 <gawainlynch>	Yep, agreed… I only went for 2 weeks to not capitalise on people's time… but I am totally on board with it
Nov 18 05:48:52 *	gawainlynch removes channel operator status from gawainlynch
Nov 18 05:49:11 <SahAssar2>	Oh shit, time flies when you're cooking food...
Nov 18 05:49:24 <Bopp>	:-D
Nov 18 05:49:31 <Bopp>	… and we're done!
Nov 18 05:49:31 <gawainlynch>	SahAssar2: While we have you… anything quickly you want to add?
Nov 18 05:49:59 <SahAssar2>	gawainlynch: Probably not, I'll just read to logs while stuffing my face with delicious carbonara :)
Nov 18 05:50:07 <gawainlynch>	+1
Nov 18 05:50:11 <gawainlynch>	</closed>
Nov 18 05:55:14 <rossriley>	on 2049….. 
Nov 18 05:56:48 <rossriley>	the new search code should help to improve that, but the downside is I don’t think it’s going to be implemented in 2.3
Nov 18 05:57:20 <gawainlynch>	rossriley: No stress… just wanted to get it on the table
Nov 18 06:03:10 <rossriley>	ok, sorry was just reading up on the last PR i did for search...
Nov 18 06:04:26 <rossriley>	the code is there, maybe we could hook up the search on the fronted to use the new code and see how it performs
Nov 18 06:04:47 <gawainlynch>	rossriley: Thing is… do we really want to for 2.3?
Nov 18 06:05:20 <gawainlynch>	Not objecting, just cautious about the amount of exposure we already have
Nov 18 06:05:34 <rossriley>	that was what I was unsure about… it’s ready, it passes the tests, but it’s another thing that needs real-world testing etc
Nov 18 06:05:49 <gawainlynch>	Ah
Nov 18 06:06:05 <gawainlynch>	How hard is it to switch on/off?
Nov 18 06:06:34 <gawainlynch>	Thought being maybe run with it into beta, and if too much comes up, revert
Nov 18 06:07:13 <gawainlynch>	But also, as you said, it passes tests… and no koalas were involved in the making of those tests 
Nov 18 06:09:01 <rossriley>	ha.. tests are certified koala free
Nov 18 06:09:09 <gawainlynch>	:)
Nov 18 06:09:33 <gawainlynch>	Bopp: Are you here or FO4-ing?
Nov 18 06:09:40 <Bopp>	here
Nov 18 06:09:48 <gawainlynch>	What's your thought?
Nov 18 06:10:38 <rossriley>	i think, we should boot it to 2.4, but try and make 2.4 follow very soon after 2.3
Nov 18 06:10:48 <Bopp>	yes, that
Nov 18 06:10:53 <Bopp>	it's hardly broken now. 
Nov 18 06:10:56 <gawainlynch>	Actually… while we're on that
Nov 18 06:11:03 <Bopp>	and we need to get out 2.3
Nov 18 06:11:07 <gawainlynch>	We have some issues with SF3
Nov 18 06:11:19 <gawainlynch>	Namely… Codeception
Nov 18 06:11:50 <rossriley>	what’s everyone’s thoughts on having experimental feature toggles, because it would be ideal for that… I just worry that because search is so subjective, we might push something that feels wrong for people on a minor upgrade
Nov 18 06:12:01 <gawainlynch>	The acceptance tests will need to be moved away from it, preferably to Symfony's functional tests
Nov 18 06:12:30 <gawainlynch>	rossriley: Yeah, Bopp and I had thrown the experimental flag around before… I like
Nov 18 06:12:36 <Bopp>	rossriley: I'm not a fan of adding extra config for stuff. 
Nov 18 06:13:10 <Bopp>	If we think it's better thn what we had, just put it in master, and roll with it
Nov 18 06:13:23 <gawainlynch>	Bopp: But more a deliberately undocumented way to turn things on/off
Nov 18 06:13:51 <gawainlynch>	Or that 
Nov 18 06:13:59 <Bopp>	This is not something i'm going to push hard against, I just don't see the value, compared to the extra overhead. 
Nov 18 06:14:16 <gawainlynch>	Fair point
Nov 18 06:14:26 <Bopp>	"We'll tell you which search to use, and you'll like it" 
Nov 18 06:14:33 <gawainlynch>	Haha
Nov 18 06:14:41 <gawainlynch>	Pick the Apple users
Nov 18 06:15:03 <Bopp>	and if people don't, they'll just make an extension to implement their own.. nobody's stopping you from doing that if you want to
Nov 18 06:16:25 <gawainlynch>	Also works for me