Skip to content

Dev meeting 2017 06 06

Jump to bottom
Gawain Lynch edited this page Jun 20, 2017 · 5 revisions

Agenda

e.g.

  • Status on drop bear invasion (@YourGitHubID)

Actionable Items

Outcomes

Log

19:29] 
gawainlynch ping @bob @carson @ross @sahassar

[19:29] 
sahassar Phonepong

[19:29] 
gawainlynch Laptop-pong

[19:30] 
carson Texas-pong


[19:31] 
gawainlynch OK, the other two are around somewhere, while waiting:
* [RFC] Symlink handling in core #6740

[19:31] 
boltissueball #6740 [open] [RFC] Symlink handling in core https://github.com/bolt/bolt/issues/6740

[19:31] 
bob
Pong!

[19:31] 
gawainlynch @carson I was hoping to hear a yes/no/go-away on that one … have you had a chance to think about it?

[19:32] 
@bob: 3.3 beta/release progress see tracker #6001

[19:32] 
boltissueball #6001 [open] [Tracker] Bolt 3.3 Release Blocking Issues https://github.com/bolt/bolt/issues/6001

[19:32] 
gawainlynch What's left … tracker is empty, everything I think is tagged

[19:32] 
bob
yes, but..

[19:32] 
ross Checking in

[19:33] 
bob
We should look closely over this: https://github.com/bolt/bolt/milestone/21

[19:33] 
Clean up: either close, fix or push forward

[19:33] 
gawainlynch Push

[19:33] 
carson None of those look like 3.3 blockers to me at this point

[19:33] 
bob
#5979 is one i'd like resolved, though

[19:33] 
boltissueball #5979 [open] [RFC] No way to re-trigger copying web assets for extensions.. https://github.com/bolt/bolt/issues/5979

[19:33] 
carson Not that they aren’t important

[19:34] 
`cp src target`

[19:34] 
gawainlynch Moved :wink:

[19:34] 
5979 is a bit (lot) harder than I thought with 3.3

[19:34] 
bob
Kidding aside, if #5979 is so easy to fix, can we please fix it?

[19:34] 
boltissueball #5979 [open] [RFC] No way to re-trigger copying web assets for extensions.. https://github.com/bolt/bolt/issues/5979

[19:34] 
bob
oh.

[19:35] 
gawainlynch Basically we'd need to create the Composer event for each one, and that is ugly/hacky (edited)

[19:36] 
So, revisit soon-ish … but lets get 3.3.0 out a.s.a.p :slightly_smiling_face:

[19:36] 
bob
ok. cool

[19:36] 
Want that too.

[19:36] 
gawainlynch What's blocking your work on that, anything?

[19:36] 
bob
I'm busy with monkey-testing and dogfooding

[19:37] 
gawainlynch :+1:

[19:37] 
OK, so leave you to it for the moment then?

[19:37] 
bob
And in the process bumping into issues like the jsonapi one.

[19:37] 
Think I found another like it, but need to investigate

[19:37] 
Other than that, wrapping up.

[19:38] 
we should be good to release soon.

[19:38] 
Document the upgrade process

[19:38] 
gawainlynch Yeah, I knew what I was looking for … I opened an issue the other day, only to get gently nudged by @carson that we weren't on Silex 2 yet :smile:

[19:38] 
bob
like the stupid `cache/development/data` thing

[19:38] 
carson ?

[19:38] 
gawainlynch ¿

[19:39] 
bob
update a site..

[19:39] 
site doesn't work,

[19:39] 
throws exception that `app/cache/development/data` doesn't exist or isn't writable

[19:39] 
gawainlynch So far, 100% of those have been early invocation of services

[19:39] 
ross That could be solved by excluding the delete of the subdirectories on cache clear

[19:39] 
bob
need to run app/nut cache:clear _twice_ and it works

[19:40] 
also, the infinite loop on login

[19:40] 
carson Can you open issues for those?

[19:41] 
bob
if you're coming from a 3.1 or 3.2 install _before_ the changes in session, you'll need to manually wipe cookies, or you're stuck in a loop

[19:41] 
@carson: Gladly, but I can't reproduce them in a clean way, so i didn't do that yet.

[19:42] 
carson Well you are bringing them up as things to address so… :wink:

[19:42] 
bob
.. plus uncertainty whether it was an error on my end, or a know quirk or whatnot

[19:42] 
gawainlynch I spent the last couple of days starting on clean 3.2 installs and updating to 3.3 *without* that problem

[19:43] 
Not doubting, but a test case would really help (edited)

[19:43] 
bob
@gawainlynch ok, that's good to know. I'll spend more time working _with_ bolt 3.3 this week, and will open issues if i still bump into anything

[19:43] 
gawainlynch :+1:

[19:44] 
bob
@gawainlynch That's the hard part.. I have this weird behaviour.. I fix it by mashing buttons on the keyboard.. and then I can reproduce reliably often.

[19:44] 
gawainlynch Yeah, if we can track down a test case … more than happy to xdebug the life out of it :slightly_smiling_face:

[19:44] 
bob
I know, getting the test case is the hard part.

[19:44] 
gawainlynch Yeah, tell me about it

[19:45] 
OK, next … mainly for @carson — [PR][Docs] Bolt 3.3+ Amazon S3 Remote Filesystem https://github.com/bolt/docs/pull/740

[19:45] 
carson Yeah it’s on my list

[19:45] 
gawainlynch :+1:

[19:45] 
* [PR] Symfony 3 & Silex 2 project filesystem layout #6739

[19:45] 
boltissueball #6739 [open] [4.0] Phase I: Symfony 3 & Silex 2 project filesystem layout https://github.com/bolt/bolt/pull/6739

[19:45] 
gawainlynch Gentle nudges :wink:

[19:46] 
@ross — [PR] Allow opt in to new setcontent queries #6622

[19:46] 
boltissueball #6622 [open] Allow opt in to new setcontent queries https://github.com/bolt/bolt/pull/6622

[19:46] 
gawainlynch Is that one of the ones waiting on my config work, or your free time?

[19:46] 
bob
I'm fine with the Bolt 4.0 PR's, but i'd rather leave them for someone else to review and merge in.

[19:47] 
gawainlynch No stress, but I am trying to keep my backlog of open PRs manageable, so I don't overload ATM

[19:48] 
ross I'm just not sure on the problem with laziness on #6622

[19:48] 
boltissueball #6622 [open] Allow opt in to new setcontent queries https://github.com/bolt/bolt/pull/6622

[19:48] 
gawainlynch Ah

[19:48] 
ross Need to get an idea of what the problem is and how we can fix

[19:49] 
carson @ross you don’t understand what I commented?

[19:50] 
ross Carson no about whether to use `storage` or the lazy version

[19:52] 
carson Ok previously we had `BoltExtension::getStorage()->getContent()`. Now you added `BoltExtension::getQueryEngine()->getContent()`. Since both objects have the getContent method just do your conditional in getStorage.

[19:53] 
public function getStorage()
{
    return $new ? $this->queryEngine : $this->em;
}

[19:53] 
Then you can drop all the twig node and token parser changes

[19:54] 
ross ok, I can do that for now, I was thinking that in the 3.4/3.5 cycle we might want to tweak the node behaviour too, so that's why I did it that way

[19:54] 
gawainlynch The extension loads with the lazy EntityManager … can we use the runtime instead, as that isn't invoked during registration?

[19:56] 
carson Well I guess it can wait until then :wink:

[19:56] 
gawainlynch As in hold off on the PR, Carson?

[19:57] 
carson I think whatever changes you want to make could still be done in a DRY-er way

[19:58] 
ross I'll change it for now, no hassle

[19:58] 
if we need any more changes it can be a separate pr

[19:58] 
carson Thanks Ross

[19:58] 
gawainlynch :+1:

[19:59] 
carson I don’t think bob and I agreed with the version number either

[19:59] 
bob
@carson the version number how exactly?

[20:00] 
carson Your comment on the PR

[20:00] 
gawainlynch Integer instead of semantic text

[20:00] 
bob
Oh, that one!

[20:00] 
gawainlynch I'm with Ross & Carson … I think it's fine, personally, for the reasons that Carson argues in that thread

[20:01] 
…I just didn't read it properly the first time

[20:01] 
bob
Yeah, but it's not that important to me.. If the consensus is one way, i'll happily concede

[20:01] 
gawainlynch Last one … @carson I take it you have #6726 on your TODO list, and I should be patient, 'cause overloaded Carson is overloaded?

[20:01] 
boltissueball #6726 [open] [4.0] Silex 2 … and WebLink https://github.com/bolt/bolt/pull/6726

[20:02] 
carson Wait I'm with Bob not Ross on that one.

[20:02] 
gawainlynch Oh, you mean a boolean?

[20:02] 
carson Yeah

[20:02] 
gawainlynch WFM2 :+1:

[20:03] 
carson I do. And it’s for 4.0 so it’s at the bottom of my list

[20:03] 
gawainlynch OK, just an FYI we're about to run into a lot of blockers with versions

[20:03] 
carson Hmm?

[20:04] 
gawainlynch SF 3.3 stuff

[20:04] 
It's all over the place :confused:

[20:04] 
But yeah, other things first

[20:04] 
carson You mean changes for 4.0?

[20:04] 
gawainlynch Yeah … hence your point

[20:04] 
carson I don’t care if master is broken lol

[20:05] 
gawainlynch I do, I want to keep working on it, and keep it moving

[20:05] 
carson I agree. But there are other things in the way just to get to master

[20:06] 
gawainlynch Understand, just trying to flag to not perma-push it to the bottom of the list :slightly_smiling_face:

[20:06] 
carson I know you want to keep working on it. But I want to get things resolved for 3.x so we can drop the bad code in 4.0. So it’s just a low priority for me

[20:06] 
Soon :tm:  :wink:

[20:06] 
gawainlynch Well, that is also part of my aim … it starts giving us a more solid base to aim for, and understand

[20:07] 
But yeah, zero stress … as I said "flag" :slightly_smiling_face:

[20:07] 
OK, let's call it then

[20:07] 
#meeting

[20:07] 
boltissueball </meeting> Failed parsing XML: 'hug' expected, No 'love' shown for bot. Program 'meeting' terminated.
Clone this wiki locally