Dev meeting 2017 01 24

Agenda

• PR review (@GawainLynch):
  • Modded core's select field to accommodate for multiple contenttypes. #6270
  • Allow to use environment variable to change configuration settings #6275
  • Fixes of Type Hinting in Bolt\Storage\Query namespace #6259
  • Adapted searchSingleContentType() to allow status = ... to be passed as a filter #6163
• Bolt 3.3 beta status (@Bob)
• New installer testing https://github.com/GawainLynch/installer and what is in/out, e.g.:
  • Demo
  • LTS versions

e.g.

• Status on drop bear invasion (@YourGitHubID)

Actionable Items

Outcomes

Log

<gawainlynch> ping Bopp carsonfull gawainlynch rarila rossriley SahAssar slick0_ rixbeck
<rarila> Shimmer and Shine party this weekened
<rarila> *PENG*
<gawainlynch> I can imagine!
<Bopp> pongk
<rossriley> hello
<gawainlynch> OK … I know carsonfull is around, hopefully coming in soon … so let's roll
<gawainlynch> * Bolt 3.3 beta status (@Bob)
<Bopp> Ok! 
<gawainlynch> Over to you, :hamster: :-)
<Bopp> I am STILL the bottleneck, mea culpa
<gawainlynch> Bopp: I wouldn't say it is your fault … things are pretty crazy IRL …
<Bopp> There's light at the end of the tunnel, as i'm wrapping up the first stages of two larger projects at work
<gawainlynch> What are your blockers?
<gawainlynch> (non RL)
<Bopp> My blockers are "blogposting" and "a few hours" :-)
<gawainlynch> OK, so in process :)
<gawainlynch> We have a few PRs to go over, rossriley: Fixes of Type Hinting in Bolt\Storage\Query namespace #6259
-[BoltIssueBall]/#boltcms- #6259 [open] Fixes of Type Hinting in Bolt\Storage\Query namespace https://github.com/bolt/bolt/pull/6259 
<Bopp> so, we're all good for beta 3, and especially after Carson's bughunt this week, i feel we're doing well.
<gawainlynch> Have you had a chance to look at that? i.e. amd I wrong and Adam correct?
<rossriley> in principle they look ok, but I do agree we shouldn’t add the array typehint on a stable branch
<gawainlynch> OK, well given the lack of other feedback to reject, I'll massage and get it into 3.3 later
<rossriley> although I guess if that’s into 3.4 then that does give us a couple of cycles to test
<gawainlynch> * Adapted searchSingleContentType() to allow status = ... to be passed as a filter #6163
-[BoltIssueBall]/#boltcms- #6163 [open] Adapted searchSingleContentType() to allow status = ... to be passed as a filter https://github.com/bolt/bolt/pull/6163  — assigned to rossriley
<gawainlynch> Mainly … we bumped that one … but "what to do next"?
<gawainlynch> I'd like to clean up our PR queue as much as we can
<rossriley> I don’t see a problem with that one TBH
<carsonfull> present
<gawainlynch> Yo!
<Bopp> hey carsonfull
<rossriley> I’ve already put in the PR to allow status in the new storage engine….
<gawainlynch> rossriley: Well, the call was to bump it from legacy … but we don't really have a clear indidation on where to go next
<gawainlynch> rossriley: 6163 you mean?
<rossriley> yes
<gawainlynch> I don't see that comment, did you or I nuke it?
<gawainlynch> Oh wait, and I derping and you mean that you completed it in another PR?
<rossriley> I’ll add something to the PR as far as I know you can do $app[‘query’]->getContent(‘pages/search’) and manually add any parameters you like
<gawainlynch> WFM
<gawainlynch> * Allow to use environment variable to change configuration settings #6275
-[BoltIssueBall]/#boltcms- #6275 [open] Allow to use environment variable to change configuration settings https://github.com/bolt/bolt/pull/6275 
<gawainlynch> Not really feeling "comfy" with that one, other thoughts?
<carsonfull> Me eitehr
<rossriley> I personally don’t like the approach of that one
<rossriley> but it would be good to provide a more user-friendly way to get the same effect
<gawainlynch> OK, so wrto that PR, reject?
<carsonfull> Yeah reject that one.
<gawainlynch> +1
<carsonfull> It's just short sighted
<gawainlynch> Last PR to go over: * Modded core's select field to accommodate for multiple contenttypes. #6270
-[BoltIssueBall]/#boltcms- #6270 [open] Modded core's select field to accommodate for multiple contenttypes. https://github.com/bolt/bolt/pull/6270 
<carsonfull> Open to the idea after config refactor
<gawainlynch> I really hoped SahAssar could be here for that one, 
<gawainlynch> (6270 that is)
<rossriley> I’m +1 for that one...
<gawainlynch> I get where those two are trying to go with it, but feels more v4
<gawainlynch> Bopp & carsonfull?
<carsonfull> I don't understand it enough to give input
<gawainlynch> Zero stress
<gawainlynch> Bopp has gone to the fridge for a fresh #beer I think … while we wait …
* [BoltIssueBall] $this->app['bartender']->setDrink('beer')->setTab('gawainlynch')->serveAll();
<Bopp> oh, sorry. 
<Bopp> am here
<Bopp> I'm all for it, if it doesn't break BC
<rossriley> we’ve added support to getContent for multiple contenttypes so I think if we allow contenttype selects then it should support multiple
<Bopp> .. or if it would get us in troulbe in later 3.x work
<Bopp> more 3.4 than 3.3 though
<gawainlynch> Took the word from my mouth then, Bopp 
<rossriley> and with the new field system we can switch behaviour depending on config, we already switch between Type\Select and Type\SelectMultiple 
<rossriley> but yes 3.4 definitely
<rossriley> new feature
<gawainlynch> OK, that gives me enough to go on
<gawainlynch> Last one from the agenda list:
<gawainlynch> New installer testing https://github.com/GawainLynch/installer and what is in/out, e.g.:
<gawainlynch> Demo
<gawainlynch> LTS versions
<Bopp> Yes, it's awesome, 
<Bopp> at least from the 5 minutes i've toyed with it
<Bopp> I'll get on it to make it look nice. 
<gawainlynch> This is totally non-urgent … but it would be good for those that deal with novice group to have a look and give feedback on dialogues etc
<gawainlynch> There is still some Symfony based stuff in there, but I suck at UX
<gawainlynch> OK … flagged 
<gawainlynch> Anyone have things to raise?
<rossriley> one other thing...
<rossriley> adding explicit DB versions to the requirements
<gawainlynch> Namely PostgreSQL
<gawainlynch> +1
<Bopp> Sure, +1
<rossriley> yes, but I think we should do the others too, just to be clear
<rossriley> I’ve pushed some stuff into 3.3 that requires Postgres 9.1+
<[BoltGitHubBot]> [bolt] GawainLynch closed pull request #6270: Modded core's select field to accommodate for multiple contenttypes. (release/3.4...feature__select-multiple-contenttypes) https://git.io/vMXwg
<gawainlynch> Yeah, and things might get sticky too with the MySQL/MariaDB slpit 
<gawainlynch> *split 
<Bopp> It'd be OK to list them, but personally i've never bumped into DB issues because of "old mysql" or "old sqlite" 
<rossriley> so Bopp, can you mention that when you write the release for 3.3
<gawainlynch> You probably won't yet
<rossriley> just in case anyone has a very old version and wants to upgrade
<Bopp> rossriley: sure. 
<gawainlynch> DBAL handles *most* of it for us
<gawainlynch> …just not all
<Bopp> What versions should we use as baseline for sqlite and mysql/maria?
<gawainlynch> MySQL 7 & Sqlite 5 
<gawainlynch> (PHP 6 joke wrapped up in there)
<Bopp> ಠ_ಠ 
<gawainlynch> OK, nothing more from me … we're good then?
<Bopp> yes, 
<Bopp> i'd like some quasi-serious guesstimates for baseline mysql / sqlite versions
<gawainlynch> 5.5 & 3
<Bopp> just "3" ? 
<gawainlynch> Sqlite doesn't SemVer
<Bopp> ok. 
<gawainlynch> In that case </meeting>