Dev meeting 2017 04 04

Agenda

• {{ app }} -> {{ global }}. What's the plan? What will and what will not be moved over? (@BobdenOtter)
• 3.3 Public Beta progress see tracker #6001 (@BobdenOtter)

e.g.

• Status on drop bear invasion (@YourGitHubID)

Actionable Items

Outcomes

Log

19:31]
bob twiddles thumbs.

[19:32]
bob @channel 🔔 Meeting time! 🔔

[19:32]
gawainlynch was busy addressing a Texas style storm

[19:32]
carson 😄

[19:32]
gawainlynch Off you go then

[19:32]
bob euhm.. ok.

[19:33]
So, things you need to take care of? or meeting as planned?

[19:33]
gawainlynch No, I was giving you a nudge … but let's roll then

[19:33]
bob 🙂

[19:33]
gawainlynch 3.3-beta

[19:33]
Where's we at people?

[19:34]
bob Extra-nudge for @ross and @sahassar 😉

[19:34]
#6001

[19:34]
boltissueball #6001 [open] [Tracker] Bolt 3.3 Release Blocking Issues https://github.com/bolt/bolt/issues/6001

[19:34]
bob That one should be up to date.

[19:34]
Unfortunately for Carson, most things have his name on it, still

[19:35]
carson Yeah, sorry I’ve been busy with RL lately

[19:36]
Hoping to finish them in the next few days

[19:36]
gawainlynch I should be able to give him a bit of a hand next week

[19:36]
bob Yeah.. Please know i'm not trying to place blame or anything, carson 🙂

[19:36]
gawainlynch I am! Carson, it is all your fault! 😛

[19:36]
carson Understood 🙂

[19:36]
bob I have some docs to work on, but work-work has been killing.

[19:37]
gawainlynch … and nobody has told me today 😉

[19:37]
carson I worry the most about docs honestly

[19:37]
gawainlynch I have some docs coming, but want to get you to look first carson is poss.

[19:38]
OK, does anyone … not at the pub … have anything to raise?

[19:38]
bob yes

[19:38]
https://github.com/bolt/bolt/wiki/Dev-meeting-2017-04-04

[19:38]
cough

[19:39]

{{ app }} -> {{ global }}. What's the plan? What will and what will not be moved over? (@BobdenOtter)

[19:39]
gawainlynch You and your last minute agenda updates 😄 (edited)

[19:39]
bob dude, it was 19 minutes ago. 😉

[19:39]
carson global is not a Silex\Application

[19:40]
bob anyhow, I saw Carson mention today that we should use {{ global.request }} instead of {{ app.request }}.

[19:40]
carson Only request, debug, session, environment, user, and security can be there

[19:40]
bob So, i suppose {{ global.db.query('DROP TABLE bolt_users;') }} is out of the question?

[19:41]
carson Yes

[19:41]
bob Kidding aside, can we put record, records, page and similar in there?

[19:41]
carson No

[19:41]
bob Since in Twig 2 we can't set them globally,

[19:41]
and we need to have them somewhere.

[19:41]
carson They just need to be moved to the template context

[19:42]
They don’t need to be globals, and shouldn’t be either

[19:43]
I’m working on that too

[19:43]
But depends on the compatibility flag discussion

[19:43]
bob I have a few extensions,

[19:43]
where you can pass in a "record" to do something with it,

[19:44]
or, if you don't, it acts on "The record", gleaned from the global scope.

[19:44]
How are we going to be doing that?

[19:44]
carson Not finalized, but I have a couple ideas.

[19:44]
bob https://github.com/bolt/bolt/blob/release/3.3/src/Twig/Runtime/RecordRuntime.php#L155-L159

[19:45]
^ for example

[19:45]
carson Is that the fields() function?

[19:45]
bob yes

[19:45]
carson Yeah that’s what’s slowing me down right now lol

[19:45]
bob But, for example SEO uses it too

[19:46]
carson Yes, yes I know how your extensions do it

[19:46]
bob Why not just add record to globals, though? That seems like it would make your pain go away?

[19:46]
carson It’s not a global

[19:46]
It’s specific to the current request

[19:47]
bob .. as is global.request

[19:47]
carson That’s pulled from the RequestStack

[19:47]
We could have something similar to a ContentStack

[19:47]
bob Seems like adding complexity.

[19:48]
What about config? {{ app.config.get('foo') }} ?

[19:48]
carson It does usually take more code to make things less hacky, yes.

[19:48]
config is already a global

[19:49]
bob It's not just "more code", it's also "more things to remember for users" and "more docs that need writing" and ultimately "more people needing support"

[19:49]
carson That all depends on how it’s implemented.

[19:49]
bob So, {{ config.get('foo') }} would work?

[19:49]
carson Yes

[19:49]
bob Ok.

[19:50]
gawainlynch OK, so for now … onward and let's get 3.3 out this year

[19:50]
bob I know you're (we all) doing these things to make the code better, i'm just staying critical to make sure that we can also still use it.

[19:51]
carson I understand that. I don’t want to make things hard to use either

[19:51]
bob Ok, good to hear. 🙂

[19:52]
gawainlynch It's all part of why we're working the way we are to get as much covered, so that when we cut over there is less/none to do

[19:52]
carson I don’t think $env->getGlobals()['record'] is documented either

[19:53]
bob Doesn't look familiar, so I guess not. 🙂

[19:53]
carson That’s what you coded in your extensions

[19:53]
And that’s what is changing

[19:54]
Users can still access {{ record }} in templates

[19:55]
bob carson yes, that's because we set it where it should be used (namely the record route)

[19:55]
Oh, like that.

[19:56]
Yeah, that's just from the Twig docs.

[19:56]
carson Ok we are on a rabbit trail. We can talk more once PR is up

[19:57]
gawainlynch 👍

[19:57]
bob And I think it's not "getGlobals" that's deprecated, but setting globals after initialisation.

[19:57]
but yeah, if you have a PR, and stuff still works, i'm fine. (edited)

[19:57]
carson Correct $env->getGlobals()['foo'] is fine.

[19:57]
The problem is record is specific to the current request (edited)

[19:57]
bob it is, but it's useless if you can't set anything in it

[19:58]
carson We do lol. config is there

[19:58]
Because config doesn’t change with the current request.

[19:58]
bob right.

[19:59]
I'll wait patiently for the PR, and I'm sure it'll make sense to me then. 😉

[19:59]
carson Ok sounds good 👍

[20:00]
gawainlynch #meeting

[20:00]
boltissueball Failed parsing XML: 'hug' expected, No 'love' shown for bot. Program 'meeting' terminated.