Merge Hdrp/staging #1917

…se are clipped (#1490)

Fix case 1264632 - HDRP Lit comes with Coat Mask in the stack, which is disabled by default

* Fix SceneEV100 RTHandle and add a shadow to text * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Added a new debug mode for cluster visualization where we visualize a slice instead of opaque objects. * Update changelog

* Set atlas viewport before softness in request is set * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…d Scene is disabled (#1504) * Create emissive mesh if not created but is requested. * Changelog * Remove unnecessary create function call Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

… they were not (#1509) * Prevent OnEnable probes to be marked as rendered if actually they were not rendered. * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Avoid the sun icon to be cut * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…1506) * Don't actually set the game object -1 as layer * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…ositor .asset file (#1499) * Do not allow manual edit/reset of values in the compositor profile .asset file * Also disable edits on already existing compositor .asset files * Fix issue when the user deletes the composition graph or .asset in runtime * Rename function name Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…#1489) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix flickering layer in graphics compositor * Revert unintentional changes in the HDRenderPipeline file * Proper fix after more tests * Avoiding cloning children attached to the layer camera Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Don't update legacy shape with HDRP vals for discs * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Various doc fix * Added Volume snippet and filled out a few properties * Added .md extension to internal docs link not in toc * Update documentation Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>

* Fix issues with texture atlas always updating * Clean a bit * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Motion blur with alembic animation

…ed-velocity Added precomputed velocity test

… into HDRP/staging # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md

…ras in HDRP [Depends on C++] (#1098) * Fix an issue where world space UI was not emitted for reflection cameras in HDRP * Update changelog * Added proper ifdef for 2020.2

…exture cookies update. (#1527) * Fixed the update condition of cookie atlas and added doc for render texture cookies update. * Update changelog * Update doc based on review feedback

* Updated doc for the newly added debug mode for cluster display. * Fix from review feedback

…hen changing the default lookdev volume profile. (#1529) * Fixed an issue where only one of the two lookdev views would update when changing the default lookdev volume profile. * Update changelog

…ceneView (#1570)

* Fixed a bug related to light cluster invalidation * unnecessary allocation removed Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>

…parametrizations values

* Added ray traced reflection support for the render graph version of the pipeline. Enabled the reflection tests for the render graph variant. * Added render graph support of RTAO and required denoisers. * Added render graph support of RTGI. * Supporting RTSSS and Recursive Rendering in the rendergraph mode. Enabling RR, RTSSS and other tests for render graph. * Supporting RT and screen space shadow for render graph Enabling the remaining dxr (non-pt) tests * adressing review corrections * Removing some unwanted memory allocations * unwanted params * nullref fix

… into HDRP/staging

* Implementation of custom post processes in render graph * Fixed input depth for DoF with Render Graph * Re-enabled 8103 for render graph. * Fixed depth clear in RG * Fixed post process history reset with RG * Added exposure debug to render graph

…er-parametrization Hdrp/fix/terrain layer parametrization

* Enable AOV API at runtime * Add an info message to say that it is required to enable runtime AOV API * fix indent * Fix issue with AOV depth buffer export * Update CHANGELOG.md * rename DebugRemap to DebugDepthRemap * update rendegraph * Update HDProfileId.cs * update documentation based on feedback

* Shadow doc update * Small change. * Another small change. * PR comments * Removed links to github Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>

* Check if we need to update the texture if it has been already cached. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

… probe is at same camera location (#1537) * Offset a bit reference position if it is exactly the same as proxy position. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Add macro helper * Add parenthesis

* HTile buffer removal * Changelog

* Supporting SSGI in the render graph mode. * review corrections Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

This reverts commit 96a28ae.

* Set empty cookie only for projectors and not cone spotlights * changelog * doc * Update Light-Component.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…e profile deleted (#1769) * Make sure we don't try to modify deleted stuff * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed custom pass re-ordering and removing after a change in trunk * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Small fixes to things that diverged from non render graph path. * VT for render graph implementation WIP * Fixed VT feedback debug in MSAA + cleanup + fix vtfeedback clear color * Fix compilation when VT is not enabled on the project. * Compilation fix * Fix custom pass * Fixed an assert in VTManager

…(QOL 1265297). (#1772) * Changed the way the ray tracing property is displayed on the material (QOL 1265297). * Update SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix issues with history sampling and hw dynamic res * changelog

* Sky lighting is no longer updated when the hash changed and the update mode is set to OnDemand or Realtime and hasn't passed the time threshold. * Added comment and fixed behavior of static sky. * Fixed ambient flickering when a planar is in the scene and a preview is rendered (case https://fogbugz.unity3d.com/f/cases/1269557/) * Added comment * Update changelog * Fixed GCAlloc * Update SkyManager.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…hes (case 1274508). (#1757) * - Fixed an error message trigerred when a mesh has more than 32 sub-meshes (case 1274508). * Add the warning message requested during review. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…1771) * Fixed RTGI getting noisy for grazying angle geometry (case 1266462). * Update documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Code work * Remove old doc * Add doc in new place * changelog * upgrade guide

* Fixed an issue with TAA history management on pssl. * forgot changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…eview. (#1792)

…nced mode (case 1270459). (#1745) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…le they shouldn't (case 1270537). (#1751) * Fixed screen space shadow option displayed on directional shadows while they shouldn't (case 1270537). * screen space shadow display Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…#1511) * Composition layers without any sub layers are now cleared to black * Bugfix for game view * Change clear color to transparent black Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…ics compositor (#1522) * Add proper handling of undo and redo action in graphics compositor * Remember the last selected item when closing the compositor window * Fix ArgumentOutOfRangeExcpetion after deleting layer Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…irtual textures and non-2D textures (#1530) * Avoid using virtual textures and non 2D textures as compositor layers * Typo Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…or setting it to None (#1549) * Fix issue when setting the composition graph to None in the graphics compositor * Changelog * Minor fixes * Fix ArgumentNullException when saving shader graphs after removing the compositor from the scene Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Moved runtime code for emissive mesh (case 1268379) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Change the profile every time the inspector is on * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…ral accumulation (#1569) * Bilateral aggressiveness * Update docs * Default change

* Reduce register pressure in area light eval. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* try explicit NaN check * Typo * Add comment * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Change group size for contact shadows (saves 1.1ms on PS4) * Changelog * Update comment. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…saves 0.2ms on PS4) and tiny motion blur optimization (#1700) * Small motion blur (0.05ms) opt and make sure distortion stencil works (0.3 with no distortion) * changelog * Remove early out entirely. * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…4ms) (#1725) * Disable coarse stencil for SSR * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* HTile buffer removal * Changelog * Remove all usage of HTileMask in decal code and shaders * fix compilation and update documentation for upgrade guide * Update Upgrading-from-2020.1-to-2020.2.md Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com>

Merged Disable Coarse stencil generation when it is not beneficial (saves 0.4ms) #1725

* Custom format * Fix another potential mismatch * Missing format diff * Make old function obsolete * Move enum to right place * Changelog * Update the call to create reflection probe format * Use configurable format for planar reflections too * Export 11-11-10 * Fix baked case? * Remove old wrong fix. * Update GlobalLightLoopSettings.cs * New ref images * Naming and docs * Update HDRP-Asset.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Depth offset initial scene * update depth offset scene, add dx11 reference image * fix depth offset scene guid * Add graphics test images for the rest of platforms * revert 1900_AlphaTest_SG_b.unity.meta * Update 1900_AlphaTest_SG_b.unity GUID

* Updated documentation of reflection probes * Added full stop * Fixed documentation * Update Reflection-Probe-Usage.md * Updated table of contents to point to new doc Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>

…GHT_LOOP (#1684) * Define Scalarize lightloop where needed. * Missed file * changelog * Remove define in Lightloop.hlsl * Move scalarization to shader variables * Remove unnecessary read first lane * Move to shadervar functions * Fix issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Make sure stencil is set at least once. * Add comment and skip SSR check * CHANGELOG

* Make post process and exposure not editable for reflection probes. * Changelog * fix

* Better tooltip * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Rename Visualize Cascades * Update docs

…sset. (#1816) Adding a test to cover that case. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* If SSS is on, we need to write to the spec lighting too. * Changelog * Fix for SSS being too bright when disabled in matcap mode. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Improving SSGI Filtering and fixing a blend issue with RTGI. * review correction * Update doc * Update screenshots

* Trackball update * Changelog

* update postprocess anti aliasing * postprocess antialiasing

…enshots (#1864) * fix screenshots test * fix for overflow in decal system * update reference screenshots

* Reduce G-Buffer storage requirements for anisotropic materials * Improve comment * Simplify further * Fix the seam * Comment * Comment * Changelog * Squeeze out some extra precision * Add a test scene with more complex anisotropic material setup * Add missing scene in build settings, and copy windx11 ref image to other APIs * Update 1213 references images * Update ref image again from yamato to check for instability Co-authored-by: Remy Maetz <remym@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Update detail map documentation * Correction and added image

* Don't toggle components if they are hidden in inspector or non editable * Changelog * Change flags to check Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Remove font warning messages * Only apply on dynamic fonts

* Add 64 bits optionnal check for DXR wizard (for DXR player) * Added changelog entry * Changed the check to a required one with a fix button * Change obsolete switch target function * Fix ordering to avoid breaking the resources group Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* AxF UI - Remove possibility to select main BRDF as BTF since it is unsupported (could be handy to show it if it was imported as such, but for now we safely ignore since importer doesn't produce a material with that mode selected) Also prevent compilation error even if selected. * AxF UI - Add a bit of tooltips (even if for some fields engine editor bug doesn't show them), group advanced surface inputs into their own foldable UI block, make clearer the tiling/offset vector meaning. * AxF UI - Remove UI parts that were moved into the main mapping section. * AxF - Update the documentation to reflect UI changes.

This reverts commit 56e2536.

* Fixed multiedition of framesettings (case 1270044) * Fixed UI for framesettings * Fixed subsurface scattering multiedition

* Skip copy on consoles * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Reset mip map and full screen mode when setting one another. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Shorten Density Volume Texture tool name * Updated import documentation * Updated the upgrade guide * typo * Rewrite text Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…nd (#1834) * Display stats as average over a second * Changelog * Wrong comment. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Immediate mode implementation (WIP) * Immediate mode implementation (WIP2 - Still some tests failing) * Revert wrong default value for immediate mode

* Don't use LOAD_TEXTURE2D_X as not possible on PS4 on RWTextureArrays * Changelog * Changing the second texture to be read-only Co-authored-by: Anis <anis@unity3d.com>

* Quad overdraw * Vertex density * doc * Auto assign register * Use other uav slots * depth test pixel displacement * Changed sliders range. Updated doc. Fixed viewport clipping for distant vertices * Reduced allocated rendertarget count Now allocates one fullscreen uav instead of three * Return RTHandle * Vulkan fix test * Proper Vulkan fix * Added 2 graphic tests * Update screenshots * Fix for unlit and tessellated shaders * Disable Metal. Fix XR. Update screenshots * Switch to RWStructuredBuffer * Bind compute buffer instead of texture * Fix alloc * Fix data usage for rendergraph * Disable new tests for rendergraph * Bind compute buffer instead of texture * Change uav register * Create dedicated fullscreen debug pass * Add pass to remaining shaders and SG * Use CoreUtils.DrawRendererList * Update screenshots * Disable quad overdraw on metal * Update doc * Workaround for another metal compiler bug Bug when accessing ShaderVariablesDebugDisplay cbuffer in tessellation stage * Try something else * At least now it compiles * Completely disable these modes on metal * ... * Update whats new and upgrade guide * rendergraph * Enable tests for rendegraph * Remove debug entry * Fixes for rendergraph lambda to static; fix with msaa Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…ion (#1479) * Rename Raytracing Node to Raytracing Quality * Update Upgrading-from-2020.1-to-2020.2.md * Update documentation * Update TableOfContents.md * Update SGNode-Raytracing-Quality.md * Update CHANGELOG.md * adress feedback * Rename files * Update RayTracingQualityNode.cs * Update com.unity.render-pipelines.high-definition/Documentation~/Scalability-Manual.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/Documentation~/Scalability-Manual.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/Documentation~/SGNode-Raytracing-Quality.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/Documentation~/Upgrading-from-2020.1-to-2020.2.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Update com.unity.render-pipelines.high-definition/Documentation~/TableOfContents.md Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> * Updated raytracing node in 1000_Indirect * renamed default/ optimized to default / raytraced * fix compilation * update doc and screenshot * Update SGLit_RaytracingKeyword_Emission.shadergraph * update the code properly * update meta file * Increase Raytracing Quality Keyword coverage for RT effects (#1587) * Raytracing quality test coverage update RR test, PT test, RT Shadow Test, Material Quality * Update Indirect scene + ref image * update test for new code Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 1000_RaytracingQualityKeyword_PathTracer_Default.unity * Updated test scenes - added emission to test RTGI - added refraction color to test RT color shadows - recreated graph * Checked the test renderGraph Compatible * Fix issue with unlit shader * Update the test to add unlit case * Update 1000_RaytracingQualityKeyword_MaterialQuality_Indirect.png * Update 803_SubSurfaceScatteringGlobalIllumination.unity Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com>

…d on the ambient occlusion component (QOL 1277999). (#1944)

* Add IES/Cookie Test * Add GI IES/Cookie Test * Add GI IES Test + Missing files * Add references images IES Cookies & Baking tests * Temp Disable Test * Enable one test * Add IES test + change threshold * Missing file * Fix spaceship demo & animated texture * Add changelog * Yamato crash fix: tentative (out of memory) split IES GI Test as 2 test. Yamato: "message: Progressive Lightmapper: GBuffer job skipped - out of memory." * Lighting Data * Tweak test 2107 for faster light baking * Update GI Baking parameter less intensity to avoid out of memory on Yamato * New Attempt to fix IES Test/Yamato * new push for Yamato * update windows vulkan screenshots with Yamato one * Update Metal/OSX ref image * Update 2010_IES_Cookies.png * change lightmap size from 1024 to 256 * update reference screenshots Co-authored-by: Remy Maetz <remym@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Planar blending and ux fix Fix planar reflection object in scene 2205 Remove invalid tests for planar reflections Added blending for planar reflections * Fix gizmo offset. Remove rotation inspector for planar * Correct fabric * Fix compilation errors * Updated doc * Init positionNDC for raytracing shaders * Update mac screenshot; Reorder SampleEnv new argument * Added new SampleEnv to upgrade guide; Added PosInput initializer for raytracing shaders * Update ShaderPassRaytracingIndirect.hlsl * Update ShaderPassRaytracingIndirect.hlsl Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Initial commit of light unit slider drawer * missing meta file * First pass slider + icon draw, rect management * Functionality for slider markers with tooltip, and light unit slider rects * Move drawing functionality into the light unit levels, to handle the placement of markers * Add the indentation disable scope * Horizontally clamp the markers onto the slider * Move to light unit directory and rename * Begin moving light unit values into a table * Move light unit slider values into tables and construct the slider with them * Swap in the updated icons from the light unit sheet. * Add slider thumb tooltip * Add tooltip formatting to display abbreviated level values * Add the light unit to the slider tooltips * Add missing meta file * Update editor resources for light unit icons * General cleanup of light unit slider functionality * Scale up the marker tooltip for easier disovery. Display caution value * Initial integration of light unit slider into light UI for light intensities. * Fix light unit marker clamping * Add to changelog * Initial implementation of exponential slider * Fill in the remaining light value tables, implement light unit slider descriptor, implement the exponential light unit slider * Fix the draw exposure slider to read from the exposure descriptor * Initial implementation of temperature slider * Switch to using indent scopes * Fix linear mapping from value range to slider range (account for < 0) * No markers for temperature slider * Initial integration of light unit temperature slider into HD light UI * Fix incorrect temperature tooltip * Add comments, comply with code standard, refactor light unit tooltip into static * Change the color temperature toggle into the popup dropdown * Refactor icon loading to support editor skinning (dark/light mode) * Move the final light unit icons into the main directory, and remove the old ones * Undo un-intentional push of assembly friending to local dev package * Fix marker colors with respect to editor theme * Initial implementation piecewise light unit slider * Add interactivity to piecewise slider * Ensure that the current function piece is being used when moving the slider * Handle the out of bounds piecewise slider case * Use the piecewise slider for all light intensity units and exposure * Improve light unit tooltip, improve caution icon quality * Initial integration of light unit slider into exposure volume component * Improve the drawing of slider in the exposure volume * Initial implementation of custom slider range distributions (for Lux). Change marker color * Change min exposure range to -5, and clamp the value to slider to 0-1 * Update Lux tooltips * Update exposure tooltips * Fix exposure slider to allow horizontal scrolling in the text field * Add clamp support for temperature slider * Update temperature icon to the one in the table * Add the above/below caution tooltip for exposure * Update lite theme color for markers * Square off the marker shape * Change the caution value to the upper limit of the value ranges * Enable filter/temperature mode by default for all lights * Initial refactor of light intensity slider to use lumens internally * Directly use vector range as key into the piece-wise function map * Simplify piece-wise function evaluation * String interpolation for tooltip * Implement various improvements to conform to code standards, add comments, better method names * Remove the abbreviation for light unit value tooltip, show the full thing * Improve the internal lumen conversion to properly handle spot reflector (keeping the slider constant between light unit) * Update changelog

* FXC creates bad code in eye shader * Changelog * Add comment

* Moved diffusion profile list to default settings * Updated upgrade guide * Updated changelog * Improved HDRP default settings window perf (~x5) and fix diffusion profile list not interactive Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Commits on Sep 18, 2020

Fixed custom pass utils api doc (#1927 )

alelievr committed Sep 18, 2020

Configuration menu

View commit details

Copy full SHA for edfcfc0

Browse repository at this point

Copy the full SHA

edfcfc0 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge Hdrp/staging #1917

Merge Hdrp/staging #1917

Commits on Aug 4, 2020

Commits on Aug 5, 2020

Commits on Aug 6, 2020

Commits on Aug 12, 2020

Commits on Aug 13, 2020

Commits on Aug 17, 2020

Commits on Aug 20, 2020

Commits on Aug 24, 2020

Commits on Aug 25, 2020

Commits on Aug 26, 2020

Commits on Aug 31, 2020

Commits on Sep 1, 2020

Commits on Sep 2, 2020

Commits on Sep 3, 2020

Commits on Sep 4, 2020

Commits on Sep 7, 2020

Commits on Sep 8, 2020

Commits on Sep 9, 2020

Commits on Sep 10, 2020

Commits on Sep 11, 2020

Commits on Sep 14, 2020

Commits on Sep 15, 2020

Commits on Sep 16, 2020

Commits on Sep 17, 2020

Commits on Sep 18, 2020

Commits on Sep 21, 2020

Commits on Sep 22, 2020

Commits on Sep 23, 2020

Commits on Sep 24, 2020