chore: Release v1.4.0 #6257
Merged
chore: Release v1.4.0 #6257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restrict unverified user from making free orders. * Check ticket-type rather than payment-mode * No need to revert the old PR * Check if order contains all free tickets. * Required changes
Refactored code to reduce nesting
* add the resend email route * resend emails using ticket route * handle errors with UnprocessableEntry * modify order to user key
Updates the requirements on [sqlalchemy-utils](https://github.com/kvesteri/sqlalchemy-utils) to permit the latest version. - [Release notes](https://github.com/kvesteri/sqlalchemy-utils/releases) - [Changelog](https://github.com/kvesteri/sqlalchemy-utils/blob/master/CHANGES.rst) - [Commits](kvesteri/sqlalchemy-utils@0.34.0...0.34.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
This reverts commit a258111.
* handle padding error * catch specific base64 error
…6217) Updates the requirements on [apscheduler](https://github.com/agronholm/apscheduler) to permit the latest version. - [Release notes](https://github.com/agronholm/apscheduler/releases) - [Changelog](https://github.com/agronholm/apscheduler/blob/master/docs/versionhistory.rst) - [Commits](agronholm/apscheduler@v3.6.0...v3.6.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
__sudo: required__ no longer is. The __sudo__ command is now always available in Travis CI and there is no way to turn it off.
> if data['state'] is not 'draft' or not 'pending':
The second half of this if statement is __always__ False because __python -c "print(not 'pending')"__ # --> False
The correct ways to write this line are:
```python
if data['state'] != 'draft' or data['state'] != 'pending':
# or better yet...
if data['state'] not in ('draft', 'pending'):
```
Shifted test to unit dir Added tabs
Updates the requirements on [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) to permit the latest version. - [Release notes](https://github.com/sqlalchemy/sqlalchemy/releases) - [Changelog](https://github.com/sqlalchemy/sqlalchemy/blob/master/CHANGES) - [Commits](https://github.com/sqlalchemy/sqlalchemy/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
changed the tag from `Yes` to `-` closes #6185
fixes hound issue adds an event field to the function
Correct usage of func Add missing SMTP parameter
houndci-bot
reviewed
Jul 30, 2019
| self.assertFalse(represents_int('test')) | ||
|
|
||
|
|
||
| def test_string_empty(self): |
| EventSubTopicRelationshipRequired, EventSubTopicRelationshipOptional | ||
| from app.api.event_topics import EventTopicList, EventTopicDetail, EventTopicRelationship | ||
| from app.api.event_types import EventTypeList, EventTypeDetail, EventTypeRelationship | ||
| from app.api.events import EventList, EventDetail, EventRelationship, EventCopyResource |
There was a problem hiding this comment.
'app.api.events.EventCopyResource' imported but unused
Codecov Report
@@ Coverage Diff @@
## master #6257 +/- ##
==========================================
- Coverage 66.13% 65.84% -0.29%
==========================================
Files 288 286 -2
Lines 14479 14501 +22
==========================================
- Hits 9575 9548 -27
- Misses 4904 4953 +49
Continue to review full report at Codecov.
|
shreyanshdwivedi
approved these changes
Jul 30, 2019
mrsaicharan1
approved these changes
Jul 30, 2019
uds5501
approved these changes
Jul 30, 2019
iamareebjamal
changed the title
iamareebjamal
added a commit
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.