Skip to content

[ExecuTorch][WebGPU] Port 10 unary activations to the WebGPU backend#21154

Open
JCNTH wants to merge 1 commit into
gh/JCNTH/114/basefrom
gh/JCNTH/114/head
Open

[ExecuTorch][WebGPU] Port 10 unary activations to the WebGPU backend#21154
JCNTH wants to merge 1 commit into
gh/JCNTH/114/basefrom
gh/JCNTH/114/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Ports the Vulkan delegate's no-param unary activations — abs, exp, sqrt, rsqrt, sin, cos, tanh, round, neg, hardswish — built on the shared add_unary_op helper. Each is a per-op .wgsl (2D-fold dispatch, wg_size=256) whose body mirrors the Vulkan formula in backends/vulkan/runtime/graph/ops/glsl/unary_op.yaml + activations.h verbatim, registered through runtime/ops/unary/Activations.cpp.

Key changes:

  • runtime/ops/unary/{abs,exp,sqrt,rsqrt,sin,cos,tanh,round,neg,hardswish}.wgsl (+ generated _wgsl.h) — output[idx] = <vulkan-math>; notably rsqrt = 1.0 / sqrt(x), tanh = tanh(clamp(x, -15.0, 15.0)), hardswish = the piecewise select.
  • runtime/ops/unary/Activations.cpp — registers aten.<op>.default for the 10 ops, each calling the shared add_unary_op.
  • CMakeLists.txtruntime/ops/unary/Activations.cpp in WEBGPU_SRCS.

tan and hardsigmoid are intentionally excluded: the Vulkan partitioner (backends/vulkan/op_registry.py) does not tag them, so they cannot be delegated to this backend without a separate partitioner change.

Differential Revision: D112257637

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21154

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Unrelated Failures

As of commit 510a256 with merge base 266e0dc (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jul 22, 2026
@JCNTH
JCNTH requested a review from psiddh July 23, 2026 02:11

@psiddh psiddh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving full WebGPU stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants