[ExecuTorch][WebGPU] Op-tests for q8ta_relu#21194
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21194
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 32 New Failures, 3 Unrelated FailuresAs of commit 6e241f4 with merge base 266e0dc ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
psiddh
left a comment
There was a problem hiding this comment.
Approving full WebGPU stack
Stack from ghstack (oldest at bottom):
Problem: The new
q8ta_reluint8 op needs golden coverage; themax(x, 0)relu term must be pinned.Solution: A
q8ta_relusuite goldens the kernel byte-exact against the CPU eager op with the int8 input as a baked constant, plus an export-delegation smoke test.Implementation:
cases.pyregistersbasic,diff_qparams(input scale != output scale), andnonzero_zpcases over int8 inputs spanning the sign-extend edges (-128/127); values whose dequantized magnitude is negative are relu-clamped to 0, so a droppedmax(x, 0)fails byte-exact.golden_dtype="float32"(int8 result is exactly representable).test_q8ta_relu.pycarries the delegation smoke test.Differential Revision: D112257625