Skip to content

[ExecuTorch][WebGPU] Op-test framework: multi-output goldens#21170

Open
JCNTH wants to merge 1 commit into
gh/JCNTH/130/basefrom
gh/JCNTH/130/head
Open

[ExecuTorch][WebGPU] Op-test framework: multi-output goldens#21170
JCNTH wants to merge 1 commit into
gh/JCNTH/130/basefrom
gh/JCNTH/130/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Extends the op-test generator to golden-verify EVERY output of a multi-output op (e.g. split_with_sizes_copy → N tensors), not just output[0]. The C++ driver already selected outs[output_index] per manifest entry; only the generator hardcoded a single output_index = 0.

Key changes:

  • test/op_tests/generate_op_tests.pygenerate_case now returns one manifest entry PER output tensor: it iterates the module's tuple return, writes a golden per output ({case}_out{i}.golden.bin, output_index = i), and runs the dual-oracle gate per output. generate() uses extend. Single-output ops emit exactly one entry, byte-identical to before (no _out suffix, output_index = 0).
  • test/op_tests/test_generator.pytest_generate_case_writes_artifacts reads the returned list (asserts one entry for the single-output add).

Differential Revision: D112257608

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21170

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit b0d07ac with merge base 266e0dc (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2026
This was referenced Jul 22, 2026
@JCNTH
JCNTH requested a review from psiddh July 23, 2026 02:09

@psiddh psiddh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving full WebGPU stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants