[ExecuTorch][WebGPU] Op-test framework: multi-output goldens#21170
[ExecuTorch][WebGPU] Op-test framework: multi-output goldens#21170JCNTH wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21170
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit b0d07ac with merge base 266e0dc ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
psiddh
left a comment
There was a problem hiding this comment.
Approving full WebGPU stack
Stack from ghstack (oldest at bottom):
Extends the op-test generator to golden-verify EVERY output of a multi-output op (e.g.
split_with_sizes_copy→ N tensors), not justoutput[0]. The C++ driver already selectedouts[output_index]per manifest entry; only the generator hardcoded a singleoutput_index = 0.Key changes:
test/op_tests/generate_op_tests.py—generate_casenow returns one manifest entry PER output tensor: it iterates the module's tuple return, writes a golden per output ({case}_out{i}.golden.bin,output_index = i), and runs the dual-oracle gate per output.generate()usesextend. Single-output ops emit exactly one entry, byte-identical to before (no_outsuffix,output_index = 0).test/op_tests/test_generator.py—test_generate_case_writes_artifactsreads the returned list (asserts one entry for the single-outputadd).Differential Revision: D112257608