[ExecuTorch][WebGPU] Op-tests for q8ta_add#21192
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21192
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 30 New Failures, 3 Unrelated FailuresAs of commit f691b3c with merge base 266e0dc ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
psiddh
left a comment
There was a problem hiding this comment.
Approving full WebGPU stack
Stack from ghstack (oldest at bottom):
Problem: The new
q8ta_addint8 op needs golden coverage; its int8 output uses the int8-golden harness, and thealphaterm (which the Vulkan glsl buffer path drops) must be pinned.Solution: A
q8ta_addsuite goldens the kernel byte-exact against the CPU eager op with both operands as baked int8 constants, plus an export-delegation smoke test.Implementation:
cases.pyregistersbasic,alpha=2.0(fails byte-exact if thea + alpha*bterm is dropped), andnonzero_zpcases over int8 inputs spanning the sign-extend + requant-clamp edges (-128/127);golden_dtype="float32"(int8 result is exactly representable).test_q8ta_add.pycarries the delegation smoke test.Differential Revision: D112257600