[ExecuTorch][WebGPU] Op-tests for comparisons + bool-output golden harness#21220
Open
JCNTH wants to merge 1 commit into
Open
[ExecuTorch][WebGPU] Op-tests for comparisons + bool-output golden harness#21220JCNTH wants to merge 1 commit into
JCNTH wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21220
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 46 New Failures, 3 Unrelated FailuresAs of commit bc10f23 with merge base 266e0dc ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 22, 2026
This was referenced Jul 22, 2026
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
psiddh
approved these changes
Jul 23, 2026
psiddh
left a comment
psiddh
left a comment
Contributor
There was a problem hiding this comment.
Approving full WebGPU stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Problem: The new comparison ops (
aten.eq/lt/le/gt/ge.Tensor) output BOOL, which the op-test golden harness did not handle (only fp32/int8/int64). And the goldens must actually discriminate the comparators.Solution: Extend the golden harness with a
boolbranch (mirrors the int8/int64 branches):generate_op_testswrites the bool golden as 0/1 bytes (raw.dtype==torch.bool -> _write_int8(raw.to(int8)), dtype "bool") andop_test_driverreads the bool output viaconst_data_ptr<bool>()and byte-compares. The change is additive (bool is a distinct dtype; the branch precedes int8) — existing fp32/int8/int64 paths are untouched (regression 27/27).CompareModule(op)covers all 5 ops; the two inputs draw from DIFFERENT discrete-range seeds (compare_gen_a/compare_gen_b) soa!=bwith frequent collisions — givingeq/le/gegenuine ties andlt/gta real true/false mix, so an op-switch swap diverges from the golden.Implementation:
cases.pyregisterseq/lt/le/gt/gevia a shared_compare_suite(2d/3d/sq shapes, all numel%4==0);test_compare.pyholdsCompareModule+ the seeded gens + a delegation smoke test.Differential Revision: D112257586