[ExecuTorch][WebGPU] Op-tests for argmax/argmin + int64-golden harness#21210
Open
JCNTH wants to merge 1 commit into
Open
[ExecuTorch][WebGPU] Op-tests for argmax/argmin + int64-golden harness#21210JCNTH wants to merge 1 commit into
JCNTH wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21210
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 46 New Failures, 3 Unrelated FailuresAs of commit a1092a2 with merge base 266e0dc ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 22, 2026
This was referenced Jul 22, 2026
This PR needs a
|
meta-cla
Bot
added
the
CLA Signed
psiddh
approved these changes
Jul 23, 2026
psiddh
left a comment
psiddh
left a comment
Contributor
There was a problem hiding this comment.
Approving full WebGPU stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Problem: The new argmax/argmin ops output int64 indices, but the op-test harness was float/int8-only (it cast any int output to fp32, so the driver would read index bytes as float — a garbage compare).
Solution: Extend the shared harness with an int64-golden path (mirroring the landed int8 path): the generator writes an int64 golden for int32/int64 raw outputs (
_write_int64, dtype "int64"), and the driver readsconst_data_ptr<int64_t>()and exact-compares to the int64 golden (load_int64_bin). The argmax/argmin suites usegolden_dtype="float32"so the golden's fp32 argmax matches the fp32 kernel exactly (an fp64 oracle could flip a near-tie index).Implementation:
generate_op_tests.pyadds_write_int64+ theis_int64branch.op_test_driver.cppadds the int64 exact-compare branch;driver_util.{h,cpp}addload_int64_bin.cases.pyregistersargmax/argminwith randn 2d/3d cases (max/min at an INTERIOR index — exercises the reduction walk) and a deliberate-tie case per op (argmax_tie_gen/argmin_tie_genplace a repeated extremum at idx 1 and 3 so the FIRST occurrence wins — this discriminates the strict->/<tie-break from a>=/<=bug).test_argmax.pyholds the modules + tie gens.Differential Revision: D112257677