Clamp probes compression factor to 0 #19

FrancescoC-unity · 2020-04-06T16:21:08Z

Super simple PR. just clamp the value of "probe compression factor" to a positive value.

…-to-0

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 * [Backport 8.x.x] Fix various leaks in HDRP (#119) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs * Update changelog * [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#115) * Follow references when unloading unneeded assets * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix MSAA resolve when there is no motion vectors * Fix issues causing planar probes to be broken with multiple cameras in the scene * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. * Hdrp/fix/custom pass msaa rendering info * Added disocclusion and ghosting to the glossary (#75) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position * Fix null reference when processing light probe * Fix black screen in XR when HDRP package is present but not used * [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor * fix Stacklit.hlsl after merge * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Vfx/docs/bulk review continued (#78) * Reviewed Contexts and terminology. * Began reviewing Events * Added sticky notes doc and reviewed Events * Update Contexts.md * Formatted documentation. * Update Contexts.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 * [Backport 8.x.x] Fix various leaks in HDRP (#119) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs * Update changelog * [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#115) * Follow references when unloading unneeded assets * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix MSAA resolve when there is no motion vectors * Fix issues causing planar probes to be broken with multiple cameras in the scene * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. * Hdrp/fix/custom pass msaa rendering info * Added disocclusion and ghosting to the glossary (#75) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position * Fix null reference when processing light probe * Fix black screen in XR when HDRP package is present but not used * [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor * fix Stacklit.hlsl after merge * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Vfx/docs/bulk review continued (#78) * Reviewed Contexts and terminology. * Began reviewing Events * Added sticky notes doc and reviewed Events * Update Contexts.md * Formatted documentation. * Update Contexts.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Fix for white flash happening when changing lighting condition (like teleport) * Fix issue with metal shader and raytracing * Fix default volume profile collapse * Update AxF-Shader.md (#152) * Bind missing buffer #159 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 * [Backport 8.x.x] Fix various leaks in HDRP (#119) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs * Update changelog * [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#115) * Follow references when unloading unneeded assets * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix MSAA resolve when there is no motion vectors * Fix issues causing planar probes to be broken with multiple cameras in the scene * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. * Hdrp/fix/custom pass msaa rendering info * Added disocclusion and ghosting to the glossary (#75) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position * Fix null reference when processing light probe * Fix black screen in XR when HDRP package is present but not used * [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor * fix Stacklit.hlsl after merge * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Vfx/docs/bulk review continued (#78) * Reviewed Contexts and terminology. * Began reviewing Events * Added sticky notes doc and reviewed Events * Update Contexts.md * Formatted documentation. * Update Contexts.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Fix for white flash happening when changing lighting condition (like teleport) * Fix issue with metal shader and raytracing * Fix default volume profile collapse * Update AxF-Shader.md (#152) * Bind missing buffer #159 * Enable Light Baking Cookies by default + Warning #79 * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [8.x.x Backport]Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. (#6210) * Fixed the MaxLightCount being display when the light volume debug menu is on ColorAndEdge. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Update documentation to mention more explicitely the lack of support of vertex animation (#6204) * Update documentation to mention more explicitely the lack of support of vertex animation * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [8.x.x Backport] Make subsection in decal debug menu to specify "affect transparents" (#6202) * Make subsection in decal debug menu * changelog * Support cookie on light backing for Disc Area Light #6138 * Hdrp /lookdev/fix crash on adding volume as viewed game object #6129 * fixed changelog * Add smoothness remark (#6226) * Removed legacy VR code from HDRP #5923 * Fixed duplicated entry for com.unity.modules.xr in the runtime asmdef file #5895 * Improve light clipping and culling #2 #4711 * Hdrp/fix/decal material ui errors #6225 * Fix z-fighting in sceneview when scene lighting is off (#6213) * Do not override the depth state of transparent materials in RenderDebugView * Changelog * Changelog - add case number Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update CHANGELOG.md * Mention default post processing in default volumes. (#6233) * Fix cubemap inspector so that thumbnail for cubemap work #6231 * - Fix an exception in ray tracing that happens if two LOD levels are using the same mesh renderer. (#6197) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fix some typos in the debug menu (#6249) * Backport renaming * changelog * Added debug exposure to light hierarchy debug. (#6216) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history. (#6254) * Clearer naming of tile and cluster categories for environment lights #6227 * Fix texture curve destroy (#6277) # Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md * Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). (#6270) * fix for Fogbugz 1214609 - HDRP Wizard addively increases the Light Intesity instead of setting it (#6266) * Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. #6235 * Add XR setting to control camera jitter for temporal effects #6259 * fix unreachable code in TextureXR.useTexArray (#6260) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Deprecate Utilities namespace #6219 * Fix issue on thumbnail generation so that no error on new project and thumbnail are generated at first import #6265 * Update CHANGELOG.md * [8.x.x Backport] Partial fix LookDev opened when CoreRP package reimported (#6289) * Fix null texture usage happening on CoreRP upgrade * Partially fix garbage collected stylesheet issue. (Need more work on UIElement side, see case 1228706 ) * Update CHANGELOG.md * Clean log * [Backport 8.x.x] Hdrp/fix default volume switch (#6336) * Fixed an issue where default volume would not update when switching profile. * Fixed an issue when setting the default volume for the first time where the hdrp asset would not be dirtied * Changelog * [Backport 8.x.x] Fixed an issue where AO override would not override specular occlusion (#6339) * Manual cherry pick of 9162acb50898c948e35475bb1c0d58dbea4217b7 * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 8.x.x] Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6335) * Fixed an issue where Volume inspector might not refresh correctly in some cases. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix material baked emission #5392 * Fixed volume components lifespan in the clipboard #5869 * Hdrp/fix/particle light shadows #6111 * Bugfix: uncached reflection probe cameras were reseting the debug mode #6245 * Fix case in PBR sky where a camera below ground might invalidate result of a camera above #6272 * Hdrp/probe scale 1219246 (#6288) * Fix when scale down < 0 all direction of box Influence Volume * Update Change log * Update CHANGELOG.md * Split set rendering feature set and API validity check #6301 * Fix Render Texture with XR #6306 * Fix sRGB mismatch with XR SDK #6311 * Fix XR single-pass with Mock HMD plugin #6313 * Fix XR culling with multiple cameras #6314 * Add custom pass opaque rendering error message #6330 * Update Light-Component.md (#6332) * Update CHANGELOG.md * Update TextureCurve.cs * fix merge issue * Update CHANGELOG.md * - Fixed an issue related to the envlightdatasrt not being bound in recursive rendering. (#6410) * First pass of light loop optimizations (still single threaded) (#6367) (#6424) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Address review points * Add comment * changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Catch and handle NRefactory parser exceptions (#6392) Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> * Avoid negative input to sqrt() (#6397) - The calculation of `k` is not numerically robust when done in FP16 and might generate a negative value. - This can be observed as rendering artifacts on Mali drivers newer than Bifrost/Valhall R21. - This commit fixes this by by clamping `k` to [0, inf] before the `sqrt()`. - On Mali-G77 the clamp compiles down to a free output modifier on the previous instruction, so there's no performance impact. * Refreshed the GUIDs for additional post processing data to avoid conflicts with PPv2 (#6394) * Added known issues page (#6447) * Platform/playstation #6380 * Shadow cascade tooltip fix (when using the metric mode) #6448 * Focus on Decal uses the extends of the projectors #6449 * [8.x.x Backport] Fixed how the area light influence volume is computed to match rasterization. (#6455) * - Fixed how the area light influence volume is computed to match rasterization. * Fix an issue with axis order Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed usage of light size data that are not available at runtime. (#6490) * Changed the diffusion profile warning on the material to an info and changed the message to be more precise. (#6481) * Fix shadow tesselation culling (#6477) * Fix custom pass culling params * Fixed shadow tessellation culling * revert custom pass code * Add option to disable XR rendering on the camera settings #6372 * Move scene view camera settings to camera settings window #6390 * Corrected typo and changed links to .md (#6414) * Corrected typo and changed links to .md * Update Master-Node-Fabric.md * Hdrp /fix reset of HDAdditionalLightData #6453 * Fix null error when leaving debug menu #6467 * Hdrp /fix drag area width at left of light intensity #6471 * Fix issue with baked reflection probes constantly marked as dirty with auto-bake on #6473 * Fix custom pass depth copy #6484 * Hdrp /lookdev ui fixes #6491 * Expose a debug constant in ShaderLab to make HDRP/Unlit SRP Batcher compatible again. #6496 * fix unused leftover (#6497) * Fix custom pass test reference images (#6512) * [8.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6506) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#27) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * path validation when creating new volume profile (#36) * Clamp probes compression factor to 0 #19 * [Backport 8.x.x] Fix various leaks in HDRP (#119) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs * Update changelog * [8.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#115) * Follow references when unloading unneeded assets * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix MSAA resolve when there is no motion vectors * Fix issues causing planar probes to be broken with multiple cameras in the scene * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. * Hdrp/fix/custom pass msaa rendering info * Added disocclusion and ghosting to the glossary (#75) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position * Fix null reference when processing light probe * Fix black screen in XR when HDRP package is present but not used * [8.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#20) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor * fix Stacklit.hlsl after merge * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Vfx/docs/bulk review continued (#78) * Reviewed Contexts and terminology. * Began reviewing Events * Added sticky notes doc and reviewed Events * Update Contexts.md * Formatted documentation. * Update Contexts.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Fix for white flash happening when changing lighting condition (like teleport) * Fix issue with metal shader and raytracing * Fix default volume profile collapse * Update AxF-Shader.md (#152) * Bind missing buffer #159 * Enable Light Baking Cookies by default + Warning #79 * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * [Backport 8.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#180) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Add range attenuation to box-shaped spotlights [Skip CI] #101 * Contact shadow min distance + fix scalarization code #150 * Hdrp/combine material samples with shader samples [Skip CI] #117 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Thomas <Chman@users.noreply.github.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: vlad-andreev <vlad-andreev@users.noreply.github.com> Co-authored-by: vlad-andreev <vlad-andreev@unity3d.com> Co-authored-by: ChristianF-ARM <45175346+ChristianF-ARM@users.noreply.github.com> Co-authored-by: Tim Cannell <timcannell@unity3d.com> Co-authored-by: Jussi Knuuttila <jussi.knuuttila@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com>

* Hdrp /fix reset of HDAdditionalLightData (#6453) * fix type resolving issue when reseting HDAdditionalLightdata * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add option to disable XR rendering on the camera settings (#6372) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix unused leftover (#6497) * Split HDRP Test scene 1900 in two scene (#6498) * Fix custom pass test reference images (#6512) * Updated ref image for PT fog test (5005). (#6513) * Review corrections for previous PR (#6494) * Fixed an usage of a a compute buffer not bound (1229964) (#6476) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520) Fixing an issue with sub-surface scattering and updating screenshots * fix typo (#6500) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. * Update changelog. * Additional fix for regular inspector * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. * Update changelog * Removed wrongly serialized fields in StaticLightingSky (#6441) * Removed unnecessarily serialized members in StaticLightingSky component. * Update changelog * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504) * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix a compilation issue to to a backport that did not go well. (#9) * Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31) * Clamp probes compression factor to 0 (#19) * Clamp to positive * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * path validation when creating new volume profile (#36) * Validate whole path when creating new profile * Changelog Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com> * Alpha to coverage frame setting (#33) * Added FrameSettingsField.AlphaToMask * Changelog + Documentation * Changed field index * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41) * AxF: Add support for specular AA from geometric curvature. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights. * AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe. * AxF: Use get scalar roughness function to factor out code. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * Add changelog entries. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement constant buffers for HDRP global variables. (#52) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Fixed color/depth pyramid debug * Cleanup * Small fix * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Add Performance framework package and HDRP performance tests (#45) * Added performance test project * Added new test scene system and memory p[rofiling * Added shader analysis package * Create symlink folder in library directory * Update editor window * Update shader analysis selection * Added CLI utility to execute shader analysis reports * Added example for the cli * Removed problematic HDRP graphic test packages * Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903) * Update memory profiling test sample count * Update shader graph support * Updated project settings * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Use background job API and improved progress reporting * Empty commit for Performance reports * Updated ui * Empty commit for Performance reports * Empty commit for Performance reports * Added filter on shader pass and variants * Added option to only generate shader variants * Empty commit for Performance reports * Increase garlic heap size * Begin to add build profiling * Added more build info * Working version of the shader compilation time reporting * wip * Removed useless cli * Added util functions to name test and sample groups * Renamed all markers and finished the build profiling * Update test framework package * Updated shader analysis tests * Updated API * Updated API and log command for compiler * Updated api * Use unknown metric instead of time one as workaround * Enable the CPU profiling API * Fix when deleting an analyzed shader * Load reference on enable * Added shader analysis package * Fixed PS4 test name * Fixed memory unit * Added more test scenes * Force performance tests to run on PS4 base * Fixed sample units and use the same SampleGroup for multiple frames in counter test * Begin to create the graphic perf test * Finished the first version of performance graphic test package * Fixed build tests * Increase static analysis timeout * More timeout * Removed Lit shader static analysis * Fix counters tests * Added performance settings window in project settings * Re-add Forward build test scene * Fixed shader analysis filter * PR fixes * Begin to write the doc * Finished V1 of the performance package doc * Added grafana image and doc description * Updated doc * Maybe fix yamayo tests * Update documentation for static analysis * Added note on core asmdef * Removed debug * Fixed total memory * Added tesselation counters test * Tessellation shadow test * Added per scene settings * Added naming convention doc * Fixed build issue on yamato * Compilation fix to revert * Begin to write the new doc page * Completed performance doc * Fixed build test * Added Lit in static analysis * Removed deferred static analysis Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Hdrp/fix/custom pass msaa rendering info (#42) * Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass AOV API (#50) * Very basic AOV support for custom pass * Updated AOV API for custom passes * Changelog * Update AOV API * API improvements * API documentation * API doc, factorize all push texture calls in RenderCustomPass * added default values and constructor for CustomPassAOVBuffers * fix merge conflicts * Fix GC alloc during rendering: use a for loop instead of findIndex+lambda Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the…

* Hdrp /fix reset of HDAdditionalLightData (#6453) * fix type resolving issue when reseting HDAdditionalLightdata * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Add option to disable XR rendering on the camera settings (#6372) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix unused leftover (#6497) * Split HDRP Test scene 1900 in two scene (#6498) * Fix custom pass test reference images (#6512) * Updated ref image for PT fog test (5005). (#6513) * Review corrections for previous PR (#6494) * Fixed an usage of a a compute buffer not bound (1229964) (#6476) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed scene selection pass not working proporly for meshes rendered with recursive rendering. (#6520) Fixing an issue with sub-surface scattering and updating screenshots * fix typo (#6500) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. (#6493) * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. * Update changelog. * Additional fix for regular inspector * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. (#6480) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. * Update changelog * Removed wrongly serialized fields in StaticLightingSky (#6441) * Removed unnecessarily serialized members in StaticLightingSky component. * Update changelog * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6504) * Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid overlapping Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix a compilation issue to to a backport that did not go well. (#9) * Fixed a regression in the ray traced indirect diffuse due to the new probe system. (#31) * Clamp probes compression factor to 0 (#19) * Clamp to positive * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * path validation when creating new volume profile (#36) * Validate whole path when creating new profile * Changelog Co-authored-by: pavlos.mavridis <pavlos.mavridis@unity3d.com> * Alpha to coverage frame setting (#33) * Added FrameSettingsField.AlphaToMask * Changelog + Documentation * Changed field index * Axf - Add specaa, add baked ao, fix reflection hierarchy for carpaint. (#41) * AxF: Add support for specular AA from geometric curvature. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * AxF: Fix a typo that caused a bug for SVBRDF materials using precise Fresnel variants to always use full reflectance (1) for delta lights. * AxF: Fix ignored reflection hierarchy + proxy intersection for carpaint. Add comments about problems if two directions are differents. Also add an option (disabled for now) to have BRDFColor with base angle of dominant direction. Rename some variables to make clearer direction on top for bottom lobe. * AxF: Use get scalar roughness function to factor out code. * AxF: Add internal support for baked ambient and specular occlusion (no baked AO input map currently). Fix AO factor to adapt better to carpaint.model. * Add changelog entries. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement constant buffers for HDRP global variables. (#52) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Fixed color/depth pyramid debug * Cleanup * Small fix * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Add Performance framework package and HDRP performance tests (#45) * Added performance test project * Added new test scene system and memory p[rofiling * Added shader analysis package * Create symlink folder in library directory * Update editor window * Update shader analysis selection * Added CLI utility to execute shader analysis reports * Added example for the cli * Removed problematic HDRP graphic test packages * Add xml file to avoid IL2CPP stripping issues with test runner on the performance test(#5903) * Update memory profiling test sample count * Update shader graph support * Updated project settings * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Empty commit for Performance reports * Use background job API and improved progress reporting * Empty commit for Performance reports * Updated ui * Empty commit for Performance reports * Empty commit for Performance reports * Added filter on shader pass and variants * Added option to only generate shader variants * Empty commit for Performance reports * Increase garlic heap size * Begin to add build profiling * Added more build info * Working version of the shader compilation time reporting * wip * Removed useless cli * Added util functions to name test and sample groups * Renamed all markers and finished the build profiling * Update test framework package * Updated shader analysis tests * Updated API * Updated API and log command for compiler * Updated api * Use unknown metric instead of time one as workaround * Enable the CPU profiling API * Fix when deleting an analyzed shader * Load reference on enable * Added shader analysis package * Fixed PS4 test name * Fixed memory unit * Added more test scenes * Force performance tests to run on PS4 base * Fixed sample units and use the same SampleGroup for multiple frames in counter test * Begin to create the graphic perf test * Finished the first version of performance graphic test package * Fixed build tests * Increase static analysis timeout * More timeout * Removed Lit shader static analysis * Fix counters tests * Added performance settings window in project settings * Re-add Forward build test scene * Fixed shader analysis filter * PR fixes * Begin to write the doc * Finished V1 of the performance package doc * Added grafana image and doc description * Updated doc * Maybe fix yamayo tests * Update documentation for static analysis * Added note on core asmdef * Removed debug * Fixed total memory * Added tesselation counters test * Tessellation shadow test * Added per scene settings * Added naming convention doc * Fixed build issue on yamato * Compilation fix to revert * Begin to write the new doc page * Completed performance doc * Fixed build test * Added Lit in static analysis * Removed deferred static analysis Co-authored-by: Frédéric Vauchelles <fredericv@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Hdrp/fix/custom pass msaa rendering info (#42) * Add an info box to warn about depth test artifacts when rendering object twice in custom passes with MSAA * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass AOV API (#50) * Very basic AOV support for custom pass * Updated AOV API for custom passes * Changelog * Update AOV API * API improvements * API documentation * API doc, factorize all push texture calls in RenderCustomPass * added default values and constructor for CustomPassAOVBuffers * fix merge conflicts * Fix GC alloc during rendering: use a for loop instead of findIndex+lambda Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly…

* Fix color field height * changelog

* property attributes not serialized (#253) * Initial tests * Fix typo * Change the VFXPropertyAttribute class * Use VFXPropertyAttributes in VFXProperty * Refactor interface * Remove old VFXPropertyAttribute class * More fixes * Fix bug in DataAnchorController * Fix invalid cast typo * Remove shader warnings (#261) * Fix shader warnings in test projects * Update changelog * Vfx/feature/filter enum (#243) * Allow filtering enums values in VFXModels. * Add an explicit GetHashCode() to default NameNType. * Update CHANGELOG.md * Update VFXHDRPSubOutput.cs * fix based on review * Remove raytracing enumerator filter as it was removed from HDRP enum * Remove irrelevant render queues from some HDRP outputs (#263) * Remove AfterPostProcessing render queue for lit outputs * Remove render queue field from distortion outputs * Update changelog * Update HDRP changelog instead of VFX * Fix issue when converting outputs with invalid render queue # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Fixed Flipbook Texture Names * Update CHANGELOG.md * Fix exception when creating new category on new visual effect asset. * Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205) * Fix to graft : support for flag enum in inspector * *Update changelog * Revert "Fix Enum Flag" (#15) * "Fix Enum Flag" (#16) This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241. * Fix for Initial Event field height, (#17) * Fix for Initial Event field height, that were clipping the bottom of legged letters * Update CHANGELOG.md * Vfx/fix colorfield height (#19) * Fix color field height * changelog * Mesh Sampling (revival) (#1) * Squashed commit of the following: commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935 Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933 Use simpler & explicit definition of propagated flags * Fix several issue/comment Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765 * Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph * Fix tooltip issue from @lewisjordan Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386 Side note : use mode instead of "addressingMode" in PositionMesh as well. * Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553 * As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777 * Add composition for Position (Mesh) as suggested by @thomasi Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Update experimental disclaimers (#367) * Updated experimental disclaimers * Removed link and added description instead. * [HDRP] MSAA & MotionVector (#12) * Support WRITE_MSAA_DEPTH Unlit template * Fix MSAA for lit output * *Update changelog * Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH TODO : Fix Sphere output as well * Fix typo in ParticlePoint * Factorize common fragment Lit & unlit for depth alike passes. * Fix particle hexadreon wrong depth with alpha clip * Revert "Fix particle hexadreon wrong depth with alpha clip" This reverts commit b16bd570440087984c2c8c48279bebb088f748e8. * Allow an object slot to have null as its value (#25) * Allow an object slot to have null as its value * changelog * Vfx/fix/prevent capacity change locked (#24) * Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode * changelog * *Update all vfx (had to do it manually...) * Restore missing enty in hdrp changelog (bad resolve conflict from me) * Fix 1233044 - capacity cannot be zero (#21) * Prevent capacity from being 0 * Fix strip capacity as well * Vfx/fix/param order (#22) * Fix for dragged parameters order when there are categories * changelog Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix minor issue with VFXPreviousPositionBinder.cs (#23) Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/fix/sgoperator create context drag (#28) * Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot. * changelog * Vfx/fix/context no blocks (#27) * Don't show block windows when context cant have blocks (output mesh ) * changelog * PropertyBinder : Minor Fixes (#29) * Fix for binder when null asset & fix for binder while resetting * Call ClearPropertyBinders while resetting * Add Update Modes & Time Access (revival) (#4) * Squashed commit of the following: commit d77638ba4188bfb03c81130b82cacb2a719f03be Merge: 49eaeadff7 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 09:46:59 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 14:53:09 2020 +0100 Update UX for new time access (#260) https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280 See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z commit 78d5d9938d9896d517efa89662764afd44ef12fc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 16:03:26 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060 commit bc7e715b0e41b55126fdf171b7459b680e3e3824 Merge: 9a82a52bfe ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 14:52:03 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88 Merge: f56986d415 66df0debfc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 09:17:53 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit f56986d4157f140ca84b039d97c8b7064a18214e Merge: 047820690f 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:25:07 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 047820690fa496bd43d3a60df16dd0932502c7cb Merge: d6d17dfbbc e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:56:39 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:59:15 2020 +0100 Squashed commit of the following: commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 13:37:05 2020 +0100 Use implicit block for old position backup commit e786cf3ade7d7515da4569dde9455881af02f282 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Jan 12 15:05:03 2020 +0100 WIP : Add option to skip zero delta per update context commit e864fae742120fbfebabb26b605ddedfd184b02b Merge: 4eecc0b90b fb12af4c28 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:47:57 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 16:08:07 2020 +0100 Rename ProcessEveryFrame in ExactFixedTimeStep commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 16:21:50 2020 +0100 Fix ManagerMaxDeltaTime (was GameDeltaTime) commit eaebe2649e93a5083fd62c91ac92185794b908e5 Merge: 98e7dcfcdc 276c02f29a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:42:08 2020 +0100 Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes commit 98e7dcfcdceb710c252e4d1a257815a724539e68 Merge: 248004d55a 0737eb535c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:26:54 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 248004d55a7b96c6532cd3c197e175b751d6f3fe Merge: 2bbadae355 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 9 13:12:50 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 2bbadae355bb3c4a308b8d4e020e96127fa94818 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:07:46 2019 +0100 Add tooltip to VFXTime.cs commit 9dc7ea790327b44ffde94bbf783d588e74c50174 Merge: bf48ba84eb 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:29:13 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit bf48ba84ebfd1472d041966ba4be627e3a1ef427 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:26:30 2019 +0100 *Update changelog.md commit b5d76d5d5d65584fde771213d9a01adc6dd9b856 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 16:10:19 2019 +0100 Add operator to enable time accesses commit 1a2fe7b8dc5072dd49d985f045f276385e08287f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 11:25:52 2019 +0100 Add built-in expression (but not listed) commit b0d0e64ee04036adf48f4481bfd22eace649bac3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:37:50 2019 +0100 Add some header commit 490a441046a227bb1cc1b98418d0559da17d3771 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:36:57 2019 +0100 Add tooltip & text content commit 621c5b2b78545800b2e94921b9314ef860992059 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:09:32 2019 +0100 *Add custom inspector to edit update flags efficiently * Fix build (VFXPropertyAttribute.Create isn't needed anymore) * Fix editor test * Read Attribute in Spawn Context (#6) * Squashed commit of the following: commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 11:14:14 2020 +0200 *Update image reference (having issue with standalone, not sure of the result) commit 275c22de35f08ada783c96c625b12475f0c42337 Merge: 85254f1ec4 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 09:59:48 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # com.unity.visualeffectgraph/CHANGELOG.md commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 16:21:39 2020 +0100 *Update image reference due to fix with grapicTest update commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf Merge: d8db341bfb 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:51:43 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset commit d8db341bfbd9257e1a5285d200e3eabe24857b01 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:57:38 2020 +0100 *Apply Formatting commit f80441dd6b30ef726d46ae2fe32bcf05d208b760 Merge: b3d858ffe1 01f176355a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:32:49 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7 Merge: 0bce44dc9a 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:18:58 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # .yamato/upm-ci-vfx_lwrp.yml # .yamato/upm-ci-vfxmain.yml # com.unity.visualeffectgraph/CHANGELOG.md commit 0bce44dc9a694bf36b849efb894e999fa9dc959e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:20:03 2020 +0100 *Fix build commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df Merge: 2130ea0ef2 e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 09:47:09 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 2130ea0ef2186ecdc5692878940d5d6635dca31b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:09:13 2020 +0100 *Update tooltips (thanks @vlad) commit f8cdb95f5d2075848e530d997551b69de43f39e0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:01:44 2020 +0100 Rename SpawnerState in SpawnState commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 13:54:24 2020 +0100 Improve ReadAttribute test to cover NewLoop state commit 2c515bfde823bfbce87df8a1444e19e5c2327e32 Merge: a9efee24ff bff1b74b59 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 16:32:45 2019 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit a9efee24ff84131c53dc2ba93f1985b02217e3d7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:54:25 2019 +0100 *Update comment commit 6b17879881555cd72b3af4463fd907423f92ad7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:53:11 2019 +0100 Throws an exception while detecting unexpected expression flag commit cbad9212075ec6776cf9d892185dd6ee64f8fab2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:43:33 2019 +0100 Reorder spawner state operator commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:35:30 2019 +0100 Fix issue "Cannot plug in attribute-derived nodes into a spawner block." commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:58:30 2019 +0100 *Update changelog commit 61bd2e5871f23002dd1add024858efdef5e09372 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:46:52 2019 +0100 Update _CCCC test & Rename Spawner State library name commit 4942912123d795023aacb0363c8e462a2da29943 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 16:58:17 2019 +0100 Fix test & clean useless code in VFXExpression.Initialize commit e6d6c593eb27c612a225340615dabe7692f76a00 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:22:31 2019 +0100 Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose commit f00f740b775f67e9378072744513f3ff920f470d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:16:39 2019 +0100 Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change) commit b7d8e238dd7e05bf99114a980c8584da7985dcf8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:45:56 2019 +0100 Clean test data & add reference images commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:17:51 2019 +0100 Move graphicTest to common files commit fa21846e7787fec9068c5a18a33dc568df3f7cc9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 11:53:18 2019 +0100 Separate cleanly per event attribute expressions commit 80e5259674a011e864e65f13c77ce06f92f33b7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 08:38:41 2019 +0100 New test for chaining & read attributes commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 18:47:20 2019 +0100 Add read attribute for loop settings (context evaluation) commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 15:30:56 2019 +0100 Clean expression patching commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 11:45:06 2019 +0100 Clarify compatibility code for spawner order & random implication commit 0dcf774f623fb93eb7bc19b06407b88669472443 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 18:42:30 2019 +0100 Add tricky case in test vfx & fix compatibility code TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 16:49:42 2019 +0100 *Up local test commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 15:22:03 2019 +0100 Detect & Compute partial evaluation commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:16:29 2019 +0100 Add spawner State Operator & SpawnCount (even if it's actually an attribute) commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:04:04 2019 +0100 Add spawner state accessor commit adb1d6d66172f2d187b577facaf7b2aea4677d13 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 11:24:20 2019 +0100 Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling commit d43ad0e1395d0e51f3583ce9627a72006356e117 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 2 16:19:05 2019 +0100 Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute commit 8a25b5fbed33569529d30379fce2acd4da7de88d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 29 16:14:32 2019 +0100 Backup test asset (temporarily) commit dcb3efaf885dbbdec317f5a42ace9ace336fded9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 16:37:48 2019 +0100 WIP : experimenting new concept of Read Attribute expression * Merge with vfx/staging * Update VFX * Misc small fixes (#36) * Fix strips outputs, spawnIndex and default metallic value * Increase threshold in particle strip unlit test * Test for Override resetted (#26) * *WIP* add test * Actually add a more legit "prefab" test * Prepare fix later fix of 1206890 : can't change the C++ without updating this test * Fix editor test (todo : graft this change to master to anticipate the C++ change) * Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20) * New Test : total time is sum of delta time (#7) * *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249 * [Fix] Disable reset option (#41) * Disable reset option * Add repro case 1251533 * Fix minor issue with PreviousPropertyBinder (bis) (#31) * Fix minor issue with VFXPreviousPositionBinder.cs * Fix exception in OnEnable Note : I didn't try it locally yet. * Actual fix of VFXPreviousPositionBinder.cs Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix culture issues when generating attributes defines in shaders (#40) * [PropertyBinder] Move Update to LateUpdate (#38) * Fix issue with VFXPropertyBinder : we should use late update instead of Update * *Update 23_ParameterBinder reference image * Call resyncslots on shadergraph dependent models. (#10) * Call resyncslots on shadergraph dependent models. * missing call to checkgraphbeforeimport * indentation * fix slot not updated if only the attributes change * Do the same for models having subgraphs than for models having shadergraphs. * Fix based on PR review * Update CHANGELOG.md * update vfx and settings * Renable 009_MultiCamera in URP project * Easy Wins (Small Workflow / Cosmetic fixes) (#37) * Properties now exposed by default in blackboard * Dissociated Colors for bool/int/uint * Added Degrees / Radians conversion subgraphs in samples * De-nicified attribute name (conserve case) in Set Custom Attribute title * Changed the default "No Asset" message when opening the visual effect graph window. * Subgraphs are not in hardcoded categories anymore + Updated Serialization * Added Documentation for setting Subgraph Menu Categories Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/docs/compatability disclaimer (#43) * Added compatability disc * Updated format. * Save a specific vfx asset and its sugraphs only (#35) * Save graph asset works * Update CHANGELOG.md * Update VisualEffectGraphWindow.md * Update VisualEffectGraphWindow.md * Fix for block copy not dirtying the scene. * Remove some unecessary compilation (not all) (#46) * New TransformVector4 and GetTextureDimensions operators (#18) * Vfx/feature/new operators 2 (#266) * Add TransformVector4 operator * Remove unused code * Fix warning * Refactor dynamic type operator * Samll fix to previous commit * Add texture dimensions operator and expressions * Add tooltips * Add changelog entry * Fix merge compilation * Modify point cache test * Prevent textures from being constant folded * Move modified test to correct folder * Output Event (#5) * Squashed commit of the following: commit 449a60793a4c5c91e1913c42632448eb07ebe5de Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:27:48 2020 +0200 Fix stackoverflow with subgraph (but doesn't fix the internal workflow) commit caf0df3af5f451f9576c2cc7f328b57a87479f30 Merge: bb1047c59a a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 10:22:47 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/output-event commit bb1047c59a084551e7df3b93d7d5ad501145ecaf Merge: 7b2890b76f 98ce4878d1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 17:17:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:54:17 2020 +0100 Add a check of outputEvent in SpawnerTest commit 945992b2feff4b8f7a24740944c77a4a92f271dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:24:56 2020 +0100 *Update OutputEventTest.cs to check Test_Output_Event commit c48fda763e807503f27f98deeda4238b6628c264 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 18 10:17:21 2020 +0100 *Update image reference & Test (stop using a undebuggeable random position) commit 5a5ad49cb485907ee869445627821810589ab34a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 22:12:58 2020 +0100 Fix newly integrated spawn test for output event commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c Merge: ef4837245e 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 17:53:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs commit ef4837245e1d88846f6d686e2803094d1d6cd04d Merge: 2331c32fb4 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 08:30:00 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda Merge: 5d225d6e19 0103971ce2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Feb 6 08:01:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 5d225d6e192b32394faf0964ad263cc33c5280cc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:01:51 2020 +0100 Fix editor test commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:00:35 2020 +0100 Add distinct while retrieving virtual link commit 725252869ac24d962490b4550821fbba2ab119b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Feb 3 14:38:52 2020 +0100 *WIP* Output test commit 96098fa11f4781837543fba099936b15a8c7158d Merge: 02178104a3 bb04ca28fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 31 14:07:02 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 02178104a301fb434d5e6821cd369884bbc01006 Merge: 1443b66691 db8325ba2b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 18:06:20 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 1443b66691d46ed9598ccc26b0b9425d373b61e1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:37:08 2020 +0100 *Reduce unexpected changes commit aa1afcafa9c95d042db146043c60015d3f5c96f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:31:13 2020 +0100 New UX for output event (use data instead of system name) (#229) * *WIP* Experiment for UX using eventName * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name * Remove useless naming pattern linking label & title for output Cleaner & Safer implementation for outputEvent edition * Use unique system naming * Add test for Data for VFXOutputEvent * Fix hacky OnInvalidate commit 9cd41b81cef062991907d5ce446336bde78b79d3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 15:11:39 2020 +0100 Add editor test to check return value of output event (not attribute, already cover by graphic test) commit 1a09c63a98e4650b82160e670cedfb06b630284d Merge: 35126156f2 52ce8b9636 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 11:02:45 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 35126156f2b93b04543de0eb91aca79adf331b2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 17 13:58:06 2020 +0100 Avoid exception if system isn't present yet commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 16 10:53:13 2020 +0100 *Update Test, adding a test on unused source attribute commit bfd29d8862539cef5b14392e21cbd896436339a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 20:20:59 2020 +0100 Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test) commit d89160df852b64a4b5ecf378c506aa0c9f1c099c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 16:13:02 2020 +0100 Filters out orphan output event context commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 14:30:08 2020 +0100 *Update changelog commit cf54e5372e273f86dd5c2e00a6178a543f234fd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 08:40:09 2020 +0100 Add reference image for HDRP commit d710998eb133a3dbadbdec580d1ecad3752aca85 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:17:28 2020 +0100 Add reference images for newly added test commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 15:23:18 2020 +0100 *Add a material to unit test commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 17:02:27 2020 +0100 Start implementing a effective test project commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 16:56:28 2020 +0100 FIx system name synchronisation (not really ideal) commit 7782b888266a011f4f986a7bb3161f024730caa7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 14:24:08 2020 +0100 Fix UI of output event commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 10:11:56 2020 +0100 Fix build commit 50ae031af02d4c41e651f64b40e9d265668b803f Merge: d838cd2d37 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 7 13:36:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 14:58:00 2019 +0100 Add a wip test scene commit 459b344b3f97c794d47a8eb6942b1129d18632cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 11:40:30 2019 +0100 Fill VFXDataOutputEvent commit e54905485dd553cadcde307ca00a8d7ce8454c0f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 18:21:31 2019 +0100 Add basic output event type (empty FillDesc implementation for now) * Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP* * Update 009_OutputEvent test * Move 009_OutputEvent to correct folder (TODO, this to rename it before merge) * Fix sanity test & allow multiple connection from in outputEvent (as initialize) * Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context * Fix editor test using eventName instead of tile * Revert unexpected changes * *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485 * Rename VisualEffectOutputEventArgs => VFXOutputEventArgs * Disable connection from OutputEvent to GPUEvent * *Fix build VisualEffect.OutputEventArgs => VFXOutputEventArgs Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5 * Vfx/feature/enum parameter (#8) * Restart of enum parameters * more work * more work * Still more work. * reorderable list looks good. * Adding and removing values works. * dragging item works. * Enum values show in the inspector. * fixes for rebase * Enumvalue works on subgraphs. * notify enum name change. * Added documentation for blackboard value filtering. * no value per enum * only uint can now avec enum values. * don't nicify enum values. * Update Blackboard.md * Update VFXBlackboard.uss * sanitize parameter already having range * Clamp enum value works. * Changing switch testValue to uint. * value appearing as menu if mode is enum. * Update CHANGELOG.md * Mutli editor of different values of enum parameter works. * cpoy paste enumValues and min/max when copying parameter. * Copy parameter mode when converting to subgraph. * fix * Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt. * Vfx/docs/new operator docs (#50) * Added documentation for new operators * Changed bullet format. * Fix creation of StringPropertyRM (#51) * Fix creation of StringPropertyRM * Update CHANGELOG.md * Fix input of event emitting block beeing to small because of output * Multi-mesh output, LODs and compute culling (#14) * Implement multi mesh * Add LOD + lit mesh output support * Small fix + optim * Fix crash with multi mesh + sorting * Fix shader compilation with single mesh and compute culling * implement multi sorting * Add globalSort parameter * Fix camera absolute mode * Fix URP shader compilation * Add frustum culling to LOD * Add frustum culling setting * filter out implicit settings and add tooltips * Add radius scale + tooltips * Add a graphics test * Update change log + lod and multi mesh as experimental features * Forgot a file * Small changes based on QA review * Simulate headers on enum values in SlotContainerEditor (#49) * Simulate headers on enum values in SlotContainerEditor * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Update VFX * Fix for blackboard scrollable element hidden by resize. * Disable LOD test for XR * Fix test threshold that was reset to 0... * Ignoer graphviz folder * Target Gameobject windows resize doesn't go too far above scrollbars * Missing or incorrect unit in uss. * fix for reference image "VFX/Execution" not updated to new path ( warning when adding output) * Change description in package.json to reflect VFX is not out of preview with URP and mobile Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: Thomas Iché <peeweek@gmail.com> Co-authored-by: Thomas Iché <thomasi@unity3d.com> Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>

* [7.x.x Backport] Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). (#6507) * - Fixed a weird behavior in the scalable settings drawing when the space becomes tiny (1212045). * Small fix to avoid text overlapping too much Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fixed an usage of a a compute buffer not bound (1229964) (#28) Co-authored-by: Anis <anis@unity3d.com> * Removed wrongly serialized fields in StaticLightingSky (#6441) * Fix issues in the post process system with RenderTexture being invalid in some cases. Causing rendering problems. #6480 * Update PostProcessSystem.cs * Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. #6493 * Hdrp/docs/glossary f number (#6523) * Update Glossary.md * Update Glossary.md * Clamp probes compression factor to 0 (#19) * path validation when creating new volume profile (#36) * [Backport 7.x.x] Fix various leaks in HDRP (#120) * Fixed a number of leak in HDRP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs * Update changelog * [7.x.x backport] Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#128) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#21) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * d Fix MSAA resolve when there is no motion vectors #1 * Fix issues causing planar probes to be broken with multiple cameras in the scene #4 * Pospow and SG triplanar fix #40 * Hdrp/fix/custom pass msaa rendering info #42 * Added disocclusion and ghosting to the glossary (#75) * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * fix switch shader compilation (#111) * Update SceneViewDrawMode.cs (#118) * Fix culling of reflection probes that change position #121 * Fix null reference when processing light probe #131 * Fix black screen in XR when HDRP package is present but not used #137 * Fix default volume profile collapse #138 * Fix for white flash happening when changing lighting condition (like teleport) #140 * Added baked GI rp support caveat and made setting shadow filter quality clearer for deferred high. (#145) * Update AxF-Shader.md (#152) * Bind missing buffer #159 * [Backport 7.x.x] Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#179) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/PBR/HDPBRLit.cs * Update changelog * Catch and handle NRefactory parser exceptions #6392 * [7.x.x backport] Fix quality settings UI and shadow mask UI #122 (#123) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * fix typo * fix typo 2 * Fixed the indirect diffuse texture not being ignored when it should (ray tracing disabled). (#284) * [7.x.x Backport] Fix pre/post pass sg properties #82 (#85) * Fix depth pre/post passes not correctly enabled when switching shaders on the material # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Lit/ShaderGraph/HDLitMasterNode.cs # com.unity.render-pipelines.high-definition/Editor/Material/Unlit/HDShaderGUI.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDSubShaderUtilities.cs * Hide prepass and postpass in the material UI # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#306) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Updated raytracing async compute warning. (#304) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a null ref exception in static sky when the default volume profile is invalid. (#303) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog * [Backport 7.x.x] Fixed an error about procedural sky being logged by mistake. (#307) * Fixed an error about procedural sky being logged by mistake. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix flickering lighting in the scene and game view when lookdev is open. (#379) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog * [7.x.x Backport] Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#317) * render until ambient probe is ready * remove comment * changelog * [Backport 7.x.x] Fixed some gcalloc in the debug window (#464) * Fixed some GCAlloc in the debug window # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Debug/VolumeDebug.cs * Update changelog * [Backport 7.x.x] Hdrp/small ui update (#466) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs # com.unity.render-pipelines.high-definition/Editor/Sky/AtmosphericScattering/FogEditor.cs * update changelog * [Backport 7.x.x] PBR Sky renderer now shares its internal precomputation table between different instances. (#482) * PBR Sky renderer now shares its internal precomputation table between different instances. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs * Doc update * Update changelog * [Backport 7.x.x] New tooltip for camera background and fixed exposure when switching the background mode. (#480) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs * Update changelog * [Backport 7.x.x] Fixed asset preview being rendered white because of static lighting sky. (#479) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Update changelog * Changed UI name, tooltip, and doc for maximum decals on screen (#232) Implements feedback from https://fogbugz.unity3d.com/f/cases/1189618/ * Update Custom-Post-Process.md (#233) * Update HDRP-Features.md (#235) * Hdrp/reflection probe scale perf #252 * HD: Switch to 1920x1080 default standalone resolution (#279) Well, the default is "fullscreen desktop resolution" anyway, so this does not change anything at default settings. But, if user unchecks the "default native fullscreen", then it was going into 1024x768 on Standalone platform. Which was the most popular resolution back in year 2005. In year 2019, the 1920x1080 is the most popular, so make that the default. See also: https://ono.unity3d.com/unity/unity/pull-request/105219/_/desktop/default-res (moved https://github.cds.internal.unity3d.com/unity/com.unity.template-hd/pull/33 to this new repo) * Makes sure quaternion is normalized and valid before converting to ma… #331 * Fix cookie srgb #297 * Updated forward and deferred rendering definitions (#350) * Update Forward-And-Deferred-Rendering.md * Update Forward-And-Deferred-Rendering.md * Update Light-Component.md (#357) * Hd/add layer modification on generated emissive mesh for area light #364 * Update Look-Dev-Environment-Library.md (#365) * Update Volumetric-Lighting.md (#402) Fixes https://fogbugz.unity3d.com/f/cases/1238592 * Hd/fix nullref while removing decal component #416 * Fix issue with Uber Post process shader when alpha is enabled #422 * Fix the bug (#430) * Fix issue causing not all baked reflection probes to be deleted #441 * Updated Decal Projector doc (#477) Updated Limitations section and added a disclaimer about decal shader stripping. * Look Dev docs refactor 2 #484 * [7.x.x Backport] Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#425) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA #315 * Fix issue with the resolve of motion vectors (#421) * fix issue with ShowPrePassAndPostPass * fix compilation issue in rendergraph * Fixed null reference exception in LookDev when setting the SRP to None #447 * Check reflection probe null pointer before use. (case 1244047) #456 * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Fix few multi-editing issues with Emission UI #473 * Re-enable cubemap thumbnail gen only for d3d11 #487 * Hd/fix undo environmentlibrary lookdev #490 * Added system requirements and frame settings api docs (#510) * Added system requirements and frame settings api doc * Update System-Requirements.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * hide exposure compensation for fixed exposure (#535) * hide exposure compensation for fixed exposure * Update PostProcessSystem.cs * [9.x.x] Fix Microshadow not working properly with LightLayers enabled in deferred #522 * Use path relative to package for depth of field #523 * Fix taaFrameIndex and restore TAA tests for XR #534 * Fix an issue in reading the gbuffer for ray traced subsurface scattering (#538) * fix DXR manifest * update reference screenshots * [Backport 7.x.x] Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time. (#988) * Fixed an issue where manipulating the color wheels in a volume component would reset the cursor every time. * Update changelog * [Backport 7.x.x] Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once. (#990) * Fixed an issue where static sky lighting would not be updated for a new scene until it's reloaded at least once. # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Sky/SkyManager.cs * Update changelog * [Backport 7.x.x] Add defines guards around shadows hlsl files (#1091) * Add guards to shadow includes # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowAlgorithms.hlsl * changelog * [Backport 7.x.x] Fix issue with light layers > 7 in the deferred path (#1093) * Mask layers to consider only the supported 8 bits * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fix decal being duplicated in prefab isolation mode. (#1103) * Fixed decals being duplicated in prefab isolation mode. * Fix decals in the player. * Update changelog * Revert "[Backport 7.x.x] Fix decal being duplicated in prefab isolation mode. (#1103)" This reverts commit 5e5ecd9. * Update CHANGELOG.md * Hdrp/docs/volumetric lighting format fix (#628) * Updated volumetric lighting and subsurface scattering docs * Update Override-Diffusion-Profile.md * Adds mention of fidelityfx-cas as requested by AMD (#629) * Update Light-Component.md (#682) * Fix transparent movec scene view #698 * Update HDRP-Camera.md (#706) * Update Reflection-Probe (#790) * Update Reflection-Probe.md * Update Reflection-Probe.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix reflection probe framesettings override #796 * Workaround for GetKernelThreadGroupSizes returning wrong data #760 * Sanitize transparent motion vectors setting #761 * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow #823 * Force post process parent setting to be before child settings #799 * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Fix warning in HDAdditionalLightData OnValidate #885 * Revert "Fix warning in HDAdditionalLightData OnValidate #885" This reverts commit 1798e28. * Fix warning in HDAdditionalLightData OnValidate #885 * Fix warning in HDAdditionalLightData OnValidate #885 - fix merge issue * Editing volumes via script doc (#884) * Added Volumes API doc * Update Volumes-API.md * Changed terminology back to Volume Override * Added terminology disclaimer * Fix message for metal and ao (#859) * Update HDR information. Also updated format and links. (#853) * Fix issue with the blue line of prefab modifications for Volume mode #860 * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865 * Rename h to hlsl * Change extensions of CAS includes from h to hlsl #961 * Fix SSAO with double sided material and normal mode to none #1043 * fix typo in the Render Pipeline Wizard #1037 * Fix emissive mesh layer mask behaviour #1062 * Fix for area light baked data not updating when changing the gizmo #1075 * Fixed an error when switch area light shape to disk while an emissive… #1112 * Have the PBR Sky not render black when below horizon #1116 * Fix area light gizmo not updating engine side light v2 #1156 * Fix XR single-pass macros in tessellation shaders #1160 * Update Override-Micro-Shadows.md (#1236) * Added disclaimer to volumes (#1247) * Fix XR Display providers not getting zNear and zFar updated on them. #1269 * Moved requirements in toc to make it consistent with URP/VFX #1352 * Docs quality fixes #1445 * Added enable Volume snippet #1477 * Update Volume-Override-Enable-Override.md * Porting console fixes to staging (#699) * Fix some NaNs issues on consoles - fix * [7.x.x Backport] Fix exposure white flash when enabling SSR (#845) * inform postprocess * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [7.x.x Backport] Fix depth pyramid issues with dynamic resolution (#849) * Port * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed Look Dev with Light Theme (#1101) * Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#1104) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Fixed issue when using Custom * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Backport 7.x.x] Fixed an issue where look dev lighting would go black when a new scene is loaded. (#1321) * Fixed an issue where look dev lighting would go black when a new scene is loaded. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Anis <anis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: victor <victor.ceitelis@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Aras Pranckevičius <aras@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com>

* property attributes not serialized (#253) * Initial tests * Fix typo * Change the VFXPropertyAttribute class * Use VFXPropertyAttributes in VFXProperty * Refactor interface * Remove old VFXPropertyAttribute class * More fixes * Fix bug in DataAnchorController * Fix invalid cast typo * Remove shader warnings (#261) * Fix shader warnings in test projects * Update changelog * Vfx/feature/filter enum (#243) * Allow filtering enums values in VFXModels. * Add an explicit GetHashCode() to default NameNType. * Update CHANGELOG.md * Update VFXHDRPSubOutput.cs * fix based on review * Remove raytracing enumerator filter as it was removed from HDRP enum * Remove irrelevant render queues from some HDRP outputs (#263) * Remove AfterPostProcessing render queue for lit outputs * Remove render queue field from distortion outputs * Update changelog * Update HDRP changelog instead of VFX * Fix issue when converting outputs with invalid render queue # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Fixed Flipbook Texture Names * Update CHANGELOG.md * Fix exception when creating new category on new visual effect asset. * Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205) * Fix to graft : support for flag enum in inspector * *Update changelog * Revert "Fix Enum Flag" (#15) * "Fix Enum Flag" (#16) This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241. * Fix for Initial Event field height, (#17) * Fix for Initial Event field height, that were clipping the bottom of legged letters * Update CHANGELOG.md * Vfx/fix colorfield height (#19) * Fix color field height * changelog * Mesh Sampling (revival) (#1) * Squashed commit of the following: commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935 Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933 Use simpler & explicit definition of propagated flags * Fix several issue/comment Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765 * Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph * Fix tooltip issue from @lewisjordan Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386 Side note : use mode instead of "addressingMode" in PositionMesh as well. * Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553 * As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777 * Add composition for Position (Mesh) as suggested by @thomasi Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Update experimental disclaimers (#367) * Updated experimental disclaimers * Removed link and added description instead. * [HDRP] MSAA & MotionVector (#12) * Support WRITE_MSAA_DEPTH Unlit template * Fix MSAA for lit output * *Update changelog * Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH TODO : Fix Sphere output as well * Fix typo in ParticlePoint * Factorize common fragment Lit & unlit for depth alike passes. * Fix particle hexadreon wrong depth with alpha clip * Revert "Fix particle hexadreon wrong depth with alpha clip" This reverts commit b16bd570440087984c2c8c48279bebb088f748e8. * Allow an object slot to have null as its value (#25) * Allow an object slot to have null as its value * changelog * Vfx/fix/prevent capacity change locked (#24) * Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode * changelog * *Update all vfx (had to do it manually...) * Restore missing enty in hdrp changelog (bad resolve conflict from me) * Fix 1233044 - capacity cannot be zero (#21) * Prevent capacity from being 0 * Fix strip capacity as well * Vfx/fix/param order (#22) * Fix for dragged parameters order when there are categories * changelog Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix minor issue with VFXPreviousPositionBinder.cs (#23) Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/fix/sgoperator create context drag (#28) * Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot. * changelog * Vfx/fix/context no blocks (#27) * Don't show block windows when context cant have blocks (output mesh ) * changelog * PropertyBinder : Minor Fixes (#29) * Fix for binder when null asset & fix for binder while resetting * Call ClearPropertyBinders while resetting * Add Update Modes & Time Access (revival) (#4) * Squashed commit of the following: commit d77638ba4188bfb03c81130b82cacb2a719f03be Merge: 49eaeadff7 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 09:46:59 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 14:53:09 2020 +0100 Update UX for new time access (#260) https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280 See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z commit 78d5d9938d9896d517efa89662764afd44ef12fc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 16:03:26 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060 commit bc7e715b0e41b55126fdf171b7459b680e3e3824 Merge: 9a82a52bfe ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 14:52:03 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88 Merge: f56986d415 66df0debfc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 09:17:53 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit f56986d4157f140ca84b039d97c8b7064a18214e Merge: 047820690f 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:25:07 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 047820690fa496bd43d3a60df16dd0932502c7cb Merge: d6d17dfbbc e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:56:39 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:59:15 2020 +0100 Squashed commit of the following: commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 13:37:05 2020 +0100 Use implicit block for old position backup commit e786cf3ade7d7515da4569dde9455881af02f282 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Jan 12 15:05:03 2020 +0100 WIP : Add option to skip zero delta per update context commit e864fae742120fbfebabb26b605ddedfd184b02b Merge: 4eecc0b90b fb12af4c28 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:47:57 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 16:08:07 2020 +0100 Rename ProcessEveryFrame in ExactFixedTimeStep commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 16:21:50 2020 +0100 Fix ManagerMaxDeltaTime (was GameDeltaTime) commit eaebe2649e93a5083fd62c91ac92185794b908e5 Merge: 98e7dcfcdc 276c02f29a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:42:08 2020 +0100 Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes commit 98e7dcfcdceb710c252e4d1a257815a724539e68 Merge: 248004d55a 0737eb535c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:26:54 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 248004d55a7b96c6532cd3c197e175b751d6f3fe Merge: 2bbadae355 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 9 13:12:50 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 2bbadae355bb3c4a308b8d4e020e96127fa94818 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:07:46 2019 +0100 Add tooltip to VFXTime.cs commit 9dc7ea790327b44ffde94bbf783d588e74c50174 Merge: bf48ba84eb 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:29:13 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit bf48ba84ebfd1472d041966ba4be627e3a1ef427 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:26:30 2019 +0100 *Update changelog.md commit b5d76d5d5d65584fde771213d9a01adc6dd9b856 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 16:10:19 2019 +0100 Add operator to enable time accesses commit 1a2fe7b8dc5072dd49d985f045f276385e08287f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 11:25:52 2019 +0100 Add built-in expression (but not listed) commit b0d0e64ee04036adf48f4481bfd22eace649bac3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:37:50 2019 +0100 Add some header commit 490a441046a227bb1cc1b98418d0559da17d3771 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:36:57 2019 +0100 Add tooltip & text content commit 621c5b2b78545800b2e94921b9314ef860992059 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:09:32 2019 +0100 *Add custom inspector to edit update flags efficiently * Fix build (VFXPropertyAttribute.Create isn't needed anymore) * Fix editor test * Read Attribute in Spawn Context (#6) * Squashed commit of the following: commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 11:14:14 2020 +0200 *Update image reference (having issue with standalone, not sure of the result) commit 275c22de35f08ada783c96c625b12475f0c42337 Merge: 85254f1ec4 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 09:59:48 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # com.unity.visualeffectgraph/CHANGELOG.md commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 16:21:39 2020 +0100 *Update image reference due to fix with grapicTest update commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf Merge: d8db341bfb 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:51:43 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset commit d8db341bfbd9257e1a5285d200e3eabe24857b01 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:57:38 2020 +0100 *Apply Formatting commit f80441dd6b30ef726d46ae2fe32bcf05d208b760 Merge: b3d858ffe1 01f176355a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:32:49 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7 Merge: 0bce44dc9a 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:18:58 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # .yamato/upm-ci-vfx_lwrp.yml # .yamato/upm-ci-vfxmain.yml # com.unity.visualeffectgraph/CHANGELOG.md commit 0bce44dc9a694bf36b849efb894e999fa9dc959e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:20:03 2020 +0100 *Fix build commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df Merge: 2130ea0ef2 e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 09:47:09 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 2130ea0ef2186ecdc5692878940d5d6635dca31b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:09:13 2020 +0100 *Update tooltips (thanks @vlad) commit f8cdb95f5d2075848e530d997551b69de43f39e0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:01:44 2020 +0100 Rename SpawnerState in SpawnState commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 13:54:24 2020 +0100 Improve ReadAttribute test to cover NewLoop state commit 2c515bfde823bfbce87df8a1444e19e5c2327e32 Merge: a9efee24ff bff1b74b59 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 16:32:45 2019 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit a9efee24ff84131c53dc2ba93f1985b02217e3d7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:54:25 2019 +0100 *Update comment commit 6b17879881555cd72b3af4463fd907423f92ad7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:53:11 2019 +0100 Throws an exception while detecting unexpected expression flag commit cbad9212075ec6776cf9d892185dd6ee64f8fab2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:43:33 2019 +0100 Reorder spawner state operator commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:35:30 2019 +0100 Fix issue "Cannot plug in attribute-derived nodes into a spawner block." commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:58:30 2019 +0100 *Update changelog commit 61bd2e5871f23002dd1add024858efdef5e09372 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:46:52 2019 +0100 Update _CCCC test & Rename Spawner State library name commit 4942912123d795023aacb0363c8e462a2da29943 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 16:58:17 2019 +0100 Fix test & clean useless code in VFXExpression.Initialize commit e6d6c593eb27c612a225340615dabe7692f76a00 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:22:31 2019 +0100 Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose commit f00f740b775f67e9378072744513f3ff920f470d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:16:39 2019 +0100 Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change) commit b7d8e238dd7e05bf99114a980c8584da7985dcf8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:45:56 2019 +0100 Clean test data & add reference images commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:17:51 2019 +0100 Move graphicTest to common files commit fa21846e7787fec9068c5a18a33dc568df3f7cc9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 11:53:18 2019 +0100 Separate cleanly per event attribute expressions commit 80e5259674a011e864e65f13c77ce06f92f33b7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 08:38:41 2019 +0100 New test for chaining & read attributes commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 18:47:20 2019 +0100 Add read attribute for loop settings (context evaluation) commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 15:30:56 2019 +0100 Clean expression patching commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 11:45:06 2019 +0100 Clarify compatibility code for spawner order & random implication commit 0dcf774f623fb93eb7bc19b06407b88669472443 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 18:42:30 2019 +0100 Add tricky case in test vfx & fix compatibility code TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 16:49:42 2019 +0100 *Up local test commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 15:22:03 2019 +0100 Detect & Compute partial evaluation commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:16:29 2019 +0100 Add spawner State Operator & SpawnCount (even if it's actually an attribute) commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:04:04 2019 +0100 Add spawner state accessor commit adb1d6d66172f2d187b577facaf7b2aea4677d13 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 11:24:20 2019 +0100 Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling commit d43ad0e1395d0e51f3583ce9627a72006356e117 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 2 16:19:05 2019 +0100 Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute commit 8a25b5fbed33569529d30379fce2acd4da7de88d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 29 16:14:32 2019 +0100 Backup test asset (temporarily) commit dcb3efaf885dbbdec317f5a42ace9ace336fded9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 16:37:48 2019 +0100 WIP : experimenting new concept of Read Attribute expression * Merge with vfx/staging * Update VFX * Misc small fixes (#36) * Fix strips outputs, spawnIndex and default metallic value * Increase threshold in particle strip unlit test * Test for Override resetted (#26) * *WIP* add test * Actually add a more legit "prefab" test * Prepare fix later fix of 1206890 : can't change the C++ without updating this test * Fix editor test (todo : graft this change to master to anticipate the C++ change) * Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20) * New Test : total time is sum of delta time (#7) * *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249 * [Fix] Disable reset option (#41) * Disable reset option * Add repro case 1251533 * Fix minor issue with PreviousPropertyBinder (bis) (#31) * Fix minor issue with VFXPreviousPositionBinder.cs * Fix exception in OnEnable Note : I didn't try it locally yet. * Actual fix of VFXPreviousPositionBinder.cs Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix culture issues when generating attributes defines in shaders (#40) * [PropertyBinder] Move Update to LateUpdate (#38) * Fix issue with VFXPropertyBinder : we should use late update instead of Update * *Update 23_ParameterBinder reference image * Call resyncslots on shadergraph dependent models. (#10) * Call resyncslots on shadergraph dependent models. * missing call to checkgraphbeforeimport * indentation * fix slot not updated if only the attributes change * Do the same for models having subgraphs than for models having shadergraphs. * Fix based on PR review * Update CHANGELOG.md * update vfx and settings * Renable 009_MultiCamera in URP project * Easy Wins (Small Workflow / Cosmetic fixes) (#37) * Properties now exposed by default in blackboard * Dissociated Colors for bool/int/uint * Added Degrees / Radians conversion subgraphs in samples * De-nicified attribute name (conserve case) in Set Custom Attribute title * Changed the default "No Asset" message when opening the visual effect graph window. * Subgraphs are not in hardcoded categories anymore + Updated Serialization * Added Documentation for setting Subgraph Menu Categories Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/docs/compatability disclaimer (#43) * Added compatability disc * Updated format. * Save a specific vfx asset and its sugraphs only (#35) * Save graph asset works * Update CHANGELOG.md * Update VisualEffectGraphWindow.md * Update VisualEffectGraphWindow.md * Fix for block copy not dirtying the scene. * Remove some unecessary compilation (not all) (#46) * New TransformVector4 and GetTextureDimensions operators (#18) * Vfx/feature/new operators 2 (#266) * Add TransformVector4 operator * Remove unused code * Fix warning * Refactor dynamic type operator * Samll fix to previous commit * Add texture dimensions operator and expressions * Add tooltips * Add changelog entry * Fix merge compilation * Modify point cache test * Prevent textures from being constant folded * Move modified test to correct folder * Output Event (#5) * Squashed commit of the following: commit 449a60793a4c5c91e1913c42632448eb07ebe5de Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:27:48 2020 +0200 Fix stackoverflow with subgraph (but doesn't fix the internal workflow) commit caf0df3af5f451f9576c2cc7f328b57a87479f30 Merge: bb1047c59a a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 10:22:47 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/output-event commit bb1047c59a084551e7df3b93d7d5ad501145ecaf Merge: 7b2890b76f 98ce4878d1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 17:17:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:54:17 2020 +0100 Add a check of outputEvent in SpawnerTest commit 945992b2feff4b8f7a24740944c77a4a92f271dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:24:56 2020 +0100 *Update OutputEventTest.cs to check Test_Output_Event commit c48fda763e807503f27f98deeda4238b6628c264 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 18 10:17:21 2020 +0100 *Update image reference & Test (stop using a undebuggeable random position) commit 5a5ad49cb485907ee869445627821810589ab34a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 22:12:58 2020 +0100 Fix newly integrated spawn test for output event commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c Merge: ef4837245e 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 17:53:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs commit ef4837245e1d88846f6d686e2803094d1d6cd04d Merge: 2331c32fb4 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 08:30:00 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda Merge: 5d225d6e19 0103971ce2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Feb 6 08:01:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 5d225d6e192b32394faf0964ad263cc33c5280cc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:01:51 2020 +0100 Fix editor test commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:00:35 2020 +0100 Add distinct while retrieving virtual link commit 725252869ac24d962490b4550821fbba2ab119b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Feb 3 14:38:52 2020 +0100 *WIP* Output test commit 96098fa11f4781837543fba099936b15a8c7158d Merge: 02178104a3 bb04ca28fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 31 14:07:02 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 02178104a301fb434d5e6821cd369884bbc01006 Merge: 1443b66691 db8325ba2b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 18:06:20 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 1443b66691d46ed9598ccc26b0b9425d373b61e1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:37:08 2020 +0100 *Reduce unexpected changes commit aa1afcafa9c95d042db146043c60015d3f5c96f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:31:13 2020 +0100 New UX for output event (use data instead of system name) (#229) * *WIP* Experiment for UX using eventName * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name * Remove useless naming pattern linking label & title for output Cleaner & Safer implementation for outputEvent edition * Use unique system naming * Add test for Data for VFXOutputEvent * Fix hacky OnInvalidate commit 9cd41b81cef062991907d5ce446336bde78b79d3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 15:11:39 2020 +0100 Add editor test to check return value of output event (not attribute, already cover by graphic test) commit 1a09c63a98e4650b82160e670cedfb06b630284d Merge: 35126156f2 52ce8b9636 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 11:02:45 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 35126156f2b93b04543de0eb91aca79adf331b2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 17 13:58:06 2020 +0100 Avoid exception if system isn't present yet commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 16 10:53:13 2020 +0100 *Update Test, adding a test on unused source attribute commit bfd29d8862539cef5b14392e21cbd896436339a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 20:20:59 2020 +0100 Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test) commit d89160df852b64a4b5ecf378c506aa0c9f1c099c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 16:13:02 2020 +0100 Filters out orphan output event context commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 14:30:08 2020 +0100 *Update changelog commit cf54e5372e273f86dd5c2e00a6178a543f234fd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 08:40:09 2020 +0100 Add reference image for HDRP commit d710998eb133a3dbadbdec580d1ecad3752aca85 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:17:28 2020 +0100 Add reference images for newly added test commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 15:23:18 2020 +0100 *Add a material to unit test commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 17:02:27 2020 +0100 Start implementing a effective test project commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 16:56:28 2020 +0100 FIx system name synchronisation (not really ideal) commit 7782b888266a011f4f986a7bb3161f024730caa7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 14:24:08 2020 +0100 Fix UI of output event commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 10:11:56 2020 +0100 Fix build commit 50ae031af02d4c41e651f64b40e9d265668b803f Merge: d838cd2d37 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 7 13:36:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 14:58:00 2019 +0100 Add a wip test scene commit 459b344b3f97c794d47a8eb6942b1129d18632cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 11:40:30 2019 +0100 Fill VFXDataOutputEvent commit e54905485dd553cadcde307ca00a8d7ce8454c0f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 18:21:31 2019 +0100 Add basic output event type (empty FillDesc implementation for now) * Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP* * Update 009_OutputEvent test * Move 009_OutputEvent to correct folder (TODO, this to rename it before merge) * Fix sanity test & allow multiple connection from in outputEvent (as initialize) * Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context * Fix editor test using eventName instead of tile * Revert unexpected changes * *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485 * Rename VisualEffectOutputEventArgs => VFXOutputEventArgs * Disable connection from OutputEvent to GPUEvent * *Fix build VisualEffect.OutputEventArgs => VFXOutputEventArgs Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5 * Vfx/feature/enum parameter (#8) * Restart of enum parameters * more work * more work * Still more work. * reorderable list looks good. * Adding and removing values works. * dragging item works. * Enum values show in the inspector. * fixes for rebase * Enumvalue works on subgraphs. * notify enum name change. * Added documentation for blackboard value filtering. * no value per enum * only uint can now avec enum values. * don't nicify enum values. * Update Blackboard.md * Update VFXBlackboard.uss * sanitize parameter already having range * Clamp enum value works. * Changing switch testValue to uint. * value appearing as menu if mode is enum. * Update CHANGELOG.md * Mutli editor of different values of enum parameter works. * cpoy paste enumValues and min/max when copying parameter. * Copy parameter mode when converting to subgraph. * fix * Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt. * Vfx/docs/new operator docs (#50) * Added documentation for new operators * Changed bullet format. * Fix creation of StringPropertyRM (#51) * Fix creation of StringPropertyRM * Update CHANGELOG.md * Fix input of event emitting block beeing to small because of output * Multi-mesh output, LODs and compute culling (#14) * Implement multi mesh * Add LOD + lit mesh output support * Small fix + optim * Fix crash with multi mesh + sorting * Fix shader compilation with single mesh and compute culling * implement multi sorting * Add globalSort parameter * Fix camera absolute mode * Fix URP shader compilation * Add frustum culling to LOD * Add frustum culling setting * filter out implicit settings and add tooltips * Add radius scale + tooltips * Add a graphics test * Update change log + lod and multi mesh as experimental features * Forgot a file * Small changes based on QA review * Simulate headers on enum values in SlotContainerEditor (#49) * Simulate headers on enum values in SlotContainerEditor * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Update VFX * Fix for blackboard scrollable element hidden by resize. * Disable LOD test for XR * Fix test threshold that was reset to 0... * Ignoer graphviz folder * Target Gameobject windows resize doesn't go too far above scrollbars * Missing or incorrect unit in uss. * fix for reference image "VFX/Execution" not updated to new path ( warning when adding output) * Change description in package.json to reflect VFX is not out of preview with URP and mobile * Simplify linear drag (#67) * Simplify linear drag * Fix warning * Enable m_CachingShaderPreprocessor (#65) * *Enable m_CachingShaderPreprocessor * Try enabling vulkan * Unify m_APIs in URP & HDRP * Fix for node window staying when clicking elsewhere (#68) * Fix for node window stayting when clicking elsewhere * Update CHANGELOG.md * Prevent resourcehistory from beeing set to null by serialization (#66) * Vfx/docs/system requirements (#69) * Added system requirements documentation. * Corrected phrasing * Added toc entry * Reorganised toc entry Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix position of block creation window (#72) * Fix Missing System Seed Builtin (#70) * Add missing system seed variant * Add test to cover all builtin expression are available through operator (avoid regression) * *Update changelog.md * Fix inconsistant case * Fix indentation * Fix Prefab Highlight for initial event name toggle & override (#71) * Fix prefab blue highlight * *Update changelog.md * Add test for Mesh Stripping (#59) * *Add test data * Enable StripUnusedMeshComponents: 1 * Enable mesh stripping in HDRP project * *Add reference images * Call recreateCopy after recusion test not before. (#52) * Call recreateCopy after recusion test not before. * Update CHANGELOG.md * Uniquify create visual effect gameobject name. Standard behaviour. (#75) * Uniquify create visual effect gameobject name. Standard behaviour. * Update CHANGELOG.md * Use the AssetDatabase.FindAsset to find VFXResources asset (#48) * Use the AssetDatabase.FindAsset to find VFXResources asset * Update CHANGELOG.md * Search VFXResource only if necessary. * LoadUserResourcesIfNeeded * Fix changelog merge * Added feature: User can specify a directory that holds their VFX template assets (#34) Added feature: User can specify a directory that holds their VFX template assets Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu. ## How to use The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems ![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d) Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option. ![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df) This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders. ![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f) Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed: ![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2) * Vfx/fix/1246989 normals and scale (#81) * Fix normal for lit mesh and non uniform scales * Use inverse transpose in planar primitives * Fix planar primitive with non uniform scale in local * Add gfx test * Add comment * Update changelog * Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76) * Fix Texture2DArray and Cubemap exposition from sg in output mesh context * Add case to changelog * Temporarily deactivate non uniform scale test (Some files were lost :() * [Test] Enable test to cover properly reset override behavior (#80) * Renable test to cover issue 1206890 * Fix newly introduced test : Exepcted value is original after reset override & handle correctly color * int and uint support in Compare (#53) * Add int and uint to Compare node and condition expression * minor fixes * Change SerializeType so that tests are correct against System.Type and null * Fix switch * Update changelog * Added render pipeline compatability table (#87) Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix square complexity on parameter to serialized property matching (#78) * Fix square complexity on parameter to serialized property matching * Update CHANGELOG.md * Fix vfx view not beeing framed at launch (#79) * Fix vfx view not beeing framed at launch * safer implementation * Update CHANGELOG.md * Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84) * Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null * Update CHANGELOG.md * SampleSDF operator (#88) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Fix Shadow compilation using shaderGraph (URP/HDRP) (#77) * *Prepare a proper way to test different shadow cases * prepare a shadow graph unlit (modifying alpha) * Add reference data for shadow test * Minimal data for reproduce issue 1259511 * Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define * *Update ShadowMaterial * *Update ShaderGraphShadow.vfx * *Move shader to common testing asset * Add equivalent test for URP * Add graphicTest for URP * *Update reference images * Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting * Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence * Fix incorrect block listing * *Update changelog.md * Fix pass selection for lit effect * Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution * Voluntary add disabled branch on shadow unlit to cover alphaTreshold case * *Minor comment * Fix return alpha clipping (missing actual alpha test enabled) * *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging) * VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.' # Conflicts: # com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template * Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset * *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f) * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288 It was a bad merge Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96) * Fix missing type copy in reduce Tested locally on a PS4 * Add expection to detect unsupported value type * Fix 1154328 - infinite recompile with rand (#93) * Change the way rand expression equality is handled * Refactor a bit * Add editor test * World to Viewport Point & Viewport to World Point operators + Test (#98) * World to Viewport Point & Viewport to World Point operators + Test First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator. Includes a test scene for these 2 operators. * Update CHANGELOG.md Update Changelog * Added documentation md files. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Make null ( not deserializable ) objects part of undo state (#86) * Fix compile loop in vfxoperator (#61) * Update to visual studio package 2.0.2 (#74) * Fix SDF Operators and blocks from PR #88 (#94) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Remove the use of inverse transpose for the "normals" * Restore the Inverse Transpose and modify Collision code * Restore Conform and Collide previous behavior + direction points to the surface * add documentation * Consistent distance and normal handling + ref images * Cleaning + World space stick distance and radius + references * Max scale through expression evaluated on GPU (if needed) * Max3 on CPU * Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91) * Simpler update to use now available ByteAddressBuffer * Temp Workaround a GPU hang We should isolate properly this code. * Proper fix of OOB FetchBuffer * *Update changelog.md * Update assets * Update URP tests assets * More update to assets * Remove old gfx tests images ref * Fix changelog * Fix Construct Matrix on GPU (#102) * Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU * *Update changelog.md * Output Event Helpers (#58) * Base Commit * Moved Files down one folder * Updated Package Configuration, CHANGELOG and documentation * Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour * Small fixes and checks * Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check * Small Fixes * Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly * Other custom Editors + Helpbox * Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in Prefab Spawn * Removed Rerouting Helpers as CopyValuesFrom is broken at the moment. * Fixed ASMDEFs / class accessibility * Updated Documentation * Fixed Class Accessibility for ExposedPropertyDrawer * Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer) Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Add support for Gradient sampling with and without gradient mode #100 * Fix changelog * Fix case 1279294 : Invalid Random per component behavior in spawn context (#107) * Revert "Output Event Helpers" (#110) * Revert "Output Event Helpers (#58)" This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78. * Revert "Fix changelog" This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137. * Fix changelog (missing revert) * Fix changelog : Unexpected carriage return * Point cache: Binary format corrupted due to an extra byte offset (#108) * Point cache header, wait for new line character only (/n) and skip carriage return(/r) An extra trailing new line character was causing an invalid offset in binary point cache files. * Update Changelog * Remove unnecessary files * Fix InvalidCastException when using byte properties in point cache files (#109) * Change casting to byte We were trying to cast an object containing a byte to an int. Also, a better normalization would be dividing by 255. * Update CHANGELOG.md * update asset and scripts * Remove u…

* Add alembic test to HDRP_DXR_Tests * Update alembic reference images * Use Yamato reference images * XR test updated reference image * Revert reference image for WindowsEditor. It looks like playmode_XR has a different result than playmode and playmode_Rendergraph * Modify alembic test to confirm alembic works with ray tracing by viewing alembic mesh via ray traced reflection * Set XR threshold multiplier to 1.5, based on other tests that have to wait for frame * Update WindowsEditor reference image * updated most prefabs to not be prefab variants unecesssarily, updated diffusion profile for bamboo leaves, fixed wood normal map, rebaked, added new "medium" bake settings * [CI] Updated .ymls to new revision * Expose PointCacheAsset textures (#2030) Currently there's no pCache property in vfx graph, this change exposes textures to make them usable instead of pCache. More: https://forum.unity.com/threads/expose-point-cache-as-blackboard-attribute.856603/#post-6355635 * Fixed links and images Fixed issues in the ToC, links in all docs and images in all docs. * Fix Static-shader-analysis.md links. Changed file name of Static-shader-analysis.md and fixed links. * removed useless -preview.1 * Toc name change Also amended links. * TableOfContents name change. * Universal/fixing changelog (#2090) * removing duplicate Added sections * removed accidental added text * Fixed the dates issue * Moved fixed to the right section * Updated fontainbleau compatability and added relevant links * Fix clear coat chagelog issues. (#2095) * Renamed UI `Vector1` to `Float` / Renamed enum `Float` precision to `Single` (V2) (#1979) * rename precision from float to single * rename vector 1 to float * rename vector1 in the documentation * Update Compositor-User-Guide.md * Update Upgrade-Guide-10-0-x.md * fix precision test * add search synonym to upgraded node * update precision test graph * Fixed extra whitespaces and minor rewording * Rename also all enum which a Vector1 inside to get correct string conversion as float * Renamed Float.md and updated links to it * Revert "Rename also all enum which a Vector1 inside to get correct string conversion as float" This reverts commit 3d5fe9b48a1c2b7642b40327c5fea7a259016638. * rename property type to have correct type display * Update DiffusionProfileShaderProperty.cs * Fix blackboard info name after merge of Antoie PR * rename the uss color mode to keep correct banding color Co-authored-by: Alex Lindman <alexandral@unity3d.com> Co-authored-by: Sharlene Tan <sharlenet@unity3d.com> * VFX Staging to Master for 10.1 (#1945) * property attributes not serialized (#253) * Initial tests * Fix typo * Change the VFXPropertyAttribute class * Use VFXPropertyAttributes in VFXProperty * Refactor interface * Remove old VFXPropertyAttribute class * More fixes * Fix bug in DataAnchorController * Fix invalid cast typo * Remove shader warnings (#261) * Fix shader warnings in test projects * Update changelog * Vfx/feature/filter enum (#243) * Allow filtering enums values in VFXModels. * Add an explicit GetHashCode() to default NameNType. * Update CHANGELOG.md * Update VFXHDRPSubOutput.cs * fix based on review * Remove raytracing enumerator filter as it was removed from HDRP enum * Remove irrelevant render queues from some HDRP outputs (#263) * Remove AfterPostProcessing render queue for lit outputs * Remove render queue field from distortion outputs * Update changelog * Update HDRP changelog instead of VFX * Fix issue when converting outputs with invalid render queue # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Fixed Flipbook Texture Names * Update CHANGELOG.md * Fix exception when creating new category on new visual effect asset. * Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205) * Fix to graft : support for flag enum in inspector * *Update changelog * Revert "Fix Enum Flag" (#15) * "Fix Enum Flag" (#16) This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241. * Fix for Initial Event field height, (#17) * Fix for Initial Event field height, that were clipping the bottom of legged letters * Update CHANGELOG.md * Vfx/fix colorfield height (#19) * Fix color field height * changelog * Mesh Sampling (revival) (#1) * Squashed commit of the following: commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935 Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933 Use simpler & explicit definition of propagated flags * Fix several issue/comment Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765 * Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph * Fix tooltip issue from @lewisjordan Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386 Side note : use mode instead of "addressingMode" in PositionMesh as well. * Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553 * As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777 * Add composition for Position (Mesh) as suggested by @thomasi Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Update experimental disclaimers (#367) * Updated experimental disclaimers * Removed link and added description instead. * [HDRP] MSAA & MotionVector (#12) * Support WRITE_MSAA_DEPTH Unlit template * Fix MSAA for lit output * *Update changelog * Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH TODO : Fix Sphere output as well * Fix typo in ParticlePoint * Factorize common fragment Lit & unlit for depth alike passes. * Fix particle hexadreon wrong depth with alpha clip * Revert "Fix particle hexadreon wrong depth with alpha clip" This reverts commit b16bd570440087984c2c8c48279bebb088f748e8. * Allow an object slot to have null as its value (#25) * Allow an object slot to have null as its value * changelog * Vfx/fix/prevent capacity change locked (#24) * Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode * changelog * *Update all vfx (had to do it manually...) * Restore missing enty in hdrp changelog (bad resolve conflict from me) * Fix 1233044 - capacity cannot be zero (#21) * Prevent capacity from being 0 * Fix strip capacity as well * Vfx/fix/param order (#22) * Fix for dragged parameters order when there are categories * changelog Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix minor issue with VFXPreviousPositionBinder.cs (#23) Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/fix/sgoperator create context drag (#28) * Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot. * changelog * Vfx/fix/context no blocks (#27) * Don't show block windows when context cant have blocks (output mesh ) * changelog * PropertyBinder : Minor Fixes (#29) * Fix for binder when null asset & fix for binder while resetting * Call ClearPropertyBinders while resetting * Add Update Modes & Time Access (revival) (#4) * Squashed commit of the following: commit d77638ba4188bfb03c81130b82cacb2a719f03be Merge: 49eaeadff7 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 09:46:59 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 14:53:09 2020 +0100 Update UX for new time access (#260) https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280 See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z commit 78d5d9938d9896d517efa89662764afd44ef12fc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 16:03:26 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060 commit bc7e715b0e41b55126fdf171b7459b680e3e3824 Merge: 9a82a52bfe ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 14:52:03 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88 Merge: f56986d415 66df0debfc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 09:17:53 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit f56986d4157f140ca84b039d97c8b7064a18214e Merge: 047820690f 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:25:07 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 047820690fa496bd43d3a60df16dd0932502c7cb Merge: d6d17dfbbc e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:56:39 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:59:15 2020 +0100 Squashed commit of the following: commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 13:37:05 2020 +0100 Use implicit block for old position backup commit e786cf3ade7d7515da4569dde9455881af02f282 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Jan 12 15:05:03 2020 +0100 WIP : Add option to skip zero delta per update context commit e864fae742120fbfebabb26b605ddedfd184b02b Merge: 4eecc0b90b fb12af4c28 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:47:57 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 16:08:07 2020 +0100 Rename ProcessEveryFrame in ExactFixedTimeStep commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 16:21:50 2020 +0100 Fix ManagerMaxDeltaTime (was GameDeltaTime) commit eaebe2649e93a5083fd62c91ac92185794b908e5 Merge: 98e7dcfcdc 276c02f29a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:42:08 2020 +0100 Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes commit 98e7dcfcdceb710c252e4d1a257815a724539e68 Merge: 248004d55a 0737eb535c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:26:54 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 248004d55a7b96c6532cd3c197e175b751d6f3fe Merge: 2bbadae355 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 9 13:12:50 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 2bbadae355bb3c4a308b8d4e020e96127fa94818 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:07:46 2019 +0100 Add tooltip to VFXTime.cs commit 9dc7ea790327b44ffde94bbf783d588e74c50174 Merge: bf48ba84eb 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:29:13 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit bf48ba84ebfd1472d041966ba4be627e3a1ef427 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:26:30 2019 +0100 *Update changelog.md commit b5d76d5d5d65584fde771213d9a01adc6dd9b856 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 16:10:19 2019 +0100 Add operator to enable time accesses commit 1a2fe7b8dc5072dd49d985f045f276385e08287f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 11:25:52 2019 +0100 Add built-in expression (but not listed) commit b0d0e64ee04036adf48f4481bfd22eace649bac3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:37:50 2019 +0100 Add some header commit 490a441046a227bb1cc1b98418d0559da17d3771 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:36:57 2019 +0100 Add tooltip & text content commit 621c5b2b78545800b2e94921b9314ef860992059 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:09:32 2019 +0100 *Add custom inspector to edit update flags efficiently * Fix build (VFXPropertyAttribute.Create isn't needed anymore) * Fix editor test * Read Attribute in Spawn Context (#6) * Squashed commit of the following: commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 11:14:14 2020 +0200 *Update image reference (having issue with standalone, not sure of the result) commit 275c22de35f08ada783c96c625b12475f0c42337 Merge: 85254f1ec4 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 09:59:48 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # com.unity.visualeffectgraph/CHANGELOG.md commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 16:21:39 2020 +0100 *Update image reference due to fix with grapicTest update commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf Merge: d8db341bfb 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:51:43 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset commit d8db341bfbd9257e1a5285d200e3eabe24857b01 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:57:38 2020 +0100 *Apply Formatting commit f80441dd6b30ef726d46ae2fe32bcf05d208b760 Merge: b3d858ffe1 01f176355a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:32:49 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7 Merge: 0bce44dc9a 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:18:58 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # .yamato/upm-ci-vfx_lwrp.yml # .yamato/upm-ci-vfxmain.yml # com.unity.visualeffectgraph/CHANGELOG.md commit 0bce44dc9a694bf36b849efb894e999fa9dc959e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:20:03 2020 +0100 *Fix build commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df Merge: 2130ea0ef2 e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 09:47:09 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 2130ea0ef2186ecdc5692878940d5d6635dca31b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:09:13 2020 +0100 *Update tooltips (thanks @vlad) commit f8cdb95f5d2075848e530d997551b69de43f39e0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:01:44 2020 +0100 Rename SpawnerState in SpawnState commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 13:54:24 2020 +0100 Improve ReadAttribute test to cover NewLoop state commit 2c515bfde823bfbce87df8a1444e19e5c2327e32 Merge: a9efee24ff bff1b74b59 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 16:32:45 2019 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit a9efee24ff84131c53dc2ba93f1985b02217e3d7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:54:25 2019 +0100 *Update comment commit 6b17879881555cd72b3af4463fd907423f92ad7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:53:11 2019 +0100 Throws an exception while detecting unexpected expression flag commit cbad9212075ec6776cf9d892185dd6ee64f8fab2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:43:33 2019 +0100 Reorder spawner state operator commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:35:30 2019 +0100 Fix issue "Cannot plug in attribute-derived nodes into a spawner block." commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:58:30 2019 +0100 *Update changelog commit 61bd2e5871f23002dd1add024858efdef5e09372 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:46:52 2019 +0100 Update _CCCC test & Rename Spawner State library name commit 4942912123d795023aacb0363c8e462a2da29943 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 16:58:17 2019 +0100 Fix test & clean useless code in VFXExpression.Initialize commit e6d6c593eb27c612a225340615dabe7692f76a00 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:22:31 2019 +0100 Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose commit f00f740b775f67e9378072744513f3ff920f470d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:16:39 2019 +0100 Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change) commit b7d8e238dd7e05bf99114a980c8584da7985dcf8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:45:56 2019 +0100 Clean test data & add reference images commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:17:51 2019 +0100 Move graphicTest to common files commit fa21846e7787fec9068c5a18a33dc568df3f7cc9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 11:53:18 2019 +0100 Separate cleanly per event attribute expressions commit 80e5259674a011e864e65f13c77ce06f92f33b7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 08:38:41 2019 +0100 New test for chaining & read attributes commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 18:47:20 2019 +0100 Add read attribute for loop settings (context evaluation) commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 15:30:56 2019 +0100 Clean expression patching commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 11:45:06 2019 +0100 Clarify compatibility code for spawner order & random implication commit 0dcf774f623fb93eb7bc19b06407b88669472443 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 18:42:30 2019 +0100 Add tricky case in test vfx & fix compatibility code TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 16:49:42 2019 +0100 *Up local test commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 15:22:03 2019 +0100 Detect & Compute partial evaluation commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:16:29 2019 +0100 Add spawner State Operator & SpawnCount (even if it's actually an attribute) commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:04:04 2019 +0100 Add spawner state accessor commit adb1d6d66172f2d187b577facaf7b2aea4677d13 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 11:24:20 2019 +0100 Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling commit d43ad0e1395d0e51f3583ce9627a72006356e117 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 2 16:19:05 2019 +0100 Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute commit 8a25b5fbed33569529d30379fce2acd4da7de88d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 29 16:14:32 2019 +0100 Backup test asset (temporarily) commit dcb3efaf885dbbdec317f5a42ace9ace336fded9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 16:37:48 2019 +0100 WIP : experimenting new concept of Read Attribute expression * Merge with vfx/staging * Update VFX * Misc small fixes (#36) * Fix strips outputs, spawnIndex and default metallic value * Increase threshold in particle strip unlit test * Test for Override resetted (#26) * *WIP* add test * Actually add a more legit "prefab" test * Prepare fix later fix of 1206890 : can't change the C++ without updating this test * Fix editor test (todo : graft this change to master to anticipate the C++ change) * Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20) * New Test : total time is sum of delta time (#7) * *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249 * [Fix] Disable reset option (#41) * Disable reset option * Add repro case 1251533 * Fix minor issue with PreviousPropertyBinder (bis) (#31) * Fix minor issue with VFXPreviousPositionBinder.cs * Fix exception in OnEnable Note : I didn't try it locally yet. * Actual fix of VFXPreviousPositionBinder.cs Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix culture issues when generating attributes defines in shaders (#40) * [PropertyBinder] Move Update to LateUpdate (#38) * Fix issue with VFXPropertyBinder : we should use late update instead of Update * *Update 23_ParameterBinder reference image * Call resyncslots on shadergraph dependent models. (#10) * Call resyncslots on shadergraph dependent models. * missing call to checkgraphbeforeimport * indentation * fix slot not updated if only the attributes change * Do the same for models having subgraphs than for models having shadergraphs. * Fix based on PR review * Update CHANGELOG.md * update vfx and settings * Renable 009_MultiCamera in URP project * Easy Wins (Small Workflow / Cosmetic fixes) (#37) * Properties now exposed by default in blackboard * Dissociated Colors for bool/int/uint * Added Degrees / Radians conversion subgraphs in samples * De-nicified attribute name (conserve case) in Set Custom Attribute title * Changed the default "No Asset" message when opening the visual effect graph window. * Subgraphs are not in hardcoded categories anymore + Updated Serialization * Added Documentation for setting Subgraph Menu Categories Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/docs/compatability disclaimer (#43) * Added compatability disc * Updated format. * Save a specific vfx asset and its sugraphs only (#35) * Save graph asset works * Update CHANGELOG.md * Update VisualEffectGraphWindow.md * Update VisualEffectGraphWindow.md * Fix for block copy not dirtying the scene. * Remove some unecessary compilation (not all) (#46) * New TransformVector4 and GetTextureDimensions operators (#18) * Vfx/feature/new operators 2 (#266) * Add TransformVector4 operator * Remove unused code * Fix warning * Refactor dynamic type operator * Samll fix to previous commit * Add texture dimensions operator and expressions * Add tooltips * Add changelog entry * Fix merge compilation * Modify point cache test * Prevent textures from being constant folded * Move modified test to correct folder * Output Event (#5) * Squashed commit of the following: commit 449a60793a4c5c91e1913c42632448eb07ebe5de Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:27:48 2020 +0200 Fix stackoverflow with subgraph (but doesn't fix the internal workflow) commit caf0df3af5f451f9576c2cc7f328b57a87479f30 Merge: bb1047c59a a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 10:22:47 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/output-event commit bb1047c59a084551e7df3b93d7d5ad501145ecaf Merge: 7b2890b76f 98ce4878d1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 17:17:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:54:17 2020 +0100 Add a check of outputEvent in SpawnerTest commit 945992b2feff4b8f7a24740944c77a4a92f271dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:24:56 2020 +0100 *Update OutputEventTest.cs to check Test_Output_Event commit c48fda763e807503f27f98deeda4238b6628c264 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 18 10:17:21 2020 +0100 *Update image reference & Test (stop using a undebuggeable random position) commit 5a5ad49cb485907ee869445627821810589ab34a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 22:12:58 2020 +0100 Fix newly integrated spawn test for output event commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c Merge: ef4837245e 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 17:53:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs commit ef4837245e1d88846f6d686e2803094d1d6cd04d Merge: 2331c32fb4 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 08:30:00 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda Merge: 5d225d6e19 0103971ce2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Feb 6 08:01:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 5d225d6e192b32394faf0964ad263cc33c5280cc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:01:51 2020 +0100 Fix editor test commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:00:35 2020 +0100 Add distinct while retrieving virtual link commit 725252869ac24d962490b4550821fbba2ab119b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Feb 3 14:38:52 2020 +0100 *WIP* Output test commit 96098fa11f4781837543fba099936b15a8c7158d Merge: 02178104a3 bb04ca28fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 31 14:07:02 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 02178104a301fb434d5e6821cd369884bbc01006 Merge: 1443b66691 db8325ba2b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 18:06:20 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 1443b66691d46ed9598ccc26b0b9425d373b61e1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:37:08 2020 +0100 *Reduce unexpected changes commit aa1afcafa9c95d042db146043c60015d3f5c96f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:31:13 2020 +0100 New UX for output event (use data instead of system name) (#229) * *WIP* Experiment for UX using eventName * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name * Remove useless naming pattern linking label & title for output Cleaner & Safer implementation for outputEvent edition * Use unique system naming * Add test for Data for VFXOutputEvent * Fix hacky OnInvalidate commit 9cd41b81cef062991907d5ce446336bde78b79d3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 15:11:39 2020 +0100 Add editor test to check return value of output event (not attribute, already cover by graphic test) commit 1a09c63a98e4650b82160e670cedfb06b630284d Merge: 35126156f2 52ce8b9636 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 11:02:45 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 35126156f2b93b04543de0eb91aca79adf331b2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 17 13:58:06 2020 +0100 Avoid exception if system isn't present yet commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 16 10:53:13 2020 +0100 *Update Test, adding a test on unused source attribute commit bfd29d8862539cef5b14392e21cbd896436339a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 20:20:59 2020 +0100 Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test) commit d89160df852b64a4b5ecf378c506aa0c9f1c099c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 16:13:02 2020 +0100 Filters out orphan output event context commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 14:30:08 2020 +0100 *Update changelog commit cf54e5372e273f86dd5c2e00a6178a543f234fd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 08:40:09 2020 +0100 Add reference image for HDRP commit d710998eb133a3dbadbdec580d1ecad3752aca85 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:17:28 2020 +0100 Add reference images for newly added test commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 15:23:18 2020 +0100 *Add a material to unit test commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 17:02:27 2020 +0100 Start implementing a effective test project commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 16:56:28 2020 +0100 FIx system name synchronisation (not really ideal) commit 7782b888266a011f4f986a7bb3161f024730caa7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 14:24:08 2020 +0100 Fix UI of output event commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 10:11:56 2020 +0100 Fix build commit 50ae031af02d4c41e651f64b40e9d265668b803f Merge: d838cd2d37 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 7 13:36:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 14:58:00 2019 +0100 Add a wip test scene commit 459b344b3f97c794d47a8eb6942b1129d18632cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 11:40:30 2019 +0100 Fill VFXDataOutputEvent commit e54905485dd553cadcde307ca00a8d7ce8454c0f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 18:21:31 2019 +0100 Add basic output event type (empty FillDesc implementation for now) * Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP* * Update 009_OutputEvent test * Move 009_OutputEvent to correct folder (TODO, this to rename it before merge) * Fix sanity test & allow multiple connection from in outputEvent (as initialize) * Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context * Fix editor test using eventName instead of tile * Revert unexpected changes * *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485 * Rename VisualEffectOutputEventArgs => VFXOutputEventArgs * Disable connection from OutputEvent to GPUEvent * *Fix build VisualEffect.OutputEventArgs => VFXOutputEventArgs Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5 * Vfx/feature/enum parameter (#8) * Restart of enum parameters * more work * more work * Still more work. * reorderable list looks good. * Adding and removing values works. * dragging item works. * Enum values show in the inspector. * fixes for rebase * Enumvalue works on subgraphs. * notify enum name change. * Added documentation for blackboard value filtering. * no value per enum * only uint can now avec enum values. * don't nicify enum values. * Update Blackboard.md * Update VFXBlackboard.uss * sanitize parameter already having range * Clamp enum value works. * Changing switch testValue to uint. * value appearing as menu if mode is enum. * Update CHANGELOG.md * Mutli editor of different values of enum parameter works. * cpoy paste enumValues and min/max when copying parameter. * Copy parameter mode when converting to subgraph. * fix * Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt. * Vfx/docs/new operator docs (#50) * Added documentation for new operators * Changed bullet format. * Fix creation of StringPropertyRM (#51) * Fix creation of StringPropertyRM * Update CHANGELOG.md * Fix input of event emitting block beeing to small because of output * Multi-mesh output, LODs and compute culling (#14) * Implement multi mesh * Add LOD + lit mesh output support * Small fix + optim * Fix crash with multi mesh + sorting * Fix shader compilation with single mesh and compute culling * implement multi sorting * Add globalSort parameter * Fix camera absolute mode * Fix URP shader compilation * Add frustum culling to LOD * Add frustum culling setting * filter out implicit settings and add tooltips * Add radius scale + tooltips * Add a graphics test * Update change log + lod and multi mesh as experimental features * Forgot a file * Small changes based on QA review * Simulate headers on enum values in SlotContainerEditor (#49) * Simulate headers on enum values in SlotContainerEditor * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Update VFX * Fix for blackboard scrollable element hidden by resize. * Disable LOD test for XR * Fix test threshold that was reset to 0... * Ignoer graphviz folder * Target Gameobject windows resize doesn't go too far above scrollbars * Missing or incorrect unit in uss. * fix for reference image "VFX/Execution" not updated to new path ( warning when adding output) * Change description in package.json to reflect VFX is not out of preview with URP and mobile * Simplify linear drag (#67) * Simplify linear drag * Fix warning * Enable m_CachingShaderPreprocessor (#65) * *Enable m_CachingShaderPreprocessor * Try enabling vulkan * Unify m_APIs in URP & HDRP * Fix for node window staying when clicking elsewhere (#68) * Fix for node window stayting when clicking elsewhere * Update CHANGELOG.md * Prevent resourcehistory from beeing set to null by serialization (#66) * Vfx/docs/system requirements (#69) * Added system requirements documentation. * Corrected phrasing * Added toc entry * Reorganised toc entry Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix position of block creation window (#72) * Fix Missing System Seed Builtin (#70) * Add missing system seed variant * Add test to cover all builtin expression are available through operator (avoid regression) * *Update changelog.md * Fix inconsistant case * Fix indentation * Fix Prefab Highlight for initial event name toggle & override (#71) * Fix prefab blue highlight * *Update changelog.md * Add test for Mesh Stripping (#59) * *Add test data * Enable StripUnusedMeshComponents: 1 * Enable mesh stripping in HDRP project * *Add reference images * Call recreateCopy after recusion test not before. (#52) * Call recreateCopy after recusion test not before. * Update CHANGELOG.md * Uniquify create visual effect gameobject name. Standard behaviour. (#75) * Uniquify create visual effect gameobject name. Standard behaviour. * Update CHANGELOG.md * Use the AssetDatabase.FindAsset to find VFXResources asset (#48) * Use the AssetDatabase.FindAsset to find VFXResources asset * Update CHANGELOG.md * Search VFXResource only if necessary. * LoadUserResourcesIfNeeded * Fix changelog merge * Added feature: User can specify a directory that holds their VFX template assets (#34) Added feature: User can specify a directory that holds their VFX template assets Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu. ## How to use The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems ![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d) Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option. ![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df) This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders. ![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f) Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed: ![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2) * Vfx/fix/1246989 normals and scale (#81) * Fix normal for lit mesh and non uniform scales * Use inverse transpose in planar primitives * Fix planar primitive with non uniform scale in local * Add gfx test * Add comment * Update changelog * Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76) * Fix Texture2DArray and Cubemap exposition from sg in output mesh context * Add case to changelog * Temporarily deactivate non uniform scale test (Some files were lost :() * [Test] Enable test to cover properly reset override behavior (#80) * Renable test to cover issue 1206890 * Fix newly introduced test : Exepcted value is original after reset override & handle correctly color * int and uint support in Compare (#53) * Add int and uint to Compare node and condition expression * minor fixes * Change SerializeType so that tests are correct against System.Type and null * Fix switch * Update changelog * Added render pipeline compatability table (#87) Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix square complexity on parameter to serialized property matching (#78) * Fix square complexity on parameter to serialized property matching * Update CHANGELOG.md * Fix vfx view not beeing framed at launch (#79) * Fix vfx view not beeing framed at launch * safer implementation * Update CHANGELOG.md * Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84) * Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null * Update CHANGELOG.md * SampleSDF operator (#88) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Fix Shadow compilation using shaderGraph (URP/HDRP) (#77) * *Prepare a proper way to test different shadow cases * prepare a shadow graph unlit (modifying alpha) * Add reference data for shadow test * Minimal data for reproduce issue 1259511 * Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define * *Update ShadowMaterial * *Update ShaderGraphShadow.vfx * *Move shader to common testing asset * Add equivalent test for URP * Add graphicTest for URP * *Update reference images * Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting * Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence * Fix incorrect block listing * *Update changelog.md * Fix pass selection for lit effect * Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution * Voluntary add disabled branch on shadow unlit to cover alphaTreshold case * *Minor comment * Fix return alpha clipping (missing actual alpha test enabled) * *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging) * VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.' # Conflicts: # com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template * Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset * *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f) * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288 It was a bad merge Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96) * Fix missing type copy in reduce Tested locally on a PS4 * Add expection to detect unsupported value type * Fix 1154328 - infinite recompile with rand (#93) * Change the way rand expression equality is handled * Refactor a bit * Add editor test * World to Viewport Point & Viewport to World Point operators + Test (#98) * World to Viewport Point & Viewport to World Point operators + Test First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator. Includes a test scene for these 2 operators. * Update CHANGELOG.md Update Changelog * Added documentation md files. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Make null ( not deserializable ) objects part of undo state (#86) * Fix compile loop in vfxoperator (#61) * Update to visual studio package 2.0.2 (#74) * Fix SDF Operators and blocks from PR #88 (#94) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Remove the use of inverse transpose for the "normals" * Restore the Inverse Transpose and modify Collision code * Restore Conform and Collide previous behavior + direction points to the surface * add documentation * Consistent distance and normal handling + ref images * Cleaning + World space stick di…

* property attributes not serialized (#253) * Initial tests * Fix typo * Change the VFXPropertyAttribute class * Use VFXPropertyAttributes in VFXProperty * Refactor interface * Remove old VFXPropertyAttribute class * More fixes * Fix bug in DataAnchorController * Fix invalid cast typo * Remove shader warnings (#261) * Fix shader warnings in test projects * Update changelog * Vfx/feature/filter enum (#243) * Allow filtering enums values in VFXModels. * Add an explicit GetHashCode() to default NameNType. * Update CHANGELOG.md * Update VFXHDRPSubOutput.cs * fix based on review * Remove raytracing enumerator filter as it was removed from HDRP enum * Remove irrelevant render queues from some HDRP outputs (#263) * Remove AfterPostProcessing render queue for lit outputs * Remove render queue field from distortion outputs * Update changelog * Update HDRP changelog instead of VFX * Fix issue when converting outputs with invalid render queue # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Fixed Flipbook Texture Names * Update CHANGELOG.md * Fix exception when creating new category on new visual effect asset. * Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205) * Fix to graft : support for flag enum in inspector * *Update changelog * Revert "Fix Enum Flag" (#15) * "Fix Enum Flag" (#16) This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241. * Fix for Initial Event field height, (#17) * Fix for Initial Event field height, that were clipping the bottom of legged letters * Update CHANGELOG.md * Vfx/fix colorfield height (#19) * Fix color field height * changelog * Mesh Sampling (revival) (#1) * Squashed commit of the following: commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935 Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933 Use simpler & explicit definition of propagated flags * Fix several issue/comment Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765 * Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph * Fix tooltip issue from @lewisjordan Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386 Side note : use mode instead of "addressingMode" in PositionMesh as well. * Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553 * As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777 * Add composition for Position (Mesh) as suggested by @thomasi Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Update experimental disclaimers (#367) * Updated experimental disclaimers * Removed link and added description instead. * [HDRP] MSAA & MotionVector (#12) * Support WRITE_MSAA_DEPTH Unlit template * Fix MSAA for lit output * *Update changelog * Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH TODO : Fix Sphere output as well * Fix typo in ParticlePoint * Factorize common fragment Lit & unlit for depth alike passes. * Fix particle hexadreon wrong depth with alpha clip * Revert "Fix particle hexadreon wrong depth with alpha clip" This reverts commit b16bd570440087984c2c8c48279bebb088f748e8. * Allow an object slot to have null as its value (#25) * Allow an object slot to have null as its value * changelog * Vfx/fix/prevent capacity change locked (#24) * Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode * changelog * *Update all vfx (had to do it manually...) * Restore missing enty in hdrp changelog (bad resolve conflict from me) * Fix 1233044 - capacity cannot be zero (#21) * Prevent capacity from being 0 * Fix strip capacity as well * Vfx/fix/param order (#22) * Fix for dragged parameters order when there are categories * changelog Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix minor issue with VFXPreviousPositionBinder.cs (#23) Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/fix/sgoperator create context drag (#28) * Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot. * changelog * Vfx/fix/context no blocks (#27) * Don't show block windows when context cant have blocks (output mesh ) * changelog * PropertyBinder : Minor Fixes (#29) * Fix for binder when null asset & fix for binder while resetting * Call ClearPropertyBinders while resetting * Add Update Modes & Time Access (revival) (#4) * Squashed commit of the following: commit d77638ba4188bfb03c81130b82cacb2a719f03be Merge: 49eaeadff7 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 09:46:59 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 14:53:09 2020 +0100 Update UX for new time access (#260) https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280 See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z commit 78d5d9938d9896d517efa89662764afd44ef12fc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 16:03:26 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060 commit bc7e715b0e41b55126fdf171b7459b680e3e3824 Merge: 9a82a52bfe ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 14:52:03 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88 Merge: f56986d415 66df0debfc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 09:17:53 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit f56986d4157f140ca84b039d97c8b7064a18214e Merge: 047820690f 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:25:07 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 047820690fa496bd43d3a60df16dd0932502c7cb Merge: d6d17dfbbc e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:56:39 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:59:15 2020 +0100 Squashed commit of the following: commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 13:37:05 2020 +0100 Use implicit block for old position backup commit e786cf3ade7d7515da4569dde9455881af02f282 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Jan 12 15:05:03 2020 +0100 WIP : Add option to skip zero delta per update context commit e864fae742120fbfebabb26b605ddedfd184b02b Merge: 4eecc0b90b fb12af4c28 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:47:57 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 16:08:07 2020 +0100 Rename ProcessEveryFrame in ExactFixedTimeStep commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 16:21:50 2020 +0100 Fix ManagerMaxDeltaTime (was GameDeltaTime) commit eaebe2649e93a5083fd62c91ac92185794b908e5 Merge: 98e7dcfcdc 276c02f29a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:42:08 2020 +0100 Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes commit 98e7dcfcdceb710c252e4d1a257815a724539e68 Merge: 248004d55a 0737eb535c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:26:54 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 248004d55a7b96c6532cd3c197e175b751d6f3fe Merge: 2bbadae355 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 9 13:12:50 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 2bbadae355bb3c4a308b8d4e020e96127fa94818 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:07:46 2019 +0100 Add tooltip to VFXTime.cs commit 9dc7ea790327b44ffde94bbf783d588e74c50174 Merge: bf48ba84eb 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:29:13 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit bf48ba84ebfd1472d041966ba4be627e3a1ef427 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:26:30 2019 +0100 *Update changelog.md commit b5d76d5d5d65584fde771213d9a01adc6dd9b856 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 16:10:19 2019 +0100 Add operator to enable time accesses commit 1a2fe7b8dc5072dd49d985f045f276385e08287f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 11:25:52 2019 +0100 Add built-in expression (but not listed) commit b0d0e64ee04036adf48f4481bfd22eace649bac3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:37:50 2019 +0100 Add some header commit 490a441046a227bb1cc1b98418d0559da17d3771 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:36:57 2019 +0100 Add tooltip & text content commit 621c5b2b78545800b2e94921b9314ef860992059 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:09:32 2019 +0100 *Add custom inspector to edit update flags efficiently * Fix build (VFXPropertyAttribute.Create isn't needed anymore) * Fix editor test * Read Attribute in Spawn Context (#6) * Squashed commit of the following: commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 11:14:14 2020 +0200 *Update image reference (having issue with standalone, not sure of the result) commit 275c22de35f08ada783c96c625b12475f0c42337 Merge: 85254f1ec4 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 09:59:48 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # com.unity.visualeffectgraph/CHANGELOG.md commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 16:21:39 2020 +0100 *Update image reference due to fix with grapicTest update commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf Merge: d8db341bfb 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:51:43 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset commit d8db341bfbd9257e1a5285d200e3eabe24857b01 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:57:38 2020 +0100 *Apply Formatting commit f80441dd6b30ef726d46ae2fe32bcf05d208b760 Merge: b3d858ffe1 01f176355a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:32:49 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7 Merge: 0bce44dc9a 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:18:58 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # .yamato/upm-ci-vfx_lwrp.yml # .yamato/upm-ci-vfxmain.yml # com.unity.visualeffectgraph/CHANGELOG.md commit 0bce44dc9a694bf36b849efb894e999fa9dc959e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:20:03 2020 +0100 *Fix build commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df Merge: 2130ea0ef2 e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 09:47:09 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 2130ea0ef2186ecdc5692878940d5d6635dca31b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:09:13 2020 +0100 *Update tooltips (thanks @vlad) commit f8cdb95f5d2075848e530d997551b69de43f39e0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:01:44 2020 +0100 Rename SpawnerState in SpawnState commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 13:54:24 2020 +0100 Improve ReadAttribute test to cover NewLoop state commit 2c515bfde823bfbce87df8a1444e19e5c2327e32 Merge: a9efee24ff bff1b74b59 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 16:32:45 2019 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit a9efee24ff84131c53dc2ba93f1985b02217e3d7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:54:25 2019 +0100 *Update comment commit 6b17879881555cd72b3af4463fd907423f92ad7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:53:11 2019 +0100 Throws an exception while detecting unexpected expression flag commit cbad9212075ec6776cf9d892185dd6ee64f8fab2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:43:33 2019 +0100 Reorder spawner state operator commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:35:30 2019 +0100 Fix issue "Cannot plug in attribute-derived nodes into a spawner block." commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:58:30 2019 +0100 *Update changelog commit 61bd2e5871f23002dd1add024858efdef5e09372 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:46:52 2019 +0100 Update _CCCC test & Rename Spawner State library name commit 4942912123d795023aacb0363c8e462a2da29943 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 16:58:17 2019 +0100 Fix test & clean useless code in VFXExpression.Initialize commit e6d6c593eb27c612a225340615dabe7692f76a00 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:22:31 2019 +0100 Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose commit f00f740b775f67e9378072744513f3ff920f470d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:16:39 2019 +0100 Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change) commit b7d8e238dd7e05bf99114a980c8584da7985dcf8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:45:56 2019 +0100 Clean test data & add reference images commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:17:51 2019 +0100 Move graphicTest to common files commit fa21846e7787fec9068c5a18a33dc568df3f7cc9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 11:53:18 2019 +0100 Separate cleanly per event attribute expressions commit 80e5259674a011e864e65f13c77ce06f92f33b7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 08:38:41 2019 +0100 New test for chaining & read attributes commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 18:47:20 2019 +0100 Add read attribute for loop settings (context evaluation) commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 15:30:56 2019 +0100 Clean expression patching commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 11:45:06 2019 +0100 Clarify compatibility code for spawner order & random implication commit 0dcf774f623fb93eb7bc19b06407b88669472443 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 18:42:30 2019 +0100 Add tricky case in test vfx & fix compatibility code TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 16:49:42 2019 +0100 *Up local test commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 15:22:03 2019 +0100 Detect & Compute partial evaluation commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:16:29 2019 +0100 Add spawner State Operator & SpawnCount (even if it's actually an attribute) commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:04:04 2019 +0100 Add spawner state accessor commit adb1d6d66172f2d187b577facaf7b2aea4677d13 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 11:24:20 2019 +0100 Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling commit d43ad0e1395d0e51f3583ce9627a72006356e117 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 2 16:19:05 2019 +0100 Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute commit 8a25b5fbed33569529d30379fce2acd4da7de88d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 29 16:14:32 2019 +0100 Backup test asset (temporarily) commit dcb3efaf885dbbdec317f5a42ace9ace336fded9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 16:37:48 2019 +0100 WIP : experimenting new concept of Read Attribute expression * Merge with vfx/staging * Update VFX * Misc small fixes (#36) * Fix strips outputs, spawnIndex and default metallic value * Increase threshold in particle strip unlit test * Test for Override resetted (#26) * *WIP* add test * Actually add a more legit "prefab" test * Prepare fix later fix of 1206890 : can't change the C++ without updating this test * Fix editor test (todo : graft this change to master to anticipate the C++ change) * Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20) * New Test : total time is sum of delta time (#7) * *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249 * [Fix] Disable reset option (#41) * Disable reset option * Add repro case 1251533 * Fix minor issue with PreviousPropertyBinder (bis) (#31) * Fix minor issue with VFXPreviousPositionBinder.cs * Fix exception in OnEnable Note : I didn't try it locally yet. * Actual fix of VFXPreviousPositionBinder.cs Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix culture issues when generating attributes defines in shaders (#40) * [PropertyBinder] Move Update to LateUpdate (#38) * Fix issue with VFXPropertyBinder : we should use late update instead of Update * *Update 23_ParameterBinder reference image * Call resyncslots on shadergraph dependent models. (#10) * Call resyncslots on shadergraph dependent models. * missing call to checkgraphbeforeimport * indentation * fix slot not updated if only the attributes change * Do the same for models having subgraphs than for models having shadergraphs. * Fix based on PR review * Update CHANGELOG.md * update vfx and settings * Renable 009_MultiCamera in URP project * Easy Wins (Small Workflow / Cosmetic fixes) (#37) * Properties now exposed by default in blackboard * Dissociated Colors for bool/int/uint * Added Degrees / Radians conversion subgraphs in samples * De-nicified attribute name (conserve case) in Set Custom Attribute title * Changed the default "No Asset" message when opening the visual effect graph window. * Subgraphs are not in hardcoded categories anymore + Updated Serialization * Added Documentation for setting Subgraph Menu Categories Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/docs/compatability disclaimer (#43) * Added compatability disc * Updated format. * Save a specific vfx asset and its sugraphs only (#35) * Save graph asset works * Update CHANGELOG.md * Update VisualEffectGraphWindow.md * Update VisualEffectGraphWindow.md * Fix for block copy not dirtying the scene. * Remove some unecessary compilation (not all) (#46) * New TransformVector4 and GetTextureDimensions operators (#18) * Vfx/feature/new operators 2 (#266) * Add TransformVector4 operator * Remove unused code * Fix warning * Refactor dynamic type operator * Samll fix to previous commit * Add texture dimensions operator and expressions * Add tooltips * Add changelog entry * Fix merge compilation * Modify point cache test * Prevent textures from being constant folded * Move modified test to correct folder * Output Event (#5) * Squashed commit of the following: commit 449a60793a4c5c91e1913c42632448eb07ebe5de Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:27:48 2020 +0200 Fix stackoverflow with subgraph (but doesn't fix the internal workflow) commit caf0df3af5f451f9576c2cc7f328b57a87479f30 Merge: bb1047c59a a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 10:22:47 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/output-event commit bb1047c59a084551e7df3b93d7d5ad501145ecaf Merge: 7b2890b76f 98ce4878d1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 17:17:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:54:17 2020 +0100 Add a check of outputEvent in SpawnerTest commit 945992b2feff4b8f7a24740944c77a4a92f271dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:24:56 2020 +0100 *Update OutputEventTest.cs to check Test_Output_Event commit c48fda763e807503f27f98deeda4238b6628c264 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 18 10:17:21 2020 +0100 *Update image reference & Test (stop using a undebuggeable random position) commit 5a5ad49cb485907ee869445627821810589ab34a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 22:12:58 2020 +0100 Fix newly integrated spawn test for output event commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c Merge: ef4837245e 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 17:53:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs commit ef4837245e1d88846f6d686e2803094d1d6cd04d Merge: 2331c32fb4 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 08:30:00 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda Merge: 5d225d6e19 0103971ce2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Feb 6 08:01:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 5d225d6e192b32394faf0964ad263cc33c5280cc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:01:51 2020 +0100 Fix editor test commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:00:35 2020 +0100 Add distinct while retrieving virtual link commit 725252869ac24d962490b4550821fbba2ab119b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Feb 3 14:38:52 2020 +0100 *WIP* Output test commit 96098fa11f4781837543fba099936b15a8c7158d Merge: 02178104a3 bb04ca28fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 31 14:07:02 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 02178104a301fb434d5e6821cd369884bbc01006 Merge: 1443b66691 db8325ba2b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 18:06:20 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 1443b66691d46ed9598ccc26b0b9425d373b61e1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:37:08 2020 +0100 *Reduce unexpected changes commit aa1afcafa9c95d042db146043c60015d3f5c96f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:31:13 2020 +0100 New UX for output event (use data instead of system name) (#229) * *WIP* Experiment for UX using eventName * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name * Remove useless naming pattern linking label & title for output Cleaner & Safer implementation for outputEvent edition * Use unique system naming * Add test for Data for VFXOutputEvent * Fix hacky OnInvalidate commit 9cd41b81cef062991907d5ce446336bde78b79d3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 15:11:39 2020 +0100 Add editor test to check return value of output event (not attribute, already cover by graphic test) commit 1a09c63a98e4650b82160e670cedfb06b630284d Merge: 35126156f2 52ce8b9636 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 11:02:45 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 35126156f2b93b04543de0eb91aca79adf331b2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 17 13:58:06 2020 +0100 Avoid exception if system isn't present yet commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 16 10:53:13 2020 +0100 *Update Test, adding a test on unused source attribute commit bfd29d8862539cef5b14392e21cbd896436339a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 20:20:59 2020 +0100 Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test) commit d89160df852b64a4b5ecf378c506aa0c9f1c099c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 16:13:02 2020 +0100 Filters out orphan output event context commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 14:30:08 2020 +0100 *Update changelog commit cf54e5372e273f86dd5c2e00a6178a543f234fd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 08:40:09 2020 +0100 Add reference image for HDRP commit d710998eb133a3dbadbdec580d1ecad3752aca85 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:17:28 2020 +0100 Add reference images for newly added test commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 15:23:18 2020 +0100 *Add a material to unit test commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 17:02:27 2020 +0100 Start implementing a effective test project commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 16:56:28 2020 +0100 FIx system name synchronisation (not really ideal) commit 7782b888266a011f4f986a7bb3161f024730caa7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 14:24:08 2020 +0100 Fix UI of output event commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 10:11:56 2020 +0100 Fix build commit 50ae031af02d4c41e651f64b40e9d265668b803f Merge: d838cd2d37 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 7 13:36:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 14:58:00 2019 +0100 Add a wip test scene commit 459b344b3f97c794d47a8eb6942b1129d18632cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 11:40:30 2019 +0100 Fill VFXDataOutputEvent commit e54905485dd553cadcde307ca00a8d7ce8454c0f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 18:21:31 2019 +0100 Add basic output event type (empty FillDesc implementation for now) * Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP* * Update 009_OutputEvent test * Move 009_OutputEvent to correct folder (TODO, this to rename it before merge) * Fix sanity test & allow multiple connection from in outputEvent (as initialize) * Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context * Fix editor test using eventName instead of tile * Revert unexpected changes * *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485 * Rename VisualEffectOutputEventArgs => VFXOutputEventArgs * Disable connection from OutputEvent to GPUEvent * *Fix build VisualEffect.OutputEventArgs => VFXOutputEventArgs Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5 * Vfx/feature/enum parameter (#8) * Restart of enum parameters * more work * more work * Still more work. * reorderable list looks good. * Adding and removing values works. * dragging item works. * Enum values show in the inspector. * fixes for rebase * Enumvalue works on subgraphs. * notify enum name change. * Added documentation for blackboard value filtering. * no value per enum * only uint can now avec enum values. * don't nicify enum values. * Update Blackboard.md * Update VFXBlackboard.uss * sanitize parameter already having range * Clamp enum value works. * Changing switch testValue to uint. * value appearing as menu if mode is enum. * Update CHANGELOG.md * Mutli editor of different values of enum parameter works. * cpoy paste enumValues and min/max when copying parameter. * Copy parameter mode when converting to subgraph. * fix * Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt. * Vfx/docs/new operator docs (#50) * Added documentation for new operators * Changed bullet format. * Fix creation of StringPropertyRM (#51) * Fix creation of StringPropertyRM * Update CHANGELOG.md * Fix input of event emitting block beeing to small because of output * Multi-mesh output, LODs and compute culling (#14) * Implement multi mesh * Add LOD + lit mesh output support * Small fix + optim * Fix crash with multi mesh + sorting * Fix shader compilation with single mesh and compute culling * implement multi sorting * Add globalSort parameter * Fix camera absolute mode * Fix URP shader compilation * Add frustum culling to LOD * Add frustum culling setting * filter out implicit settings and add tooltips * Add radius scale + tooltips * Add a graphics test * Update change log + lod and multi mesh as experimental features * Forgot a file * Small changes based on QA review * Simulate headers on enum values in SlotContainerEditor (#49) * Simulate headers on enum values in SlotContainerEditor * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Update VFX * Fix for blackboard scrollable element hidden by resize. * Disable LOD test for XR * Fix test threshold that was reset to 0... * Ignoer graphviz folder * Target Gameobject windows resize doesn't go too far above scrollbars * Missing or incorrect unit in uss. * fix for reference image "VFX/Execution" not updated to new path ( warning when adding output) * Change description in package.json to reflect VFX is not out of preview with URP and mobile * Simplify linear drag (#67) * Simplify linear drag * Fix warning * Enable m_CachingShaderPreprocessor (#65) * *Enable m_CachingShaderPreprocessor * Try enabling vulkan * Unify m_APIs in URP & HDRP * Fix for node window staying when clicking elsewhere (#68) * Fix for node window stayting when clicking elsewhere * Update CHANGELOG.md * Prevent resourcehistory from beeing set to null by serialization (#66) * Vfx/docs/system requirements (#69) * Added system requirements documentation. * Corrected phrasing * Added toc entry * Reorganised toc entry Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix position of block creation window (#72) * Fix Missing System Seed Builtin (#70) * Add missing system seed variant * Add test to cover all builtin expression are available through operator (avoid regression) * *Update changelog.md * Fix inconsistant case * Fix indentation * Fix Prefab Highlight for initial event name toggle & override (#71) * Fix prefab blue highlight * *Update changelog.md * Add test for Mesh Stripping (#59) * *Add test data * Enable StripUnusedMeshComponents: 1 * Enable mesh stripping in HDRP project * *Add reference images * Call recreateCopy after recusion test not before. (#52) * Call recreateCopy after recusion test not before. * Update CHANGELOG.md * Uniquify create visual effect gameobject name. Standard behaviour. (#75) * Uniquify create visual effect gameobject name. Standard behaviour. * Update CHANGELOG.md * Use the AssetDatabase.FindAsset to find VFXResources asset (#48) * Use the AssetDatabase.FindAsset to find VFXResources asset * Update CHANGELOG.md * Search VFXResource only if necessary. * LoadUserResourcesIfNeeded * Fix changelog merge * Added feature: User can specify a directory that holds their VFX template assets (#34) Added feature: User can specify a directory that holds their VFX template assets Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu. ## How to use The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems ![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d) Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option. ![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df) This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders. ![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f) Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed: ![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2) * Vfx/fix/1246989 normals and scale (#81) * Fix normal for lit mesh and non uniform scales * Use inverse transpose in planar primitives * Fix planar primitive with non uniform scale in local * Add gfx test * Add comment * Update changelog * Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76) * Fix Texture2DArray and Cubemap exposition from sg in output mesh context * Add case to changelog * Temporarily deactivate non uniform scale test (Some files were lost :() * [Test] Enable test to cover properly reset override behavior (#80) * Renable test to cover issue 1206890 * Fix newly introduced test : Exepcted value is original after reset override & handle correctly color * int and uint support in Compare (#53) * Add int and uint to Compare node and condition expression * minor fixes * Change SerializeType so that tests are correct against System.Type and null * Fix switch * Update changelog * Added render pipeline compatability table (#87) Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix square complexity on parameter to serialized property matching (#78) * Fix square complexity on parameter to serialized property matching * Update CHANGELOG.md * Fix vfx view not beeing framed at launch (#79) * Fix vfx view not beeing framed at launch * safer implementation * Update CHANGELOG.md * Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84) * Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null * Update CHANGELOG.md * SampleSDF operator (#88) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Fix Shadow compilation using shaderGraph (URP/HDRP) (#77) * *Prepare a proper way to test different shadow cases * prepare a shadow graph unlit (modifying alpha) * Add reference data for shadow test * Minimal data for reproduce issue 1259511 * Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define * *Update ShadowMaterial * *Update ShaderGraphShadow.vfx * *Move shader to common testing asset * Add equivalent test for URP * Add graphicTest for URP * *Update reference images * Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting * Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence * Fix incorrect block listing * *Update changelog.md * Fix pass selection for lit effect * Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution * Voluntary add disabled branch on shadow unlit to cover alphaTreshold case * *Minor comment * Fix return alpha clipping (missing actual alpha test enabled) * *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging) * VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.' # Conflicts: # com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template * Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset * *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f) * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288 It was a bad merge Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96) * Fix missing type copy in reduce Tested locally on a PS4 * Add expection to detect unsupported value type * Fix 1154328 - infinite recompile with rand (#93) * Change the way rand expression equality is handled * Refactor a bit * Add editor test * World to Viewport Point & Viewport to World Point operators + Test (#98) * World to Viewport Point & Viewport to World Point operators + Test First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator. Includes a test scene for these 2 operators. * Update CHANGELOG.md Update Changelog * Added documentation md files. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Make null ( not deserializable ) objects part of undo state (#86) * Fix compile loop in vfxoperator (#61) * Update to visual studio package 2.0.2 (#74) * Fix SDF Operators and blocks from PR #88 (#94) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Remove the use of inverse transpose for the "normals" * Restore the Inverse Transpose and modify Collision code * Restore Conform and Collide previous behavior + direction points to the surface * add documentation * Consistent distance and normal handling + ref images * Cleaning + World space stick distance and radius + references * Max scale through expression evaluated on GPU (if needed) * Max3 on CPU * Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91) * Simpler update to use now available ByteAddressBuffer * Temp Workaround a GPU hang We should isolate properly this code. * Proper fix of OOB FetchBuffer * *Update changelog.md * Update assets * Update URP tests assets * More update to assets * Remove old gfx tests images ref * Fix changelog * Fix Construct Matrix on GPU (#102) * Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU * *Update changelog.md * Output Event Helpers (#58) * Base Commit * Moved Files down one folder * Updated Package Configuration, CHANGELOG and documentation * Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour * Small fixes and checks * Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check * Small Fixes * Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly * Other custom Editors + Helpbox * Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in Prefab Spawn * Removed Rerouting Helpers as CopyValuesFrom is broken at the moment. * Fixed ASMDEFs / class accessibility * Updated Documentation * Fixed Class Accessibility for ExposedPropertyDrawer * Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer) Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Add support for Gradient sampling with and without gradient mode #100 * Fix changelog * Fix case 1279294 : Invalid Random per component behavior in spawn context (#107) * Revert "Output Event Helpers" (#110) * Revert "Output Event Helpers (#58)" This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78. * Revert "Fix changelog" This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137. * Fix changelog (missing revert) * Fix changelog : Unexpected carriage return * Point cache: Binary format corrupted due to an extra byte offset (#108) * Point cache header, wait for new line character only (/n) and skip carriage return(/r) An extra trailing new line character was causing an invalid offset in binary point cache files. * Update Changelog * Remove unnecessary files * Fix InvalidCastException when using byte properties in point cache files (#109) * Change casting to byte We were trying to cast an object containing a byte to an int. Also, a better normalization would be dividing by 255. * Update CHANGELOG.md * update asset and scripts * Remove unwanted files …

* property attributes not serialized (#253) * Initial tests * Fix typo * Change the VFXPropertyAttribute class * Use VFXPropertyAttributes in VFXProperty * Refactor interface * Remove old VFXPropertyAttribute class * More fixes * Fix bug in DataAnchorController * Fix invalid cast typo * Remove shader warnings (#261) * Fix shader warnings in test projects * Update changelog * Vfx/feature/filter enum (#243) * Allow filtering enums values in VFXModels. * Add an explicit GetHashCode() to default NameNType. * Update CHANGELOG.md * Update VFXHDRPSubOutput.cs * fix based on review * Remove raytracing enumerator filter as it was removed from HDRP enum * Remove irrelevant render queues from some HDRP outputs (#263) * Remove AfterPostProcessing render queue for lit outputs * Remove render queue field from distortion outputs * Update changelog * Update HDRP changelog instead of VFX * Fix issue when converting outputs with invalid render queue # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Fixed Flipbook Texture Names * Update CHANGELOG.md * Fix exception when creating new category on new visual effect asset. * Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205) * Fix to graft : support for flag enum in inspector * *Update changelog * Revert "Fix Enum Flag" (#15) * "Fix Enum Flag" (#16) This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241. * Fix for Initial Event field height, (#17) * Fix for Initial Event field height, that were clipping the bottom of legged letters * Update CHANGELOG.md * Vfx/fix colorfield height (#19) * Fix color field height * changelog * Mesh Sampling (revival) (#1) * Squashed commit of the following: commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935 Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933 Use simpler & explicit definition of propagated flags * Fix several issue/comment Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765 * Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph * Fix tooltip issue from @lewisjordan Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386 Side note : use mode instead of "addressingMode" in PositionMesh as well. * Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553 * As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777 * Add composition for Position (Mesh) as suggested by @thomasi Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Update experimental disclaimers (#367) * Updated experimental disclaimers * Removed link and added description instead. * [HDRP] MSAA & MotionVector (#12) * Support WRITE_MSAA_DEPTH Unlit template * Fix MSAA for lit output * *Update changelog * Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH TODO : Fix Sphere output as well * Fix typo in ParticlePoint * Factorize common fragment Lit & unlit for depth alike passes. * Fix particle hexadreon wrong depth with alpha clip * Revert "Fix particle hexadreon wrong depth with alpha clip" This reverts commit b16bd570440087984c2c8c48279bebb088f748e8. * Allow an object slot to have null as its value (#25) * Allow an object slot to have null as its value * changelog * Vfx/fix/prevent capacity change locked (#24) * Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode * changelog * *Update all vfx (had to do it manually...) * Restore missing enty in hdrp changelog (bad resolve conflict from me) * Fix 1233044 - capacity cannot be zero (#21) * Prevent capacity from being 0 * Fix strip capacity as well * Vfx/fix/param order (#22) * Fix for dragged parameters order when there are categories * changelog Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix minor issue with VFXPreviousPositionBinder.cs (#23) Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/fix/sgoperator create context drag (#28) * Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot. * changelog * Vfx/fix/context no blocks (#27) * Don't show block windows when context cant have blocks (output mesh ) * changelog * PropertyBinder : Minor Fixes (#29) * Fix for binder when null asset & fix for binder while resetting * Call ClearPropertyBinders while resetting * Add Update Modes & Time Access (revival) (#4) * Squashed commit of the following: commit d77638ba4188bfb03c81130b82cacb2a719f03be Merge: 49eaeadff7 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 09:46:59 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 14:53:09 2020 +0100 Update UX for new time access (#260) https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280 See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z commit 78d5d9938d9896d517efa89662764afd44ef12fc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 16:03:26 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060 commit bc7e715b0e41b55126fdf171b7459b680e3e3824 Merge: 9a82a52bfe ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 14:52:03 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88 Merge: f56986d415 66df0debfc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 09:17:53 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit f56986d4157f140ca84b039d97c8b7064a18214e Merge: 047820690f 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:25:07 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 047820690fa496bd43d3a60df16dd0932502c7cb Merge: d6d17dfbbc e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:56:39 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:59:15 2020 +0100 Squashed commit of the following: commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 13:37:05 2020 +0100 Use implicit block for old position backup commit e786cf3ade7d7515da4569dde9455881af02f282 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Jan 12 15:05:03 2020 +0100 WIP : Add option to skip zero delta per update context commit e864fae742120fbfebabb26b605ddedfd184b02b Merge: 4eecc0b90b fb12af4c28 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:47:57 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 16:08:07 2020 +0100 Rename ProcessEveryFrame in ExactFixedTimeStep commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 16:21:50 2020 +0100 Fix ManagerMaxDeltaTime (was GameDeltaTime) commit eaebe2649e93a5083fd62c91ac92185794b908e5 Merge: 98e7dcfcdc 276c02f29a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:42:08 2020 +0100 Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes commit 98e7dcfcdceb710c252e4d1a257815a724539e68 Merge: 248004d55a 0737eb535c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:26:54 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 248004d55a7b96c6532cd3c197e175b751d6f3fe Merge: 2bbadae355 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 9 13:12:50 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 2bbadae355bb3c4a308b8d4e020e96127fa94818 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:07:46 2019 +0100 Add tooltip to VFXTime.cs commit 9dc7ea790327b44ffde94bbf783d588e74c50174 Merge: bf48ba84eb 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:29:13 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit bf48ba84ebfd1472d041966ba4be627e3a1ef427 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:26:30 2019 +0100 *Update changelog.md commit b5d76d5d5d65584fde771213d9a01adc6dd9b856 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 16:10:19 2019 +0100 Add operator to enable time accesses commit 1a2fe7b8dc5072dd49d985f045f276385e08287f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 11:25:52 2019 +0100 Add built-in expression (but not listed) commit b0d0e64ee04036adf48f4481bfd22eace649bac3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:37:50 2019 +0100 Add some header commit 490a441046a227bb1cc1b98418d0559da17d3771 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:36:57 2019 +0100 Add tooltip & text content commit 621c5b2b78545800b2e94921b9314ef860992059 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:09:32 2019 +0100 *Add custom inspector to edit update flags efficiently * Fix build (VFXPropertyAttribute.Create isn't needed anymore) * Fix editor test * Read Attribute in Spawn Context (#6) * Squashed commit of the following: commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 11:14:14 2020 +0200 *Update image reference (having issue with standalone, not sure of the result) commit 275c22de35f08ada783c96c625b12475f0c42337 Merge: 85254f1ec4 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 09:59:48 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # com.unity.visualeffectgraph/CHANGELOG.md commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 16:21:39 2020 +0100 *Update image reference due to fix with grapicTest update commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf Merge: d8db341bfb 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:51:43 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset commit d8db341bfbd9257e1a5285d200e3eabe24857b01 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:57:38 2020 +0100 *Apply Formatting commit f80441dd6b30ef726d46ae2fe32bcf05d208b760 Merge: b3d858ffe1 01f176355a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:32:49 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7 Merge: 0bce44dc9a 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:18:58 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # .yamato/upm-ci-vfx_lwrp.yml # .yamato/upm-ci-vfxmain.yml # com.unity.visualeffectgraph/CHANGELOG.md commit 0bce44dc9a694bf36b849efb894e999fa9dc959e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:20:03 2020 +0100 *Fix build commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df Merge: 2130ea0ef2 e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 09:47:09 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 2130ea0ef2186ecdc5692878940d5d6635dca31b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:09:13 2020 +0100 *Update tooltips (thanks @vlad) commit f8cdb95f5d2075848e530d997551b69de43f39e0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:01:44 2020 +0100 Rename SpawnerState in SpawnState commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 13:54:24 2020 +0100 Improve ReadAttribute test to cover NewLoop state commit 2c515bfde823bfbce87df8a1444e19e5c2327e32 Merge: a9efee24ff bff1b74b59 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 16:32:45 2019 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit a9efee24ff84131c53dc2ba93f1985b02217e3d7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:54:25 2019 +0100 *Update comment commit 6b17879881555cd72b3af4463fd907423f92ad7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:53:11 2019 +0100 Throws an exception while detecting unexpected expression flag commit cbad9212075ec6776cf9d892185dd6ee64f8fab2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:43:33 2019 +0100 Reorder spawner state operator commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:35:30 2019 +0100 Fix issue "Cannot plug in attribute-derived nodes into a spawner block." commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:58:30 2019 +0100 *Update changelog commit 61bd2e5871f23002dd1add024858efdef5e09372 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:46:52 2019 +0100 Update _CCCC test & Rename Spawner State library name commit 4942912123d795023aacb0363c8e462a2da29943 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 16:58:17 2019 +0100 Fix test & clean useless code in VFXExpression.Initialize commit e6d6c593eb27c612a225340615dabe7692f76a00 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:22:31 2019 +0100 Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose commit f00f740b775f67e9378072744513f3ff920f470d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:16:39 2019 +0100 Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change) commit b7d8e238dd7e05bf99114a980c8584da7985dcf8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:45:56 2019 +0100 Clean test data & add reference images commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:17:51 2019 +0100 Move graphicTest to common files commit fa21846e7787fec9068c5a18a33dc568df3f7cc9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 11:53:18 2019 +0100 Separate cleanly per event attribute expressions commit 80e5259674a011e864e65f13c77ce06f92f33b7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 08:38:41 2019 +0100 New test for chaining & read attributes commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 18:47:20 2019 +0100 Add read attribute for loop settings (context evaluation) commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 15:30:56 2019 +0100 Clean expression patching commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 11:45:06 2019 +0100 Clarify compatibility code for spawner order & random implication commit 0dcf774f623fb93eb7bc19b06407b88669472443 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 18:42:30 2019 +0100 Add tricky case in test vfx & fix compatibility code TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 16:49:42 2019 +0100 *Up local test commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 15:22:03 2019 +0100 Detect & Compute partial evaluation commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:16:29 2019 +0100 Add spawner State Operator & SpawnCount (even if it's actually an attribute) commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:04:04 2019 +0100 Add spawner state accessor commit adb1d6d66172f2d187b577facaf7b2aea4677d13 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 11:24:20 2019 +0100 Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling commit d43ad0e1395d0e51f3583ce9627a72006356e117 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 2 16:19:05 2019 +0100 Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute commit 8a25b5fbed33569529d30379fce2acd4da7de88d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 29 16:14:32 2019 +0100 Backup test asset (temporarily) commit dcb3efaf885dbbdec317f5a42ace9ace336fded9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 16:37:48 2019 +0100 WIP : experimenting new concept of Read Attribute expression * Merge with vfx/staging * Update VFX * Misc small fixes (#36) * Fix strips outputs, spawnIndex and default metallic value * Increase threshold in particle strip unlit test * Test for Override resetted (#26) * *WIP* add test * Actually add a more legit "prefab" test * Prepare fix later fix of 1206890 : can't change the C++ without updating this test * Fix editor test (todo : graft this change to master to anticipate the C++ change) * Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20) * New Test : total time is sum of delta time (#7) * *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249 * [Fix] Disable reset option (#41) * Disable reset option * Add repro case 1251533 * Fix minor issue with PreviousPropertyBinder (bis) (#31) * Fix minor issue with VFXPreviousPositionBinder.cs * Fix exception in OnEnable Note : I didn't try it locally yet. * Actual fix of VFXPreviousPositionBinder.cs Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix culture issues when generating attributes defines in shaders (#40) * [PropertyBinder] Move Update to LateUpdate (#38) * Fix issue with VFXPropertyBinder : we should use late update instead of Update * *Update 23_ParameterBinder reference image * Call resyncslots on shadergraph dependent models. (#10) * Call resyncslots on shadergraph dependent models. * missing call to checkgraphbeforeimport * indentation * fix slot not updated if only the attributes change * Do the same for models having subgraphs than for models having shadergraphs. * Fix based on PR review * Update CHANGELOG.md * update vfx and settings * Renable 009_MultiCamera in URP project * Easy Wins (Small Workflow / Cosmetic fixes) (#37) * Properties now exposed by default in blackboard * Dissociated Colors for bool/int/uint * Added Degrees / Radians conversion subgraphs in samples * De-nicified attribute name (conserve case) in Set Custom Attribute title * Changed the default "No Asset" message when opening the visual effect graph window. * Subgraphs are not in hardcoded categories anymore + Updated Serialization * Added Documentation for setting Subgraph Menu Categories Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/docs/compatability disclaimer (#43) * Added compatability disc * Updated format. * Save a specific vfx asset and its sugraphs only (#35) * Save graph asset works * Update CHANGELOG.md * Update VisualEffectGraphWindow.md * Update VisualEffectGraphWindow.md * Fix for block copy not dirtying the scene. * Remove some unecessary compilation (not all) (#46) * New TransformVector4 and GetTextureDimensions operators (#18) * Vfx/feature/new operators 2 (#266) * Add TransformVector4 operator * Remove unused code * Fix warning * Refactor dynamic type operator * Samll fix to previous commit * Add texture dimensions operator and expressions * Add tooltips * Add changelog entry * Fix merge compilation * Modify point cache test * Prevent textures from being constant folded * Move modified test to correct folder * Output Event (#5) * Squashed commit of the following: commit 449a60793a4c5c91e1913c42632448eb07ebe5de Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:27:48 2020 +0200 Fix stackoverflow with subgraph (but doesn't fix the internal workflow) commit caf0df3af5f451f9576c2cc7f328b57a87479f30 Merge: bb1047c59a a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 10:22:47 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/output-event commit bb1047c59a084551e7df3b93d7d5ad501145ecaf Merge: 7b2890b76f 98ce4878d1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 17:17:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:54:17 2020 +0100 Add a check of outputEvent in SpawnerTest commit 945992b2feff4b8f7a24740944c77a4a92f271dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:24:56 2020 +0100 *Update OutputEventTest.cs to check Test_Output_Event commit c48fda763e807503f27f98deeda4238b6628c264 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 18 10:17:21 2020 +0100 *Update image reference & Test (stop using a undebuggeable random position) commit 5a5ad49cb485907ee869445627821810589ab34a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 22:12:58 2020 +0100 Fix newly integrated spawn test for output event commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c Merge: ef4837245e 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 17:53:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs commit ef4837245e1d88846f6d686e2803094d1d6cd04d Merge: 2331c32fb4 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 08:30:00 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda Merge: 5d225d6e19 0103971ce2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Feb 6 08:01:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 5d225d6e192b32394faf0964ad263cc33c5280cc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:01:51 2020 +0100 Fix editor test commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:00:35 2020 +0100 Add distinct while retrieving virtual link commit 725252869ac24d962490b4550821fbba2ab119b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Feb 3 14:38:52 2020 +0100 *WIP* Output test commit 96098fa11f4781837543fba099936b15a8c7158d Merge: 02178104a3 bb04ca28fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 31 14:07:02 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 02178104a301fb434d5e6821cd369884bbc01006 Merge: 1443b66691 db8325ba2b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 18:06:20 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 1443b66691d46ed9598ccc26b0b9425d373b61e1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:37:08 2020 +0100 *Reduce unexpected changes commit aa1afcafa9c95d042db146043c60015d3f5c96f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:31:13 2020 +0100 New UX for output event (use data instead of system name) (#229) * *WIP* Experiment for UX using eventName * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name * Remove useless naming pattern linking label & title for output Cleaner & Safer implementation for outputEvent edition * Use unique system naming * Add test for Data for VFXOutputEvent * Fix hacky OnInvalidate commit 9cd41b81cef062991907d5ce446336bde78b79d3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 15:11:39 2020 +0100 Add editor test to check return value of output event (not attribute, already cover by graphic test) commit 1a09c63a98e4650b82160e670cedfb06b630284d Merge: 35126156f2 52ce8b9636 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 11:02:45 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 35126156f2b93b04543de0eb91aca79adf331b2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 17 13:58:06 2020 +0100 Avoid exception if system isn't present yet commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 16 10:53:13 2020 +0100 *Update Test, adding a test on unused source attribute commit bfd29d8862539cef5b14392e21cbd896436339a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 20:20:59 2020 +0100 Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test) commit d89160df852b64a4b5ecf378c506aa0c9f1c099c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 16:13:02 2020 +0100 Filters out orphan output event context commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 14:30:08 2020 +0100 *Update changelog commit cf54e5372e273f86dd5c2e00a6178a543f234fd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 08:40:09 2020 +0100 Add reference image for HDRP commit d710998eb133a3dbadbdec580d1ecad3752aca85 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:17:28 2020 +0100 Add reference images for newly added test commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 15:23:18 2020 +0100 *Add a material to unit test commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 17:02:27 2020 +0100 Start implementing a effective test project commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 16:56:28 2020 +0100 FIx system name synchronisation (not really ideal) commit 7782b888266a011f4f986a7bb3161f024730caa7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 14:24:08 2020 +0100 Fix UI of output event commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 10:11:56 2020 +0100 Fix build commit 50ae031af02d4c41e651f64b40e9d265668b803f Merge: d838cd2d37 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 7 13:36:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 14:58:00 2019 +0100 Add a wip test scene commit 459b344b3f97c794d47a8eb6942b1129d18632cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 11:40:30 2019 +0100 Fill VFXDataOutputEvent commit e54905485dd553cadcde307ca00a8d7ce8454c0f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 18:21:31 2019 +0100 Add basic output event type (empty FillDesc implementation for now) * Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP* * Update 009_OutputEvent test * Move 009_OutputEvent to correct folder (TODO, this to rename it before merge) * Fix sanity test & allow multiple connection from in outputEvent (as initialize) * Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context * Fix editor test using eventName instead of tile * Revert unexpected changes * *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485 * Rename VisualEffectOutputEventArgs => VFXOutputEventArgs * Disable connection from OutputEvent to GPUEvent * *Fix build VisualEffect.OutputEventArgs => VFXOutputEventArgs Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5 * Vfx/feature/enum parameter (#8) * Restart of enum parameters * more work * more work * Still more work. * reorderable list looks good. * Adding and removing values works. * dragging item works. * Enum values show in the inspector. * fixes for rebase * Enumvalue works on subgraphs. * notify enum name change. * Added documentation for blackboard value filtering. * no value per enum * only uint can now avec enum values. * don't nicify enum values. * Update Blackboard.md * Update VFXBlackboard.uss * sanitize parameter already having range * Clamp enum value works. * Changing switch testValue to uint. * value appearing as menu if mode is enum. * Update CHANGELOG.md * Mutli editor of different values of enum parameter works. * cpoy paste enumValues and min/max when copying parameter. * Copy parameter mode when converting to subgraph. * fix * Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt. * Vfx/docs/new operator docs (#50) * Added documentation for new operators * Changed bullet format. * Fix creation of StringPropertyRM (#51) * Fix creation of StringPropertyRM * Update CHANGELOG.md * Fix input of event emitting block beeing to small because of output * Multi-mesh output, LODs and compute culling (#14) * Implement multi mesh * Add LOD + lit mesh output support * Small fix + optim * Fix crash with multi mesh + sorting * Fix shader compilation with single mesh and compute culling * implement multi sorting * Add globalSort parameter * Fix camera absolute mode * Fix URP shader compilation * Add frustum culling to LOD * Add frustum culling setting * filter out implicit settings and add tooltips * Add radius scale + tooltips * Add a graphics test * Update change log + lod and multi mesh as experimental features * Forgot a file * Small changes based on QA review * Simulate headers on enum values in SlotContainerEditor (#49) * Simulate headers on enum values in SlotContainerEditor * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Update VFX * Fix for blackboard scrollable element hidden by resize. * Disable LOD test for XR * Fix test threshold that was reset to 0... * Ignoer graphviz folder * Target Gameobject windows resize doesn't go too far above scrollbars * Missing or incorrect unit in uss. * fix for reference image "VFX/Execution" not updated to new path ( warning when adding output) * Change description in package.json to reflect VFX is not out of preview with URP and mobile * Simplify linear drag (#67) * Simplify linear drag * Fix warning * Enable m_CachingShaderPreprocessor (#65) * *Enable m_CachingShaderPreprocessor * Try enabling vulkan * Unify m_APIs in URP & HDRP * Fix for node window staying when clicking elsewhere (#68) * Fix for node window stayting when clicking elsewhere * Update CHANGELOG.md * Prevent resourcehistory from beeing set to null by serialization (#66) * Vfx/docs/system requirements (#69) * Added system requirements documentation. * Corrected phrasing * Added toc entry * Reorganised toc entry Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix position of block creation window (#72) * Fix Missing System Seed Builtin (#70) * Add missing system seed variant * Add test to cover all builtin expression are available through operator (avoid regression) * *Update changelog.md * Fix inconsistant case * Fix indentation * Fix Prefab Highlight for initial event name toggle & override (#71) * Fix prefab blue highlight * *Update changelog.md * Add test for Mesh Stripping (#59) * *Add test data * Enable StripUnusedMeshComponents: 1 * Enable mesh stripping in HDRP project * *Add reference images * Call recreateCopy after recusion test not before. (#52) * Call recreateCopy after recusion test not before. * Update CHANGELOG.md * Uniquify create visual effect gameobject name. Standard behaviour. (#75) * Uniquify create visual effect gameobject name. Standard behaviour. * Update CHANGELOG.md * Use the AssetDatabase.FindAsset to find VFXResources asset (#48) * Use the AssetDatabase.FindAsset to find VFXResources asset * Update CHANGELOG.md * Search VFXResource only if necessary. * LoadUserResourcesIfNeeded * Fix changelog merge * Added feature: User can specify a directory that holds their VFX template assets (#34) Added feature: User can specify a directory that holds their VFX template assets Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu. ## How to use The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems ![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d) Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option. ![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df) This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders. ![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f) Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed: ![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2) * Vfx/fix/1246989 normals and scale (#81) * Fix normal for lit mesh and non uniform scales * Use inverse transpose in planar primitives * Fix planar primitive with non uniform scale in local * Add gfx test * Add comment * Update changelog * Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76) * Fix Texture2DArray and Cubemap exposition from sg in output mesh context * Add case to changelog * Temporarily deactivate non uniform scale test (Some files were lost :() * [Test] Enable test to cover properly reset override behavior (#80) * Renable test to cover issue 1206890 * Fix newly introduced test : Exepcted value is original after reset override & handle correctly color * int and uint support in Compare (#53) * Add int and uint to Compare node and condition expression * minor fixes * Change SerializeType so that tests are correct against System.Type and null * Fix switch * Update changelog * Added render pipeline compatability table (#87) Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix square complexity on parameter to serialized property matching (#78) * Fix square complexity on parameter to serialized property matching * Update CHANGELOG.md * Fix vfx view not beeing framed at launch (#79) * Fix vfx view not beeing framed at launch * safer implementation * Update CHANGELOG.md * Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84) * Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null * Update CHANGELOG.md * SampleSDF operator (#88) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Fix Shadow compilation using shaderGraph (URP/HDRP) (#77) * *Prepare a proper way to test different shadow cases * prepare a shadow graph unlit (modifying alpha) * Add reference data for shadow test * Minimal data for reproduce issue 1259511 * Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define * *Update ShadowMaterial * *Update ShaderGraphShadow.vfx * *Move shader to common testing asset * Add equivalent test for URP * Add graphicTest for URP * *Update reference images * Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting * Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence * Fix incorrect block listing * *Update changelog.md * Fix pass selection for lit effect * Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution * Voluntary add disabled branch on shadow unlit to cover alphaTreshold case * *Minor comment * Fix return alpha clipping (missing actual alpha test enabled) * *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging) * VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.' # Conflicts: # com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template * Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset * *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f) * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288 It was a bad merge Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96) * Fix missing type copy in reduce Tested locally on a PS4 * Add expection to detect unsupported value type * Fix 1154328 - infinite recompile with rand (#93) * Change the way rand expression equality is handled * Refactor a bit * Add editor test * World to Viewport Point & Viewport to World Point operators + Test (#98) * World to Viewport Point & Viewport to World Point operators + Test First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator. Includes a test scene for these 2 operators. * Update CHANGELOG.md Update Changelog * Added documentation md files. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Make null ( not deserializable ) objects part of undo state (#86) * Fix compile loop in vfxoperator (#61) * Update to visual studio package 2.0.2 (#74) * Fix SDF Operators and blocks from PR #88 (#94) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Remove the use of inverse transpose for the "normals" * Restore the Inverse Transpose and modify Collision code * Restore Conform and Collide previous behavior + direction points to the surface * add documentation * Consistent distance and normal handling + ref images * Cleaning + World space stick distance and radius + references * Max scale through expression evaluated on GPU (if needed) * Max3 on CPU * Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91) * Simpler update to use now available ByteAddressBuffer * Temp Workaround a GPU hang We should isolate properly this code. * Proper fix of OOB FetchBuffer * *Update changelog.md * Update assets * Update URP tests assets * More update to assets * Remove old gfx tests images ref * Fix changelog * Fix Construct Matrix on GPU (#102) * Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU * *Update changelog.md * Output Event Helpers (#58) * Base Commit * Moved Files down one folder * Updated Package Configuration, CHANGELOG and documentation * Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour * Small fixes and checks * Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check * Small Fixes * Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly * Other custom Editors + Helpbox * Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in Prefab Spawn * Removed Rerouting Helpers as CopyValuesFrom is broken at the moment. * Fixed ASMDEFs / class accessibility * Updated Documentation * Fixed Class Accessibility for ExposedPropertyDrawer * Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer) Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Add support for Gradient sampling with and without gradient mode #100 * Fix changelog * Fix case 1279294 : Invalid Random per component behavior in spawn context (#107) * Revert "Output Event Helpers" (#110) * Revert "Output Event Helpers (#58)" This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78. * Revert "Fix changelog" This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137. * Fix changelog (missing revert) * Fix changelog : Unexpected carriage return * Point cache: Binary format corrupted due to an extra byte offset (#108) * Point cache header, wait for new line character only (/n) and skip carriage return(/r) An extra trailing new line character was causing an invalid offset in binary point cache files. * Update Changelog * Remove unnecessary files * Fix InvalidCastException when using byte properties in point cache files (#109) * Change casting to byte We were trying to cast an object containing a byte to an int. Also, a better normalization would be dividing by 255. * Update CHANGELOG.md * update asset and script…

* 10.2 fixes * [VFX] harmonize position + fix API validation (#2365) * property attributes not serialized (#253) * Initial tests * Fix typo * Change the VFXPropertyAttribute class * Use VFXPropertyAttributes in VFXProperty * Refactor interface * Remove old VFXPropertyAttribute class * More fixes * Fix bug in DataAnchorController * Fix invalid cast typo * Remove shader warnings (#261) * Fix shader warnings in test projects * Update changelog * Vfx/feature/filter enum (#243) * Allow filtering enums values in VFXModels. * Add an explicit GetHashCode() to default NameNType. * Update CHANGELOG.md * Update VFXHDRPSubOutput.cs * fix based on review * Remove raytracing enumerator filter as it was removed from HDRP enum * Remove irrelevant render queues from some HDRP outputs (#263) * Remove AfterPostProcessing render queue for lit outputs * Remove render queue field from distortion outputs * Update changelog * Update HDRP changelog instead of VFX * Fix issue when converting outputs with invalid render queue # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Fixed Flipbook Texture Names * Update CHANGELOG.md * Fix exception when creating new category on new visual effect asset. * Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205) * Fix to graft : support for flag enum in inspector * *Update changelog * Revert "Fix Enum Flag" (#15) * "Fix Enum Flag" (#16) This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241. * Fix for Initial Event field height, (#17) * Fix for Initial Event field height, that were clipping the bottom of legged letters * Update CHANGELOG.md * Vfx/fix colorfield height (#19) * Fix color field height * changelog * Mesh Sampling (revival) (#1) * Squashed commit of the following: commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935 Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933 Use simpler & explicit definition of propagated flags * Fix several issue/comment Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765 * Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph * Fix tooltip issue from @lewisjordan Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386 Side note : use mode instead of "addressingMode" in PositionMesh as well. * Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553 * As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777 * Add composition for Position (Mesh) as suggested by @thomasi Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Update experimental disclaimers (#367) * Updated experimental disclaimers * Removed link and added description instead. * [HDRP] MSAA & MotionVector (#12) * Support WRITE_MSAA_DEPTH Unlit template * Fix MSAA for lit output * *Update changelog * Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH TODO : Fix Sphere output as well * Fix typo in ParticlePoint * Factorize common fragment Lit & unlit for depth alike passes. * Fix particle hexadreon wrong depth with alpha clip * Revert "Fix particle hexadreon wrong depth with alpha clip" This reverts commit b16bd570440087984c2c8c48279bebb088f748e8. * Allow an object slot to have null as its value (#25) * Allow an object slot to have null as its value * changelog * Vfx/fix/prevent capacity change locked (#24) * Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode * changelog * *Update all vfx (had to do it manually...) * Restore missing enty in hdrp changelog (bad resolve conflict from me) * Fix 1233044 - capacity cannot be zero (#21) * Prevent capacity from being 0 * Fix strip capacity as well * Vfx/fix/param order (#22) * Fix for dragged parameters order when there are categories * changelog Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix minor issue with VFXPreviousPositionBinder.cs (#23) Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/fix/sgoperator create context drag (#28) * Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot. * changelog * Vfx/fix/context no blocks (#27) * Don't show block windows when context cant have blocks (output mesh ) * changelog * PropertyBinder : Minor Fixes (#29) * Fix for binder when null asset & fix for binder while resetting * Call ClearPropertyBinders while resetting * Add Update Modes & Time Access (revival) (#4) * Squashed commit of the following: commit d77638ba4188bfb03c81130b82cacb2a719f03be Merge: 49eaeadff7 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 09:46:59 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 14:53:09 2020 +0100 Update UX for new time access (#260) https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280 See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z commit 78d5d9938d9896d517efa89662764afd44ef12fc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 16:03:26 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060 commit bc7e715b0e41b55126fdf171b7459b680e3e3824 Merge: 9a82a52bfe ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 14:52:03 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88 Merge: f56986d415 66df0debfc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 09:17:53 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit f56986d4157f140ca84b039d97c8b7064a18214e Merge: 047820690f 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:25:07 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 047820690fa496bd43d3a60df16dd0932502c7cb Merge: d6d17dfbbc e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:56:39 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:59:15 2020 +0100 Squashed commit of the following: commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 13:37:05 2020 +0100 Use implicit block for old position backup commit e786cf3ade7d7515da4569dde9455881af02f282 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Jan 12 15:05:03 2020 +0100 WIP : Add option to skip zero delta per update context commit e864fae742120fbfebabb26b605ddedfd184b02b Merge: 4eecc0b90b fb12af4c28 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:47:57 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 16:08:07 2020 +0100 Rename ProcessEveryFrame in ExactFixedTimeStep commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 16:21:50 2020 +0100 Fix ManagerMaxDeltaTime (was GameDeltaTime) commit eaebe2649e93a5083fd62c91ac92185794b908e5 Merge: 98e7dcfcdc 276c02f29a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:42:08 2020 +0100 Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes commit 98e7dcfcdceb710c252e4d1a257815a724539e68 Merge: 248004d55a 0737eb535c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:26:54 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 248004d55a7b96c6532cd3c197e175b751d6f3fe Merge: 2bbadae355 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 9 13:12:50 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 2bbadae355bb3c4a308b8d4e020e96127fa94818 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:07:46 2019 +0100 Add tooltip to VFXTime.cs commit 9dc7ea790327b44ffde94bbf783d588e74c50174 Merge: bf48ba84eb 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:29:13 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit bf48ba84ebfd1472d041966ba4be627e3a1ef427 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:26:30 2019 +0100 *Update changelog.md commit b5d76d5d5d65584fde771213d9a01adc6dd9b856 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 16:10:19 2019 +0100 Add operator to enable time accesses commit 1a2fe7b8dc5072dd49d985f045f276385e08287f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 11:25:52 2019 +0100 Add built-in expression (but not listed) commit b0d0e64ee04036adf48f4481bfd22eace649bac3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:37:50 2019 +0100 Add some header commit 490a441046a227bb1cc1b98418d0559da17d3771 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:36:57 2019 +0100 Add tooltip & text content commit 621c5b2b78545800b2e94921b9314ef860992059 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:09:32 2019 +0100 *Add custom inspector to edit update flags efficiently * Fix build (VFXPropertyAttribute.Create isn't needed anymore) * Fix editor test * Read Attribute in Spawn Context (#6) * Squashed commit of the following: commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 11:14:14 2020 +0200 *Update image reference (having issue with standalone, not sure of the result) commit 275c22de35f08ada783c96c625b12475f0c42337 Merge: 85254f1ec4 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 09:59:48 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # com.unity.visualeffectgraph/CHANGELOG.md commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 16:21:39 2020 +0100 *Update image reference due to fix with grapicTest update commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf Merge: d8db341bfb 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:51:43 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset commit d8db341bfbd9257e1a5285d200e3eabe24857b01 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:57:38 2020 +0100 *Apply Formatting commit f80441dd6b30ef726d46ae2fe32bcf05d208b760 Merge: b3d858ffe1 01f176355a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:32:49 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7 Merge: 0bce44dc9a 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:18:58 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # .yamato/upm-ci-vfx_lwrp.yml # .yamato/upm-ci-vfxmain.yml # com.unity.visualeffectgraph/CHANGELOG.md commit 0bce44dc9a694bf36b849efb894e999fa9dc959e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:20:03 2020 +0100 *Fix build commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df Merge: 2130ea0ef2 e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 09:47:09 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 2130ea0ef2186ecdc5692878940d5d6635dca31b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:09:13 2020 +0100 *Update tooltips (thanks @vlad) commit f8cdb95f5d2075848e530d997551b69de43f39e0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:01:44 2020 +0100 Rename SpawnerState in SpawnState commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 13:54:24 2020 +0100 Improve ReadAttribute test to cover NewLoop state commit 2c515bfde823bfbce87df8a1444e19e5c2327e32 Merge: a9efee24ff bff1b74b59 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 16:32:45 2019 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit a9efee24ff84131c53dc2ba93f1985b02217e3d7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:54:25 2019 +0100 *Update comment commit 6b17879881555cd72b3af4463fd907423f92ad7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:53:11 2019 +0100 Throws an exception while detecting unexpected expression flag commit cbad9212075ec6776cf9d892185dd6ee64f8fab2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:43:33 2019 +0100 Reorder spawner state operator commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:35:30 2019 +0100 Fix issue "Cannot plug in attribute-derived nodes into a spawner block." commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:58:30 2019 +0100 *Update changelog commit 61bd2e5871f23002dd1add024858efdef5e09372 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:46:52 2019 +0100 Update _CCCC test & Rename Spawner State library name commit 4942912123d795023aacb0363c8e462a2da29943 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 16:58:17 2019 +0100 Fix test & clean useless code in VFXExpression.Initialize commit e6d6c593eb27c612a225340615dabe7692f76a00 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:22:31 2019 +0100 Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose commit f00f740b775f67e9378072744513f3ff920f470d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:16:39 2019 +0100 Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change) commit b7d8e238dd7e05bf99114a980c8584da7985dcf8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:45:56 2019 +0100 Clean test data & add reference images commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:17:51 2019 +0100 Move graphicTest to common files commit fa21846e7787fec9068c5a18a33dc568df3f7cc9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 11:53:18 2019 +0100 Separate cleanly per event attribute expressions commit 80e5259674a011e864e65f13c77ce06f92f33b7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 08:38:41 2019 +0100 New test for chaining & read attributes commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 18:47:20 2019 +0100 Add read attribute for loop settings (context evaluation) commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 15:30:56 2019 +0100 Clean expression patching commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 11:45:06 2019 +0100 Clarify compatibility code for spawner order & random implication commit 0dcf774f623fb93eb7bc19b06407b88669472443 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 18:42:30 2019 +0100 Add tricky case in test vfx & fix compatibility code TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 16:49:42 2019 +0100 *Up local test commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 15:22:03 2019 +0100 Detect & Compute partial evaluation commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:16:29 2019 +0100 Add spawner State Operator & SpawnCount (even if it's actually an attribute) commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:04:04 2019 +0100 Add spawner state accessor commit adb1d6d66172f2d187b577facaf7b2aea4677d13 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 11:24:20 2019 +0100 Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling commit d43ad0e1395d0e51f3583ce9627a72006356e117 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 2 16:19:05 2019 +0100 Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute commit 8a25b5fbed33569529d30379fce2acd4da7de88d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 29 16:14:32 2019 +0100 Backup test asset (temporarily) commit dcb3efaf885dbbdec317f5a42ace9ace336fded9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 16:37:48 2019 +0100 WIP : experimenting new concept of Read Attribute expression * Merge with vfx/staging * Update VFX * Misc small fixes (#36) * Fix strips outputs, spawnIndex and default metallic value * Increase threshold in particle strip unlit test * Test for Override resetted (#26) * *WIP* add test * Actually add a more legit "prefab" test * Prepare fix later fix of 1206890 : can't change the C++ without updating this test * Fix editor test (todo : graft this change to master to anticipate the C++ change) * Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20) * New Test : total time is sum of delta time (#7) * *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249 * [Fix] Disable reset option (#41) * Disable reset option * Add repro case 1251533 * Fix minor issue with PreviousPropertyBinder (bis) (#31) * Fix minor issue with VFXPreviousPositionBinder.cs * Fix exception in OnEnable Note : I didn't try it locally yet. * Actual fix of VFXPreviousPositionBinder.cs Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix culture issues when generating attributes defines in shaders (#40) * [PropertyBinder] Move Update to LateUpdate (#38) * Fix issue with VFXPropertyBinder : we should use late update instead of Update * *Update 23_ParameterBinder reference image * Call resyncslots on shadergraph dependent models. (#10) * Call resyncslots on shadergraph dependent models. * missing call to checkgraphbeforeimport * indentation * fix slot not updated if only the attributes change * Do the same for models having subgraphs than for models having shadergraphs. * Fix based on PR review * Update CHANGELOG.md * update vfx and settings * Renable 009_MultiCamera in URP project * Easy Wins (Small Workflow / Cosmetic fixes) (#37) * Properties now exposed by default in blackboard * Dissociated Colors for bool/int/uint * Added Degrees / Radians conversion subgraphs in samples * De-nicified attribute name (conserve case) in Set Custom Attribute title * Changed the default "No Asset" message when opening the visual effect graph window. * Subgraphs are not in hardcoded categories anymore + Updated Serialization * Added Documentation for setting Subgraph Menu Categories Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/docs/compatability disclaimer (#43) * Added compatability disc * Updated format. * Save a specific vfx asset and its sugraphs only (#35) * Save graph asset works * Update CHANGELOG.md * Update VisualEffectGraphWindow.md * Update VisualEffectGraphWindow.md * Fix for block copy not dirtying the scene. * Remove some unecessary compilation (not all) (#46) * New TransformVector4 and GetTextureDimensions operators (#18) * Vfx/feature/new operators 2 (#266) * Add TransformVector4 operator * Remove unused code * Fix warning * Refactor dynamic type operator * Samll fix to previous commit * Add texture dimensions operator and expressions * Add tooltips * Add changelog entry * Fix merge compilation * Modify point cache test * Prevent textures from being constant folded * Move modified test to correct folder * Output Event (#5) * Squashed commit of the following: commit 449a60793a4c5c91e1913c42632448eb07ebe5de Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:27:48 2020 +0200 Fix stackoverflow with subgraph (but doesn't fix the internal workflow) commit caf0df3af5f451f9576c2cc7f328b57a87479f30 Merge: bb1047c59a a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 10:22:47 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/output-event commit bb1047c59a084551e7df3b93d7d5ad501145ecaf Merge: 7b2890b76f 98ce4878d1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 17:17:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:54:17 2020 +0100 Add a check of outputEvent in SpawnerTest commit 945992b2feff4b8f7a24740944c77a4a92f271dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:24:56 2020 +0100 *Update OutputEventTest.cs to check Test_Output_Event commit c48fda763e807503f27f98deeda4238b6628c264 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 18 10:17:21 2020 +0100 *Update image reference & Test (stop using a undebuggeable random position) commit 5a5ad49cb485907ee869445627821810589ab34a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 22:12:58 2020 +0100 Fix newly integrated spawn test for output event commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c Merge: ef4837245e 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 17:53:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs commit ef4837245e1d88846f6d686e2803094d1d6cd04d Merge: 2331c32fb4 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 08:30:00 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda Merge: 5d225d6e19 0103971ce2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Feb 6 08:01:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 5d225d6e192b32394faf0964ad263cc33c5280cc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:01:51 2020 +0100 Fix editor test commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:00:35 2020 +0100 Add distinct while retrieving virtual link commit 725252869ac24d962490b4550821fbba2ab119b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Feb 3 14:38:52 2020 +0100 *WIP* Output test commit 96098fa11f4781837543fba099936b15a8c7158d Merge: 02178104a3 bb04ca28fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 31 14:07:02 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 02178104a301fb434d5e6821cd369884bbc01006 Merge: 1443b66691 db8325ba2b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 18:06:20 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 1443b66691d46ed9598ccc26b0b9425d373b61e1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:37:08 2020 +0100 *Reduce unexpected changes commit aa1afcafa9c95d042db146043c60015d3f5c96f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:31:13 2020 +0100 New UX for output event (use data instead of system name) (#229) * *WIP* Experiment for UX using eventName * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name * Remove useless naming pattern linking label & title for output Cleaner & Safer implementation for outputEvent edition * Use unique system naming * Add test for Data for VFXOutputEvent * Fix hacky OnInvalidate commit 9cd41b81cef062991907d5ce446336bde78b79d3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 15:11:39 2020 +0100 Add editor test to check return value of output event (not attribute, already cover by graphic test) commit 1a09c63a98e4650b82160e670cedfb06b630284d Merge: 35126156f2 52ce8b9636 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 11:02:45 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 35126156f2b93b04543de0eb91aca79adf331b2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 17 13:58:06 2020 +0100 Avoid exception if system isn't present yet commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 16 10:53:13 2020 +0100 *Update Test, adding a test on unused source attribute commit bfd29d8862539cef5b14392e21cbd896436339a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 20:20:59 2020 +0100 Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test) commit d89160df852b64a4b5ecf378c506aa0c9f1c099c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 16:13:02 2020 +0100 Filters out orphan output event context commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 14:30:08 2020 +0100 *Update changelog commit cf54e5372e273f86dd5c2e00a6178a543f234fd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 08:40:09 2020 +0100 Add reference image for HDRP commit d710998eb133a3dbadbdec580d1ecad3752aca85 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:17:28 2020 +0100 Add reference images for newly added test commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 15:23:18 2020 +0100 *Add a material to unit test commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 17:02:27 2020 +0100 Start implementing a effective test project commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 16:56:28 2020 +0100 FIx system name synchronisation (not really ideal) commit 7782b888266a011f4f986a7bb3161f024730caa7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 14:24:08 2020 +0100 Fix UI of output event commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 10:11:56 2020 +0100 Fix build commit 50ae031af02d4c41e651f64b40e9d265668b803f Merge: d838cd2d37 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 7 13:36:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 14:58:00 2019 +0100 Add a wip test scene commit 459b344b3f97c794d47a8eb6942b1129d18632cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 11:40:30 2019 +0100 Fill VFXDataOutputEvent commit e54905485dd553cadcde307ca00a8d7ce8454c0f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 18:21:31 2019 +0100 Add basic output event type (empty FillDesc implementation for now) * Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP* * Update 009_OutputEvent test * Move 009_OutputEvent to correct folder (TODO, this to rename it before merge) * Fix sanity test & allow multiple connection from in outputEvent (as initialize) * Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context * Fix editor test using eventName instead of tile * Revert unexpected changes * *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485 * Rename VisualEffectOutputEventArgs => VFXOutputEventArgs * Disable connection from OutputEvent to GPUEvent * *Fix build VisualEffect.OutputEventArgs => VFXOutputEventArgs Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5 * Vfx/feature/enum parameter (#8) * Restart of enum parameters * more work * more work * Still more work. * reorderable list looks good. * Adding and removing values works. * dragging item works. * Enum values show in the inspector. * fixes for rebase * Enumvalue works on subgraphs. * notify enum name change. * Added documentation for blackboard value filtering. * no value per enum * only uint can now avec enum values. * don't nicify enum values. * Update Blackboard.md * Update VFXBlackboard.uss * sanitize parameter already having range * Clamp enum value works. * Changing switch testValue to uint. * value appearing as menu if mode is enum. * Update CHANGELOG.md * Mutli editor of different values of enum parameter works. * cpoy paste enumValues and min/max when copying parameter. * Copy parameter mode when converting to subgraph. * fix * Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt. * Vfx/docs/new operator docs (#50) * Added documentation for new operators * Changed bullet format. * Fix creation of StringPropertyRM (#51) * Fix creation of StringPropertyRM * Update CHANGELOG.md * Fix input of event emitting block beeing to small because of output * Multi-mesh output, LODs and compute culling (#14) * Implement multi mesh * Add LOD + lit mesh output support * Small fix + optim * Fix crash with multi mesh + sorting * Fix shader compilation with single mesh and compute culling * implement multi sorting * Add globalSort parameter * Fix camera absolute mode * Fix URP shader compilation * Add frustum culling to LOD * Add frustum culling setting * filter out implicit settings and add tooltips * Add radius scale + tooltips * Add a graphics test * Update change log + lod and multi mesh as experimental features * Forgot a file * Small changes based on QA review * Simulate headers on enum values in SlotContainerEditor (#49) * Simulate headers on enum values in SlotContainerEditor * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Update VFX * Fix for blackboard scrollable element hidden by resize. * Disable LOD test for XR * Fix test threshold that was reset to 0... * Ignoer graphviz folder * Target Gameobject windows resize doesn't go too far above scrollbars * Missing or incorrect unit in uss. * fix for reference image "VFX/Execution" not updated to new path ( warning when adding output) * Change description in package.json to reflect VFX is not out of preview with URP and mobile * Simplify linear drag (#67) * Simplify linear drag * Fix warning * Enable m_CachingShaderPreprocessor (#65) * *Enable m_CachingShaderPreprocessor * Try enabling vulkan * Unify m_APIs in URP & HDRP * Fix for node window staying when clicking elsewhere (#68) * Fix for node window stayting when clicking elsewhere * Update CHANGELOG.md * Prevent resourcehistory from beeing set to null by serialization (#66) * Vfx/docs/system requirements (#69) * Added system requirements documentation. * Corrected phrasing * Added toc entry * Reorganised toc entry Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix position of block creation window (#72) * Fix Missing System Seed Builtin (#70) * Add missing system seed variant * Add test to cover all builtin expression are available through operator (avoid regression) * *Update changelog.md * Fix inconsistant case * Fix indentation * Fix Prefab Highlight for initial event name toggle & override (#71) * Fix prefab blue highlight * *Update changelog.md * Add test for Mesh Stripping (#59) * *Add test data * Enable StripUnusedMeshComponents: 1 * Enable mesh stripping in HDRP project * *Add reference images * Call recreateCopy after recusion test not before. (#52) * Call recreateCopy after recusion test not before. * Update CHANGELOG.md * Uniquify create visual effect gameobject name. Standard behaviour. (#75) * Uniquify create visual effect gameobject name. Standard behaviour. * Update CHANGELOG.md * Use the AssetDatabase.FindAsset to find VFXResources asset (#48) * Use the AssetDatabase.FindAsset to find VFXResources asset * Update CHANGELOG.md * Search VFXResource only if necessary. * LoadUserResourcesIfNeeded * Fix changelog merge * Added feature: User can specify a directory that holds their VFX template assets (#34) Added feature: User can specify a directory that holds their VFX template assets Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu. ## How to use The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems ![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d) Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option. ![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df) This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders. ![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f) Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed: ![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2) * Vfx/fix/1246989 normals and scale (#81) * Fix normal for lit mesh and non uniform scales * Use inverse transpose in planar primitives * Fix planar primitive with non uniform scale in local * Add gfx test * Add comment * Update changelog * Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76) * Fix Texture2DArray and Cubemap exposition from sg in output mesh context * Add case to changelog * Temporarily deactivate non uniform scale test (Some files were lost :() * [Test] Enable test to cover properly reset override behavior (#80) * Renable test to cover issue 1206890 * Fix newly introduced test : Exepcted value is original after reset override & handle correctly color * int and uint support in Compare (#53) * Add int and uint to Compare node and condition expression * minor fixes * Change SerializeType so that tests are correct against System.Type and null * Fix switch * Update changelog * Added render pipeline compatability table (#87) Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix square complexity on parameter to serialized property matching (#78) * Fix square complexity on parameter to serialized property matching * Update CHANGELOG.md * Fix vfx view not beeing framed at launch (#79) * Fix vfx view not beeing framed at launch * safer implementation * Update CHANGELOG.md * Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84) * Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null * Update CHANGELOG.md * SampleSDF operator (#88) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Fix Shadow compilation using shaderGraph (URP/HDRP) (#77) * *Prepare a proper way to test different shadow cases * prepare a shadow graph unlit (modifying alpha) * Add reference data for shadow test * Minimal data for reproduce issue 1259511 * Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define * *Update ShadowMaterial * *Update ShaderGraphShadow.vfx * *Move shader to common testing asset * Add equivalent test for URP * Add graphicTest for URP * *Update reference images * Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting * Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence * Fix incorrect block listing * *Update changelog.md * Fix pass selection for lit effect * Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution * Voluntary add disabled branch on shadow unlit to cover alphaTreshold case * *Minor comment * Fix return alpha clipping (missing actual alpha test enabled) * *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging) * VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.' # Conflicts: # com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template * Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset * *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f) * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288 It was a bad merge Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96) * Fix missing type copy in reduce Tested locally on a PS4 * Add expection to detect unsupported value type * Fix 1154328 - infinite recompile with rand (#93) * Change the way rand expression equality is handled * Refactor a bit * Add editor test * World to Viewport Point & Viewport to World Point operators + Test (#98) * World to Viewport Point & Viewport to World Point operators + Test First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator. Includes a test scene for these 2 operators. * Update CHANGELOG.md Update Changelog * Added documentation md files. Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Make null ( not deserializable ) objects part of undo state (#86) * Fix compile loop in vfxoperator (#61) * Update to visual studio package 2.0.2 (#74) * Fix SDF Operators and blocks from PR #88 (#94) * Operator creation, does NOT sample an SDF * First implementation of the sampleSDF operator, might not be optimised * Delete VFXExpressionSampleSDF.cs * Updated Test Graph * Better handling of out of bounds queries for normals and distances * Delete HDRenderPipelineEditorResources.asset * Delete XRPackageSettings.asset * Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input * Update 27_SampleSDF.vfx * Update 27_SampleSDF.vfx * restored the deleted asset * Enforces and apply the 4 parents max rule * Removes the return statements in branch * Revert "restored the deleted asset" This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb. * Revert "Revert "restored the deleted asset"" This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20. * Fix compilation error and warnings * Fix Pascal case * Fix Pascal. Really. * Revert "Revert "Revert "restored the deleted asset""" This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1. * Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling) * Delete packages-lock.json * Revert "Delete packages-lock.json" This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735. * Revert "Revert "Delete packages-lock.json"" This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4. * Restore this mistakenly modified file * Update 27_SampleSDF.vfx * Get rid of useless transpose * Added Graphic Test * Added reference images * Fix incorrect out-of-bounds check + auto recompile * Added reference images * Clarify the name of the output * Remove the use of inverse transpose for the "normals" * Restore the Inverse Transpose and modify Collision code * Restore Conform and Collide previous behavior + direction points to the surface * add documentation * Consistent distance and normal handling + ref images * Cleaning + World space stick distance and radius + references * Max scale through expression evaluated on GPU (if needed) * Max3 on CPU * Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91) * Simpler update to use now available ByteAddressBuffer * Temp Workaround a GPU hang We should isolate properly this code. * Proper fix of OOB FetchBuffer * *Update changelog.md * Update assets * Update URP tests assets * More update to assets * Remove old gfx tests images ref * Fix changelog * Fix Construct Matrix on GPU (#102) * Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU * *Update changelog.md * Output Event Helpers (#58) * Base Commit * Moved Files down one folder * Updated Package Configuration, CHANGELOG and documentation * Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour * Small fixes and checks * Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check * Small Fixes * Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly * Other custom Editors + Helpbox * Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in Prefab Spawn * Removed Rerouting Helpers as CopyValuesFrom is broken at the moment. * Fixed ASMDEFs / class accessibility * Updated Documentation * Fixed Class Accessibility for ExposedPropertyDrawer * Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer) Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Add support for Gradient sampling with and without gradient mode #100 * Fix changelog * Fix case 1279294 : Invalid Random per component behavior in spawn context (#107) * Revert "Output Event Helpers" (#110) * Revert "Output Event Helpers (#58)" This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78. * Revert "Fix changelog" This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137. * Fix changelog (missing revert) * Fix changelog : Unexpected carriage return * Point cache: Binary format corrupted due to an extra byte offset (#108) * Point cache header, wait for new line character only (/n) and skip carriage return(/r) An extra trailing new line character was causing an invalid offset in binary point cache files. * Update Changelog * Remove unnecessary files * Fix InvalidCastException when using byte properties in point cache files (#109) * Change casting to byte We were trying to cast an object containing a byte to an int. Also, a better normalization would be di…

commit b6b0cdca59dd4026117bd3e65e14d17e00b95b09 Author: Lewis Jordan <lewis.jordan@hotmail.co.uk> Date: Mon Oct 19 15:42:25 2020 +0100 Updated the light cheat sheet to include pbs sky (#2273) Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> commit c1b3c12041fced756ccc84b90940f1a1fa0d0053 Author: Lewis Jordan <lewis.jordan@hotmail.co.uk> Date: Mon Oct 19 15:42:06 2020 +0100 Screenshot audit and bugfix (#2259) * Updated DecalProjector screenshot * Updated environment lighting page and screenshot * Fixed bug in frame settings doc * Update Frame-Settings.md * Updated volume override images * Updated post-processing docs * Updated SSR reference doc * Finished screenshot audit * Fixed bug in autodesk shaders * Added debug menu entries * Added RequestedVirtualTextureTiles entry * Updated outdated docs that did not reflect the image * Update Render-Pipeline-Debug-Window.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> commit dcc46748cae48698496983a50d317a5118d6f8c0 Author: Lewis Jordan <lewis.jordan@hotmail.co.uk> Date: Mon Oct 19 15:41:34 2020 +0100 Updated ray-traced shadows doc to include information about double sided materials (#2257) commit 691b32e00d109a135a842069e19a693e1d945e44 Author: sebastienlagarde <sebastien@unity3d.com> Date: Mon Oct 19 15:45:55 2020 +0200 Bump version to 10.2.0 (#2268) * Bump version to 10.2.0 * bumped shader minimum package version in version.hlsl * Fix various typo and bump core * add missing date to shader graph Co-authored-by: Felipe Lira <felipedrl@gmail.com> commit 2e401c61ffca7312ba503d7be5dfd5e58b25d01f Author: noreply@unity3d.com <noreply@unity3d.com> Date: Mon Oct 19 01:42:40 2020 +0000 [CI] Updated .ymls to new revision commit 0350ec7898029cea083bbc9cc6dd979460b6ee16 Author: Chris Tchou <ctchou@unity3d.com> Date: Sun Oct 18 08:11:48 2020 -0700 [ShaderGraph] [bugfix 1206438] Detect and handle subgraph deletion while subgraph node is in use (#2186) commit 48c802198267897ecaa28a71d94ab913f4b8b33b Author: noreply@unity3d.com <noreply@unity3d.com> Date: Sun Oct 18 01:47:04 2020 +0000 [CI] Updated .ymls to new revision commit d0680d5a8ac4f6e0f8dc9e265e8179c7ca81bb7c Author: noreply@unity3d.com <noreply@unity3d.com> Date: Sat Oct 17 02:11:25 2020 +0000 [CI] Updated .ymls to new revision commit 3eaea35384d31cf5bfcef815a1b2fd44075a3e0a Author: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> Date: Fri Oct 16 15:43:20 2020 -0700 [10.2][Shader Graph] Small UI Bugfixes (#2029) * change exposuire node label to avoid text clipping solves case 1265057 * move mesh deformation nodes into utility category fixes 1227081 * update changelogs * move mesh deform nodes to input and update docs * add cross pipeline note to target and upgrade guide docs * Docs edit * Move changelog entries to 10.2 section Co-authored-by: Sharlene Tan <sharlenet@unity3d.com> Co-authored-by: Marc Templin <marcte@unity3d.com> commit 846e8dc61254147f5a0181d0b89fe5a7c4bebcbf Author: Chris Tchou <ctchou@unity3d.com> Date: Fri Oct 16 15:31:37 2020 -0700 [ShaderGraph] [bugfix 1241602] Sample2DLOD node will compile on GLES2 devices, but always returns opaque black (#1903) commit b61baf0ba523c6583d7b4c02440de5a3956d6c93 Author: Chris Tchou <ctchou@unity3d.com> Date: Fri Oct 16 15:20:08 2020 -0700 [ShaderGraph] [bugfix 1283800] Make shader versioning semi-deterministic (#2138) commit c9c885575b82fc6a374fdc9f4d64dde755bbea19 Author: elizabeth-legros <59933602+elizabeth-legros@users.noreply.github.com> Date: Fri Oct 16 17:01:28 2020 -0500 Update CHANGELOG.md (#2266) Actual changes are in 10.1 so retconning the fix into those notes even though this won't publish until 10.2. commit 1c66550ead8d8a5579e9080ed7bd14df6d3869f6 Author: noreply@unity3d.com <noreply@unity3d.com> Date: Fri Oct 16 19:54:59 2020 +0000 [CI] [2020.2] Updated latest editors metafile commit 90948d0e89fdbf29b8452f27ffb9291cefd607f3 Author: Felipe Lira <felipedrl@gmail.com> Date: Fri Oct 16 15:48:05 2020 +0200 [10.x.x] Filter list of events in RenderObjects pass to only show valid events. (#2125) * Fixed issue that caused the RenderObjectsPass to render incorrectly when set to events before BeforeRenderingOpaques. * Added API docs for events. Added BeforeRenderingPrepasses to RenderObjects UI. * updated changelog * Addressed PR feedback. commit 890b14cc428ae61dd5c3a510b5c8d5518ae7b4c1 Author: Sophia <16596228+sophiaaar@users.noreply.github.com> Date: Fri Oct 16 15:46:33 2020 +0200 [URP][Performance] Enable subset of perf tests in nightly jobs (#2157) Too many commits to list. see the PR for full changes Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com> Co-authored-by: Sean Stolberg <seans@unity3d.com> commit 544de544b923426b18b633c470a31a739532e0c4 Author: Oleksandr Kokoshyn <oleksandr.kokoshyn@unity3d.com> Date: Fri Oct 16 11:29:00 2020 +0200 Fixed the link to Changelog. (#2254) commit 18623463f30f75badd220d17b23251bb602a3296 Author: Oleksandr Kokoshyn <oleksandr.kokoshyn@unity3d.com> Date: Fri Oct 16 11:03:09 2020 +0200 What's new in URP 10 (#2228) * Images for What's New * Created the What's New section. * Fixed typo. * Minor formatting fix. * Change from Martin T. * Last changes. commit 111ed2e673594a878615d58d96308c53444f1b4d Author: Oleksandr Kokoshyn <oleksandr.kokoshyn@unity3d.com> Date: Fri Oct 16 10:51:17 2020 +0200 Created the page Known Issues (URP 10). (#2245) * Created the page Known Issues (URP 10). * Added the link to the issue tracker. commit 66237e6898e58b6a0effddfaae40459babcb4987 Merge: fef8b17d2f 320da10c01 Author: sebastienlagarde <sebastien@unity3d.com> Date: Fri Oct 16 10:09:50 2020 +0200 Merge pull request #2250 from Unity-Technologies/srp/change-min-version Change min version to 2020.2b8 commit 320da10c01550f013b59b539758328bff30e0b57 Author: Sebastien Lagarde <sebastien@unity3d.com> Date: Fri Oct 16 10:05:19 2020 +0200 Change min version to 2020.2b8 commit fef8b17d2f500709822ac53bc4573cc9dae204fc Author: Lukas Chodosevičius <lukasc@unity3d.com> Date: Fri Oct 16 11:00:24 2020 +0300 Adding conditionals for baked shadow calculation and shadowmask if ba… (#2236) * Adding conditionals for baked shadow calculation and shadowmask if baked shadow is used. This increases performance for mobile platforms as they can avoid some calculation * Fixing lightprobes to work for shadowmask dynamic objects that are using baked shadow * Optimizing baked shadow selection (Suggested by Felipe). Also changing k_DefaultLightsProbeChannel constant ot correct one commit d55e669465c6b8f7873297614340808fb073ef91 Merge: eccca8b441 57498c9a67 Author: sebastienlagarde <sebastien@unity3d.com> Date: Fri Oct 16 08:46:10 2020 +0200 Merge pull request #2248 from Unity-Technologies/HDRP/staging Fix HDRP API doc commit 57498c9a6792b16aed9e23f6d41f7962c9da2adb Author: JulienIgnace-Unity <julien@unity3d.com> Date: Fri Oct 16 08:42:47 2020 +0200 HDRP public API doc (#2237) * Updated missing doc for HDRP package * Update hdrp config doc * Update based on review Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> commit cad5a09335424b71dc6a44bc3d16700451ad991c Merge: 0d164f2e24 eccca8b441 Author: Sebastien Lagarde <sebastien@unity3d.com> Date: Thu Oct 15 23:35:20 2020 +0200 Merge branch 'master' into HDRP/staging commit eccca8b441fe0059e449aba0d1b398543d2b9ac2 Author: sebastienlagarde <sebastien@unity3d.com> Date: Thu Oct 15 23:34:13 2020 +0200 Remove XR system test + Fix cinemachine in template + Add dxr test (#2247) commit 0d164f2e24a542d8e175b9864a25676810deb86f Author: sebastienlagarde <sebastien@unity3d.com> Date: Thu Oct 15 20:58:38 2020 +0200 Update cinemachine 2.6.1 (#2246) commit 183d6229effdb07591c62f562baaab7b65fc64a5 Author: Julien Ignace <julien@unity3d.com> Date: Thu Oct 15 18:30:16 2020 +0200 Revert "Fix shadows culling with XR (#2223)" This reverts commit 922ca4673b18d1e62eb2e09fc85516b72c1743d7. # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md commit aa21bbd4123443beb278ee374ad928abd774cdf2 Author: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Date: Thu Oct 15 10:59:48 2020 -0400 remove XRSystemTests (#2241) commit 3129d19e2af79ca42ba183e3de09b133e548198d Author: Oleksandr Kokoshyn <oleksandr.kokoshyn@unity3d.com> Date: Thu Oct 15 14:27:21 2020 +0200 Changes to XR feature comparison, from Matt Fuad. (#2232) commit 0a3abbb5497ebe8e9c675e401f87c915b85e61b1 Author: Oleksandr Kokoshyn <oleksandr.kokoshyn@unity3d.com> Date: Thu Oct 15 14:25:23 2020 +0200 Added the upgrade instruction and the requirements for URP 10.1. (#2196) commit 0a9fa40ca2a2b5e52fc4b36f8234d9738e412b0f Author: Oleksandr Kokoshyn <oleksandr.kokoshyn@unity3d.com> Date: Thu Oct 15 14:22:45 2020 +0200 Fixed the formatting of the table for the Shadows section. (#2194) commit 106d63a9b02140ebe629704173a8be0ec5fb7e0c Author: Sebastien Lagarde <sebastien@unity3d.com> Date: Thu Oct 15 14:05:51 2020 +0200 fix #if defined(UNITY_REVERSED_Z) usage => #if UNITY_REVERSED_Z commit 409a092ef5f0616288ca2dc2b1edf5e12fc1a939 Author: Martin Thorzen <35328557+martint-unity@users.noreply.github.com> Date: Thu Oct 15 13:50:15 2020 +0200 Removing the asset database save call (#2207) * Removing the asset database save call * added changelog commit 478145ccc1990d695415d4975442099dc6eb4fcd Author: Felipe Lira <felipedrl@gmail.com> Date: Thu Oct 15 11:54:07 2020 +0200 [10.x.x] Added LightMode documentation. (#1997) * Added LightMode documentation. * fixed formatting * Edited the LightMode tag input from Felipe. * Input from Felipe. Co-authored-by: Oleksandr Kokoshyn <oleksandr.kokoshyn@unity3d.com> commit 94e8a73cd5f27fb842fdb9be517b624faa574c93 Author: Tomas Zigmantavičius <30701728+tomzig16@users.noreply.github.com> Date: Thu Oct 15 12:01:33 2020 +0300 [10.x.x] Android remove redundant SDK tools check (#2104) * Remove mklink command from yamato Android jobs * Remove Android build tools setup from SetupProject.cs * Run ruamel build.py commit cec0431b521ba4ff6c3de2af185cc4e923c9104f Author: Sebastien Lagarde <sebastien@unity3d.com> Date: Thu Oct 15 10:16:06 2020 +0200 Fix for non-static objects not being present at times in OnEnable probes (#1768) commit 0dd86b51132224dcf9896582089c0b61d696d3e8 Merge: 90e2798e7f 730b9ecb8b Author: Sebastien Lagarde <sebastien@unity3d.com> Date: Thu Oct 15 10:14:37 2020 +0200 Merge branch 'master' into HDRP/staging commit 90e2798e7f511160d882208b1122b7815d998b08 Author: Tianliang Ning <paula.s.ning@gmail.com> Date: Wed Oct 14 15:42:21 2020 -0700 Add test for DXR alembic support (#2054) * Add alembic test to HDRP_DXR_Tests * Update alembic reference images * Use Yamato reference images * XR test updated reference image * Revert reference image for WindowsEditor. It looks like playmode_XR has a different result than playmode and playmode_Rendergraph * Modify alembic test to confirm alembic works with ray tracing by viewing alembic mesh via ray traced reflection * Set XR threshold multiplier to 1.5, based on other tests that have to wait for frame * Update WindowsEditor reference image * updated most prefabs to not be prefab variants unecesssarily, updated diffusion profile for bamboo leaves, fixed wood normal map, rebaked, added new "medium" bake settings * [CI] Updated .ymls to new revision * Expose PointCacheAsset textures (#2030) Currently there's no pCache property in vfx graph, this change exposes textures to make them usable instead of pCache. More: https://forum.unity.com/threads/expose-point-cache-as-blackboard-attribute.856603/#post-6355635 * Fixed links and images Fixed issues in the ToC, links in all docs and images in all docs. * Fix Static-shader-analysis.md links. Changed file name of Static-shader-analysis.md and fixed links. * removed useless -preview.1 * Toc name change Also amended links. * TableOfContents name change. * Universal/fixing changelog (#2090) * removing duplicate Added sections * removed accidental added text * Fixed the dates issue * Moved fixed to the right section * Updated fontainbleau compatability and added relevant links * Fix clear coat chagelog issues. (#2095) * Renamed UI `Vector1` to `Float` / Renamed enum `Float` precision to `Single` (V2) (#1979) * rename precision from float to single * rename vector 1 to float * rename vector1 in the documentation * Update Compositor-User-Guide.md * Update Upgrade-Guide-10-0-x.md * fix precision test * add search synonym to upgraded node * update precision test graph * Fixed extra whitespaces and minor rewording * Rename also all enum which a Vector1 inside to get correct string conversion as float * Renamed Float.md and updated links to it * Revert "Rename also all enum which a Vector1 inside to get correct string conversion as float" This reverts commit 3d5fe9b48a1c2b7642b40327c5fea7a259016638. * rename property type to have correct type display * Update DiffusionProfileShaderProperty.cs * Fix blackboard info name after merge of Antoie PR * rename the uss color mode to keep correct banding color Co-authored-by: Alex Lindman <alexandral@unity3d.com> Co-authored-by: Sharlene Tan <sharlenet@unity3d.com> * VFX Staging to Master for 10.1 (#1945) * property attributes not serialized (#253) * Initial tests * Fix typo * Change the VFXPropertyAttribute class * Use VFXPropertyAttributes in VFXProperty * Refactor interface * Remove old VFXPropertyAttribute class * More fixes * Fix bug in DataAnchorController * Fix invalid cast typo * Remove shader warnings (#261) * Fix shader warnings in test projects * Update changelog * Vfx/feature/filter enum (#243) * Allow filtering enums values in VFXModels. * Add an explicit GetHashCode() to default NameNType. * Update CHANGELOG.md * Update VFXHDRPSubOutput.cs * fix based on review * Remove raytracing enumerator filter as it was removed from HDRP enum * Remove irrelevant render queues from some HDRP outputs (#263) * Remove AfterPostProcessing render queue for lit outputs * Remove render queue field from distortion outputs * Update changelog * Update HDRP changelog instead of VFX * Fix issue when converting outputs with invalid render queue # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Fixed Flipbook Texture Names * Update CHANGELOG.md * Fix exception when creating new category on new visual effect asset. * Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205) * Fix to graft : support for flag enum in inspector * *Update changelog * Revert "Fix Enum Flag" (#15) * "Fix Enum Flag" (#16) This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241. * Fix for Initial Event field height, (#17) * Fix for Initial Event field height, that were clipping the bottom of legged letters * Update CHANGELOG.md * Vfx/fix colorfield height (#19) * Fix color field height * changelog * Mesh Sampling (revival) (#1) * Squashed commit of the following: commit 4cd4cb244d720c87580c3386a75209532f2b8629 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:13:24 2020 +0200 Minor change to ease graphViz output view commit a6f9f78ecff57045899508f8a7bb03c9cc731c29 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 18:11:09 2020 +0200 Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue) Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags) Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior commit 7c11de30553cbc378926e3a1d6775f361921ad7a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:54:57 2020 +0200 *Update 007 SampleMesh to cover more cases commit 0baa1401f6fad276323d6369eb4330ef717c978f Merge: 40749ce2ba a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 31 18:04:49 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 40749ce2ba015f004c6e161d75c4063edefd0f3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:50:40 2020 +0100 *Reupdate Image (HDRP, there was an issue with shaderGraph) commit fa7ecbf9656db5316a60aadd450414b4d790e9ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 21:46:02 2020 +0100 *Update reference Image & .vfx (always in HDRP project) commit 7abaf9bbf27c587033ad621301778b15748793e4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 15:13:20 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh commit c5a7a3ed477af8732da0095091c080692c9c64b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 14:52:07 2020 +0100 Add graphic test to cover constant folding (TODO : Update all images) commit 27e3c7464d60659905f13f172c79a79a94b7ac56 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 26 13:37:38 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 commit 128101bc638d98d9628dc90be078450e1f706534 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 12:39:39 2020 +0100 Minor : forgot a punctation commit 8c395cd600dfd8301cf6c83d1354ba457e49e889 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 24 11:01:30 2020 +0100 *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488 commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:33:39 2020 +0100 Fix documentation image link (bis) commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:24:13 2020 +0100 *Fix path in documentation commit 662d086481c228491536d1463dfe61198048a263 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 09:06:12 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790 commit 241ca5edf7451345ecce30da9310b19e24ee37d5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 23 08:21:56 2020 +0100 *Update documentation commit d89f307aca40f88bdda2dc0e9a0324556e296400 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 17:50:44 2020 +0100 *Update documentation commit 9f79d5a48e22881011ccf978217b21ce44ed9a37 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 15:59:56 2020 +0100 first draft of documentation commit f84300e560bfd3698e27da58a4e93236209ac513 Merge: 9c5bd4e887 c04b64c1b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 20 13:22:28 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f Merge: f8284406c8 ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:13:09 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit f8284406c8a99ceb442c13e20049ca14efd3cd7d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Mar 16 10:12:08 2020 +0100 Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944 Split Texture & Buffer commit 39328fb09e1d470727becea05842cd48ceb7c5e2 Author: Tristan Genevet <tristan@unity3d.com> Date: Wed Mar 11 11:42:23 2020 +0100 Fix delegate set that must not be postponed commit 9ddac63551eea34f630ddea0380035728b97bf3a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 17:48:44 2020 +0100 Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial) commit e04224320d5404e44c969e49470eec827622916f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:30:46 2020 +0100 Fix after merge commit fb7dbd291fc063640295b35a24caf87ddccef1f9 Merge: 302ae40d59 5bdcd30bd9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 10 15:15:42 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 302ae40d59ec0c3dd214405392853de8097373ca Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:48:54 2020 +0100 Fix build & behavior commit 61ce50e6dd9e08987bb7273f678e064edc01d110 Merge: 70c93148d4 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 10:18:17 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs commit 70c93148d49f776dc68a47c28053258f8a713f54 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Feb 12 09:04:23 2020 +0100 Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressing mode in Position (Mesh) too & Update Tooltips commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 17:18:28 2020 +0100 *Update reference image for HDRP (clear color isn't exactly the same) commit 65883b0f521cd1e1438890084593081400d594a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 16:09:18 2020 +0100 Fix Color Sampling test commit 3e7ab2cddca5556855280709d18395df1229be57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:54:25 2020 +0100 *Update Mesh Sampling vfx commit b46ffc745a55347e4d310e617afd1a40f2c2a804 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:47:06 2020 +0100 Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567 commit 03dff8383f4cc7acb383a630f0745871db2b7303 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:31:48 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555 Remove output count from the SampleMesh for consistency commit 0d6620339efc53b56906226e78b005ab06a0ab53 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:26:24 2020 +0100 *Update test using vertex mesh sampling commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 15:17:00 2020 +0100 *Use flag in inspector as @julienf suggested commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 11:22:36 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772 Add adressingMode in Custom Sampling commit 00444271a0c3c1efda6373f16432cad3659d8238 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 10:29:07 2020 +0100 Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770 commit d4422c88b66f0cf67c561086798b176db69b3d1a Merge: a7052746e1 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:05:59 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit a7052746e10326979c3e4c4d69ddc4004bcad83b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 09:04:44 2020 +0100 Unexpected change in upm-ci-vfxmain.yml commit 3fa67e367aeda4f85025886d53729111a0d841e6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:57 2019 +0100 Update upm-ci-vfxmain.yml commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d Merge: 442c3cd4e0 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:34:28 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 08:59:41 2019 +0100 Fix experimental & add mesh vertex count output as suggested by @vlad commit 7e306fe26a8839a9d72f4625a61e91814b4105ce Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:13:04 2019 +0100 Update upm-ci-vfxmain.yml commit 31604a66ff6f0b2031681bf26ac7f59d047d493d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:12:46 2019 +0100 Revert upm-ci-vfxmain.yml commit 9f8cdafdbc98f084453894897b54858a67e75483 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 13:11:49 2019 +0100 Revert upm-ci-vfx_lwrp.yml commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573 Merge: 858f1a94ed 5b678082c5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:55:52 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling commit 858f1a94edfc88756a43b41d4652624939a6ab57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:49:20 2019 +0100 Restrict constant folding on mesh operation commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 16:04:40 2019 +0100 *Update ChangeLog.md commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 14:21:01 2019 +0100 Clean useless code commit 8e2e438886de3db5b8ba6c2613102a38947461aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 13:45:51 2019 +0100 Use name expression to compute vertex index commit 8349f56e96668f3656113850048e427859602583 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 09:03:17 2019 +0100 Rename "texture_" to "mesh_" when expression is actually a mesh Remove useless sampler for mesh commit 51f1e01943e4d221a7323363c39656b861a94fe7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 08:39:31 2019 +0100 Update Canvas to include test in graphicTest commit fff4b79856a215bc1d13cb08752f88e40549ddbb Merge: ca39c0d6ec efba8dad57 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 26 07:49:14 2019 +0100 Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset commit ca39c0d6ece391081f786e10e96aa6007af6b18e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 19 11:22:36 2019 +0100 Remove shape test commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 15:02:58 2019 +0100 Temporary : change yamato target to graphics/vfx/fix/mesh-sampling commit aea552d59b018fbf7c217b37d8846e02bfefb349 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:59:04 2019 +0100 *Update player reference images commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 18 14:36:49 2019 +0100 Fix PositionMesh commit 05aec35f9a430497583f5b952fa97ce6784c676d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 17:01:52 2019 +0100 *Update graphicTest commit 052cb87133878404390365f0403b6faa44821133 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 15:30:46 2019 +0100 Fix mesh color sampling commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 14 11:41:59 2019 +0100 Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity commit 2ecdcc54480aa17665db6b980a5ba797539931e9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:28:19 2019 +0100 Add MeshVertexCount operator commit c5b144214270c741bc61a6bc0994c0c5098ba39a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Nov 13 10:08:14 2019 +0100 Add a true embedded random in SampleMesh commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Nov 12 18:35:35 2019 +0100 Fix unexpected cast int to uint commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 14:39:06 2019 +0100 Add WIP TODOPAUL commit 6ff729e50e85204a597c0628be601a2b8064cc3e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 8 13:55:20 2019 +0100 Use uint instead of int & remove RandInt commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:09:22 2019 +0100 *Update Shape.vfx commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 15:07:11 2019 +0100 Fix build commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:46:47 2019 +0100 Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae Merge: bd366e5cf8 d2bacd6482 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Nov 4 14:43:23 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/mesh-sampling # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs # com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs # com.unity.visualeffectgraph/Shaders/VFXCommon.cginc commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f Author: Richard Kettlewell <richardk@unity3d.com> Date: Wed Dec 12 12:53:50 2018 +0000 Fix mesh sampling stride and remove fmod when not needed commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:40:06 2018 +0000 color space fix commit 3df16fe0c60a235e3991249553ccf4167bd7d736 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 16:03:25 2018 +0000 Shape gfx test commit ceef2e0410503647eb1f997f217e9442fb50b823 Author: Richard Kettlewell <richardk@unity3d.com> Date: Tue Dec 11 12:32:36 2018 +0000 Remove baking prototype and fix channel offsets commit 39d518807d279fd328cc4408d5f85667f60e719b Author: Richard Kettlewell <richardk@unity3d.com> Date: Mon Dec 10 15:26:55 2018 +0000 Mesh sampling * Commit data files as lfs * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935 Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable * Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933 Use simpler & explicit definition of propagated flags * Fix several issue/comment Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765 * Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph * Fix tooltip issue from @lewisjordan Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385 Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386 Side note : use mode instead of "addressingMode" in PositionMesh as well. * Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553 * As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777 * Add composition for Position (Mesh) as suggested by @thomasi Co-authored-by: Tristan Genevet <tristan@unity3d.com> * Update experimental disclaimers (#367) * Updated experimental disclaimers * Removed link and added description instead. * [HDRP] MSAA & MotionVector (#12) * Support WRITE_MSAA_DEPTH Unlit template * Fix MSAA for lit output * *Update changelog * Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH TODO : Fix Sphere output as well * Fix typo in ParticlePoint * Factorize common fragment Lit & unlit for depth alike passes. * Fix particle hexadreon wrong depth with alpha clip * Revert "Fix particle hexadreon wrong depth with alpha clip" This reverts commit b16bd570440087984c2c8c48279bebb088f748e8. * Allow an object slot to have null as its value (#25) * Allow an object slot to have null as its value * changelog * Vfx/fix/prevent capacity change locked (#24) * Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode * changelog * *Update all vfx (had to do it manually...) * Restore missing enty in hdrp changelog (bad resolve conflict from me) * Fix 1233044 - capacity cannot be zero (#21) * Prevent capacity from being 0 * Fix strip capacity as well * Vfx/fix/param order (#22) * Fix for dragged parameters order when there are categories * changelog Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix minor issue with VFXPreviousPositionBinder.cs (#23) Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/fix/sgoperator create context drag (#28) * Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot. * changelog * Vfx/fix/context no blocks (#27) * Don't show block windows when context cant have blocks (output mesh ) * changelog * PropertyBinder : Minor Fixes (#29) * Fix for binder when null asset & fix for binder while resetting * Call ClearPropertyBinders while resetting * Add Update Modes & Time Access (revival) (#4) * Squashed commit of the following: commit d77638ba4188bfb03c81130b82cacb2a719f03be Merge: 49eaeadff7 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 09:46:59 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 14:53:09 2020 +0100 Update UX for new time access (#260) https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280 See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z commit 78d5d9938d9896d517efa89662764afd44ef12fc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 16:03:26 2020 +0100 Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060 commit bc7e715b0e41b55126fdf171b7459b680e3e3824 Merge: 9a82a52bfe ec959d5de3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 14:52:03 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88 Merge: f56986d415 66df0debfc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Mar 13 09:17:53 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit f56986d4157f140ca84b039d97c8b7064a18214e Merge: 047820690f 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:25:07 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 047820690fa496bd43d3a60df16dd0932502c7cb Merge: d6d17dfbbc e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:56:39 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:59:15 2020 +0100 Squashed commit of the following: commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 13:37:05 2020 +0100 Use implicit block for old position backup commit e786cf3ade7d7515da4569dde9455881af02f282 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Sun Jan 12 15:05:03 2020 +0100 WIP : Add option to skip zero delta per update context commit e864fae742120fbfebabb26b605ddedfd184b02b Merge: 4eecc0b90b fb12af4c28 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:47:57 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 16:08:07 2020 +0100 Rename ProcessEveryFrame in ExactFixedTimeStep commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 16:21:50 2020 +0100 Fix ManagerMaxDeltaTime (was GameDeltaTime) commit eaebe2649e93a5083fd62c91ac92185794b908e5 Merge: 98e7dcfcdc 276c02f29a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:42:08 2020 +0100 Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes commit 98e7dcfcdceb710c252e4d1a257815a724539e68 Merge: 248004d55a 0737eb535c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 10 13:26:54 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 248004d55a7b96c6532cd3c197e175b751d6f3fe Merge: 2bbadae355 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 9 13:12:50 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit 2bbadae355bb3c4a308b8d4e020e96127fa94818 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 10:07:46 2019 +0100 Add tooltip to VFXTime.cs commit 9dc7ea790327b44ffde94bbf783d588e74c50174 Merge: bf48ba84eb 1758e4de4b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:29:13 2019 +0100 Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes commit bf48ba84ebfd1472d041966ba4be627e3a1ef427 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 17:26:30 2019 +0100 *Update changelog.md commit b5d76d5d5d65584fde771213d9a01adc6dd9b856 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 16:10:19 2019 +0100 Add operator to enable time accesses commit 1a2fe7b8dc5072dd49d985f045f276385e08287f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 11:25:52 2019 +0100 Add built-in expression (but not listed) commit b0d0e64ee04036adf48f4481bfd22eace649bac3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:37:50 2019 +0100 Add some header commit 490a441046a227bb1cc1b98418d0559da17d3771 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:36:57 2019 +0100 Add tooltip & text content commit 621c5b2b78545800b2e94921b9314ef860992059 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 19 10:09:32 2019 +0100 *Add custom inspector to edit update flags efficiently * Fix build (VFXPropertyAttribute.Create isn't needed anymore) * Fix editor test * Read Attribute in Spawn Context (#6) * Squashed commit of the following: commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 11:14:14 2020 +0200 *Update image reference (having issue with standalone, not sure of the result) commit 275c22de35f08ada783c96c625b12475f0c42337 Merge: 85254f1ec4 a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Apr 3 09:59:48 2020 +0200 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # com.unity.visualeffectgraph/CHANGELOG.md commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 16:21:39 2020 +0100 *Update image reference due to fix with grapicTest update commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf Merge: d8db341bfb 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 11:51:43 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset commit d8db341bfbd9257e1a5285d200e3eabe24857b01 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:57:38 2020 +0100 *Apply Formatting commit f80441dd6b30ef726d46ae2fe32bcf05d208b760 Merge: b3d858ffe1 01f176355a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 5 17:32:49 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7 Merge: 0bce44dc9a 5d2dfe278f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 25 13:18:58 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # .yamato/upm-ci-vfx_lwrp.yml # .yamato/upm-ci-vfxmain.yml # com.unity.visualeffectgraph/CHANGELOG.md commit 0bce44dc9a694bf36b849efb894e999fa9dc959e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 14:20:03 2020 +0100 *Fix build commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df Merge: 2130ea0ef2 e6fd39c7a2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 24 09:47:09 2020 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 2130ea0ef2186ecdc5692878940d5d6635dca31b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:09:13 2020 +0100 *Update tooltips (thanks @vlad) commit f8cdb95f5d2075848e530d997551b69de43f39e0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 14:01:44 2020 +0100 Rename SpawnerState in SpawnState commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Jan 13 13:54:24 2020 +0100 Improve ReadAttribute test to cover NewLoop state commit 2c515bfde823bfbce87df8a1444e19e5c2327e32 Merge: a9efee24ff bff1b74b59 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 16:32:45 2019 +0100 Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner commit a9efee24ff84131c53dc2ba93f1985b02217e3d7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:54:25 2019 +0100 *Update comment commit 6b17879881555cd72b3af4463fd907423f92ad7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 14:53:11 2019 +0100 Throws an exception while detecting unexpected expression flag commit cbad9212075ec6776cf9d892185dd6ee64f8fab2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:43:33 2019 +0100 Reorder spawner state operator commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 16 09:35:30 2019 +0100 Fix issue "Cannot plug in attribute-derived nodes into a spawner block." commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:58:30 2019 +0100 *Update changelog commit 61bd2e5871f23002dd1add024858efdef5e09372 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 9 15:46:52 2019 +0100 Update _CCCC test & Rename Spawner State library name commit 4942912123d795023aacb0363c8e462a2da29943 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 16:58:17 2019 +0100 Fix test & clean useless code in VFXExpression.Initialize commit e6d6c593eb27c612a225340615dabe7692f76a00 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:22:31 2019 +0100 Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose commit f00f740b775f67e9378072744513f3ff920f470d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 15:16:39 2019 +0100 Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change) commit b7d8e238dd7e05bf99114a980c8584da7985dcf8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:45:56 2019 +0100 Clean test data & add reference images commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 14:17:51 2019 +0100 Move graphicTest to common files commit fa21846e7787fec9068c5a18a33dc568df3f7cc9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 11:53:18 2019 +0100 Separate cleanly per event attribute expressions commit 80e5259674a011e864e65f13c77ce06f92f33b7f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Dec 6 08:38:41 2019 +0100 New test for chaining & read attributes commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 18:47:20 2019 +0100 Add read attribute for loop settings (context evaluation) commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 15:30:56 2019 +0100 Clean expression patching commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Dec 5 11:45:06 2019 +0100 Clarify compatibility code for spawner order & random implication commit 0dcf774f623fb93eb7bc19b06407b88669472443 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 18:42:30 2019 +0100 Add tricky case in test vfx & fix compatibility code TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 16:49:42 2019 +0100 *Up local test commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Dec 4 15:22:03 2019 +0100 Detect & Compute partial evaluation commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:16:29 2019 +0100 Add spawner State Operator & SpawnCount (even if it's actually an attribute) commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 15:04:04 2019 +0100 Add spawner state accessor commit adb1d6d66172f2d187b577facaf7b2aea4677d13 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 3 11:24:20 2019 +0100 Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling commit d43ad0e1395d0e51f3583ce9627a72006356e117 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 2 16:19:05 2019 +0100 Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute commit 8a25b5fbed33569529d30379fce2acd4da7de88d Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Nov 29 16:14:32 2019 +0100 Backup test asset (temporarily) commit dcb3efaf885dbbdec317f5a42ace9ace336fded9 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Nov 28 16:37:48 2019 +0100 WIP : experimenting new concept of Read Attribute expression * Merge with vfx/staging * Update VFX * Misc small fixes (#36) * Fix strips outputs, spawnIndex and default metallic value * Increase threshold in particle strip unlit test * Test for Override resetted (#26) * *WIP* add test * Actually add a more legit "prefab" test * Prepare fix later fix of 1206890 : can't change the C++ without updating this test * Fix editor test (todo : graft this change to master to anticipate the C++ change) * Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20) * New Test : total time is sum of delta time (#7) * *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time * Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249 * [Fix] Disable reset option (#41) * Disable reset option * Add repro case 1251533 * Fix minor issue with PreviousPropertyBinder (bis) (#31) * Fix minor issue with VFXPreviousPositionBinder.cs * Fix exception in OnEnable Note : I didn't try it locally yet. * Actual fix of VFXPreviousPositionBinder.cs Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix culture issues when generating attributes defines in shaders (#40) * [PropertyBinder] Move Update to LateUpdate (#38) * Fix issue with VFXPropertyBinder : we should use late update instead of Update * *Update 23_ParameterBinder reference image * Call resyncslots on shadergraph dependent models. (#10) * Call resyncslots on shadergraph dependent models. * missing call to checkgraphbeforeimport * indentation * fix slot not updated if only the attributes change * Do the same for models having subgraphs than for models having shadergraphs. * Fix based on PR review * Update CHANGELOG.md * update vfx and settings * Renable 009_MultiCamera in URP project * Easy Wins (Small Workflow / Cosmetic fixes) (#37) * Properties now exposed by default in blackboard * Dissociated Colors for bool/int/uint * Added Degrees / Radians conversion subgraphs in samples * De-nicified attribute name (conserve case) in Set Custom Attribute title * Changed the default "No Asset" message when opening the visual effect graph window. * Subgraphs are not in hardcoded categories anymore + Updated Serialization * Added Documentation for setting Subgraph Menu Categories Co-authored-by: Julien Fryer <julienf@unity3d.com> * Vfx/docs/compatability disclaimer (#43) * Added compatability disc * Updated format. * Save a specific vfx asset and its sugraphs only (#35) * Save graph asset works * Update CHANGELOG.md * Update VisualEffectGraphWindow.md * Update VisualEffectGraphWindow.md * Fix for block copy not dirtying the scene. * Remove some unecessary compilation (not all) (#46) * New TransformVector4 and GetTextureDimensions operators (#18) * Vfx/feature/new operators 2 (#266) * Add TransformVector4 operator * Remove unused code * Fix warning * Refactor dynamic type operator * Samll fix to previous commit * Add texture dimensions operator and expressions * Add tooltips * Add changelog entry * Fix merge compilation * Modify point cache test * Prevent textures from being constant folded * Move modified test to correct folder * Output Event (#5) * Squashed commit of the following: commit 449a60793a4c5c91e1913c42632448eb07ebe5de Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 14:27:48 2020 +0200 Fix stackoverflow with subgraph (but doesn't fix the internal workflow) commit caf0df3af5f451f9576c2cc7f328b57a87479f30 Merge: bb1047c59a a9338688a6 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Apr 2 10:22:47 2020 +0200 Merge branch 'vfx/staging' into vfx/feature/output-event commit bb1047c59a084551e7df3b93d7d5ad501145ecaf Merge: 7b2890b76f 98ce4878d1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 17:17:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:54:17 2020 +0100 Add a check of outputEvent in SpawnerTest commit 945992b2feff4b8f7a24740944c77a4a92f271dc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Mar 19 16:24:56 2020 +0100 *Update OutputEventTest.cs to check Test_Output_Event commit c48fda763e807503f27f98deeda4238b6628c264 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Mar 18 10:17:21 2020 +0100 *Update image reference & Test (stop using a undebuggeable random position) commit 5a5ad49cb485907ee869445627821810589ab34a Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 22:12:58 2020 +0100 Fix newly integrated spawn test for output event commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c Merge: ef4837245e 47b17e444b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Mar 17 17:53:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset # com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs # com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs commit ef4837245e1d88846f6d686e2803094d1d6cd04d Merge: 2331c32fb4 0e325d7de5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 11 08:30:00 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda Merge: 5d225d6e19 0103971ce2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Feb 6 08:01:06 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md commit 5d225d6e192b32394faf0964ad263cc33c5280cc Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:01:51 2020 +0100 Fix editor test commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Feb 4 15:00:35 2020 +0100 Add distinct while retrieving virtual link commit 725252869ac24d962490b4550821fbba2ab119b3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Feb 3 14:38:52 2020 +0100 *WIP* Output test commit 96098fa11f4781837543fba099936b15a8c7158d Merge: 02178104a3 bb04ca28fb Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 31 14:07:02 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 02178104a301fb434d5e6821cd369884bbc01006 Merge: 1443b66691 db8325ba2b Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 18:06:20 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 1443b66691d46ed9598ccc26b0b9425d373b61e1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:37:08 2020 +0100 *Reduce unexpected changes commit aa1afcafa9c95d042db146043c60015d3f5c96f2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 28 17:31:13 2020 +0100 New UX for output event (use data instead of system name) (#229) * *WIP* Experiment for UX using eventName * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name * Remove useless naming pattern linking label & title for output Cleaner & Safer implementation for outputEvent edition * Use unique system naming * Add test for Data for VFXOutputEvent * Fix hacky OnInvalidate commit 9cd41b81cef062991907d5ce446336bde78b79d3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 15:11:39 2020 +0100 Add editor test to check return value of output event (not attribute, already cover by graphic test) commit 1a09c63a98e4650b82160e670cedfb06b630284d Merge: 35126156f2 52ce8b9636 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 22 11:02:45 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit 35126156f2b93b04543de0eb91aca79adf331b2c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Fri Jan 17 13:58:06 2020 +0100 Avoid exception if system isn't present yet commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Thu Jan 16 10:53:13 2020 +0100 *Update Test, adding a test on unused source attribute commit bfd29d8862539cef5b14392e21cbd896436339a5 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 20:20:59 2020 +0100 Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test) commit d89160df852b64a4b5ecf378c506aa0c9f1c099c Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 16:13:02 2020 +0100 Filters out orphan output event context commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 14:30:08 2020 +0100 *Update changelog commit cf54e5372e273f86dd5c2e00a6178a543f234fd3 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 15 08:40:09 2020 +0100 Add reference image for HDRP commit d710998eb133a3dbadbdec580d1ecad3752aca85 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 16:17:28 2020 +0100 Add reference images for newly added test commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 14 15:23:18 2020 +0100 *Add a material to unit test commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 17:02:27 2020 +0100 Start implementing a effective test project commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 16:56:28 2020 +0100 FIx system name synchronisation (not really ideal) commit 7782b888266a011f4f986a7bb3161f024730caa7 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 14:24:08 2020 +0100 Fix UI of output event commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Wed Jan 8 10:11:56 2020 +0100 Fix build commit 50ae031af02d4c41e651f64b40e9d265668b803f Merge: d838cd2d37 8ab634f533 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Jan 7 13:36:21 2020 +0100 Merge branch 'vfx/staging' into vfx/feature/output-event commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8 Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 14:58:00 2019 +0100 Add a wip test scene commit 459b344b3f97c794d47a8eb6942b1129d18632cd Author: Paul Demeulenaere <pauld@unity3d.com> Date: Tue Dec 24 11:40:30 2019 +0100 Fill VFXDataOutputEvent commit e54905485dd553cadcde307ca00a8d7ce8454c0f Author: Paul Demeulenaere <pauld@unity3d.com> Date: Mon Dec 23 18:21:31 2019 +0100 Add basic output event type (empty FillDesc implementation for now) * Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP* * Update 009_OutputEvent test * Move 009_OutputEvent to correct folder (TODO, this to rename it before merge) * Fix sanity test & allow multiple connection from in outputEvent (as initialize) * Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context * Fix editor test using eventName instead of tile * Revert unexpected changes * *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485 * Rename VisualEffectOutputEventArgs => VFXOutputEventArgs * Disable connection from OutputEvent to GPUEvent * *Fix build VisualEffect.OutputEventArgs => VFXOutputEventArgs Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5 * Vfx/feature/enum parameter (#8) * Restart of enum parameters * more work * more work * Still more work. * reorderable list looks good. * Adding and removing values works. * dragging item works. * Enum values show in the inspector. * fixes for rebase * Enumvalue works on subgraphs. * notify enum name change. * Added documentation for blackboard value filtering. * no value per enum * only uint can now avec enum values. * don't nicify enum values…

Probe Volumes: Force the lightmapper to free old additionalbakedata jobs in a few cases, such as when probe volumes are disabled, or when probe volumes are hidden. Previously, it looks like the lightmapper could hang onto this data until you quit. (#19) Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091 Probe Volumes: Lots of bugfixes around baking. Reflection Probes and Density Volumes: now respect scene visibility toggles in regards to their contribution to the scene. TODO: Remove debug logging that was added! Backing up WIP work. SceneObjectIDMap: Fix bug where index from gameobject dictionary would get out of sync from entries after an insertion occurred to fill a hole. This resulted in a nasty bug where reflection probes would occasionally generate the same filename as eachother, would overwrite eachothers textures, and would point to the same texture after the bake completed. Probe Volume: Comment out log spam. Planning to clean it out completely in a follow up commit Probe Volume: Remove log spam from ProbeVolumeManager Added HDRP_STRIP_LEGACY_AMBIENT_PROBE_BAKING define for enabling legacy ambient probe bake feature stripping - requires custom build with backport of https://ono.unity3d.com/unity/unity/pull-request/123092/_/lighting/SRP-opt-out-skymanager Make HDBakedReflectionSystem public for baking API Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

* [HDRP] Fix issues with GenerateMaxZ when opaque object or decal frame settings is disabled (#2518) * Bind black texture if opaque is disabled. * Fix decal issue * Same as generateMaxZ issue with decals but on RTR now. * Fix mb vel prep Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix button Bake with Reflection Probe in custom mode (#2525) * Fix bake mode of reflection probe custom * Update CHANGELOG.md * HDRP Default Frame settings under “Light Loop Debug” tab don’t have tooltip (#2528) * [CI] Updated .ymls to new revision * [HDRP] Remove input system package from template * [10.x.x] Fix issue causing materials to upgrade multiple times (#2512) * Assume missing material version to be UniversalProjectSettings.materialVersionForUpgrade * Update change log Co-authored-by: Felipe Lira <felipedrl@gmail.com> * [Universal|Bugfix] Camera inspector requests current URP asset (#2514) (#2534) * Get the current pipeline asset, rather than the one in graphics settings * Update Changelog * changed addiional usages of graphics settings vs current asset * revert the shaderpreprocessor changes # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md Co-authored-by: Felipe Lira <felipedrl@gmail.com> * [10.x.x backport] Backported DOC PR #2010. (#2497) * Backported DOC PR #2010. * Added more detailed instructions on how to configure post-processing. Added extra info on Volumes, rewrote confusing info on Volumes. * Some minor editions. * Added parallax mapping to What's New. (#2541) * Added parallax mapping to What's New. * Edited the reference to heightmap. * Added the What's new 10.2 page, added known issues. Added the link to… (#2473) * Added the What's new 10.2 page, added known issues. Added the link to What's new on the landing page. * Added VFX Graph to the Particle known issue. * Fixed exceptions related to the debug display settings when changing the default frame settings. (#2533) * Added documentation for LODs not being supported by ray tracing. (#2535) * resave eye related materials. (#2532) * Change how camera motion vector clamp works in Motion Blur (#2522) * Use proper matrix to compute camera motion vector * Add multiple modes of camera clamp * Change UX a bit * Doc * Upgrade guide + changelog * Fix the GC allocs * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [VFX] Fix orient error feedback failing in subblocks (#2544) * Fix orient in subblocks * Improve exception message * Fix suitableContext for subblocks not being serialized * Fix subgraph not being sanitized at import * [CI] Updated .ymls to new revision * Run upgrader on default mats (#2538) * [URP] backport hdr toggle sceneview (#2521) Co-authored-by: Felipe Lira <felipedrl@gmail.com> * [10.x.x][backport] Multiple yml backports (#2517) * [Yamato] Redo metafiles with utr flags (#2193) * replace all 2020.2 with 2020_2 in ymls * Revert manual underscore changes for versions * [Performance] New performance jobs (#2455) * Add build test jobs for Windows and Android * Add playmode editor job for Windows * Rename yamato jobs to reflect that the api comatibility level is using whatever the project default is * [Yamato] Fix cmd line args for graphics API (#2437) * delete "SetupProject" from URP project * Fix API and colorspace templates for job builder * update GTF to 7.6.0-preview Co-authored-by: tomzig16 <tzigmantavicius@gmail.com> * backport 2540 * add rest of python changes from clean master copy Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> * [CI] [2020.2] Updated latest editors metafile * Disable subblocks space conversion (#2567) * space fixes in subblocks (no more conversion happens) * Nicify subgraph names * update changelog * Fixed custom pass null reference exception in draw renderers custom pass (#2559) * Fixed fullscreen pass help box height (#2560) * 10.x.x/universal/backport 2513 (#2536) * Removing some gamma space only code brings bloom closer aligned between linear and gamma colourspaces * Added changelog # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md * Remove material pass evaluation for probe volumes + fix probe volume debug views when rendergraph (#2545) * Set HDRP tests timeout to 500s (#2561) * Fixed picking for materials with depth offset (#2573) * [HDRP] Fix issue with previous frame exposure texture being not null, but containing garbage (#2574) * Consolidated ray tracing documentation to make blue book links point to reference documentaiton (#2575) * Refactored ray traced reflections doc * Refactored ambient occlusion doc * Simplified the ray-traced shadows documentation * Consolidated GI doc * Fixed some references to the wrong rt effect * Minor fixes * Added ssgi/rtgi disclaimer * Update Ray-Traced-Contact-Shadows.md * Update Ray-Traced-Contact-Shadows.md Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * Remove material pass evaluation for probe volumes + fix probe volume deb… * [CI] [2020.2] Updated latest editors metafile * [HDRP] Fix crash on Mac and Vulkan with Volumetric with overflow (#2580) * fix * test * Update VolumeVoxelization.compute * add comment * Bugfix for LitProperties compilation error in hybrid: Shader error in 'HDRP/Lit': undeclared identifier 'unity_DOTSInstancing_F4_Metadata__MetallicRemapMin' (#2576) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> * [HDRP] Fix issue when changing FoV with the physical camera fold-out closed (#2570) * Fix issue when changing FoV with the physical camera fold-out closed * Remove redundant ( ) * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Physical DoF: fix tiling artifacts, switch to blue noise sampling, add anamorphism support (#2578) * switch to blue noise sampling, fix lod selection * shader cleanup * Fix tiling artifact from very high search radius * Reduce light leaking with depth test * Enable the non-uniform weights again * Add support for anamorphism * Add define for stratification * Clean-up unused shader code * Shader clean-up 2 * Reduce max allowed radius range * Remove unused code * Update changelog * Update comment * update gtf for com.unity.testing.. to 7.6.0-preview (#2586) * backport of material alpha cutout issue (#2531) Co-authored-by: Felipe Lira <felipedrl@gmail.com> * Fix PS4 build (#2594) * Use the raytrace sampling include instead of the path tracing one * Avoid using sample keyword as variable name * Bump version to 10.3 * Hdrp/fix uitoolkit stylesheet loading (#2472) * bump min version to 2020.2.b12 * Add validation exception for Documentation version - change to 10.3.0 package * New reference image for test with cpu gradient sampling (#2638) * [CI] [2020.2] Updated latest editors metafile * [Backport] [Fix] case 1290628 : Memory leak when selecting/deselecting forward renderer asset (#2645) * Destroy Editors when deselecting forward renderer asset or resizing list to avoid leaking memory * Update changelog Co-authored-by: hedvig <hedvig.axelsson@unity3d.com> * 10.x.x/backport/yamato/misc fixes (#2656) * backport 035e8fc (#2571) * backport c378748 (#2572) * [Performance][URP] Specify Boat Attack revision when cloning (#2590) * backport 8841bc3 (#2604) * backport 8e87ec2 (#2639) * [Performance][URP] bug fixes (#2625) * Update bokken image for Linux tests (#2654) * [ShaderGraph] [URP] Additive blending should fade with alpha (#2360) (#2456) # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md * [Backport 10.3] [ShaderGraph] [bugfix 1283902] Pull textures into Export Package even if not sampled by shader (#2466) * Cherry-pick to 10.x.x of squash-merge of 'sg/fix/1283902' into master # Conflicts: # com.unity.shadergraph/CHANGELOG.md * Cherry-pick fix for URP test breakage : 24cf730 - Fix to address warning 0649 for projects that enable it # Conflicts: # com.unity.shadergraph/CHANGELOG.md * Post-processing docs move (#2619) * Moved post-processing toc entries and added an effect list document * Update post-processing-effect-list.md * Added link to lighting window (#2624) * Added arnold standard surface and 3ds physical material shader (#2626) * Added standard surface page and images * Added exposed property snippets * Added snippet links to standard shader doc * Added physical shader and supporting property snippets * Added toc entries * Fixed ordering and first set of missing entries * Updated transparency snippet * Added missing shader properties Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * Updated steps for enabling recursive rendering (#2661) Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * Fix XR single-pass rendering with builtin shaders (TMP) #2605 * Fixed links and tooltips (#2658) * Updated tooltips * Added md links to toc to stop false positives in validation * Fixed some malformed links * Fixed malformed links in AOV, Alpha output, HDRP Asset, and Light docs * Added qualifications to fade distance tooltips * Removed duplicate md extensions * Fixed batch of malformed and ill-defined links * Fixed more links * Fixed more links * Fixed render graph links Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * HD template update (#2640) * removed all spaces from asset names, added reflection probe proxy volumes, tuned some screenshot camera positoins * adapted some reflection proxies * updated probe proxies * reenabled dynamic rescale for punctual lights, tuned scalability volume quality settings for low/med/high, added dedicated proxy volumes for all reflection probes, updated some cameras for the marketing shots * full rebake, updated unity sphere prefab to play nice with timeline * updated cutscenes * disable timelines, enable render graph, medium settings * updated camera 6 for screenshot * minor tuning of volumetric scalability settings, slight reorientation of a lamp to avoid artifacts in the reflection * fixed the bound of a reflection probe to avoid RT-related issues Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> * Fixed some labels clipping in the Render Graph Viewer (#2628) * Fixed label of the last pass being clipped on the right. * Resource labels are now sized according to resource type names ("Texture Resources", "Compute Buffer Resources" etc) * Update changelog * Added a margin on the left of resource label. * [10xx] Backport git hooks refactor (#2682) * Refactor git hooks (#2671) * Add pre-commit (local repo & rev) * Remove old hooks system * Add hooks setup script * Add format-code hook * Update hooks repourl and revision * Update repo rev. * Update Tools' readme * Single source of truth for documentation * Update hooks to 8dd46b5 * Fix readme * Default stages hooks * Add github cds permission check during install * Update to latest gfx-automation-tools revision * Remove reformat hook (not required on 10xx) * [Backport][10.x] sg/fix/1286430 (#2587) * Avoid the system 'AppendLine' during generation and serialization The system call uses the local environment newline which can cause problems when sharing shadergraph files between Windows and other systems. This makes the newline explicitly "\n". * Update changelog to reflect the line ending fix * Fix line ending comparison issue (#2660) This test is written using implicit line endings (embedded in the reference result strings). This means that git will convert line endings to local platform specific endings when fetching from the remote, and the tests will never pass on Windows. Explicitly replace Windows-style line endings with Unix line endings for the comparison. * Backport of #2052 (#2717) * Merge 10.x.x/hd/staging (#2724) * Fix missing Doc for SSR on HDCamera #2714 * Added information about draw instanced limitation (#2697) * Fixed Volume duplication in hybrid workflow (#2616) * Volume Manager now always tests scene culling masks (required by hybrid renderer workflow) * Update changelog * Fixed changelog * Adding new Lit Iridescence graphic test (#2648) * Add 1223 irirdescence scene test * Proper order of Build settings scenes * Added reference image * Refactor Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [HDRP] [PathTracer] Code refactor for Path Tracing and SSR (#2481) * Compute volumetric distance fade in light data for ray tracing. * Factored code used to solve quadric equation. * Code refactor. * Re-added a shorter version of a simplication comment for SSR. * Merge Hd/bugfix - Set of bugfix for 10.3 (#2681) * Update CHANGELOG.md * Fix shadow test not suppose to be executed on 10.x * Fixed an inconsistent behavior between RT Area shadows and Shadow maps when shading a transmission fragment. #2547 * Fixed an issue where a warning about the static sky not being ready was wrongly displayed. #2727 Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> * [HDRP] Fix changelog * [HDRP] Fix Changelog - bis * - Fixed the clear coat not being handled properly for SSR and RTR (case 1291654). (#2598) - Fixed ghosting in RTGI and RTAO when denoising is enabled and the RTHandle size is not equal to the Viewport size (case 1291654). Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [ShaderGraph] [Backport 10.3] Fix texture associated state (samplerstate, TexelSize) for subgraphs, CFNs (#2577) * Add ST to texture params * Working with Universal / Texture2D (but not CFN yet) * CustomFunctionNode Texture2D working, allows full bare/non-bare selection of types, warns when using bare output types * Started on Cubemap/Array/3D * Partial fixes fore 3d/array/cubemap * Fix for texelSize node * Texture2D nodes all working * Fixes for cubemap nodes, Texture2DArray nodes, Texture3d nodes * Fix for HDRP * Fixes for GLES2 * Fixes for NormalFromTextureNode, Texture2dAssetNode * Added SamplerState handling, cleaned up code to remove macro usage * Fix for ParallaxOcclusionMappingNode * Fix for NormalFromTextureNode, cleanup, adding changelog * Fix for old Texture2DArray and Texture3D inputs to CustomFunctionNodes * Fix for ParallaxMapping and Triplanar nodes handling of SamplerState types * Cleanup, removing unused code and _ST values (for now) * Fix samplerstates on SampleRawCubemap and SampleTexture2DLOD nodes * Fix for VFX support, additional cleanup * Fix for decals * Fix for tests * Fix VFX path generation issues with textures * Improved backwards compatibility, added graphics tests, addressing feedback * Fix for GLES2 compilation * Fix for OpenGL Core * Adding GLCore support for LOAD_TEXTURE3D and LOAD_TEXTURE3D_LOD * Fix for consoles * Disallow creating v0 of custom function node (which will upgrade incorrectly when saved/loaded) * [HDRP] Added a new test that runs VT in forward MSAA mode (#2370) * Added a new test that runs VT in forward MSAA mode This was broken and apparently was recently fixed but the tests never caught this. * Wrap VT downsample compute shader in profiler scope This avoids the compute shader showing up alone in the frame's root. On request from QA. * Add testcases for VT with motion vectors disabled. We're interested in testing this in particular because this changes the MRT bindings. * Add new scenes to the build settings * Add DX11 Ref images * Add Vulkan & DX12 ref images * Refactor VTBufferManager.cs * update linux/Vulkan screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [HDRP] [PathTracing] Rigid animations now trigger PT dirtiness. * Add new eye scene in material samples (#2704) * New eye scene * Reduced texture and scene footprint * Reducing iris texture size to 512 * Added probe, material correction and diffusion profile Diffusion profile is now assigned and not hardcoded in the graph * Setup probe as OnEnable * Checked iris normal to true in the SG * Import iris normal as normal map. * [HDRP] Fix alpha output when atmospheric scattering is used (#2736) * Fix alpha output when atmospheric scattering is enabled. * Update comment * Update docs * Use the blending mode of the alpha channel to preserve alpha, instead of colomask * Update OpaqueAtmosphericScattering.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Iris normal disabled on eyes graphic tests (#2737) * Fix iris normal on eyes graphic tests * update DXR reference image * Revert "update DXR reference image" This reverts commit 24902138397fc70e8e389130ee0e1a3cdb4b39fc. * update reference image for DXR test * Update HDRP reference image * Update 1101 screenshot that used an asset that has been modified * Updated steps on how to enable the debug window in development builds on mac (#2738) * Updated steps on how to enable the debug window in development builds on mac * Updated mac specific navigation data * Update Render-Pipeline-Debug-Window.md * Tentative workaround for infinite loop on Mac (#2756) * Tentative workaround for infinite loop on Mac * Making sure we are exiting forloops on Metal in Volumetrics * Update VolumeVoxelization.compute * Update VolumetricLighting.compute Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update Upgrading-To-HDRP.md (#2761) * Update documentation for new eye material sample addition (#2770) * mention eye scene in material sample documentation * Update HDRP-Sample-Content.md Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Fix GetSamplePosition for Metal in Build Light list #2730 * [HDRP] Merge hd/bugfix #2787 * Fix Quality Settings Behavior for Raytraced Modes (RTR, RTGI) #2791 * Added the possibility to disable distance based roughness for reflection probes. #2641 * HDRP template - use cinemachine 2.6.3 * [HDRP] Update manifest of hd template to cinemachine 2.6.3 * [HDRP] Update test scene Distance based Roughness * [Yamato][10.x.x] Set editor pinning update to run before nightly (#2800) * Run nightly at 1am, editor pinning update at 23pm * [HDRP] Update changelog with 10.2.1 * [10.3] [HDRP] [bugfix 1292501] - Ensure all passes request the DiffusionProfile for SRP batcher compatibility (#2789) * Fix for 1292501 * Adding changelog * [ShaderGraph] [10.3] custom function node name reflects custom function (#2664) * custom function node name reflects custom function * Updating to append (Custom Function) to the node name * Updating doc images * Adding changelog * Add better generated message and regenerate hearder (#2831) * [Yamato][10.x.x] Disable editor pinning, add green revisions (#2842) * [Yamato] Disable editor pinning ABV dependency (#2778) * make editor pinning abv dependency toggleable per editor * drop trunk abv dependency for editor pinning * Fix update revisions script timestamp updates and empty commits * [Yamato] Store green revisions per jobs (#2807) * add job to store green revisions * Add 7am trigger to green revision job * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * Tentative fix freeze mac (#2858) * Merging improvement Hdrp template 2020.2 #2847 * update preview and documentation (#2859) * [CI] [2020.2] Updated green project revisions * [10.x.x] Misc. SDET backports (#2844) * Cherry pick 713b6f1 * Cherry pick 3a976b6 * Cherry pick ed6a8d7 * [Yamato] Allow multiple UTR calls per job (#2703) * change repeated utr calls * change repeated utr * update docs for repeated utr runs # Conflicts: # .yamato/config/__shared.metafile # .yamato/config/universal_perf_boatattack.metafile # .yamato/ruamel/jobs/projects/commands/android.py # .yamato/ruamel/jobs/projects/commands/iphone.py # .yamato/ruamel/jobs/shared/utr_utils.py # .yamato/urp_performance_boatattack-android-opengles3.yml # .yamato/urp_performance_boatattack-android-vulkan.yml # .yamato/urp_performance_boatattack-iphone-metal.yml Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com> * Bump Graphics Test Framework version (#2862) * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * Update all hdrp and VFX screenshots after fix shadow cascade PR ladned. (#2871) * d3d11 / d3d12 HDRP * linux / win / vulkan HDRP * hdrp DXR * VFX HDRP / URP * [HDRP] Fix changelog * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [Performance] Fix players path (#2884) * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [10.x.x] Introduce concept of falling back textures to black in rendergraph + ReadWrite tag (#2866) * Fallback + readwrite # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/ScreenSpaceLighting/SSGIDenoiser.cs # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadowManagerDirectional.RenderGraph.cs # com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadowManagerPunctual.RenderGraph.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDDiffuseShadowDenoiser.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDReflectionDenoiser.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDSimpleDenoiser.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDTemporalFilter.RenderGraph.cs * Move validity to resource instead of handle * Revert spacing change * Review comments # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs * Remove unnecessarry macro (#2835) * [HDRP] Fix Linux Vulkan reference screenshots * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [10.3] [ShaderGraph] Preview Mode Control (#2814) * Preview Mode is now overrideable on each node * Subgraph Assets can control their default PreviewMode, also changing "default" to "inherit" * Fixing custom function node drawer so users can change preview and precision modes on it * Adding changelog * Fix graph preview mode undo/redo, make interface internal * Fix for "API" breakage (these should not be public, change in 11.x) * [ShaderGraph] [10.3] [bugfix 1268134] Fix graph inspector property row scaling (#2827) * Fix for inspector scaling * Adding changelog * Fix for USS parsing (apparently it doesn't like strings sometimes, 0 is equivalent in behavior) * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * Reactivate hdrp osx playmode in the HDRP_ABV job (#2910) * Reactivate hdrp osx playmode in the HDRP_ABV job * Backport #2865 (change python3 path) * [HDRP] Update Metal screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Revert "[HDRP] Update Metal screenshots" This reverts commit 168c17737a8eb402af71415e474b21e09564da51. * [CI] [2020.2] Updated latest editors metafile * backporting (#2896) Co-authored-by: Esmeralda Salamone <esmeralda.salamone@unity3d.com> * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [10.x.x] backport of #2147 renderer list select (#2774) * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [10.3][Shader Graph] Fix Custom Function Node Upgrade Errors (#2981) * add null guards for missing parent nodes * Update CHANGELOG.md * [CI] [2020.2] Updated latest editors metafile * Backport of branch 'sg/fix/1299830' (0b81a72) (#2969) # Conflicts: # com.unity.shadergraph/CHANGELOG.md * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [SRP] Uniformise all ShaderGraph/SubShaderGraph and FBX extension to be lower case (#2986) (#3076) * change extension to lower case * change extension to lower case * [HDRP] Backport set of HDRP for 10.3 (#3080) * [HDRP] [Path Tracing] Added proper computation of geometric normal #2692 * Added a slider to control the fallback value of the directional shadow when the cascade have no coverage. #2722 * Now reflection probes cannot have SSAO, SSGI, SSR, ray tracing effects or volumetric reprojection. #2755 * [HDRP][Path Tracing] Fixed issues with path-traced volumetrics (light anim dirtiness, truncated volume shafts) #2771 * Avoid issues causing faulty transitions in shadows (resulting in no shadows with unconventional aspect ratio) #2776 * [11.x] [HDRP] [bugfix 1292501] - Ensure all passes request the DiffusionProfile for SRP batcher compatibility #2790 * Rename Text mesh pro folder in samples (#2797) * Rename the sunrise icon to fix typo, causing issue with 2x resolution loading. (#2809) * Fix code compilation due to missing reflectionPlanar * Merge Hd/bugfix #2828 * Add Light Unit Slider for Auto Exposure Limits #2811 * Updates fog documentation and tooltips (#2834) * Updated fog documentation * Updated tooltips * Update Fog.cs * Update Fog.cs * [HDRP][Path Tracing] Improved volumetric scattering sampling #2840 * fully specify TextureXR.maxViews in the doc (#2850) * [HDRP] Fix RenderGraph issue with Forward mode, debug mode and VT. #2872 * Updated cheat sheet into wording (#2879) * Merge Hd/bugfix #2903 * Merge Hd/bugfix #2928 * Fix shader compilation with RenderCustomPass * fbx fixses, added concrete edge decal, added material to fix sort order issue of drain asset. (#2946) Co-authored-by: ecottell <elliott-cottell@hotmial.com> * Raytracing getting started docs bugfix (#2957) * Fixed formatting and re-added missing image * Updated steps for applying graphics API changes * HDRP getting started doc update (#2963) * Updated getting started page with info about the new template * Fixed incorrect step numbering generated by Typora * Update Getting-started-with-HDRP.md * Fixed an issue with material using distortion from ShaderGraph init after Material creation (case 1294026) #2982 * HDRP docs bugfixes #2993 * Improved reflector property tooltip (#2994) * Fixed light reflector typo * Updated tooltip text to be more specific. Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> * [HDRP][Template] Normals fix (#3006) * [CI] Updated pinned editor versions Updating pinned editor revisions * fixed normals, rebaked lighting, added Receive SSR/SSGI for "Wood Counter_Mat * rebaked (removed plant pots from GI), enabled Receive SSR/SSGI on more materials * enable ssr/ssgi on brass material Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: ecottell <elliott.cottell@unity3d.com> Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> * Added area light support disclaimer snippet to relevant shaders and light doc (#3015) Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Chris Tchou <ctchou@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: ecottell <elliott-cottell@hotmial.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: ecottell <elliott.cottell@unity3d.com> Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * Fixed division by 0 on Nintendo Switch. (#2991) * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * updated decals position on/near the platform, slightly tuned exposure in room3, activate distance based roughness for all probes (#3134) Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> * [ShaderGraph] [10.3] [bugfix 1293632] Shader graph blackboard property scrolling behavior fix (#3085) * Cherry picked commits from source branch and fixed SubWindowTests # Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/DecalSortingInputsUIBlock.cs * Fixed bug with renaming on BBFieldView not working and other small fixes # Conflicts: # com.unity.shadergraph/Editor/Drawing/Blackboard/BlackboardFieldView.cs # com.unity.shadergraph/Editor/Drawing/Views/MaterialGraphView.cs * Included fixes pointed out by Landon on original PR for scroll boundary behavior and external unity windows * Fixed callback to work with 2020.2 * [ShaderGraph] [10.3] [bugfix 1281831] Fix 'Reset Reference' on a Blackboard property throwing a NullReferenceException (#2907) * Cherry-picked and squashed to 1 commit for backport * Added ifdef guards for editor versioning * Added last fix, needs to be migrated to master too Co-authored-by: Sai Narayan <sainarayan@unity3d.com> * [CI] [2020.2] Updated latest editors metafile * [ShaderGraph] [10.3] [bugfix 1291760] Shader graph inspector window behavior fixes (#3082) * Cherry-picked changes from original branch to backport branch for 10.x Also fixed scrollable window behaviors in GraphSubWindow for inspector and added auto-switch to Node Settings tab when a property/node/other selectable item in the graph is clicked * Fixed compilation errors for 2020.2 * Merging in fixes to mirror master and reduce conflicts, fixing compile errors * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * Fix Clearcoat on Stacklit breaks when URP is imported into the project #2970 * Create 1713_MeshDecalViewBias.png * [10.x.x][VFX] 10.3 backports (#3143) * Fix Event connected directly to Output Event (revival) #154 * Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x) * [HDRP] Fix debug view material (albedo/normal/...) * Force ui update when shader might be reimported in StaticMeshOutput (#158) * Don't create VFXGraph during import callbacks (#148) * do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation * Select node on create (#166) * Select node on create * Fix for right click in block and add doesn't deselect clicked block * fix for subgraph not being selected on drag and drop * Select converted node/block after convert subgraph * Fix for selection undo separate in some cases. Fixed flow anchor drag context selection. * Fix for undo of add subgraph operator * Dont flag dirty in vfxgraph is the model modified is a copy (#165) * Added excludeFromTAA setting to VFX outputs * Fix Custom Spawn serialization (#132) * Fix case 1294180 : Error feedback throwing an error while changing capacity (#174) * Fix Preset (with exclusion) (#177) * Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog * Fix 1276602 incorrect uchar pcache import (#129) * Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Update gradient test (#151) * Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix incorrect compilation condition for linux build (#184) * Fix GPUEvent & SubGraph (#178) * Fix SelectionHasCompleteSystems Detect correctly if there are dependencies due to GPUEvent (or stripAttribute) * Add allDependenciesIncludingNotCompilable in VFXData This helper is usefull for UI + use it in SelectionHasCompleteSystems * Add note without change the beahvior * Remove debug ToArray() * Sample Point Cache operator (#92) * Fix Case 1223747 - NaN caused by normal bending (#181) * [Subgraph] Prevent Pasting Context invalid subgraph (#191) * Fix Mouse Event Binder in player (#175) * Fix missing call to CreateVFXEventAttribute OnValidate is only called in editor, in runtime, we should init cache data with OnEnable * *Update changelog.md * Vfx/docs/bugfixes (#188) * Resolved 1272101 * Resolved 1264943 * Removed uncertainty around 'should' * Resolved 1298031 * Added snippets file * Resolved 1292127 * Fixed typos * Resolved 1295296 Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Update HDRP project assets * Change VisualEffect inspector "Edit" button to "New" when no asset is set * Spawn State documentation (#195) * Added Spawn State doc * Fixed formatting Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Added what's new page and moved blocks out one level in the table of … * backout update gradien test * Update ref images + deactivate test 26 * update URP assets * DEactivate test 32 + clean ribbon template vfx Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com> Co-authored-by: Thomas Iché <thomasi@unity3d.com> Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix XR depth copy and MSAA #3075 * Fix GC allocations from XR occlusion mesh when using multipass #3077 * [10.x.x Backport] backport several PRs for HDRP (#3142) * [HDRP] Use same filtering test case than on master for HDRP Test * Vfx/docs/rename files (#2801) * Removed illegal characters from doc filenames * Removed illegal characters from gifs * [HDRP Backport] Fixed some render texture leaks. #3050 * Added reviewed render graph and rthandle docs (#3008) * Updated rthandle system landing page * Update rthandle-system-fundamentals.md * Update rthandle-system-using.md * Update render-graph-system.md * Update render-graph-benefits.md * Update render-graph-fundamentals.md * Update render-graph-writing-a-render-pipeline.md * Fixed incorrect link * Fixed formatting issues * Noted FPS drop when switching between PBS volumes. (#3135) Added a note to the "Using Physically Based Sky" section to explain the frame rate drop that happens when Unity initalizes a PBS volume. * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * Fixed a case where overlay camera with output texture caused base camera not to render to screen (#2742) * [10.x.x] Fixed an issue where Universal Render Pipeline with disabled antiAlia… (#2744) * Fixed an issue where Universal Render Pipeline with disabled antiAliasing was overwriting QualitySettings.asset on frequent cases * Update CHANGELOG.md Co-authored-by: Felipe Lira <felipedrl@gmail.com> * [HDRP backport] Merge Hd/bugfix (#3161) (#3165) * [HDRP] Merge Hd/bugfix (#3161) * fix compilation issue * update 4060 vulkan screenshots * [HDRP][Compositor] Fix issues with compositor's undo #3100 * Remove leftover setting. (#3171) * Adds support for the PlayStation 5 platform #3151 (#3177) * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * sg-docsfix-doc2587-backport10.x (#3004) * Link to Master Preview/Main Preview was broken in TOC The link to Master Preview/Main Preview has been broken since 9.0. I updated the name of the relevant page in the TOC. * Backport of change a55ae13 * Backport of f951eaa * Backport of 0859dbb * Backport of 2483c1b * Backport of 3ccf229 * Lines 74 and 77 mispelling Shadergraph was spelled Shadergaph in two places Co-authored-by: Esmeralda Salamone <esmelusina@gmail.com> * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * What's new in 10.3 (#3212) * Updated the What's new page for URP 10.3. * Fixed a typo. * [VFX/HDRP] Fix Debug View Material (#3149) * HDRP - Fix Debug View Material (#182) * Fix fallback (?) depth state in debug view material Not sure about this : should double check with HDRP team * *Update changelog * *Updare reference image It corresponds to the result in 7.x.x & 8.x.x # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Synchronize timeout settings from master See : https://github.com/Unity-Technologies/Graphics/blob/master/com.unity.testing.visualeffectgraph/Tests/Runtime/VFXGraphicsTests.cs#L38 (f * Fix changelog.md Keep new entry last * [HDRP][URP] Added warning message in Projector component inspector UI that the component is not supported #3169 * Dcc/3dsmax2021 physical material #3163 * [HDRP] Backport several hdrp PR (#3234) * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * Sg-doc-2568-10x-10.3-backport (#3246) Update sampler node docs * Sg-doc-2695-10x-10.3-backport (#3247) Update Swizzle Node docs * [CI] [2020.2] Updated green project revisions * [SG] Fix 1307962 - Sample Raw Cubemap #3233 * [HDRP] Update eye sample scene (#3227) * Update eye sample scene Fix warning in play mode and add text for size * changelog * Update instructions * Put diffusion profiles in pural (because there's two) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Change the tooltip for color shadows and semi-transparent shadows (case 1307704). #3237 * [10.x.x][VFX] Remove some shader warnings (#3248) * Fix Event connected directly to Output Event (revival) #154 * Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x) * [HDRP] Fix debug view material (albedo/normal/...) * Force ui update when shader might be reimported in StaticMeshOutput (#158) * Don't create VFXGraph during import callbacks (#148) * do not Create VFXGraph in import callbacks * error when graph missing. Better test code for asset creation * Select node on create (#166) * Select node on create * Fix for right click in block and add doesn't deselect clicked block * fix for subgraph not being selected on drag and drop * Select converted node/block after convert subgraph * Fix for selection undo separate in some cases. Fixed flow anchor drag context selection. * Fix for undo of add subgraph operator * Dont flag dirty in vfxgraph is the model modified is a copy (#165) * Added excludeFromTAA setting to VFX outputs * Fix Custom Spawn serialization (#132) * Fix case 1294180 : Error feedback throwing an error while changing capacity (#174) * Fix Preset (with exclusion) (#177) * Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog * Fix 1276602 incorrect uchar pcache import (#129) * Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> * Update gradient test (#151) * Update gradient test * Update CHANGELOG.md Co-authored-by: Julien Fryer <julienf@unity3d.com> * Fix incorrect compilation condition for linux build (#184) * Fix GPUEvent & SubGraph (#178) * Fix SelectionHasCompleteSystems Detect correctly if there are dependencies due to GPUEvent (or stripAttribute) * Add allDependenciesIncludingNotCompilable in VFXData This helper is usefull for UI + use it in SelectionHasCompleteSystems * Add note without change the beahvior * Remove debug ToArray() * Sample Point Cache operator (#92) * Fix Case 1223747 - NaN caused by normal bending (#181) * [Subgraph] Prevent Pasting Context invalid subgraph (#191) * Fix Mouse Event Binder in player (#175) * Fix missing call to CreateVFXEventAttribute OnValidate is only called in editor, in runtime, we should init cache data with OnEnable * *Update changelog.md * Vfx/docs/bugfixes (#188) * Resolved 1272101 * Resolved 1264943 * Removed uncertainty around 'should' * Resolved 1298031 * Added snippets file * Resolved 1292127 * Fixed typos * Resolved 1295296 Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Update HDRP project assets * Change VisualEffect inspector "Edit" button to "New" when no asset is set * Spawn State documentation (#195) * Added Spawn State doc * Fixed formatting Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Added what's new page and moved blocks out one level in the table of … * backout update gradien test * Update ref images + deactivate test 26 * update URP assets * DEactivate test 32 + clean ribbon template vfx * Fix 1290493 - Spaceship specific warnings (#176) * Fix regression from #176 Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com> Co-authored-by: Thomas Iché <thomasi@unity3d.com> Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix metal warning + fix reference screenshots + disable unstable metal test #3251 * Removed the upper clamp values for recursive rendering and light cluster size (case 1294620) #2753 * Removed the upper clamp values for recursive rendering and light cluster size (case 1294620) #2753 - bis * [CI] [2020.2] Updated green project revisions * [CI] [2020.2] Updated green project revisions * [HDRP] Fix reference screenshots for Metal * [CI] [2020.2] Updated latest editors metafile * [CI] [2020.2] Updated green project revisions * [10.x.x] Backport of small fixes for 10.3 (#3225) * Backport of #3095 * Added fix for enquing render passes at runtime # Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md * Backport of #2856 Co-authored-by: Elvar Örn Unnþórsson <ellioman@ellioman.com> Co-authored-by: Nicolaj Zøllner <nicolaj.zollner@unity3d.com> * [10.x.x backport] PR#3009 DOC-2492: How to use the Render Objects Renderer Feature (#3217) * [10.x.x backport] PR#3009 DOC-2492: How to use the Render Objects Renderer Feature * Backported latest corrections. * Correction from Jonas. * Ran the formatting tool. * updated filters (#3242) * [HDRP] update some docs based on latest changelog (#3253) * Update some docs * Proof read upgrading to 2020.2 * Proof read whats new doc * Fixed typo Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * [10.x] misc. SDET backports for week 01/01 - 07/01 (#3011) * Cherry-pick e4b0ab135 - Enforce true isolation testing for upm ci * Cherry-pick 5d26a14 - Update SDET tooling * Apply master changes on the PR template * Bump gfx-testframework to 7.8.0-preview * Revert "Cherry-pick e4b0ab135 - Enforce true isolation testing for upm ci" This reverts commit e6a37ea07760e18f1a84717434501d9e5b7a0a79. * Hooks fixes and improvements from feedback (#2990) * Update python requirement to 3.6 * Force LF on all files * Update Tools readme * Update git hooks revision * Backport 23c2fde * Revert "Bump gfx-testframework to 7.8.0-preview" This reverts commit 4c015ad56953519ba5dd76ce3e2db8a35a405336. * [CI] [2020.2] Updated green project revisions * [HDRP] Delete undesired cloudlayer meta file * bump to 10.3.1 (#3261) * Compute Skinning is applied in VertMesh through defines - Add separate shader for skinning - Set DOTS_SKINNING define for all passes when hybrid v2 is enabled - Add new builtin property that determines if skinning should be applied Add front buffer index to access deformed vertices of current/previous frame. Actually get the the vertex position of the current frame when rendering the object itself. d3d debug pragma for HDTarget Remove skin setting component Apply skinning in motion vec pass, rename function Add motion vectors to unity instancing properties Remove compute deformation node Enable vertexID when DOTS_INSTANCING_ON is defined Remove manual adding of vertex id and defines in HD shader passes Remove skinning include and define Remove compute mesh index property when dots instancing is not defined Shader cleanup for dots deformations Rename shader file for dots skinning functions Remove changes from HDShaderPasses Remove formatting issues Remove include define Remove all changes from HDShaderPasses Remove debug pragma Update some comments Also skin vertices even if motion vectors are not skinned Remove duplicated define Add compute mesh index to URP shader variables. Add function to fetch vertices from compute buffer in ShaderVariablesFunctions Rename some functions, move fetching to different file Rename deformation function for HDRP Keep vertex ID as optional when hybrid v2 is not used Remove formatting from HDTarget Updated changelogs to be more descriptive. Rename material property Add dots skinning function to URP passes PBR-Forward/GBuffer, Lit-Forward/GBuffer, Depth/DepthNormal, ShadowCaster, Unlit, PostProcessing, ScreenSpaceShadows, SimpleLit-Forward/GBiffer, PreviewPass Remove modulus from deform vertex function Remove modulus, change to uints Remove documentation for Compute Deformation Node * Turn on Probevolumes for crazy hunter branch with SH2 encoding mode * Add missing generated shader includes for ProbeVolumes * Fix FreeCamera speed boost controls Two issues: 1. Holding Shift key during mouse-look with right mouse button would only boost speed for a single frame because it was checking GetKeyDown. Fixed by checking GetKey. 2. The Shift key only gives a speed boost when mouse-looking with RMB, but the Fire input (LMB by default) should always work. However, there was an issue where Fire would not boost the camera if the RMB was held down. This change fixes that so Fire will always boost and Shift will still only boost during mouse-look. * Make ProbeVolumes visible to Unity.Entities.Hybrid.HybridComponents in order to support entities 0.18 * Dots deformation changes in upgrade * Mask Volumes. An ability to place volumes with 3D textures into the world, paint custom color into them and sample this data in any Shader Graph. To be used as a global volumetric splat map. (#16) (cherry picked from commit f68dc61b5c92ccea7f249e7f58aab1583799ddcb) * Backport of motion vectors for skinned meshes in DOTS feature. Source Graphics repo branch: 10.x.x/dots-deformations/motion-vectors backported to 10.3.1/dots-deformations/motion-vectors ac5b927dfbe52eec3170a6a61d4e3e3e295d1e9f * Fix bad merge in HybridDeformedVertexStreamIndex * 10.3.1/dynamic density volumes (#18) * Apply patch from partner/crazyhunter-10.x.x-dynamic-density-volumes from the main Graphics repo * Fix HLSL truncation warning in shader * Eliminate the possibility of a null atlas texture by always allocating a 1x1x1 texture at minimum * Change from one callback per volume to a single callback * Remove time parameter from PrepareDensityVolumeData * Address review comments https://github.com/bonfirestudios/unity-com.unity.render-pipelines.high-definition/pull/18 * Add UI to control density volume atlas size * Statically allocate the density volume atlas instead of growing it * Log error if density volumes exceed size of the atlas * bugfix to DotsDeformation.hlsl::FetchComputeVertexData() to tangentOS.w in tangentOS output so mirrored normals produce correct normal maps * Probe Volume Improvements Probe Volumes: Force the lightmapper to free old additionalbakedata jobs in a few cases, such as when probe volumes are disabled, or when probe volumes are hidden. Previously, it looks like the lightmapper could hang onto this data until you quit. (#19) Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091391675b23702df4bb3c2afbf291e102c6 Probe Volumes: Lots of bugfixes around baking. Reflection Probes and Density Volumes: now respect scene visibility toggles in regards to their contribution to the scene. TODO: Remove debug logging that was added! Backing up WIP work. SceneObjectIDMap: Fix bug where index from gameobject dictionary would get out of sync from entries after an insertion occurred to fill a hole. This resulted in a nasty bug where reflection probes would occasionally generate the same filename as eachother, would overwrite eachothers textures, and would point to the same texture after the bake completed. Probe Volume: Comment out log spam. Planning to clean it out completely in a follow up commit Probe Volume: Remove log spam from ProbeVolumeManager Added HDRP_STRIP_LEGACY_AMBIENT_PROBE_BAKING define for enabling legacy ambient probe bake feature stripping - requires custom build with backport of https://ono.unity3d.com/unity/unity/pull-request/123092/_/lighting/SRP-opt-out-skymanager Make HDBakedReflectionSystem public for baking API Co-authored-by: pastasfuture <nickb@bonfirestudios.com> * Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091391675b23702df4bb3c2afbf291e102c6 * p * Probe Volumes: Track whether or not bake inputs has been set, and only attempt to get bake data if the inputs was set. Otherwise the lightmapper will error out. * Mask Volume: Hotfix: Avoid attempting to upload degenerate data to the atlas by extending IsDataAssigned() check to include a Length > 0 test * Mask Volumes tools update (#22) * Fixed the issue when the scene view camera moves on selecting the painting tool. * Use normalized values for color and opacity settings. Fixed the effect of opacity and hardness. * Added the brush color inversion while Ctrl is pressed, for quick erasing. * Replaced the Recreate Asset button with Resample Asset. The data is not lost after resizing or changing voxel density now. * Fixed a Mask Volume resampling error when old resolution has 1 on any axis. * Mask Volume: Use resolution from MaskVolumeAsset instead of MaskVolumeArtistParameters for rendering. Resolution in parameters is just for creating new assets or resampling to a new resolution. * Mask Volume: Use normal bias in painting. * Mask Volume: Use input pressure as opacity. * Mask Volume: Added inner radius and normal bias brush gizmos. * Fixed the case when a Mask Volume asset is saved to a file empty. The "Resample Asset" button can process an empty asset and fill it with valid data now. (#23) Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: Peter Bay Bastian <pbbastian@users.noreply.github.com> Co-authored-by: Felipe Lira <felipedrl@gmail.com> Co-authored-by: Andre McGrail <andrem@unity3d.com> Co-authored-by: Oleksandr Kokoshyn <oleksandr.kokoshyn@unity3d.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: julienf-unity <julienf@unity3D.com> Co-authored-by: Martin Thorzen <35328557+martint-unity@users.noreply.github.com> Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Théo Penavaire <theo-pnv@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com> Co-authored-by: Nicholas Brancaccio <pastasfuture@gmail.com> Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Tristan Genevet <tristan@unity3d.com> Co-authored-by: Hedvig <52455888+HedvigAxelsson@users.noreply.github.com> Co-authored-by: hedvig <hedvig.axelsson@unity3d.com> Co-authored-by: Chris Tchou <ctchou@unity3d.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: pierre-unity <39901544+pierre-unity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Jesse Barker <jesseb@unity3d.com> Co-authored-by: Elvar Örn Unnþórsson <ellioman@ellioman.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Graphine Charles <charles@graphinesoftware.com> Co-authored-by: jenniferd-unity <71718938+jenniferd-unity@users.noreply.github.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Esmeralda Salamone <esmelusina@gmail.com> Co-authored-by: Esmeralda Salamone <esmeralda.salamone@unity3d.com> Co-authored-by: Alex Lindman <39529353+alindmanUnity@users.noreply.github.com> Co-authored-by: ecottell <elliott-cottell@hotmial.com> Co-authored-by: ecottell <elliott.cottell@unity3d.com> Co-authored-by: Kay Chang <37455951+kaychang-unity@users.noreply.github.com> Co-authored-by: Sai Narayan Natarajan <Nightmask3@gmail.com> Co-authored-by: Sai Narayan <sainarayan@unity3d.com> Co-authored-by: Paul Demeulenaere <pauld@unity3d.com> Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com> Co-authored-by: Thomas Iché <thomasi@unity3d.com> Co-authored-by: Thomas ICHÉ <peeweek@gmail.com> Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: Lukas Chodosevičius <lukasc@unity3d.com> Co-authored-by: Val Grimm <72067840+ValGrimm-U3D@users.noreply.github.com> Co-authored-by: Arttu Peltonen <77337829+arttu-peltonen@users.noreply.github.com> Co-authored-by: Thomasch-unity3d <30902625+Thomasch-unity3d@users.noreply.github.com> Co-authored-by: Nicolaj Zøllner <nicolaj.zollner@unity3d.com> Co-authored-by: Alex Kerfoot <alexk@unity3d.com> Co-authored-by: Andrew Saraev <67020478+AndrewSaraevUnity@users.noreply.github.com> Co-authored-by: Apoorva Joshi <apoorvaj@apoorvaj.io>

Probe Volumes: Force the lightmapper to free old additionalbakedata jobs in a few cases, such as when probe volumes are disabled, or when probe volumes are hidden. Previously, it looks like the lightmapper could hang onto this data until you quit. (#19) Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091 Probe Volumes: Lots of bugfixes around baking. Reflection Probes and Density Volumes: now respect scene visibility toggles in regards to their contribution to the scene. TODO: Remove debug logging that was added! Backing up WIP work. SceneObjectIDMap: Fix bug where index from gameobject dictionary would get out of sync from entries after an insertion occurred to fill a hole. This resulted in a nasty bug where reflection probes would occasionally generate the same filename as eachother, would overwrite eachothers textures, and would point to the same texture after the bake completed. Probe Volume: Comment out log spam. Planning to clean it out completely in a follow up commit Probe Volume: Remove log spam from ProbeVolumeManager Added HDRP_STRIP_LEGACY_AMBIENT_PROBE_BAKING define for enabling legacy ambient probe bake feature stripping - requires custom build with backport of https://ono.unity3d.com/unity/unity/pull-request/123092/_/lighting/SRP-opt-out-skymanager Make HDBakedReflectionSystem public for baking API Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

…posure is applied (#19) Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

Probe Volumes: Force the lightmapper to free old additionalbakedata jobs in a few cases, such as when probe volumes are disabled, or when probe volumes are hidden. Previously, it looks like the lightmapper could hang onto this data until you quit. (#19) Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091 Probe Volumes: Lots of bugfixes around baking. Reflection Probes and Density Volumes: now respect scene visibility toggles in regards to their contribution to the scene. TODO: Remove debug logging that was added! Backing up WIP work. SceneObjectIDMap: Fix bug where index from gameobject dictionary would get out of sync from entries after an insertion occurred to fill a hole. This resulted in a nasty bug where reflection probes would occasionally generate the same filename as eachother, would overwrite eachothers textures, and would point to the same texture after the bake completed. Probe Volume: Comment out log spam. Planning to clean it out completely in a follow up commit Probe Volume: Remove log spam from ProbeVolumeManager Added HDRP_STRIP_LEGACY_AMBIENT_PROBE_BAKING define for enabling legacy ambient probe bake feature stripping - requires custom build with backport of https://ono.unity3d.com/unity/unity/pull-request/123092/_/lighting/SRP-opt-out-skymanager Make HDBakedReflectionSystem public for baking API Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

…posure is applied (#19) Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

Uncomment Probe Volume related menu items Baked Lighting Workflow: Maintain lists of all Probe Volume instances and publicly expose to allow game-specific bake code to turn on and off relevant lighting data for context-specific bakes. Probe Volume: Probe Volume Improvements Probe Volumes: Force the lightmapper to free old additionalbakedata jobs in a few cases, such as when probe volumes are disabled, or when probe volumes are hidden. Previously, it looks like the lightmapper could hang onto this data until you quit. (#19) Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091 Probe Volumes: Lots of bugfixes around baking. Reflection Probes and Density Volumes: now respect scene visibility toggles in regards to their contribution to the scene. TODO: Remove debug logging that was added! Backing up WIP work. SceneObjectIDMap: Fix bug where index from gameobject dictionary would get out of sync from entries after an insertion occurred to fill a hole. This resulted in a nasty bug where reflection probes would occasionally generate the same filename as eachother, would overwrite eachothers textures, and would point to the same texture after the bake completed. Probe Volume: Comment out log spam. Planning to clean it out completely in a follow up commit Probe Volume: Remove log spam from ProbeVolumeManager Added HDRP_STRIP_LEGACY_AMBIENT_PROBE_BAKING define for enabling legacy ambient probe bake feature stripping - requires custom build with backport of https://ono.unity3d.com/unity/unity/pull-request/123092/_/lighting/SRP-opt-out-skymanager Make HDBakedReflectionSystem public for baking API Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volume: Wrap editor-only variable dataNeedsDilation in UNITY_EDITOR define blocks to avoid warnings. Probe Volumes: Track whether or not bake inputs has been set, and only attempt to get bake data if the inputs was set. Otherwise the lightmapper will error out. Probe Volume: Add View Bias support - exposed on the ProbeVolume component next to Normal Bias (#25) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volume: Probe Volume binary serialization and minor fixes * Prefer binary serialization of Probe Volume assets. * Added "Reserialize All" action to context menus of ProbeVolumeAsset to be able to convert all assets in a project to binary format. Probe Volume: Add support for sampling probe volumes from volumetrics. Probe Volume inner loop cleanup happened in the process. Added support for disabling bilateral filtering via a define, which is used in volumetrics and vfx sampling of probe volumes now. Fix bug where density volume voxelization would erroneously sample and voxelize density volumes that no longer existed due to assumption that density volumes were last in the light list (they are not anymore: probe volumes come after). Probe Volumes: Reflection Probe Normalization by Probe Volumes added. In order to enable, NormalizeReflectionProbeWithProbeVolume needs to be enabled in the Frame Settings for the Camera, and scenes need to be rebaked. Options exist on the ProbeVolumeController volume override. (#27) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Reflection Probe Normalization: Add #if UNITY_EDITOR guards around Subscribe/UnsubscribeSHBaking Probe Volume: Fix vector truncation warnings in sample SH Luminance functions Probe Volume: Fix one more vector trunction warning Enable Probe Volumes with L2 Encoding mode Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091 Probe Volume Normalization Baking Bugfix: Sanitize out sentinel values from reflection probe request positions array - large values caused the lightmapper to barf killing all direct lighting contribution. Also added tracking for whether or not the data was set, as the lightmapper is not robust to multiple set calls Probe Volume: Make ProbeVolumeinternals visible to Unity.Entities.Hybrid.HybridComponents so that they can be converted for hybrid rendering Probe volumes rotation + reflection probe normalization fixes and improvements. Also lots of cleanup to avoid debug-only + lightmapper work when in playmode. Cleaned out old deadcode + comments. Cleaned some GC cases (#1) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> ReflectionProbeLuminanceSHPreview: Fix path to shader after merge conflict resolution mistake Probe Volume: Fix bug where bakingEnabled flag was not correctly being set to false when ForceOff was triggered in the editor (not in playmode). Also add additional logging around case where lightmapper does not have data for a specific ID (so we can track down the source faster in the future) Probe Volume: Set methods for Probe Volumes exposed that allows us to use them to do deep copies of Scenes Probe Volume Reflection Probe Normalization: Use dominant specular direction for normalization instead of R. For low roughness materials, this has little to no effect (because it uses the R vector still). For high roughness materials, this bends towards normalizing against the surface normal instead of R. So this feature improves quality of high roughness specular Fix warning log that had some formatting error DOTS Probe Volume (#2) Changed the runtime registration and access of Probe Volumes to be able to feed additional data for rendering from a DOTS system. Avoid boxing when using ProbeVolumeAtlasKey in a dictionary. (#4) Probe Volume Reflection Probe Normalization: Fix error: Output Particle Lit Quad': undeclared identifier 'ComputeReflectionProbeNormalizationDirection' Fix double dark ao and ao in lightloop (#12) Fix double dark AO + material AO availability in light loop for probe volumes. Probe Volumes: Pack AO and isUninitializedGI flag into .x channel of light layers GBuffer RT to fix double dark AO and to allow emissive surfaces to receive probe volume lighting. Also perform small restructuring to a probe volume bilateral filter function to remove a shader warning

Created a proper Probe Volume probe rendering shader. All probes in a selected probe volume are rendered in a single DrawProcedural call, 2 triangle per probe (screen space quads). Allows me to get rid of a lot of nasty mesh setup logic that was previously happening. The new Draw Probes debug shader currently has two additional options: Draw Validity, and Highlight Ringing (#14) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Use GlobalObjectId.targetObjectId (#16) * Probe Volumes: Use GlobalObjectId.targetObjectId to uniquely identify Probe Volumes, and Probe Volume Asset ownership, rather than GetInstanceID() - which was not guarenteed to be persistent. This PR cleans up the related logic, allowing us to guarentee non-colliding bake ids, avoids hanging on to asset references during duplication of probe volumes, and, in the case where you have intentionally referenced a probe volume asset on a probe volume that does not own it, avoids baking that asset, which would previously stomp source data. * Probe Volumes: GlobalUniqueID: Use a custom stack-only + packed representation of the full GlobalObjectId, rather than only using GlobalObjectID.targetObjectId to avoid collisions when different scene probe volumes happen to have the same targetObjectId. This also allows full backwards asset lookup in the future if necessary, which should help debugging + build tools. Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Make all bake requests go through the AdditionalGIBakeRequestsManager. Track the generationIndex in the least significant 8 bits of the lightmapperBakeID, and talk to the lightmapper with this composite ID. This ensures that anytime we call SetAdditionalBakeProbes we generate a completely unique bake request from the perspective of the lightmapper, ensuring that we will always bake this data (because the lightmapper will hash these IDs to determine if it has any work to do). Previously, if we set an ID with new data, or if we cleared an ID then set it with new data, the lightmapper wouldnt track these data changes, and so it would skip baking these actually new bake requests. (#17) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Fix Debug Colors display mode - shader line got erroneously commented out in a PR a few months back (#18) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Fix exposure in Probe Volume debug modes (ensure no exposure is applied (#19) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Maintain user specified absolute world space positive and negative fade while resizing bounds handle. This makes Probe Volumes resize behavior match behavior of Density Volumes and Reflection Probes. (#20) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Fix PROBE_VOLUMES_SAMPLING_MODE defines in GetReflectionPRobeNormalizationFactor (#23) Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

Probe Volume: Uncomment Probe Volume related menu items Baked Lighting Workflow: Maintain lists of all Probe Volume instances and publicly expose to allow game-specific bake code to turn on and off relevant lighting data for context-specific bakes. Probe Volume: Probe Volume Improvements Probe Volumes: Force the lightmapper to free old additionalbakedata jobs in a few cases, such as when probe volumes are disabled, or when probe volumes are hidden. Previously, it looks like the lightmapper could hang onto this data until you quit. (#19) Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091 Probe Volumes: Lots of bugfixes around baking. Reflection Probes and Density Volumes: now respect scene visibility toggles in regards to their contribution to the scene. TODO: Remove debug logging that was added! Backing up WIP work. SceneObjectIDMap: Fix bug where index from gameobject dictionary would get out of sync from entries after an insertion occurred to fill a hole. This resulted in a nasty bug where reflection probes would occasionally generate the same filename as eachother, would overwrite eachothers textures, and would point to the same texture after the bake completed. Probe Volume: Comment out log spam. Planning to clean it out completely in a follow up commit Probe Volume: Remove log spam from ProbeVolumeManager Added HDRP_STRIP_LEGACY_AMBIENT_PROBE_BAKING define for enabling legacy ambient probe bake feature stripping - requires custom build with backport of https://ono.unity3d.com/unity/unity/pull-request/123092/_/lighting/SRP-opt-out-skymanager Make HDBakedReflectionSystem public for baking API Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volume: Wrap editor-only variable dataNeedsDilation in UNITY_EDITOR define blocks to avoid warnings. Probe Volumes: Track whether or not bake inputs has been set, and only attempt to get bake data if the inputs was set. Otherwise the lightmapper will error out. Probe Volume: Add View Bias support - exposed on the ProbeVolume component next to Normal Bias (#25) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volume: Probe Volume binary serialization and minor fixes * Prefer binary serialization of Probe Volume assets. * Added "Reserialize All" action to context menus of ProbeVolumeAsset to be able to convert all assets in a project to binary format. Probe Volume: Add support for sampling probe volumes from volumetrics. Probe Volume inner loop cleanup happened in the process. Added support for disabling bilateral filtering via a define, which is used in volumetrics and vfx sampling of probe volumes now. Fix bug where density volume voxelization would erroneously sample and voxelize density volumes that no longer existed due to assumption that density volumes were last in the light list (they are not anymore: probe volumes come after). Probe Volumes: Reflection Probe Normalization by Probe Volumes added. In order to enable, NormalizeReflectionProbeWithProbeVolume needs to be enabled in the Frame Settings for the Camera, and scenes need to be rebaked. Options exist on the ProbeVolumeController volume override. (#27) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Reflection Probe Normalization: Add #if UNITY_EDITOR guards around Subscribe/UnsubscribeSHBaking Probe Volume: Fix vector truncation warnings in sample SH Luminance functions Probe Volume: Fix one more vector trunction warning Enable Probe Volumes with L2 Encoding mode Probe Volumes: Lots of bugfixes and improvements to bilateral filtering modes. Octahedral Depth data now working (requires changes on the C++ side). Added support for comparing filtering the texel coordinates and then taking a single sample, vs taking 8x samples and then filtering the results. Ported over from unity graphics repo 3c3b091 Probe Volume Normalization Baking Bugfix: Sanitize out sentinel values from reflection probe request positions array - large values caused the lightmapper to barf killing all direct lighting contribution. Also added tracking for whether or not the data was set, as the lightmapper is not robust to multiple set calls Probe Volume: Make ProbeVolumeinternals visible to Unity.Entities.Hybrid.HybridComponents so that they can be converted for hybrid rendering Probe volumes rotation + reflection probe normalization fixes and improvements. Also lots of cleanup to avoid debug-only + lightmapper work when in playmode. Cleaned out old deadcode + comments. Cleaned some GC cases (#1) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> ReflectionProbeLuminanceSHPreview: Fix path to shader after merge conflict resolution mistake Probe Volume: Fix bug where bakingEnabled flag was not correctly being set to false when ForceOff was triggered in the editor (not in playmode). Also add additional logging around case where lightmapper does not have data for a specific ID (so we can track down the source faster in the future) Probe Volume: Set methods for Probe Volumes exposed that allows us to use them to do deep copies of Scenes Probe Volume Reflection Probe Normalization: Use dominant specular direction for normalization instead of R. For low roughness materials, this has little to no effect (because it uses the R vector still). For high roughness materials, this bends towards normalizing against the surface normal instead of R. So this feature improves quality of high roughness specular Fix warning log that had some formatting error DOTS Probe Volume (#2) Changed the runtime registration and access of Probe Volumes to be able to feed additional data for rendering from a DOTS system. Avoid boxing when using ProbeVolumeAtlasKey in a dictionary. (#4) Probe Volume Reflection Probe Normalization: Fix error: Output Particle Lit Quad': undeclared identifier 'ComputeReflectionProbeNormalizationDirection' Fix double dark ao and ao in lightloop (#12) Fix double dark AO + material AO availability in light loop for probe volumes. Probe Volumes: Pack AO and isUninitializedGI flag into .x channel of light layers GBuffer RT to fix double dark AO and to allow emissive surfaces to receive probe volume lighting. Also perform small restructuring to a probe volume bilateral filter function to remove a shader warning Dynamic GI: Probe Volume Dynamic GI V1 (#7) Large feature addition to Probe Volumes to support Dynamic GI at runtime & in editor via compute jobs. Huge coordination across game team, Spotlight & HDRP team to refine the algorithm and feature set. Key Features - New toggle on a light "Affects Dynamic GI" - New toggle on a probe Volume "Support Dynamic GI" - New debug draw mode on a probe volume "Draw Neighbors" to visualize the neighbor the dynamic GI light will bounce around in - All light types are supported Missing features - During albedo baking step, mask volumes are not being sampled correctly - Off screen lights are missing their shadows when being sampled by the Hit pass of the Dynamic GI compute shader - Directional light GI seems off, maybe its the offscreen shadow issues - Sky lighting is not supported at the moment in the dynamic GI - Currently does not encode emissive in the neighborhood bake data, only albedo, surface distance & normal - Currently does require a re-bake when geometry changes, the only thing it relies on getting from the lightmapper is the probe validity value Commit notes: * Added dynamic GI options onto HDLight and ProbeVolume inspectors * work in progress dynamic gi * lots more refactoring on the data model and packing for hits vs misses * Cleanup dynamic GI code into separate file * Working axis baking code with visualization * small fixes * validity scale fix * neighbor draw quad scale control * small fix * scale fix * First pass at albedo extraction code for DynamicGI * bake bug fix * Albedo baking via Shader Graph works now, and more tweaks to neighbor debug draw * bug fix * Dynamic GI neighbor cleanup to use real probe volume data for positioning * bug fix for non uniform density volumes * cleanup * Cleanup and setup of Propagation Buffers * more work in progress dynamic GI, have a test read modify write of SH data working * cleanup dynamic GI values when its disabled * more cleanup * bug fix * New improved Albedo sampling code from Francesco * cache debug shader not material, works better for some reason * Lots of shader code and setup for real-time GI propagation. Still a work in progress but most code written on GPU side * All the compute data hooked up first pass * Kinda of working * Slightly better, still not there * Fixes plus re-write of SH data in dynamic GI * First kinda working version of new RTGI, needs lots of tuning and improvements * Move VolumeComponent to seperate file so it is preserved when assets are saved * More improvements, anti alias punctual lights and add a secondary bounce to hits * Tweaks, added FCC's SH logic for testing / comps * Cleanup and addition of 3D texture for Irradiance sampling to smooth out history * Cleanup & and added back bounce boost control for hit pass * Tuning defaults * more filddleing with defaults * temp code for testing * Intended L1 * Adding Affect Dynamic GI to light explorer UI Fixing hit lighting logic to work with multiple lights * Adding de-ringing to SH Exposing class outside of HDRP for play mode testing * Move probe volume update code around so worked better with needing state set before dispatches * Integration of SG logic for Irradiance Cache, way cleaner and better results. Removed old Irradiance cache logic using L1 SH * More cleanup and refinements of SG algorithm * Bias punctual lights near surfaces to fix strobing * Cleanup * name cleanup * Support volume rotation in neighbor debug view mode * Fixed contribution normalization. Changed the direction for infinite bounces evaluation from reflection to surface normal. * changing default sharpness to 3.5 to reduce dark banding a tad * Hacked prototype of an alternative propagation algorithm. * Smoothed radiance gathering from hits. * Cleanup and temp NaN propagation workaround. * Changed History Contribution min limit to 0 to be able to test propagation without it. * Removed old algorithm, cleaned up data format and volume parameters to make new directional version the default one * Fixed Probe Volume dynamic GI data access after merging with the DOTS Probe Volume feature. Signed-off-by: Andrew Saraev <andrew.saraev@unity3d.com> * Fixed up popping issues with Dynamic GI and other probe volumes in view, plus made it so the light list is global, not camera view culled so all lights stay active in the list for GI to propagate more accurately and shadows to update even for lights behind the camera. Merged with latest * Build compile fixes * Player build fixes, real-time GI now works in player builds * HDRP settings and toggles for probe volume dynamic GI * missed files for previous checkin * small optimizations * turn on optimizations in key dynamic gi shaders for perf * Custom dynamic GI light list that also includes off screen lights * Explicitly set dataUpdated when data is uploaded to the atlas instead of setting it in GetPayload() of the volume. To simplify communication with the DOTS version. * use shadows for dynamic GI lights. This still has a bug where off screen lights get their shadow indexes reset to -1 * Better disposing of propagation buffers Cleaned up global compute buffers for SH L012 and validity buffers, and reusing those per probe volume for propagation to reduce memory usage * possible mem leak fix & piping light bounce intensity through to dynamic GI * Some PR feedback and distance checks to probe hit & propagation phases * Added basic distance checks to entire probe volume to dispatch dynamic GI jobs or not * directional lights are weird, maybe the shadows, we should avoid them * PR feedback * Refactored ProbeVolumeBuffers cleanup to keep GameObject and DOTS logic similar. * Attempt to reduce white space conflicts * Profiler marker for Dynamic GI Slight optimization in light loop * Optimized C# by not doing SetData calls on Buffers unnecessarily Co-authored-by: Andrew Saraev <andrew.saraev@unity3d.com> Bug fixes from Dynamic GI. Cleanup buffers after bakes, and only dispatch dynamic GI for scene or game cameras Dynamic GI Spherical Harmonic from Spherical Gaussian Modes (#9) * Implemented SH from SG Modes which can be toggled between in the Probe Dynamic GI volume settings. SamplePeakAndProject is the same mode we are used to: Spherical gaussians will simply be evaluated at their peak and projected to convert to spherical harmonics. SHFromSGFit: A spherical gaussian to spherical harmonic function fit is used, which is physically plausible. SHFromSGFitWithCosineWindow: A spherical gaussian with an additional cosine window to spherical harmonic function fit is used, which is physically plausible. Less directional blur than SHFromSGFit. * Cleanup pass on SG to SH supporting math. Created Zonal Harmonic data type with supporting functions to add type saftey to the transforms as we have done with the other spherical harmonic functions. Created specialized zonal harmonic rotation functions which significantly reduces the work required for rotation. It's possible the compiler was handling this already by stripping out work on zero coefficients, and by automatically using floats instead of float3s when all channels are the same - but better to not put too much pressure on the compiler. This should also make it easier in the future to create specialized rotation functions for cardinal rotations (which will introduce additional zeros). Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Dynamic GI: Fix a bunch of shader warnings in DynamicGI shaders. Bug fix so that lights can act as dynamic GI only lights Probe Volumes: Created a proper Probe Volume probe rendering shader. All probes in a selected probe volume are rendered in a single DrawProcedural call, 2 triangle per probe (screen space quads). Allows me to get rid of a lot of nasty mesh setup logic that was previously happening. The new Draw Probes debug shader currently has two additional options: Draw Validity, and Highlight Ringing (#14) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Use GlobalObjectId.targetObjectId (#16) * Probe Volumes: Use GlobalObjectId.targetObjectId to uniquely identify Probe Volumes, and Probe Volume Asset ownership, rather than GetInstanceID() - which was not guarenteed to be persistent. This PR cleans up the related logic, allowing us to guarentee non-colliding bake ids, avoids hanging on to asset references during duplication of probe volumes, and, in the case where you have intentionally referenced a probe volume asset on a probe volume that does not own it, avoids baking that asset, which would previously stomp source data. * Probe Volumes: GlobalUniqueID: Use a custom stack-only + packed representation of the full GlobalObjectId, rather than only using GlobalObjectID.targetObjectId to avoid collisions when different scene probe volumes happen to have the same targetObjectId. This also allows full backwards asset lookup in the future if necessary, which should help debugging + build tools. Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Make all bake requests go through the AdditionalGIBakeRequestsManager. Track the generationIndex in the least significant 8 bits of the lightmapperBakeID, and talk to the lightmapper with this composite ID. This ensures that anytime we call SetAdditionalBakeProbes we generate a completely unique bake request from the perspective of the lightmapper, ensuring that we will always bake this data (because the lightmapper will hash these IDs to determine if it has any work to do). Previously, if we set an ID with new data, or if we cleared an ID then set it with new data, the lightmapper wouldnt track these data changes, and so it would skip baking these actually new bake requests. (#17) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Fix Debug Colors display mode - shader line got erroneously commented out in a PR a few months back (#18) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Fix exposure in Probe Volume debug modes (ensure no exposure is applied (#19) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Maintain user specified absolute world space positive and negative fade while resizing bounds handle. This makes Probe Volumes resize behavior match behavior of Density Volumes and Reflection Probes. (#20) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Fix PROBE_VOLUMES_SAMPLING_MODE defines in GetReflectionPRobeNormalizationFactor (#23) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volume: Add RenderGraph support for Probe Volumes. Originally this was implemented in this PR: Partner/crazyhunter 10.6.0 custom.1 rendergraph 1a835fd However, the PR contained some fairly large code divergences from mainline - so it was split out into multiple new commits during this upgrade, and divergence was minimized. Mask Volumes: Mask Volumes. An ability to place volumes with 3D textures into the world, paint custom color into them and sample this data in any Shader Graph. To be used as a global volumetric splat map. (#16) (cherry picked from commit f68dc61b5c92ccea7f249e7f58aab1583799ddcb) Mask Volumes tools update (#22) * Fixed the issue when the scene view camera moves on selecting the painting tool. * Use normalized values for color and opacity settings. Fixed the effect of opacity and hardness. * Added the brush color inversion while Ctrl is pressed, for quick erasing. * Replaced the Recreate Asset button with Resample Asset. The data is not lost after resizing or changing voxel density now. * Fixed a Mask Volume resampling error when old resolution has 1 on any axis. * Mask Volume: Use resolution from MaskVolumeAsset instead of MaskVolumeArtistParameters for rendering. Resolution in parameters is just for creating new assets or resampling to a new resolution. * Mask Volume: Use normal bias in painting. * Mask Volume: Use input pressure as opacity. * Mask Volume: Added inner radius and normal bias brush gizmos. Mask Volume: Hotfix: Avoid attempting to upload degenerate data to the atlas by extending IsDataAssigned() check to include a Length > 0 test Fixed the case when a Mask Volume asset is saved to a file empty. The "Resample Asset" button can process an empty asset and fill it with valid data now. (#23) Mask Volumes binary serialization and minor fixes * Fixed the case when the painted Mask Volume asset is not saved. Updated the default brush settings based on the user feedback. * Prefer binary serialization of Mask Volume assets. * Added "Reserialize All" action to context menus of MaskVolumeAsset to be able to convert all assets in a project to binary format. Mask Volume: Fixed minor bug where emptyUAV would silently fail to bind to _MaskVolumeAtlas - using emptyVolumeUAV instead Mask Volume: Mask Volume: Make Mask Volume internals visible to Unity.Entities.Hybrid.HybridComponents Mask Volumes: Set methods for Mask Volume exposed that allows us to use them to do deep copies of Scenes DOTS Mask Volume (#6) Refactored the access to Mask Volume instanced to be able to feed a DOTS version to the system. Probe Volumes: Probe Volumes: Delete meta file for empty folder accidentially created a while back. Cleans up a warning when the project is first imported (#34) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Cleanup the state when HDRP has Probe Volumes disabled in the HDRenderPipelineAsset or FrameSettings. Previously we would hit some null reference errors because the disabled paths were not well tested. These fixes should improve the process of setting up Probe Volumes / Mask Volumes in a new project Probe Volumes: Upadte ProbeVolumeAtlasKey to additionally unique on volume position if the volume is simulating dynamic GI. If dynamic GI is enabled, two probe volumes that point to the same asset, streamed in at different locations need unique space in the atlas (because their dynamic GI component is different). If dynamic GI is disabled, two probe volumes that point to the same asset, streamed in at different locations should share space in the atlas, since their baked data is identical. Probe Volume: VolumeGlobalUniqueID and atlas allocation stats Probe Volumes: Probe Volumes: Remove Ambient Sky fallback which was used when accumulated probe volume weight was < 1. In our project we never want to fall back to the ambient sky, we want to fallback to black. (#40) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volumes: Fix bug where tiles would receive no probe volume lighting if they contained no direct light sources, and if compute based deferred was enabled. (#41) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Probe Volume: Fix Probe Volume Visibility API Probe Volume: Fixed compilation error when Probe Volumes are not encoded with SHL2. Mask Volume: Mask Volume Feature Parity: Mask Volumes use Global Unique ID system … (#32) * Mask Volume Feature Parity: Mask Volumes use Global Unique ID system just like Probe Volumes, follow the same eviction scheme as probe volumes, have the same debug rendering options as probe volumes (where relevant) and have dead code paths cleaned out. Global Distance Fade Start / End exposed on the Volume System Probe Volume Controller and new Mask Volume Controller to limit atlas subscription when zoomed way out in large scenes. Volumes are now evicted from the atlas when they are culled in the prepare probe volume / mask volume lists stage. * Add atlas allocation stats for Mask Volumes Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Mask Volumes: Cleanup the state when HDRP has Mask Volumes disabled in the HDRenderPipelineAsset or FrameSettings. Previously we would hit some null reference errors because the disabled paths were not well tested. These fixes should improve the process of setting up Probe Volumes / Mask Volumes in a new project Dynamic GI: Probe Volumes: Dynamic GI: Fix null reference when Draw Neighbors is true, but no probeVolumeAsset has been baked yet. (#30) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Fix for dynamic GI to disable gracefully at runtime Ported MaskVolumes and Dynamic GI to RenderGraph (#27) * Ported MaskVolumes to RenderGraph * Made MaskVolume light lists work with RenderGraph * Made ProbeVolumes DynamicGI work with RenderGraph * Remove accidentially introduced extra space (to avoid merge conflicts in the future) Dynamic GI: Partner/crazyhunter 10.7.0 custom.1.pvdgi cross volumes (#38) * Scaffolding for testing how sampling neighbor probe volumes around edges of dynamic GI volumes can help with propagating GI from neighbors. Needs to be filled in * typo * work in progress * Probe Volumes: Fix up case where ProbeVolume.hlsl is included and LIGHTLOOP_DISABLE_TILE_AND_CLUSTER is defined. Add support for dynamic GI border axes sampling all other probe volumes in order to propagate dynamic GI across volume boundaries. * Fix fade calculation * Fix warning about sign / unsign mismatch. * cache and respect the HDRP asset Dynamic GI toggle at runtime for perf testing * Probe Volumes: Dynamic GI: Add Neighboring Volume Propagation Mode to Probe Dynamic GI Volume Override for selecting which algorithm is used to inject dynamic GI from neighboring probe volumes at boundaries. Options include Disabled, Sample Neighbors Direction Only (reccomended), and Sample Neighbors Position and Direction * Probe Volumes: Dynamic GI: If Dynamic GI is on, and Neighboring Volume Propagation is on, force probe volumes to upload to structured buffers and the atlas if they are within the rangeInFrontOfCamera or rangeBehindCamera distance. * Probe Volume GI: neighboringVolumePropagationMode - change default to SampleNeighborsPositionAndDirection Co-authored-by: Szymon Swistun <szymon@bonfirestudios.com> Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Define GetDiffuseOrDefaultColor() for the Unlit BSDF to fix compilati… (#39) * Define GetDiffuseOrDefaultColor() for the Unlit BSDF to fix compilation errors in Unlit shaders in the DynamicGIDataSample pass. * Define DynamicGIDataSample pass for AxF and Unlit shaders. Remove now unnecessary #if UNLIT define in ShaderPassDynamicGIDataSample. Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Blow out fix for new cross volume GI propagation, plus big fix in directional only version to much closer match to pos + directino one Dynamic GI: Optimizations to Dynamic GI, with minimal, but some, quality loss Rename volume setting parameter, and set default to directional only, it looks fine, and a better default Pre-computed & sorted relevant neighbor axis per axis and precomputed sgWeights. Found the best tradeoff for highest weighted axis / relevancy wise based on sgWeight and used 9 to help with perf. prior merge fix 10 axis loops to catch all relevant axis Shader variant for when inf bounce scale is set to 0 to remove the work entirely Bump Shadergraph ScriptedImporter version to attempt to cleanly regenerate all shadergraphs after fixing bugs in dynamic GI extraction pass hlsl includes. (#42) Co-authored-by: pastasfuture <nickb@bonfirestudios.com> Mask Volume albedo baking (#37) * Fixed dynamic GI albedo sampling inputs. Set up all Mask Volume data globally (camera-independent) before albedo baking. Signed-off-by: Andrew Saraev <andrew.saraev@unity3d.com> * Fixed Mask Volume rendering after merging. * Fixed rendering after the merge. * Fix Mask Volume preparation for baking with Render Graph enabled. * Dynamic GI baking optimization. Mask Volume rendering clean-up. Mask Volume: Mask Volume visibility fixes (#84) * Don't render Mask Volume hidden in scene. * Fixed Mask Volume flickering when two volume instances are trying to render the same asset. Mask Volumes: Remove an unnecessary editor only GC.Alloc Dynamic GI: Max Sim Per Frame Control per Probe Volumes Dynamic GI (#44) * Control over max # of probe volume dynamic GI simulation's per frame * fixed issues with static value construction * More direct control of perf controls to dynamic GI Less GC allocations and better cleanup Cleanup and removed the need entirely clearing radiance cache on first frame of probe volume dynamic GI sim. compute shaders just handle that first frame case via variant instead. Removes hitches this way Sometimes we got NaN's, so added an extra safe clear on radiance data but via compute dispatch when needed slight bug fix to previous commit Quality variants for propagation axis amounts Dynamic GI: Added basic probe volume dynamic GI stats more dynamic GI stats Optimize GI data layout (#45) * Optimized the layout of the dynamic GI data. * Added migration of existing baked data to new layout. Context menu item "Reserialize (All)" on Probe Volume Asset now also runs the migration. Had to move the migration code from Probe Volume to Probe Volume Asset for this. Limitation: Context menu migration is skipped for assets of version < 3, since updating to v.3 requires rotation from an object in a scene. * Apply inverse-square law to propagation axis weights to get a more correct distribution for diagonal axes. Dynamic GI: Dynamic GI baked emission (#51) * Bake emission into dynamic GI neighbors and use it in the propagation. * Use 2x2 pixel blocks per baking request to control texture lods with uv and position gradients within these blocks. * Added the logic to control the material sampling lod for neighbor baking. * Added support of any Probe Volume rotation while baking dynamic GI neighbors and combining dynamic and baked SH. * Respect the Baked Emission material toggle when baking the dynamic GI neighbors. * Added a volume component setting to scale baked emission for dynamic GI. * Provide ddx and ddy for position and UV of a hit when baking neighbor materials. * Set the camera position shader property to zero before baking neighbors to support position-based effects in materials. * Clean-up. Work in progress for dgi optimization - setup new compute buffer Work in progress. Populate new neighbor axis lookups buffer and switch to reading from it. Remove old neighbour axis lookup array. Order members in NeighborAxisLookup by type size. adding safety cleanup to help trigger the sorted axis set after cleanup call Dynamic GI: Bind white texture for HVSSS in dynamic GI light loop New reflection normalization (#62) * Use roughest cubemap sample instead of baked SH to calculate Probe Volume reflection normalization. * Removed luminance SH baking for Reflection Probes. Dynamic GI: Dynamic GI sky lighting (#53) * Sample sky lighting on the edges of Probe Volumes for dynamic GI propagation. * Added Sky Contribution setting to Probe Dynamic GI volume component. * Renamed "Sky Contribution" to "Sky Multiplier" to fit better with "Baked Emission Multiplier". * Removed the Direct Contribution setting and normalization that led to all bounces being effectively multiplied by 0.5 with default settings. * Rotate axes in ProbePropagationCombine in the way consistent with other stages. * Added Max Albedo setting for dynamic GI to prevent infinite bounces from blowing up the lighting. * Apply validity to emission. Cleanup. * Changed default Max Albedo to 0.9. * Divide dynamic GI direct lighting by Pi to fix the look. * Experimental changes to skylight and direct hit injection before looking deeper into our SG-to-SH conversion. * Replaced weight normalization in hit and miss passes with prenormalized amplitudes. Experimental. * Added the inv-pi normalization to infinite bounces. * Finish fixing up normalization of hits, misses, and sky. Additionally, add amplitude adjustment for edge and diagonal SGs * Fixed StackLit shader graphs compilation by adding missing ComputeReflectionProbeNormalizationDirection function, expected by the LightLoop. * WIP Dynamic GI bases: Windowed Spherical Gaussian and Ambient Dice * Turn back on sky contribution * More iteration * Latest * Cleanup dynamic gi propagation bases defines into their own header that exposes an api so that callers do not have to know the specifics of the basis. Expose all bases as options on the Probe Dynamic GI volume override * Miss integral * Fix hit and miss lobe creation to the more subtle, but correct implementation that got lost during the cleanup. * Formalize the logic for injecting light from neighboring probe volumes / sky into a basis axis. Convolve the incoming irradiance with the zonal harmonic representation of the neighbor basis lobe in order to analytically evaluate the incoming irradiance over the entire lobe, rather than just the point sample. I compared this against a brute force monte carlo sampling of the SH over the neighbor axis lobe and the results are almost completely indestringuishable. The accuracy is based on how accurate the ZH fit of the neighbor axis lobe is. * remove some dead code * delete more dead code * Add back a line of code I accidentally deleted in the cleanup * Split up the basis options into a basis dropdown and a basis propagation override dropdown. Removed the not useful no diagonal basis options. Added ambient dice wrapped options to the propagation override modes * Remove old option for SH from SG Mode: We now always use the correct SH From SG via zonal harmonic fit conversion. Changed the default propagation override to Basis Ambient Dice Wrapped Super Soft. Fixed a subtle bug with skylight propagation - use the current axis lobe direction for sampling the sky, not the neighbor direction. This makes it consistent with how hits are propagated (and cleans up a little code in the process) Co-authored-by: pastasfuture <pastasfuture@gmail.com> Dynamic GI: Dynamic GI: Fixed Dynamic GI and the neighborhood debug draw when there are 0 hits in a volume (no geometry was hit). Renormalize axes of Dynamic GI bases to support different quality (#61) * Added frame settings for Dynamic GI quality to be able to preview it in edit mode. * Precalculate and normalize axis weights on CPU. New DGI validity baking and ProbeVolume interface (#66) * Added a button to Probe Volume to bake dynamic GI without the lightmapper. Then, validity is computed with the same rays that used for hits, so it only "sees" backfaces that are one voxel away or closer. * Simplified IProbeVolumeList by grouping all runtime data the pipeline may need to write to into ProbeVolumePipelineData and ProbeVolumePropagationPipelineData structs. * Replaced single dataUpdated on ProbeVolume with dataVersion on ProbeVolumeAsset to detect changes of baked data for already loaded volumes and keep baked lighting buffers, dynamic lighting buffers, atlas slot and content — all up to date regardless of the order they are used. Fix crash in il2cpp build (#67) Co-authored-by: Paulm-Unity <paulm@unity3d.com> Fix another crash in il2cpp build DGI Fix Leak Mitigation (#68) * Fixed DGI axis bit packing. * Store neighbor validity in axis and limit propagation from an invalid probe instead of limiting propagation towards an invalid probe. * Set default Baked Emission Multiplier, Sky Multiplier and Leak Multiplier to 1.0. rename leak multiplier to leak mitigation for consistency DGI Mixed Lights (#76) * Mark mixed lights when Probe Volume is baked to filter them out of the dynamic GI light list. * Added mixed lights data to DGI neighborhood and rendering. Using manual baking steps for now. * Update and save mixed lights baked status when lights are processed by the pipeline in the baking mode. * Added frame settings to pick a combination of realtime and mixed lights to use for dynamic GI. * Force shadow rendering regardless of distances when preparing for mixed lights baking. * Restored dynamic GI basic support for all mixed light modes after the light list merge. Now need to restore forced shadowmap rendering while mixed baking is prepared. * Restored after merge: force shadowmap rendering while mixed baking is prepared by dynamic GI. * Make dynamic GI mixed lighting preview show correct expected result for the current indirect scale setting. Probe Volume, Mask Volume, Dynamic GI Dynamic GI: DGI per volume mixed lights (#79) * Added a per-volume property defining if mixed lights were baked for this volume. Add all lights to the light list and skip mixed lights in shaders when required. * Revert to the previous way of uncapping shadow distance when baking dynamic GI mixed lights. Fix two misc DynamicGI shader warnings. (#89) Expose key hooks and controls for automated dynamic GI baking Exposing seperate prepareForBaking option for probe volumes for more control over baking one more fix for better dynamic GI bakes Probe Volume: Fix ProbeVolume buffers not being reset after disable (#95) Fixed ProbeVolume BuffersDataVersion not being reset on disable. Dynamic GI: Dynamic GI: clear EngineDataIndex and simulationFrameTick. Unified clearing methods. DGI fallback radiance baking for low end settings (#92) * Added the way to copy prepared radiance into baked data of a Probe Volume and use it at runtime as a fallback for when DGI is disabled. * Changed the way of updating and tracking data version for Probe Volume assets to not reupload it on every asset reimport and validation (needed to maintain propagated radiance while baking reflections and saving assets). Toggle for Dynamic GI for low quality baked mode testing in editor DGI smaller encoding (#96) * Experiment with storing DGI hit emission and probe radiance with half-float precision. * Trying RGBM32 encoding for DGI propogation. * Moved DGI radiance encoding functions to separate from emission to quickly iterate with it without touching the baked emission data. * Use LogLUV encoding for DGI hit and probe radiance. * Added YCoCg encoding for DGI radiance for testing. * Faster and more precise LogLuv radiance encoding with lower range. * Added a radiance encoding setting to Probe Dynamic GI volume component to switch between RGB Float and LogLuv. * Fixed hit radiance decoding for different encodings when baking mixed lighting. * Moved the radiance encoding setting from the volume component to frame settings. * Dynamic GI: Added HalfLUV, and R11G11B10 encoding modes Co-authored-by: pastasfuture <pastasfuture@gmail.com> Support DGI mixed lights baking for HalfLuv and R11G11B10 radiance encodings. (#98) DGI initial state from baked (#99) * A prototype of DGI radiance initialization from baked SH. * Disable ZHWindow in ProbePropagationInitialize for now as it gives too smooth and dark radiance to axes. * Minor fixes in propagation and a cleanup. * Partner/crazyhunter 10.7.0 custom.1 dgi initial state from baked sh to from basis improvement (#107) Improve ambient dice basis coefficients, improve basis normalization, and improve methods for projection from and to SH, choosing the right method for the context. Dynamic GI: Ambient Dice to ZH: Switched over to using a raw ZH fit instead of deringed zh fit. It results in significantly lower error when compared to a ground truth monte carlo projection, which means slightly punchier + higher contrast + less washed out GI. And the ringing concern seems to not be an issue due to the way light is propagated. Across a number of test scenes no ringing is present. Co-authored-by: Nicholas Brancaccio <pastasfuture@gmail.com> Probe Volume: Probe Volumes: Fix case when ShaderConfig enables them, but they have not yet been enabled in the frame settings. Previously this case would spill errors about unassigned compute parameters like _ProbeVolumeAtlasSH - this comes up when creating standalone HDRP template projects for repro demos Probe Volume sampling quality (#102) * Added a frame setting for Probe Volume lighting sampling quality between SHL0, SHL1 and SHL2. * Probe Volume sampling quality cleanup. * WIP switch Probe Volume spherical harmonics level with global keywords. L0 and L1 are not supported by Dynamic GI yet. * Implemented missing SH L0 and L1 modes for Dynamic GI. * Removed Probe Volume SHL0 option to save shader variants. Fixed Volumetric Lighting. * Fixed VFX shaders after introducing different Probe Volume encodings. * Support baking SHL2 fallback radiance from within the SHL1 mode. Cleanup. Check if probeVolumeAtlas is null before trying to release a slot from it. The atlas could be not created yet as we are doing it later in a rendering now to match the selected SH encoding for a given frame. (#108) Probe Volumes: Remove an unnecessary editor only GC.Alloc Reflection Probe Normalization: Fix bad rebase merge of reflection probe normalization code Fix recursive mutation bug in ZH Fit version of ProbePropagationInitialize projection. Dynamic GI Propagation: Sample Neighbors: Use ZH-Fit to convert from SH to our 26-axis basis - it produces results that are a bit closer to our monte carlo naive projection ground truth Dynamic GI: Fix Infinite Bounce calculation after we changed our basis coefficients. We were missing scaling each lobe contribution by that lobes normalized integral. Also delete some dead code that was hanging around in the dynamic GI area for too long, and fix some code erroneously included inside of an ifdef (#109) Dynamic GI probe dirty flag (#111) * Store a dirty flag for each light probe in a volume, update only the ones that had reasons to change since the last update. * Added a setting to Frame Setting to be able to disable dirty flags. * Added debug visualisation of dirty probes of all active volumes. DGI propagation fixes (#112) * Fixed fallback radiance baking when dirty flags are enabled. * Fixed noticeable intensity loss for lower propagation quality due to axis weights renormalization error. * Separate radiance comparison for LogLUV encoding that avoids many false positives in dirty flags. * Fixed propagation data not being cleared when Frame Settings are changed via the settings window causing the pipeline to be destroyed. critical exception fix that was firing on domain reloads & enter play mode transitions Dynamic GI: Copy over some warning fixes to dynamic GI that were lost in the rebase shuffle

* Remove branching in GetOddNegativeScale * Prevent branching in Lit shader by assuming perspective projection

FrancescoC-unity added 2 commits April 6, 2020 18:18

Clamp to positive

0e06f27

Changelog

5592e8d

FrancescoC-unity added the HDRP label Apr 6, 2020

FrancescoC-unity requested a review from sebastienlagarde April 6, 2020 16:21

FrancescoC-unity self-assigned this Apr 6, 2020

sebastienlagarde added needs-backport-8.x needs-backport-7.x labels Apr 7, 2020

sebastienlagarde approved these changes Apr 7, 2020

View reviewed changes

Merge branch 'HDRP/staging' into HDRP/clamp-probes-compression-factor…

4c68118

…-to-0

sebastienlagarde merged commit 7c034f2 into HDRP/staging Apr 7, 2020

sebastienlagarde deleted the HDRP/clamp-probes-compression-factor-to-0 branch April 7, 2020 17:32

sebastienlagarde added backported-7.x backported-8.x and removed needs-backport-7.x needs-backport-8.x labels Apr 7, 2020

sebastienlagarde pushed a commit that referenced this pull request Apr 7, 2020

Clamp probes compression factor to 0 #19

d15725c

sebastienlagarde pushed a commit that referenced this pull request Apr 7, 2020

Clamp probes compression factor to 0 (#19)

accff86

This was referenced Apr 7, 2020

Merge 7.x.x/hd/staging #37

Merged

Merge 8.x.x/hd/staging #38

Merged

sebastienlagarde mentioned this pull request Apr 8, 2020

Merge Hdrp/staging [Skip CI] #49

Merged

6 tasks

sebastienlagarde mentioned this pull request Apr 16, 2020

Merge 8.x.x/hd/staging [Skip CI] #141

Merged

6 tasks

julienf-unity pushed a commit that referenced this pull request May 14, 2020

Vfx/fix colorfield height (#19)

6e1344f

sebastienlagarde mentioned this pull request Jun 2, 2020

[9.x.x] Merge Hdrp/staging [Skip CI] (#697) #708

Merged

10 tasks

julienf-unity pushed a commit that referenced this pull request Jul 4, 2020

Vfx/fix colorfield height (#19)

d8292d1

* Fix color field height * changelog

pastasfuture added a commit that referenced this pull request Sep 15, 2021

Probe Volumes: Fix exposure in Probe Volume debug modes (ensure no ex…

42b4448

…posure is applied (#19) Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

mohammad22 pushed a commit that referenced this pull request Mar 2, 2022

Probe Volumes: Fix exposure in Probe Volume debug modes (ensure no ex…

2f3f389

…posure is applied (#19) Co-authored-by: pastasfuture <nickb@bonfirestudios.com>

Tspk91 pushed a commit to Tspk91/QuestGraphics that referenced this pull request Jun 13, 2023

Some vertex shader optimizations (Unity-Technologies#19)

9d989ca

* Remove branching in GetOddNegativeScale * Prevent branching in Lit shader by assuming perspective projection

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clamp probes compression factor to 0 #19

Clamp probes compression factor to 0 #19

FrancescoC-unity commented Apr 6, 2020

Clamp probes compression factor to 0 #19

Clamp probes compression factor to 0 #19

Conversation

FrancescoC-unity commented Apr 6, 2020