Merges with latest #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add-supertokens-to-authentication.md * bump supertokens deps * update SuperTokens Auth doc * Update docs/authentication.md Co-authored-by: Lee Robinson <me@leerob.io> * Update docs/authentication.md Co-authored-by: Lee Robinson <me@leerob.io> * updates supertokens dependency and optimises for serverless execution * runs prettier-fix * adds supertokens to 'Bring Your Own Database' section as well * does not show home page if not logged in * extracts config into its own file and calls it in all serverless functions * removes need for backend init in app.jsx * simplifies use of dynamic * refreshes page after getServerSideProps * removes unnecessary check in API * update to docs pertaining SuperTokens * adds placeholder secrets so that the UI loads on first run * changes to readme * updates version of supertokens frontend and backend SDK, and a few other fixes * Update docs/authentication.md Co-authored-by: Lee Robinson <me@leerob.io> * updates to readme for supertokens example * updates version of dependency * updates dependency version * updates to dependencies * removes unnecessary config on frontend * changes how redirection is done post signout * update to dependency * updates examples * updates code to use for new package * updates dependencies * updates auth-react package * with-supertokens example updated to use supertokens-node v7 * updates dependency * updates supertokens-node version * Update examples/with-supertokens/package.json Co-authored-by: Lee Robinson <me@leerob.io> * updates based on check-examples.sh script * linter fix * updates supertokens-auth-react dependency version * adds development OAuth key to example * removes section from README * removes unnecessary file * updates dependency versions * with-supertokens: reduced bundle size by removing node lib from bundle Linting fix * Removed accidentally added config file * adds sign in with apple * extracted oauth keys to .env file * fixes node init issue race condition * removes unnecessary file * updates supertokens-auth-react dependency * updates superttokens-node dependency * adds a cap to react dependency * updates eslint-config-next version * removes unnecessary dev dependency Co-authored-by: NkxxkN <kevin@supertokens.io> Co-authored-by: NkxxkN <kevin.antoine@protonmail.com> Co-authored-by: Lee Robinson <me@leerob.io> Co-authored-by: Rishabh <rishabh@supertokens.io> Co-authored-by: Bhumil Sarvaiya <sarvaiyabhumil@gmail.com> Co-authored-by: jscyo <joelsteve97@hotmail.com> Co-authored-by: Mihaly Lengyel <mihaly.lengyel@tresorit.com>
The Font Optimization docs have an outdated example that recommends adding fonts via `next/head`. This is an anti-pattern that Next.js has already warned about through ESLint for a while (see https://nextjs.org/docs/messages/no-page-custom-font) and is now starting to warn about through the console because it won't work well with streaming architecture. This change removes the outdated example from the docs. Fixes #34693 ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
`test.css`, `test.scss` etc. will falsely match on a loader that searches for the string `test` fixes #34583 ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
This PR fixes the Fix the create-next-app Multiple calls to the function 'makeDir'. Currently, no execution errors are generated, but redundant execution exists. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
With the recent push to get the examples in TypeScript, I thought I'd convert this `with-redis` example over. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
This PR adds the `X-Powered-By` and `Content-Type` headers to responses sent by the web server. The latter enables compression for the Edge runtime. Still, the web server doesn't have `Content-Length` and `ETag` as the response is usually dynamic. Part of #31506. ## Bug - [x] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
This PR will generate source maps for middlewares. It's not under any flag (should it be?) Closes #34523
By moving `setRevalidateHeaders` to a separate file we can shake off the dependency of `etag` and a polyfill for `Buffer` from the web server (which brings hundreds of kilobytes). ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
* Add @types/react-dom devDependencies * fix: eslint error * fix: eslint error 2
This commit adds functionality to track usage of `@next/next/*` ESLint rules and their severity levels. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Documentation added - [x] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
* refactor entries generation of hot-reloader * change parameter name
This is a PR to update the rewrites documentation. This is after struggling to get rewrites to work with `trailingSlash` for a customer as this wasn't documented. The main culprit was the `:path*` wildcard not catching trailing slashes. The changes made to for this commit were: - [x] Added example for redirecting to blog and docs - [x] Expanded on original code example for external URLs - [x] Added code example for using rewrites with `trailingSlash` ### Context For a reproduction of the `:path*` wildcard not catching trailing slashes as expected, see below. Click on the "not working" demo link below, navigate to a specific blog post, then reload the page. It will redirect infinitely. - [Not working demo of main repo with `:path*`](https://redirect-demo-git-not-working-nutlope.vercel.app/blog/) - [Working demo of main repo with `:path(.+)`](https://redirect-demo.vercel.app/blog/) If you want to take a look at the code, here are the full repos. They both have `trailingSlash: true`: - [not working main repo](https://github.com/Nutlope/redirect-demo/tree/not-working) - [working main repo](https://github.com/Nutlope/redirect-demo) - [blog repo](https://github.com/Nutlope/starter-blog-example)
* Integrate tsec into the linting process * Update tsec-exemptions.json
Adds an API config option that disables warning a user when their API response body is over 4 megs. This has been added for users who'd like to stream larger amounts of data from their API acknowledging the drawbacks. This config mirrors the existing [`externalResolver` config](https://nextjs.org/docs/api-routes/api-middlewares#custom-config). Closes: [#33162](#33162) Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
Changes from https://github.com/planetscale/nextjs-starter. Realized the current example was not only out of date, but the demo was broken. Will update the demo site post-merge here 👍
## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` Fixes #34030. The PR is still WIP as the test case hasn't been added, help or change is welcome. cc @no-ya @ijjk Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
Fixes #34797. Context: https://github.com/yannickcr/eslint-plugin-react was released in 7.29.0 2h ago and breaks the linting of a default create-next-app. See: jsx-eslint/eslint-plugin-react#3215 This PR locks the version to the latest working one.
* Add Error Handling document * Update error-handling.md * Add more services on client errors after Jeff's recommendation * Update docs/advanced-features/error-handling.md Co-authored-by: Steven <steven@ceriously.com> * Update docs/advanced-features/error-handling.md Co-authored-by: Steven <steven@ceriously.com> * Update error-handling.md * Add info about handling file not found error * Add a screenshot of overlay when in development mode Co-authored-by: Steven <steven@ceriously.com>
Howdy! MDX no longer has an `inlineCode` component in their MDXProvider ([source](https://mdxjs.com/table-of-components/)). They've migrated to a `pre` component for blocks of code and a `code` component for inline code snippets, so I've updated the example to reflect this. I validated this locally with these example components: ```jsx const Code = (props) => ( <code> {props.children} </code> ); const Pre = (props) => ( <pre> {props.children} </pre> ); const components = { pre: Pre, code: Code, ... }; ``` Applied to a test `mdx` file: ```md This is an `inline` example. ~~~ <p>Test code</p> ~~~ ``` Which generates the following html: ```html <p>This is an <code>inline</code> example.</p> <pre> <code><p>Test code</p></code> </pre> ``` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
* Update to ncc dev overlay during build instead of pre-compile * update config
* Add warning for Yarn PnP v3 with Node.js < 16.14 * Apply suggestions from code review Co-authored-by: Steven <steven@ceriously.com> * Apply suggestions from code review Co-authored-by: Steven <steven@ceriously.com> * lint-fix Co-authored-by: Steven <steven@ceriously.com>
* Add CLI command typo detection * Apply suggestions from code review Co-authored-by: Steven <steven@ceriously.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Steven <steven@ceriously.com>
- Moves example out of hidden dropdown at the top and features more prominently - Adds a clone and deploy link for those looking to get started immediately - Cross-posts ignoring TS errors docs over, because I've personally assumed it should be on this page and then ctrl+f found nothing - Added version history to the top, based on contents of this file - Remove custom app caveats from code snippet to improve copy-paste ability
* fix flight loader for shared components * add tests * fix condition
A link leads to a 404 page due to a missing `/ `
The w3c validator seems to be down and this shouldn't block our tests so this uses the whatwg validator instead x-ref: https://github.com/vercel/next.js/runs/5361585193?check_suite_focus=true x-ref: https://github.com/vercel/next.js/runs/5356851471?check_suite_focus=true x-ref: https://github.com/vercel/next.js/runs/5361463120?check_suite_focus=true
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` `escape-regex.ts` will always be included in the bundle, so not re-using it actually makes the size larger.
CF worker doesn't allow to use `writer.write(string)` but only byte stream, we have to transform the Uint8Array stream 
This gracefully handles errors when the `url` query string param looks like an internal image because it starts with `/` but it is not pointing to an internal image. Previously, this was printing an unnecessary stack trace when the upstream content-type was undefined. Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
A closing parenthesis was missing in the docs about static HTML export.
* Update swc * lockfile * Update more swc crates * Update minifier * chore: update types * style: fix * Update deps Co-authored-by: evilebottnawi <sheo13666q@gmail.com>
This ensures non-matching API routes can be rewritten with i18n configured as currently we bail and render the 404 page when a locale prefixed API route is requested. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` x-ref: [slack thread](https://vercel.slack.com/archives/CGU8HUTUH/p1643930049224689) closes: #28921
Since we are applying this loader to more files, and these two simple RegExp filters will be executed ~70 times per entry, it's an easy optimization to move the RegExp creation outside and merge related testers into the RegExp. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
Upgrades `next-sanity` to the latest version and applies breaking changes. Improves the docs for the Sanity example. ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` Co-authored-by: even westvang <172952+evenwestvang@users.noreply.github.com>
Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
* rename example with-styled-components to with-styled-components-babel * update with-styled-components references * update docs on react hydratation erros for styled components * clone with-styled-components-babel without babel config * add styledComponents to compiler options in next.config * replace babel dependency with Next.js SWC compiler * upgrade example typescript version example with-typescript-styled-components had a typescript dependency lower than the recommended version. Upgraded from 4.2.4 to 4.5.5. * Apply suggestions from code review * update readme for with-styled-components-babel remove Notes section since it describes a workaround which is no longer required to work with `next/link`. Co-authored-by: Lee Robinson <me@leerob.io> Co-authored-by: Balázs Orbán <info@balazsorban.com>
This PR introduces a way to use WASM in middlewares. Next.js will find all `.wasm` imports in middlewares and load them as `WebAssembly.Module` objects, which then can be later instantiated. The metadata will be stored in `middleware-manifest.json` ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
* parse runtime config * add test * fix typing * fix lint warning * change branch purging condition * dont fallback to global runtime
* refactor rsc export marks * fix failed test
Fixes a bug where browsers with scripts disabled did not work with `<Image placeholder="blur" priority />`. - Introduced in #32918
Closes #33538. ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
### Changes * Remove top-level suspense boundary * Pipe stream resolved from returned promimse of `renderToReadableStream` * Remove jsx-runtime alias hack ### Test Changes Since top level suspense boundary is removed, now content are filled in 1st SSR
This PR fixes the latest version of `typescript` (4.6.2) that was failing with the following:
```
Type error: Overload signatures must all be optional or required.
207 | array: T
208 | ): T
> 209 | randomUUID?(): string
| ^
210 | }
211 | }
```
https://github.com/vercel/next.js/runs/5376232868?check_suite_focus=true#step:8:106
- Related to PeculiarVentures/webcrypto#44
Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
* Handle de-duping revalidations in minimal mode * fix type * remove header check * update other tests * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.