Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major: Change asset builds to opt-in with new option --asset-builds #756

Merged
merged 2 commits into from Aug 27, 2021

Conversation

@guybedford
Copy link
Collaborator

@guybedford guybedford commented Aug 27, 2021

This converts the asset builds option into being disabled by default and hence opt-in instead of opt-out.

The reason being that asset builds have turned out to cause instability in some build scenarios, so it would be preferable to rather use them as a tool for when builds aren't working instead.

Note that this is a breaking API change.

@guybedford guybedford requested review from styfle and Timer as code owners Aug 27, 2021
@styfle styfle requested a review from TooTallNate Aug 27, 2021
@styfle styfle changed the title Feat: Asset subbuilds as option Major: Asset subbuilds as option Aug 27, 2021
styfle
styfle approved these changes Aug 27, 2021
@styfle styfle changed the title Major: Asset subbuilds as option Major: Change asset builds to opt-in with new option --asset-builds Aug 27, 2021
@styfle styfle merged commit 3015281 into main Aug 27, 2021
5 checks passed
Loading
@styfle styfle deleted the asset-subbuilds-as-option branch Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants