Skip to content

Conversation

@cyjseagull
Copy link
Member

No description provided.

MaggieNgWu and others added 30 commits July 9, 2020 15:34
1. add crypto interface and the basic implementation

2. add libffi_java_sdk.dylib
1. support load key-pair from the p12/pem files

2. add getAddress to CryptoKeyPair

3. Place excepito in the corresponding module
1. Init network module, connect peers
2. Define interfaces of abi module
* add interface of tx module

* rename ambiguous class name

Constructor -> SolidityConstructor
Function -> SolidityFunction


Co-authored-by: cyjseagull <yujiechen_hust@163.com>
1. Channel module adds synchronous sending interface && Move client/response and client/request to client/protocol directory

2. add coverage statistic to ci
1. implement Client interface

2. implement BcosBlockHeader Response

3. add ut for Message and BcosBlockHeader
* add RawTransaction & TransactionReceipt

* format

Co-authored-by: cyjseagull <yujiechen_hust@163.com>
Co-authored-by: MaggieNgWu <hao.maggie.wu@gmail.com>
1. add groupManager related interfaces 

2. Place the files that both the transaction and client modules depend on in the model module

3. When gradlew build is executed, integrationTest is not run
* channel model

* query node version and heartbeat in channel
…OS#27)

1. add event subscribe module and implement subscribe function

2. rename utils

3. add decoder of EventLog
* add timeout

* channel integration-test

Co-authored-by: MaggieNgWu <hao.maggie.wu@gmail.com>
1. implement GroupServiceManager

2. add BcosSDK to init the groupManagerService and create client for specified group

3. modify EventSubscribeImp to use groupManager network-interface
Co-authored-by: cyjseagull <yujiechen_hust@163.com>
cyjseagull and others added 26 commits September 18, 2020 01:12
1. Setting precompiled without timeout

2. suplement error message

3. remove table_name field from the desc result

4. fix parseCallOutput
Co-authored-by: 闵健 <minjian@Jians-MacBook-Pro.local>
Co-authored-by: cyjseagull <yujiechen_hust@163.com>
Co-authored-by: chaychen <chaychen@zhangruideMacBook-Air.local>
1. move JsonRpcResponse to model and move RevertMessageParser to transaction 

2. refactor for jar package split
1. update build.gradle to unify the version

2. rename PEMManager to PEMKeyStore, P12Manager to P12KeyStore

3. modify cryptoInterface param when deploying/call contracts to CryptoKeyPair
Co-authored-by: 闵健 <minjian@Jians-MacBook-Pro.local>
Co-authored-by: cyjseagull <yujiechen_hust@163.com>
Co-authored-by: 闵健 <minjian@Jians-MacBook-Pro.local>
Co-authored-by: chaychen <chaychen@zhangruideMacBook-Air.local>
Co-authored-by: chaychen <chaychen@zhangruideMacBook-Air.local>
@cyjseagull cyjseagull merged commit 5c1a013 into FISCO-BCOS:master Oct 12, 2020
@ghost
Copy link

ghost commented Oct 12, 2020

Sider detected 5 warnings on analyzing the commit 1f46228.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off this notification if you don't want to receive it from now on.

* [Chinese WIKI](https://github.com/FISCO-BCOS/java-sdk/wiki)

## Quick Start
* [English](https://fisco-bcos-documentation.readthedocs.io/en/latest/docs/sdk/java_sdk/quick_start.html)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[remark-lint] Link to https://fisco-bcos-documentation.readthedocs.io/en/latest/docs/sdk/java_sdk/quick_start.html is dead (view)

Rule Severity
no-dead-urls warn

You can close this issue if no need to fix it. Learn more.


The FISCO BCOS community is one of the most active open-source blockchain communities in China. It provides long-term technical support for both institutional and individual developers and users of FISCO BCOS. Thousands of technical enthusiasts from numerous industry sectors have joined this community, studying and using FISCO BCOS platform. If you are also interested, you are most welcome to join us for more support and fun.

![](https://media.githubusercontent.com/media/FISCO-BCOS/LargeFiles/master/images/QR_image_en.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[remark-lint] Link to https://media.githubusercontent.com/media/FISCO-BCOS/LargeFiles/master/images/QR_image_en.png is dead (view)

Rule Severity
no-dead-urls warn

You can close this issue if no need to fix it. Learn more.

FISCO BCOS开源社区是国内活跃的开源社区,社区长期为机构和个人开发者提供各类支持与帮助。已有来自各行业的数千名技术爱好者在研究和使用FISCO BCOS。如您对FISCO BCOS开源技术及应用感兴趣,欢迎加入社区获得更多支持与帮助。


![](https://media.githubusercontent.com/media/FISCO-BCOS/LargeFiles/master/images/QR_image.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[remark-lint] Link to https://media.githubusercontent.com/media/FISCO-BCOS/LargeFiles/master/images/QR_image.png is dead (view)

Rule Severity
no-dead-urls warn

You can close this issue if no need to fix it. Learn more.

if should_ignore "${file}"; then continue; fi
if [ ! -f "${file}" ]; then continue; fi
LOG_INFO "check file ${file}"
python ${scan_code_script} "$file"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ShellCheck] Double quote to prevent globbing and word splitting. (view)

Rule Severity Code
SC2086 info 2086

References:

You can close this issue if no need to fix it. Learn more.

trigger_rules=$(jq -r '.' /tmp/report.json | grep 'trigger_rules' | awk '{print $2}' | sed 's/,//g')
echo "trigger_rules is ${trigger_rules}"
rm /tmp/report.json
if [ ${trigger_rules} -ne 0 ]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ShellCheck] Double quote to prevent globbing and word splitting. (view)

Rule Severity Code
SC2086 info 2086

References:

You can close this issue if no need to fix it. Learn more.

exit 1
fi
local merges=$(git log --format=%s HEAD^..HEAD | grep -i merge | wc -l)
if [ ${merges} -gt 2 ]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ShellCheck] Double quote to prevent globbing and word splitting. (view)

Rule Severity Code
SC2086 info 2086

References:

You can close this issue if no need to fix it. Learn more.

LOG_ERROR "${commits} != ${unique_commit}, please make commit message unique!"
exit 1
fi
local merges=$(git log --format=%s HEAD^..HEAD | grep -i merge | wc -l)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ShellCheck] Consider using grep -c instead of grep|wc -l. (view)

Rule Severity Code
SC2126 style 2126

References:

You can close this issue if no need to fix it. Learn more.


check_commit_message()
{
local commits=$(git rev-list --count HEAD^..HEAD)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ShellCheck] Declare and assign separately to avoid masking return values. (view)

Rule Severity Code
SC2155 warning 2155

References:

You can close this issue if no need to fix it. Learn more.

LOG_ERROR "${commits} commits, limit is ${commit_limit}"
exit 1
fi
local unique_commit=$(git log --format=%s HEAD^..HEAD | sort -u | wc -l)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ShellCheck] Declare and assign separately to avoid masking return values. (view)

Rule Severity Code
SC2155 warning 2155

References:

You can close this issue if no need to fix it. Learn more.

LOG_ERROR "${commits} != ${unique_commit}, please make commit message unique!"
exit 1
fi
local merges=$(git log --format=%s HEAD^..HEAD | grep -i merge | wc -l)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ShellCheck] Declare and assign separately to avoid masking return values. (view)

Rule Severity Code
SC2155 warning 2155

References:

You can close this issue if no need to fix it. Learn more.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants