Add refresh ability in autofill by pavelzw · Pull Request #2406 · bitwarden/android

pavelzw · 2023-03-07T00:54:13Z

Type of change

Objective

This PR introduces the ability to pull to refresh in the autofill window like in the default app.

Since I am not able to run it in iOS, I didn't try it there... We probably still need to do some iOS specific stuff here... Any help is appreciated to try test it out there.
I tried out #1939 but unfortunately don't have an Apple Developer account. Works on iOS too.

cc @danstooamerican

Code changes

AutofillCiphersPageViewModel.cs: Add RefreshAsync()
AutofillCiphersPage.xaml Add RefreshView
LoginListViewController.cs Add RefreshControl_ActivatedAsync()
LoginListViewController.designer.cs Add RefreshControl_ActivatedAsync
iOS.Autofill/MainInterface.storyboard Add refreshControl
iOS.Core/Views Add RefreshAsync()

Screenshots

iOS

ios-refresh-view.mov

Android

Bildschirmaufnahme.2023-03-14.um.02.12.06.mov

Before you submit

Please check for formatting errors (dotnet format --verify-no-changes) (required)
Please add unit tests where it makes sense to do so (encouraged but not required)
If this change requires a documentation update - notify the documentation team
If this change has particular deployment requirements - notify the DevOps team

…warden#1932)

…ip enabled (bitwarden#1953) * fix for missing org items with single org & personal ownership enabled * fix for ui issue with vault filter state change on pull to refresh

…#1952) * SG-386 Updated active user when coming from background to the iOS app and the extension had switched users * Added iOSExtensionActiveUserIdKey to preference keys * Reorder iOS preference keys

…al ownership policy (bitwarden#1955)

* Pinning the version of NuGet to 5.x * pinning NuGet verison to 5.9.x * pinning NuGet to 5.9.0.7134 * pinning NuGet to 5.9.0

… (System) theme (bitwarden#1959) * support for dark theme selection while using Default (System) theme * refinements

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…improved the code so there are fewer direct access from the VM to the View (bitwarden#1879)

…ks (bitwarden#1917)

… service name hardcoded to register/resolve a service (bitwarden#1865)

…Also improved a bit the code of copying commands (bitwarden#1974)

…king link (bitwarden#1978)

We only need master password hash because this is currently only used for sso password setting after auto-provisioning. Key Connector is not involved in these accounts

…1976) * Added to AppResources.resx the message warning the user about setting the lockout option to "Never" * Added the condition to check the newly selected option on the vault timeout settings * Changed the wording on the warning as to reflect the mobile version * Changed the vault timeout modal to have the ability to cancel * Simplified the reversion of value if the user cancels the change

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…gOverlayHelper and also added more logging to see when it happens. (bitwarden#1983)

…itwarden#1982)

* feat: update auto totp copy setting * feat: update show icons settings * feat: update auto add settings * feat: update settings and options to sentence case * feat: update translation keys With the latest changes the translation keys had diverged from their contents. This commit fixes that. * fix: revert AndroidManifest changes * chore: add todo comments to fix negative functions

Closes bitwarden/mobile#1985

* PS-920 - Added feedback to user when saving bad formed URLs * Added feedback to user when trying to perform login with bad formed URL * PS-920 - Refactor to use AsyncCommand *(missing file from previous commit) * PS-920 - Fixed whitespace formatting * PS-920 - Removed unused method * PS-920 - Fixed validation * Added comment for hard coded string * PS-920 - Removed unused properties * Fixed url validations * Refactored method to local function * PS-920 - Added exception handling and logging * Added generic error message string to AppResources

…#1971) * EC-259 Added Account switching on share extension on iOS, also improved performance for this and exception handling * EC-259 code formatting * EC-259 Added account switching to Share extension Send view * EC-259 Fixed navigation on share extension when a forms page is already presented * EC-259 Fix send text UI update when going from the iOS extension * EC-259 Improved DateTimeViewModel with helper property to easily setup date and time at the same time and applied on usage

Added Opera GX Support for autofill

…itwarden#1990)

* Add calculating hashes for apk files * Install checksum * Fix name of artifact * Fix * Add SHA files to github release * Update .github/workflows/build.yml Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> * Update .github/workflows/build.yml Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> * Update .github/workflows/release.yml Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> --------- Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>